From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org,
a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, swarren@nvidia.com,
treding@nvidia.com, k.kozlowski@samsung.com
Subject: Re: [PATCH V6 7/8] DT: regulator: add DT binding doc for regulator of PMIC max77620/max20024
Date: Fri, 29 Jan 2016 00:28:17 +0100 [thread overview]
Message-ID: <20160128232817.GH4130@sirena.org.uk> (raw)
In-Reply-To: <1453988274-28052-8-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Thu, Jan 28, 2016 at 07:07:53PM +0530, Laxman Dewangan wrote:
> Maxim Semiconductor's PMIC MAX77620/MAX20024 has multiple
> DCDCs and LDOs.
Please use subject lines matching the style for the subsystem. I'm
fairly sure I've mentioned this before and really if your subject lines
don't visually resemble anything else in the directory that ought to be
a warning sign.
> +- maxim,disable-active-discharge: boolean, Disable active discharge.
That's something I've seen other regulators do, can we make it a
standard property with an op?
> +max77620@3c {
> + regulators {
> + in-ldo0-1-supply = <&max77620_sd2>;
> + in-ldo7-8-supply = <&max77620_sd2>;
I'd expect any supplies for the device to be at the device level,
including supplies used by regulators.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org,
a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, swarren@nvidia.com,
treding@nvidia.com, k.kozlowski@samsung.com
Subject: [rtc-linux] Re: [PATCH V6 7/8] DT: regulator: add DT binding doc for regulator of PMIC max77620/max20024
Date: Fri, 29 Jan 2016 00:28:17 +0100 [thread overview]
Message-ID: <20160128232817.GH4130@sirena.org.uk> (raw)
In-Reply-To: <1453988274-28052-8-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
On Thu, Jan 28, 2016 at 07:07:53PM +0530, Laxman Dewangan wrote:
> Maxim Semiconductor's PMIC MAX77620/MAX20024 has multiple
> DCDCs and LDOs.
Please use subject lines matching the style for the subsystem. I'm
fairly sure I've mentioned this before and really if your subject lines
don't visually resemble anything else in the directory that ought to be
a warning sign.
> +- maxim,disable-active-discharge: boolean, Disable active discharge.
That's something I've seen other regulators do, can we make it a
standard property with an op?
> +max77620@3c {
> + regulators {
> + in-ldo0-1-supply = <&max77620_sd2>;
> + in-ldo7-8-supply = <&max77620_sd2>;
I'd expect any supplies for the device to be at the device level,
including supplies used by regulators.
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-28 23:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 13:37 [PATCH V6 0/8] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 1/8] DT: mfd: add device-tree binding doc for PMIC max77620/max20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-29 9:06 ` Lee Jones
2016-01-29 9:06 ` [rtc-linux] " Lee Jones
2016-01-29 10:59 ` Laxman Dewangan
2016-01-29 10:59 ` [rtc-linux] " Laxman Dewangan
2016-01-29 10:59 ` Laxman Dewangan
2016-02-01 8:59 ` Lee Jones
2016-02-01 8:59 ` [rtc-linux] " Lee Jones
2016-02-01 8:59 ` Lee Jones
2016-02-01 8:52 ` Laxman Dewangan
2016-02-01 8:52 ` [rtc-linux] " Laxman Dewangan
2016-02-01 8:52 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 3/8] DT: pinctrl: add DT binding doc for pincontrol of PMIC max77620/max20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 4/8] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 5/8] DT: gpio: add DT binding doc for gpio of PMIC max77620/max20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 6/8] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 13:37 ` [PATCH V6 7/8] DT: regulator: add DT binding doc for regulator of PMIC max77620/max20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
2016-01-28 23:28 ` Mark Brown [this message]
2016-01-28 23:28 ` [rtc-linux] " Mark Brown
2016-01-28 13:37 ` [PATCH V6 8/8] regulator: max77620: add regulator driver for max77620/max20024 Laxman Dewangan
2016-01-28 13:37 ` [rtc-linux] " Laxman Dewangan
2016-01-28 13:37 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128232817.GH4130@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.