Re: [PATCH V5 4/5] gpio: max77620: add gpio driver for MAX77620/MAX20024

From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org,
	a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
	lgirdwood@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	rtc-linux@googlegroups.com, swarren@nvidia.com,
	treding@nvidia.com, k.kozlowski@samsung.com,
	Chaitanya Bandi <bandik@nvidia.com>
Subject: Re: [PATCH V5 4/5] gpio: max77620: add gpio driver for MAX77620/MAX20024
Date: Mon, 1 Feb 2016 08:32:28 +0000	[thread overview]
Message-ID: <20160201083228.GY3368@x1> (raw)
In-Reply-To: <20160129163035.GA15053@rob-hp-laptop>

On Fri, 29 Jan 2016, Rob Herring wrote:

> On Wed, Jan 27, 2016 at 07:40:07PM +0530, Laxman Dewangan wrote:
> > MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
> > pins. It also supports interrupts from these pins.
> > 
> > Add GPIO driver for these pins to control via GPIO APIs.
> > 
> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> > Signed-off-by: Chaitanya Bandi <bandik@nvidia.com>
> > ---
> > Changes from V1:
> > - Use the gpiochip_add_data and get the chip data from core APIs.
> > - Cleanups based on comment received on mfd/rtc.
> > - Avoid duplication on error message.
> > 
> > Changes form V2:
> > - Run coccicheck and checkpatch in strict mode for the alignment.
> > - update based on api changes from core.
> > 
> > Changes from V3: 
> > - Change all sys initcall to module driver.
> > - change the max77620_read argument to unisgned int from u8.
> > 
> > Changes from V4: 
> > - Added DT binding document as devicetree/bindings/gpio/gpio-max77620.txt
> > 
> >  .../devicetree/bindings/gpio/gpio-max77620.txt     |  25 ++
> >  drivers/gpio/Kconfig                               |   9 +
> >  drivers/gpio/Makefile                              |   1 +
> >  drivers/gpio/gpio-max77620.c                       | 292 +++++++++++++++++++++
> >  4 files changed, 327 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-max77620.txt
> >  create mode 100644 drivers/gpio/gpio-max77620.c
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-max77620.txt b/Documentation/devicetree/bindings/gpio/gpio-max77620.txt
> > new file mode 100644
> > index 0000000..410e716
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-max77620.txt
> > @@ -0,0 +1,25 @@
> > +GPIO driver for MAX77620 Power management IC from Maxim Semiconductor.
> > +
> > +Device has 8 GPIO pins which can be configured as GPIO as well as the
> > +special IO functions.
> > +
> > +Required properties:
> > +-------------------
> > +- gpio-controller : 	Marks the device node as a gpio controller.
> > +- #gpio-cells : 	Should be two.  The first cell is the pin number and
> > +			the second cell is used to specify the gpio polarity:
> > +				0 = active high
> > +				1 = active low
> > +For more details, please refer generic GPIO DT binding document
> > +<devicetree/bindings/gpio/gpio.txt>.
> 
> I would just fold these 2 properties into the main max77620 document.

As these are simple/generic options, I'm happy to support that.

Also happy to support them staying in their own subsystem doc
i.e. this one, for consistency.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html