* [PATCH] i2c: designware-platform: Drop duplicate module information
@ 2016-02-02 13:31 Jean Delvare
2016-02-04 11:36 ` Jarkko Nikula
2016-02-12 18:58 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2016-02-02 13:31 UTC (permalink / raw)
To: Linux I2C; +Cc: David E. Box, Mika Westerberg, Wolfram Sang
The i2c-designware-platform module has duplicate module information
when CONFIG_I2C_DESIGNWARE_BAYTRAIL is set. It gets the information
from both i2c-designware-platdrv and i2c-designware-baytrail. The
latter is optional extra code which ends up in the same module so it
should not export module information.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: David E. Box <david.e.box@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/busses/i2c-designware-baytrail.c | 5 -----
1 file changed, 5 deletions(-)
--- linux-4.5-rc2.orig/drivers/i2c/busses/i2c-designware-baytrail.c 2016-02-02 09:02:08.098923894 +0100
+++ linux-4.5-rc2/drivers/i2c/busses/i2c-designware-baytrail.c 2016-02-02 13:37:34.418855732 +0100
@@ -11,7 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*/
-#include <linux/module.h>
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/acpi.h>
@@ -151,7 +150,3 @@ int i2c_dw_eval_lock_support(struct dw_i
return 0;
}
-
-MODULE_AUTHOR("David E. Box <david.e.box@linux.intel.com>");
-MODULE_DESCRIPTION("Baytrail I2C Semaphore driver");
-MODULE_LICENSE("GPL v2");
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: designware-platform: Drop duplicate module information
2016-02-02 13:31 [PATCH] i2c: designware-platform: Drop duplicate module information Jean Delvare
@ 2016-02-04 11:36 ` Jarkko Nikula
2016-02-12 18:58 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Nikula @ 2016-02-04 11:36 UTC (permalink / raw)
To: Jean Delvare, Linux I2C; +Cc: David E. Box, Mika Westerberg, Wolfram Sang
On 02/02/2016 03:31 PM, Jean Delvare wrote:
> The i2c-designware-platform module has duplicate module information
> when CONFIG_I2C_DESIGNWARE_BAYTRAIL is set. It gets the information
> from both i2c-designware-platdrv and i2c-designware-baytrail. The
> latter is optional extra code which ends up in the same module so it
> should not export module information.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: David E. Box <david.e.box@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-designware-baytrail.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> --- linux-4.5-rc2.orig/drivers/i2c/busses/i2c-designware-baytrail.c 2016-02-02 09:02:08.098923894 +0100
> +++ linux-4.5-rc2/drivers/i2c/busses/i2c-designware-baytrail.c 2016-02-02 13:37:34.418855732 +0100
> @@ -11,7 +11,6 @@
> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> * more details.
> */
> -#include <linux/module.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/acpi.h>
> @@ -151,7 +150,3 @@ int i2c_dw_eval_lock_support(struct dw_i
>
> return 0;
> }
> -
> -MODULE_AUTHOR("David E. Box <david.e.box@linux.intel.com>");
> -MODULE_DESCRIPTION("Baytrail I2C Semaphore driver");
> -MODULE_LICENSE("GPL v2");
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: designware-platform: Drop duplicate module information
2016-02-02 13:31 [PATCH] i2c: designware-platform: Drop duplicate module information Jean Delvare
2016-02-04 11:36 ` Jarkko Nikula
@ 2016-02-12 18:58 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-02-12 18:58 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C, David E. Box, Mika Westerberg
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On Tue, Feb 02, 2016 at 02:31:38PM +0100, Jean Delvare wrote:
> The i2c-designware-platform module has duplicate module information
> when CONFIG_I2C_DESIGNWARE_BAYTRAIL is set. It gets the information
> from both i2c-designware-platdrv and i2c-designware-baytrail. The
> latter is optional extra code which ends up in the same module so it
> should not export module information.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: David E. Box <david.e.box@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-12 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-02 13:31 [PATCH] i2c: designware-platform: Drop duplicate module information Jean Delvare
2016-02-04 11:36 ` Jarkko Nikula
2016-02-12 18:58 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.