All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend
Date: Tue, 2 Feb 2016 17:29:39 +0000	[thread overview]
Message-ID: <20160202172939.GE32084@stefanha-x1.localdomain> (raw)
In-Reply-To: <1454083668-23520-1-git-send-email-stefanha@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Fri, Jan 29, 2016 at 04:07:48PM +0000, Stefan Hajnoczi wrote:
> The GThread coroutine backend was a portable coroutine implementation.
> Over the years all platforms got their own optimized coroutine
> implementations and nothing uses the GThread backend anymore.
> 
> In fact, ./configure mentions the GThread backend doesn't work but might
> be useful for debugging.  Since GDB macros were added to ease debugging
> of ucontext coroutines, there seems little point in keeping a broken
> backend around.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  configure                |  19 ++---
>  util/coroutine-gthread.c | 198 -----------------------------------------------
>  2 files changed, 5 insertions(+), 212 deletions(-)
>  delete mode 100644 util/coroutine-gthread.c

NACK

Alex Bennee pointed out that ThreadSanitizer needs the GThread backend
because it cannot cope with stack switching.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2016-02-02 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 16:07 [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend Stefan Hajnoczi
2016-01-29 16:41 ` Alex Bennée
2016-02-01 11:37   ` Stefan Hajnoczi
2016-02-01 12:17     ` Alex Bennée
2016-02-02 17:29       ` Stefan Hajnoczi
2016-02-02 17:29 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160202172939.GE32084@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.