* [GIT PULL 0/3] perf/urgent fixes
@ 2016-02-03 17:04 Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 1/3] perf tools: tracepoint_error() can receive e=NULL, robustify it Arnaldo Carvalho de Melo
` (3 more replies)
0 siblings, 4 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-03 17:04 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Mark Wielaard,
Masami Hiramatsu, Naveen N . Rao, Srikar Dronamraju, Tong Zhang,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 28fb8a5b6e233fc384fb27f9f91f811b40ba9cf8:
Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-01-30 09:15:49 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to 270bde1e76f400d81f8d0ab68905a18ee17fa2e8:
perf probe: Search both .eh_frame and .debug_frame sections for probe location (2016-02-02 13:30:16 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- tracepoint_error() can receive e=NULL, robustify it, fixes a problem noticed
with a very specific combination: Machine with Intel PT (e.g. Broadwell),
kernel with no perf_event_attr.context_switch feature (e.g. 4.2) and unreadable
tracefs (for instance !root users), making the fallback from
perf_event_attr.context_switch to the sched:sched_switch tracepoint to fail
reading its info from tracefs, fix it. (Adrian Hunter)
- Fix segfault in intel pt, by making it follow the 'struct thread' lifetime cycle
checking expectations, noticed for instance, when processing perf.data files with
Intel PT data using 'perf script' and when exiting 'perf report' (Adrian Hunter)
- Fix CFI usage from .eh_frame and .debug_frame, which sometimes requires that we
fallback from .eh_frame to .debug_frame in architectures such as PowerPC (Hemant Kumar)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf tools: tracepoint_error() can receive e=NULL, robustify it
perf tools: Fix thread lifetime related segfaut in intel_pt
Hemant Kumar (1):
perf probe: Search both .eh_frame and .debug_frame sections for probe location
tools/perf/util/intel-pt.c | 9 ++++++
tools/perf/util/parse-events.c | 3 ++
tools/perf/util/probe-finder.c | 62 +++++++++++++++++++++++++-----------------
tools/perf/util/probe-finder.h | 5 +++-
4 files changed, 53 insertions(+), 26 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 1/3] perf tools: tracepoint_error() can receive e=NULL, robustify it
2016-02-03 17:04 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
@ 2016-02-03 17:04 ` Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 2/3] perf tools: Fix thread lifetime related segfaut in intel_pt Arnaldo Carvalho de Melo
` (2 subsequent siblings)
3 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-03 17:04 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Jiri Olsa, Josh Poimboeuf,
Tong Zhang, Wang Nan, stable, #, v4.4+,
Arnaldo Carvalho de Melo
See http://www.infradead.org/rpr.html
From: Adrian Hunter <adrian.hunter@intel.com>
Fixes segmentation fault using, for instance:
(gdb) run record -I -e intel_pt/tsc=1,noretcomp=1/u /bin/ls
Starting program: /home/acme/bin/perf record -I -e intel_pt/tsc=1,noretcomp=1/u /bin/ls
Missing separate debuginfos, use: dnf debuginfo-install glibc-2.22-7.fc23.x86_64
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
0 x00000000004b9ea5 in tracepoint_error (e=0x0, err=13, sys=0x19b1370 "sched", name=0x19a5d00 "sched_switch") at util/parse-events.c:410
(gdb) bt
#0 0x00000000004b9ea5 in tracepoint_error (e=0x0, err=13, sys=0x19b1370 "sched", name=0x19a5d00 "sched_switch") at util/parse-events.c:410
#1 0x00000000004b9fc5 in add_tracepoint (list=0x19a5d20, idx=0x7fffffffb8c0, sys_name=0x19b1370 "sched", evt_name=0x19a5d00 "sched_switch", err=0x0, head_config=0x0)
at util/parse-events.c:433
#2 0x00000000004ba334 in add_tracepoint_event (list=0x19a5d20, idx=0x7fffffffb8c0, sys_name=0x19b1370 "sched", evt_name=0x19a5d00 "sched_switch", err=0x0, head_config=0x0)
at util/parse-events.c:498
#3 0x00000000004bb699 in parse_events_add_tracepoint (list=0x19a5d20, idx=0x7fffffffb8c0, sys=0x19b1370 "sched", event=0x19a5d00 "sched_switch", err=0x0, head_config=0x0)
at util/parse-events.c:936
#4 0x00000000004f6eda in parse_events_parse (_data=0x7fffffffb8b0, scanner=0x19a49d0) at util/parse-events.y:391
#5 0x00000000004bc8e5 in parse_events__scanner (str=0x663ff2 "sched:sched_switch", data=0x7fffffffb8b0, start_token=258) at util/parse-events.c:1361
#6 0x00000000004bca57 in parse_events (evlist=0x19a5220, str=0x663ff2 "sched:sched_switch", err=0x0) at util/parse-events.c:1401
#7 0x0000000000518d5f in perf_evlist__can_select_event (evlist=0x19a3b90, str=0x663ff2 "sched:sched_switch") at util/record.c:253
#8 0x0000000000553c42 in intel_pt_track_switches (evlist=0x19a3b90) at arch/x86/util/intel-pt.c:364
#9 0x00000000005549d1 in intel_pt_recording_options (itr=0x19a2c40, evlist=0x19a3b90, opts=0x8edf68 <record+232>) at arch/x86/util/intel-pt.c:664
#10 0x000000000051e076 in auxtrace_record__options (itr=0x19a2c40, evlist=0x19a3b90, opts=0x8edf68 <record+232>) at util/auxtrace.c:539
#11 0x0000000000433368 in cmd_record (argc=1, argv=0x7fffffffde60, prefix=0x0) at builtin-record.c:1264
#12 0x000000000049bec2 in run_builtin (p=0x8fa2a8 <commands+168>, argc=5, argv=0x7fffffffde60) at perf.c:390
#13 0x000000000049c12a in handle_internal_command (argc=5, argv=0x7fffffffde60) at perf.c:451
#14 0x000000000049c278 in run_argv (argcp=0x7fffffffdcbc, argv=0x7fffffffdcb0) at perf.c:495
#15 0x000000000049c60a in main (argc=5, argv=0x7fffffffde60) at perf.c:618
(gdb)
Intel PT attempts to find the sched:sched_switch tracepoint but that seg
faults if tracefs is not readable, because the error reporting structure
is null, as errors are not reported when automatically adding
tracepoints. Fix by checking before using.
Committer note:
This doesn't take place in a kernel that supports
perf_event_attr.context_switch, that is the default way that will be
used for tracking context switches, only in older kernels, like 4.2, in
a machine with Intel PT (e.g. Broadwell) for non-priviledged users.
Further info from a similar patch by Wang:
The error is in tracepoint_error: it assumes the 'e' parameter is valid.
However, there are many situation a parse_event() can be called without
parse_events_error. See result of
$ grep 'parse_events(.*NULL)' ./tools/perf/ -r'
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Tong Zhang <ztong@vt.edu>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: stable@vger.kernel.org # v4.4+
Fixes: 196581717d85 ("perf tools: Enhance parsing events tracepoint error output")
Link: http://lkml.kernel.org/r/1453809921-24596-2-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/parse-events.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 4f7b0efdde2f..813d9b272c81 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -399,6 +399,9 @@ static void tracepoint_error(struct parse_events_error *e, int err,
{
char help[BUFSIZ];
+ if (!e)
+ return;
+
/*
* We get error directly from syscall errno ( > 0),
* or from encoded pointer's error ( < 0).
--
2.5.0
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH 2/3] perf tools: Fix thread lifetime related segfaut in intel_pt
2016-02-03 17:04 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 1/3] perf tools: tracepoint_error() can receive e=NULL, robustify it Arnaldo Carvalho de Melo
@ 2016-02-03 17:04 ` Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 3/3] perf probe: Search both .eh_frame and .debug_frame sections for probe location Arnaldo Carvalho de Melo
2016-02-04 7:56 ` [GIT PULL 0/3] perf/urgent fixes Ingo Molnar
3 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-03 17:04 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Josh Poimboeuf, Arnaldo Carvalho de Melo
See http://www.infradead.org/rpr.html
From: Adrian Hunter <adrian.hunter@intel.com>
intel_pt_process_auxtrace_info() creates a pt->unknown_thread thread
that eventually needs to be freed by the last thread__put() on it, when
its refcount hits zero, which may happen in
intel_pt_process_auxtrace_info() error handling path and triggers the
following segfault, which would happen as well at intel_pt_free, when
tools using this intel_pt codebase frees up resources:
# perf record -I -e intel_pt/tsc=1,noretcomp=1/u /bin/ls
0 a anaconda-ks.cfg bin perf.data perf.data.old perf-f23-bringup.todo
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.217 MB perf.data ]
#
# perf script -F event,comm,pid,tid,time,addr,ip,sym,dso,iregs
Samples for 'instructions:u' event do not have IREGS attribute set. Cannot print 'iregs' field.
intel_pt_synth_events: failed to synthesize 'instructions' event type
Segmentation fault (core dumped)
#
The problem is: there's a union in 'struct thread' combines a list_head
and a rb_node. The standard life cycle of a thread is: init rb_node in
the constructor, insert it into machine->threads rbtree using rb_node,
move it to machine->dead_threads using list_head, clean in the last
thread__put: list_del_init(&thread->node).
In the above command, it clean a thread before adding it into list,
causes the above segfault.
Since pt->unknown_thread will never live in an rbtree, initialize its
list node so that when list_del_init() is done on it we don't segfault.
After this patch:
# perf script -F event,comm,pid,tid,time,addr,ip,sym,dso,iregs
Samples for 'instructions:u' event do not have IREGS attribute set. Cannot print 'iregs' field.
intel_pt_synth_events: failed to synthesize 'instructions' event type
0x248 [0x88]: failed to process type: 70
#
Reported-by: Tong Zhang <ztong@vt.edu>
Reported-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Link: http://lkml.kernel.org/r/1454296865-19749-1-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/intel-pt.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
index 81a2eb77ba7f..05d815851be1 100644
--- a/tools/perf/util/intel-pt.c
+++ b/tools/perf/util/intel-pt.c
@@ -2068,6 +2068,15 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
err = -ENOMEM;
goto err_free_queues;
}
+
+ /*
+ * Since this thread will not be kept in any rbtree not in a
+ * list, initialize its list node so that at thread__put() the
+ * current thread lifetime assuption is kept and we don't segfault
+ * at list_del_init().
+ */
+ INIT_LIST_HEAD(&pt->unknown_thread->node);
+
err = thread__set_comm(pt->unknown_thread, "unknown", 0);
if (err)
goto err_delete_thread;
--
2.5.0
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH 3/3] perf probe: Search both .eh_frame and .debug_frame sections for probe location
2016-02-03 17:04 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 1/3] perf tools: tracepoint_error() can receive e=NULL, robustify it Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 2/3] perf tools: Fix thread lifetime related segfaut in intel_pt Arnaldo Carvalho de Melo
@ 2016-02-03 17:04 ` Arnaldo Carvalho de Melo
2016-02-04 7:56 ` [GIT PULL 0/3] perf/urgent fixes Ingo Molnar
3 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-03 17:04 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Hemant Kumar, linuxppc-dev, Mark Wielaard,
Naveen N. Rao, Srikar Dronamraju, Arnaldo Carvalho de Melo
From: Hemant Kumar <hemant@linux.vnet.ibm.com>
'perf probe' through debuginfo__find_probes() in util/probe-finder.c
checks for the functions' frame descriptions in either .eh_frame section
of an ELF or the .debug_frame.
The check is based on whether either one of these sections is present.
Depending on distro, toolchain defaults, architetcutre, build flags,
etc., CFI might be found in either .eh_frame and/or .debug_frame.
Sometimes, it may happen that, .eh_frame, even if present, may not be
complete and may miss some descriptions.
Therefore, to be sure, to find the CFI covering an address we will
always have to investigate both if available.
For e.g., in powerpc, this may happen:
$ gcc -g bin.c -o bin
$ objdump --dwarf ./bin
<1><145>: Abbrev Number: 7 (DW_TAG_subprogram)
<146> DW_AT_external : 1
<146> DW_AT_name : (indirect string, offset: 0x9e): main
<14a> DW_AT_decl_file : 1
<14b> DW_AT_decl_line : 39
<14c> DW_AT_prototyped : 1
<14c> DW_AT_type : <0x57>
<150> DW_AT_low_pc : 0x100007b8
If the .eh_frame and .debug_frame are checked for the same binary, we
will find that, .eh_frame (although present) doesn't contain a
description for "main" function.
But, .debug_frame has a description:
000000d8 00000024 00000000 FDE cie=00000000 pc=100007b8..10000838
DW_CFA_advance_loc: 16 to 100007c8
DW_CFA_def_cfa_offset: 144
DW_CFA_offset_extended_sf: r65 at cfa+16
...
Due to this (since, perf checks whether .eh_frame is present and goes on
searching for that address inside that frame), perf is unable to process
the probes:
# perf probe -x ./bin main
Failed to get call frame on 0x100007b8
Error: Failed to add events.
To avoid this issue, we need to check both the sections (.eh_frame and
.debug_frame), which is done in this patch.
Note that, we can always force everything into both .eh_frame and
.debug_frame by:
$ gcc bin.c -fasynchronous-unwind-tables -fno-dwarf2-cfi-asm -g -o bin
Signed-off-by: Hemant Kumar <hemant@linux.vnet.ibm.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Mark Wielaard <mjw@redhat.com>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1454426806-13974-1-git-send-email-hemant@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-finder.c | 62 +++++++++++++++++++++++++-----------------
tools/perf/util/probe-finder.h | 5 +++-
2 files changed, 41 insertions(+), 26 deletions(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 2be10fb27172..4ce5c5e18f48 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -686,8 +686,9 @@ static int call_probe_finder(Dwarf_Die *sc_die, struct probe_finder *pf)
pf->fb_ops = NULL;
#if _ELFUTILS_PREREQ(0, 142)
} else if (nops == 1 && pf->fb_ops[0].atom == DW_OP_call_frame_cfa &&
- pf->cfi != NULL) {
- if (dwarf_cfi_addrframe(pf->cfi, pf->addr, &frame) != 0 ||
+ (pf->cfi_eh != NULL || pf->cfi_dbg != NULL)) {
+ if ((dwarf_cfi_addrframe(pf->cfi_eh, pf->addr, &frame) != 0 &&
+ (dwarf_cfi_addrframe(pf->cfi_dbg, pf->addr, &frame) != 0)) ||
dwarf_frame_cfa(frame, &pf->fb_ops, &nops) != 0) {
pr_warning("Failed to get call frame on 0x%jx\n",
(uintmax_t)pf->addr);
@@ -1015,8 +1016,7 @@ static int pubname_search_cb(Dwarf *dbg, Dwarf_Global *gl, void *data)
return DWARF_CB_OK;
}
-/* Find probe points from debuginfo */
-static int debuginfo__find_probes(struct debuginfo *dbg,
+static int debuginfo__find_probe_location(struct debuginfo *dbg,
struct probe_finder *pf)
{
struct perf_probe_point *pp = &pf->pev->point;
@@ -1025,27 +1025,6 @@ static int debuginfo__find_probes(struct debuginfo *dbg,
Dwarf_Die *diep;
int ret = 0;
-#if _ELFUTILS_PREREQ(0, 142)
- Elf *elf;
- GElf_Ehdr ehdr;
- GElf_Shdr shdr;
-
- /* Get the call frame information from this dwarf */
- elf = dwarf_getelf(dbg->dbg);
- if (elf == NULL)
- return -EINVAL;
-
- if (gelf_getehdr(elf, &ehdr) == NULL)
- return -EINVAL;
-
- if (elf_section_by_name(elf, &ehdr, &shdr, ".eh_frame", NULL) &&
- shdr.sh_type == SHT_PROGBITS) {
- pf->cfi = dwarf_getcfi_elf(elf);
- } else {
- pf->cfi = dwarf_getcfi(dbg->dbg);
- }
-#endif
-
off = 0;
pf->lcache = intlist__new(NULL);
if (!pf->lcache)
@@ -1108,6 +1087,39 @@ found:
return ret;
}
+/* Find probe points from debuginfo */
+static int debuginfo__find_probes(struct debuginfo *dbg,
+ struct probe_finder *pf)
+{
+ int ret = 0;
+
+#if _ELFUTILS_PREREQ(0, 142)
+ Elf *elf;
+ GElf_Ehdr ehdr;
+ GElf_Shdr shdr;
+
+ if (pf->cfi_eh || pf->cfi_dbg)
+ return debuginfo__find_probe_location(dbg, pf);
+
+ /* Get the call frame information from this dwarf */
+ elf = dwarf_getelf(dbg->dbg);
+ if (elf == NULL)
+ return -EINVAL;
+
+ if (gelf_getehdr(elf, &ehdr) == NULL)
+ return -EINVAL;
+
+ if (elf_section_by_name(elf, &ehdr, &shdr, ".eh_frame", NULL) &&
+ shdr.sh_type == SHT_PROGBITS)
+ pf->cfi_eh = dwarf_getcfi_elf(elf);
+
+ pf->cfi_dbg = dwarf_getcfi(dbg->dbg);
+#endif
+
+ ret = debuginfo__find_probe_location(dbg, pf);
+ return ret;
+}
+
struct local_vars_finder {
struct probe_finder *pf;
struct perf_probe_arg *args;
diff --git a/tools/perf/util/probe-finder.h b/tools/perf/util/probe-finder.h
index bed82716e1b4..0aec7704e395 100644
--- a/tools/perf/util/probe-finder.h
+++ b/tools/perf/util/probe-finder.h
@@ -76,7 +76,10 @@ struct probe_finder {
/* For variable searching */
#if _ELFUTILS_PREREQ(0, 142)
- Dwarf_CFI *cfi; /* Call Frame Information */
+ /* Call Frame Information from .eh_frame */
+ Dwarf_CFI *cfi_eh;
+ /* Call Frame Information from .debug_frame */
+ Dwarf_CFI *cfi_dbg;
#endif
Dwarf_Op *fb_ops; /* Frame base attribute */
struct perf_probe_arg *pvar; /* Current target variable */
--
2.5.0
^ permalink raw reply related [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2016-02-03 17:04 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2016-02-03 17:04 ` [PATCH 3/3] perf probe: Search both .eh_frame and .debug_frame sections for probe location Arnaldo Carvalho de Melo
@ 2016-02-04 7:56 ` Ingo Molnar
3 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2016-02-04 7:56 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Hemant Kumar, Jiri Olsa,
Josh Poimboeuf, Mark Wielaard, Masami Hiramatsu, Naveen N . Rao,
Srikar Dronamraju, Tong Zhang, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 28fb8a5b6e233fc384fb27f9f91f811b40ba9cf8:
>
> Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-01-30 09:15:49 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 270bde1e76f400d81f8d0ab68905a18ee17fa2e8:
>
> perf probe: Search both .eh_frame and .debug_frame sections for probe location (2016-02-02 13:30:16 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - tracepoint_error() can receive e=NULL, robustify it, fixes a problem noticed
> with a very specific combination: Machine with Intel PT (e.g. Broadwell),
> kernel with no perf_event_attr.context_switch feature (e.g. 4.2) and unreadable
> tracefs (for instance !root users), making the fallback from
> perf_event_attr.context_switch to the sched:sched_switch tracepoint to fail
> reading its info from tracefs, fix it. (Adrian Hunter)
>
> - Fix segfault in intel pt, by making it follow the 'struct thread' lifetime cycle
> checking expectations, noticed for instance, when processing perf.data files with
> Intel PT data using 'perf script' and when exiting 'perf report' (Adrian Hunter)
>
> - Fix CFI usage from .eh_frame and .debug_frame, which sometimes requires that we
> fallback from .eh_frame to .debug_frame in architectures such as PowerPC (Hemant Kumar)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf tools: tracepoint_error() can receive e=NULL, robustify it
> perf tools: Fix thread lifetime related segfaut in intel_pt
>
> Hemant Kumar (1):
> perf probe: Search both .eh_frame and .debug_frame sections for probe location
>
> tools/perf/util/intel-pt.c | 9 ++++++
> tools/perf/util/parse-events.c | 3 ++
> tools/perf/util/probe-finder.c | 62 +++++++++++++++++++++++++-----------------
> tools/perf/util/probe-finder.h | 5 +++-
> 4 files changed, 53 insertions(+), 26 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2019-11-05 18:18 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-11-05 18:18 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner
Cc: Jiri Olsa, Namhyung Kim, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo,
Daniel Bristot de Oliveira, Steven Rostedt,
Arnaldo Carvalho de Melo
Hi Ingo/Thomas,
Please consider pulling,
Best regards,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 652521d460cbfa24ef27717b4b28acfac4281be6:
perf/headers: Fix spelling s/EACCESS/EACCES/, s/privilidge/privilege/ (2019-10-28 11:02:01 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.4-20191105
for you to fetch changes up to 722ddfde366fd46205456a9c5ff9b3359dc9a75e:
perf tools: Fix time sorting (2019-11-05 08:49:14 -0300)
----------------------------------------------------------------
perf/urgent fixes:
perf report/top:
Jiri Olsa:
- Fix time sorting for big numbers, i.e.:
perf report -s time -F time,overhead --stdio
was failing because the sort comparision routine was returning 'int' while
that particular -s key was int64_t, fix it.
perf scripting engines:
Steven Rostedt (VMware):
- Iterate on tep event arrays directly, fixing a bug when generating python/perl
source code from a perf.data file with more than one tracepoint event.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Jiri Olsa (1):
perf tools: Fix time sorting
Steven Rostedt (VMware) (2):
perf scripting engines: Iterate on tep event arrays directly
perf tools: Remove unused trace_find_next_event()
tools/perf/util/hist.c | 2 +-
.../perf/util/scripting-engines/trace-event-perl.c | 8 ++++--
.../util/scripting-engines/trace-event-python.c | 9 +++++--
tools/perf/util/trace-event-parse.c | 31 ----------------------
tools/perf/util/trace-event.h | 2 --
5 files changed, 14 insertions(+), 38 deletions(-)
Test results:
The first ones are container based builds of tools/perf with and without libelf
support. Where clang is available, it is also used to build perf with/without
libelf, and building with LIBCLANGLLVM=1 (built-in clang) with gcc and clang
when clang and its devel libraries are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
Clearlinux is failing when building with libpython, but that is not a perf
regression, will try to remove one compiler warning that is causing the problem
when building some of the glue code files in the python files, outside perf.
Manjaro is failing due to some missing library related to bison, looks like
a distro bug.
# export PERF_TARBALL=http://192.168.124.1/perf/perf-5.4.0-rc5.tar.xz
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0, clang version 3.8.0 (tags/RELEASE_380/final)
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822, clang version 3.8.1 (tags/RELEASE_381/final)
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0, clang version 4.0.0 (tags/RELEASE_400/final)
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0, Alpine clang version 5.0.0 (tags/RELEASE_500/final) (based on LLVM 5.0.0)
5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0, Alpine clang version 5.0.1 (tags/RELEASE_501/final) (based on LLVM 5.0.1)
6 alpine:3.9 : Ok gcc (Alpine 8.3.0) 8.3.0, Alpine clang version 5.0.1 (tags/RELEASE_502/final) (based on LLVM 5.0.1)
7 alpine:3.10 : Ok gcc (Alpine 8.3.0) 8.3.0, Alpine clang version 8.0.0 (tags/RELEASE_800/final) (based on LLVM 8.0.0)
8 alpine:edge : Ok gcc (Alpine 9.2.0) 9.2.0, Alpine clang version 8.0.1 (tags/RELEASE_801/final) (based on LLVM 8.0.1)
9 amazonlinux:1 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2), clang version 3.6.2 (tags/RELEASE_362/final)
10 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6), clang version 7.0.1 (Amazon Linux 2 7.0.1-1.amzn2.0.2)
11 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
12 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
13 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
14 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
15 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39), clang version 3.4.2 (tags/RELEASE_34/dot2-final)
16 centos:8 : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3), clang version 7.0.1 (tags/RELEASE_701/final)
17 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 9.2.1 20191101 gcc-9-branch@277702, clang version 9.0.0 (tags/RELEASE_900/final)
18 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u2) 4.9.2, Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
19 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, clang version 3.8.1-24 (tags/RELEASE_381/final)
20 debian:10 : Ok gcc (Debian 8.3.0-6) 8.3.0, clang version 7.0.1-8 (tags/RELEASE_701/final)
21 debian:experimental : Ok gcc (Debian 9.2.1-9) 9.2.1 20191008, clang version 8.0.1-3+b1 (tags/RELEASE_801/final)
22 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.3.0-19) 8.3.0
23 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.3.0-19) 8.3.0
24 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.3.0-19) 8.3.0
25 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.3.0-19) 8.3.0
26 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7), clang version 3.4.2 (tags/RELEASE_34/dot2-final)
27 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), clang version 3.5.0 (tags/RELEASE_350/final)
28 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), clang version 3.7.0 (tags/RELEASE_370/final)
29 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1), clang version 3.8.1 (tags/RELEASE_381/final)
30 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
31 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1), clang version 3.9.1 (tags/RELEASE_391/final)
32 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2), clang version 4.0.1 (tags/RELEASE_401/final)
33 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6), clang version 5.0.2 (tags/RELEASE_502/final)
34 fedora:28 : Ok gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2), clang version 6.0.1 (tags/RELEASE_601/final)
35 fedora:29 : Ok gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2), clang version 7.0.1 (Fedora 7.0.1-6.fc29)
36 fedora:30 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 8.0.0 (Fedora 8.0.0-3.fc30)
37 fedora:30-x-ARC-glibc : Ok arc-linux-gcc (ARC HS GNU/Linux glibc toolchain 2019.03-rc1) 8.3.1 20190225
38 fedora:30-x-ARC-uClibc : Ok arc-linux-gcc (ARCv2 ISA Linux uClibc toolchain 2019.03-rc1) 8.3.1 20190225
39 fedora:31 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc31)
40 fedora:32 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc32)
41 fedora:rawhide : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc32)
42 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 8.3.0-r1 p1.1) 8.3.0
43 mageia:5 : Ok gcc (GCC) 4.9.2, clang version 3.5.2 (tags/RELEASE_352/final)
44 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0, clang version 3.9.1 (tags/RELEASE_391/final)
45 mageia:7 : Ok gcc (Mageia 8.3.1-0.20190524.1.mga7) 8.3.1 20190524, clang version 8.0.0 (Mageia 8.0.0-1.mga7)
46 manjaro:latest : FAIL gcc (GCC) 9.2.0, clang version 9.0.0 (tags/RELEASE_900/final)
47 opensuse:15.0 : Ok gcc (SUSE Linux) 7.4.1 20190424 [gcc-7-branch revision 270538], clang version 5.0.1 (tags/RELEASE_501/final 312548)
48 opensuse:15.1 : Ok gcc (SUSE Linux) 7.4.1 20190905 [gcc-7-branch revision 275407], clang version 7.0.1 (tags/RELEASE_701/final 349238)
49 opensuse:15.2 : Ok gcc (SUSE Linux) 7.4.1 20190424 [gcc-7-branch revision 270538], clang version 7.0.1 (tags/RELEASE_701/final 349238)
50 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5, clang version 3.8.0 (tags/RELEASE_380/final 262553)
51 opensuse:tumbleweed : Ok gcc (SUSE Linux) 9.2.1 20190903 [gcc-9-branch revision 275330], clang version 9.0.0 (tags/RELEASE_900/final 372316)
52 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
53 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39.0.1), clang version 3.4.2 (tags/RELEASE_34/dot2-final)
54 oraclelinux:8 : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3.0.1), clang version 7.0.1 (tags/RELEASE_701/final)
55 ubuntu:12.04 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
56 ubuntu:14.04 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4) 4.8.4, Ubuntu clang version 3.4-1ubuntu3 (tags/RELEASE_34/final) (based on LLVM 3.4)
57 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609, clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
58 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
59 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
60 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
61 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
62 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
63 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
64 ubuntu:18.04 : Ok gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0, clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
65 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.4.0-1ubuntu1~18.04.1) 7.4.0
66 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.4.0-1ubuntu1~18.04.1) 7.4.0
67 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
68 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
69 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
70 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
71 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
72 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
73 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
74 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
75 ubuntu:18.10 : Ok gcc (Ubuntu 8.3.0-6ubuntu1~18.10.1) 8.3.0, clang version 7.0.0-3 (tags/RELEASE_700/final)
76 ubuntu:19.04 : Ok gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0, clang version 8.0.0-3 (tags/RELEASE_800/final)
77 ubuntu:19.04-x-alpha : Ok alpha-linux-gnu-gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0
78 ubuntu:19.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 8.3.0-6ubuntu1) 8.3.0
79 ubuntu:19.04-x-hppa : Ok hppa-linux-gnu-gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0
80 ubuntu:19.10 : Ok gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008, clang version 9.0.0-2 (tags/RELEASE_900/final)
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_pure_O: make
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_tags_O: make tags
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 NO_LIBZSTD=1 NO_LIBCAP=1
make_cscope_O: make cscope
make_help_O: make help
make_install_prefix_O: make install prefix=/tmp/krava
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_libelf_O: make NO_LIBELF=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_O: make install
make_no_slang_O: make NO_SLANG=1
make_static_O: make LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 NO_JVMTI=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_clean_all_O: make clean all
make_debug_O: make DEBUG=1
make_no_gtk2_O: make NO_GTK2=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_newt_O: make NO_NEWT=1
make_doc_O: make doc
make_no_libaudit_O: make NO_LIBAUDIT=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libperl_O: make NO_LIBPERL=1
make_util_map_o_O: make util/map.o
make_install_bin_O: make install-bin
make_perf_o_O: make perf.o
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
# uname -a
Linux seventh 5.3.8-200.fc30.x86_64 #1 SMP Tue Oct 29 14:46:22 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
# git log --oneline -1
722ddfde366f perf tools: Fix time sorting
# perf version --build-options
perf version 5.4.rc5.g722ddfde366f
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
aio: [ on ] # HAVE_AIO_SUPPORT
zstd: [ on ] # HAVE_ZSTD_SUPPORT
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Watchpoint :
22.1: Read Only Watchpoint : Skip
22.2: Write Only Watchpoint : Ok
22.3: Read / Write Watchpoint : Ok
22.4: Modify Watchpoint : Ok
23: Number of exit events of a simple workload : Ok
24: Software clock events period values : Ok
25: Object code reading : Ok
26: Sample parsing : Ok
27: Use a dummy software event to keep tracking : Ok
28: Parse with no sample_id_all bit set : Ok
29: Filter hist entries : Ok
30: Lookup mmap thread : Ok
31: Share thread mg : Ok
32: Sort output of hist entries : Ok
33: Cumulate child hist entries : Ok
34: Track with sched_switch : Ok
35: Filter fds with revents mask in a fdarray : Ok
36: Add fd to a fdarray, making it autogrow : Ok
37: kmod_path__parse : Ok
38: Thread map : Ok
39: LLVM search and compile :
39.1: Basic BPF llvm compile : Ok
39.2: kbuild searching : Ok
39.3: Compile source for BPF prologue generation : Ok
39.4: Compile source for BPF relocation : Ok
40: Session topology : Ok
41: BPF filter :
41.1: Basic BPF filtering : Ok
41.2: BPF pinning : Ok
41.3: BPF prologue generation : Ok
41.4: BPF relocation checker : Ok
42: Synthesize thread map : Ok
43: Remove thread map : Ok
44: Synthesize cpu map : Ok
45: Synthesize stat config : Ok
46: Synthesize stat : Ok
47: Synthesize stat round : Ok
48: Synthesize attr update : Ok
49: Event times : Ok
50: Read backward ring buffer : Ok
51: Print cpu map : Ok
52: Probe SDT events : Ok
53: is_printable_array : Ok
54: Print bitmap : Ok
55: perf hooks : Ok
56: builtin clang support : Skip (not compiled in)
57: unit_number__scnprintf : Ok
58: mem2node : Ok
59: time utils : Ok
60: map_groups__merge_in : Ok
61: x86 rdpmc : Ok
62: Convert perf time to TSC : Ok
63: DWARF unwind : Ok
64: x86 instruction decoder - new instructions : Ok
65: Intel PT packet decoder : Ok
66: x86 bp modify : Ok
67: probe libc's inet_pton & backtrace it with ping : Ok
68: Zstd perf.data compression/decompression : Ok
69: Check open filename arg using perf trace + vfs_getname: Ok
70: Use vfs_getname probe to get syscall args filenames : Ok
71: Add vfs_getname probe to get syscall args filenames : Ok
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2017-10-10 15:26 Arnaldo Carvalho de Melo
@ 2017-10-10 17:23 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2017-10-10 17:23 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov, Borislav Petkov,
David Ahern, David S . Miller, Jiri Olsa, Mark Rutland,
Mark Santaniello, Namhyung Kim, Peter Zijlstra, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 874d48f2af91efc38c720e7c6450547f6ea8c843:
>
> Merge tag 'perf-urgent-for-mingo-4.14-20171005' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-10-05 20:07:08 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20171010
>
> for you to fetch changes up to aa7b4e02b328f0589b6133e72aafb1289f614a79:
>
> tools include uapi bpf.h: Sync kernel ABI header with tooling header (2017-10-09 15:55:45 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Unbreak 'perf record' for arm/arm64 with events with explicit PMU (Mark Rutland)
>
> - Add missing separator for "perf script -F ip,brstack" (and brstackoff) (Mark Santaniello)
>
> - One line, comment only, sync kernel ABI header with tooling header (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> tools include uapi bpf.h: Sync kernel ABI header with tooling header
>
> Mark Rutland (1):
> perf pmu: Unbreak perf record for arm/arm64 with events with explicit PMU
>
> Mark Santaniello (1):
> perf script: Add missing separator for "-F ip,brstack" (and brstackoff)
>
> tools/include/uapi/linux/bpf.h | 2 +-
> tools/perf/builtin-script.c | 4 +--
> tools/perf/util/parse-events.c | 9 ++++---
> tools/perf/util/pmu.c | 56 +++++++++++++++++++++++++++++++-----------
> tools/perf/util/pmu.h | 1 +
> 5 files changed, 50 insertions(+), 22 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2017-10-10 15:26 Arnaldo Carvalho de Melo
2017-10-10 17:23 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-10-10 15:26 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Alexei Starovoitov,
Borislav Petkov, David Ahern, David S . Miller, Jiri Olsa,
Mark Rutland, Mark Santaniello, Namhyung Kim, Peter Zijlstra,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 874d48f2af91efc38c720e7c6450547f6ea8c843:
Merge tag 'perf-urgent-for-mingo-4.14-20171005' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-10-05 20:07:08 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20171010
for you to fetch changes up to aa7b4e02b328f0589b6133e72aafb1289f614a79:
tools include uapi bpf.h: Sync kernel ABI header with tooling header (2017-10-09 15:55:45 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Unbreak 'perf record' for arm/arm64 with events with explicit PMU (Mark Rutland)
- Add missing separator for "perf script -F ip,brstack" (and brstackoff) (Mark Santaniello)
- One line, comment only, sync kernel ABI header with tooling header (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
tools include uapi bpf.h: Sync kernel ABI header with tooling header
Mark Rutland (1):
perf pmu: Unbreak perf record for arm/arm64 with events with explicit PMU
Mark Santaniello (1):
perf script: Add missing separator for "-F ip,brstack" (and brstackoff)
tools/include/uapi/linux/bpf.h | 2 +-
tools/perf/builtin-script.c | 4 +--
tools/perf/util/parse-events.c | 9 ++++---
tools/perf/util/pmu.c | 56 +++++++++++++++++++++++++++++++-----------
tools/perf/util/pmu.h | 1 +
5 files changed, 50 insertions(+), 22 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support. Where clang is available, it is also used to build
perf with/without libelf.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 android-ndk:r15c-arm: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: FAIL
builtin-sched.c: In function 'timehist_sched_switch_event':
builtin-sched.c:2580:1: internal compiler error: in change_address_1, at emit-rtl.c:2150
}
^
util/db-export.c: In function 'db_export__sample':
util/db-export.c:429:1: internal compiler error: in change_address_1, at emit-rtl.c:2150
}
^
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/issues> for instructions.
Bug reported: https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/issues/137
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: Ok
27 mageia:5: Ok
28 opensuse:42.1: Ok
29 opensuse:42.2: Ok
30 opensuse:42.3: Ok
31 opensuse:tumbleweed: Ok
32 oraclelinux:6: Ok
33 oraclelinux:7: O
34 ubuntu:12.04.5: Ok
35 ubuntu:14.04.4: Ok
36 ubuntu:14.04.4-x-linaro-arm64: Ok
37 ubuntu:15.04: Ok
38 ubuntu:15.10: Ok
39 ubuntu:16.04: Ok
40 ubuntu:16.04-x-arm: Ok
41 ubuntu:16.04-x-arm64: Ok
42 ubuntu:16.04-x-powerpc: Ok
43 ubuntu:16.04-x-powerpc64: Ok
44 ubuntu:16.04-x-powerpc64el: Ok
45 ubuntu:16.04-x-s390: Ok
46 ubuntu:16.10: Ok
47 ubuntu:17.04: Ok
48 ubuntu:17.10: Ok
# uname -a
Linux jouet 4.13.0+ #3 SMP Mon Sep 25 11:51:22 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Intel cqm nmi context read : Skip
61: Use vfs_getname probe to get syscall args filenames : Ok
62: probe libc's inet_pton & backtrace it with ping : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libbpf_O: make NO_LIBBPF=1
make_no_slang_O: make NO_SLANG=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_tags_O: make tags
make_with_babeltrace_O: make LIBBABELTRACE=1
make_perf_o_O: make perf.o
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_no_libnuma_O: make NO_LIBNUMA=1
make_debug_O: make DEBUG=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_pure_O: make
make_static_O: make LDFLAGS=-static
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_demangle_O: make NO_DEMANGLE=1
make_help_O: make help
make_install_O: make install
make_util_map_o_O: make util/map.o
make_no_newt_O: make NO_NEWT=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_doc_O: make doc
make_no_libelf_O: make NO_LIBELF=1
make_install_bin_O: make install-bin
make_clean_all_O: make clean all
make_install_prefix_slash_O: make install prefix=/tmp/krava/
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2017-07-10 23:01 Arnaldo Carvalho de Melo
@ 2017-07-11 8:17 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2017-07-11 8:17 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Andi Kleen,
Andy Lutomirski, David Ahern, Jiri Olsa, Kan Liang, Namhyung Kim,
Peter Zijlstra, Wang Nan, Yao Jin, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling, the exclude_kernel one is a nasty brown paper
> bag one, I'd say :-\
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit dbf580623d5fee785218d1a47a2bcdf36d85c0e9:
>
> kprobes: Ensure that jprobe probepoints are at function entry (2017-07-08 11:05:35 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.13-20170710
>
> for you to fetch changes up to 80f62589fa52f530cffc50e78c0b5a2ae572d61e:
>
> perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target (2017-07-10 16:36:40 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Fix attr.exclude_kernel setting for default cycles:p (Arnaldo Carvalho de Melo)
>
> - Fix broken arrow at row 0 connecting jmp instruction to its target in
> the annotate TUI (Jin Yao)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf evsel: Fix attr.exclude_kernel setting for default cycles:p
> perf evsel: State in the default event name if attr.exclude_kernel is set
>
> Jin Yao (1):
> perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target
>
> tools/perf/ui/browser.c | 2 +-
> tools/perf/util/evsel.c | 8 +++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2017-07-10 23:01 Arnaldo Carvalho de Melo
2017-07-11 8:17 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-07-10 23:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Andy Lutomirski, David Ahern,
Jiri Olsa, Kan Liang, Namhyung Kim, Peter Zijlstra, Wang Nan,
Yao Jin, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, the exclude_kernel one is a nasty brown paper
bag one, I'd say :-\
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit dbf580623d5fee785218d1a47a2bcdf36d85c0e9:
kprobes: Ensure that jprobe probepoints are at function entry (2017-07-08 11:05:35 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.13-20170710
for you to fetch changes up to 80f62589fa52f530cffc50e78c0b5a2ae572d61e:
perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target (2017-07-10 16:36:40 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix attr.exclude_kernel setting for default cycles:p (Arnaldo Carvalho de Melo)
- Fix broken arrow at row 0 connecting jmp instruction to its target in
the annotate TUI (Jin Yao)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf evsel: Fix attr.exclude_kernel setting for default cycles:p
perf evsel: State in the default event name if attr.exclude_kernel is set
Jin Yao (1):
perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target
tools/perf/ui/browser.c | 2 +-
tools/perf/util/evsel.c | 8 +++++---
2 files changed, 6 insertions(+), 4 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:rawhide: Ok
26 mageia:5: Ok
27 opensuse:13.2: Ok
28 opensuse:42.1: Ok
29 opensuse:42.2: Ok
30 opensuse:tumbleweed: Ok
31 ubuntu:12.04.5: Ok
32 ubuntu:14.04.4: Ok
33 ubuntu:14.04.4-x-linaro-arm64: Ok
34 ubuntu:15.10: Ok
35 ubuntu:16.04: Ok
36 ubuntu:16.04-x-arm: Ok
37 ubuntu:16.04-x-arm64: Ok
38 ubuntu:16.04-x-powerpc: Ok
39 ubuntu:16.04-x-powerpc64: Ok
40 ubuntu:16.04-x-powerpc64el: Ok
41 ubuntu:16.04-x-s390: Ok
42 ubuntu:16.10: Ok
43 ubuntu:17.04: Ok
44 ubuntu:17.10: Ok
# uname -a
Linux jouet 4.12.0-rc6+ #3 SMP Tue Jun 27 15:12:38 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking: Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation: Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Skip
38.2: BPF pinning : Skip
38.3: BPF prologue generation : Skip
38.4: BPF relocation checker : Skip
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : Ok
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libelf_O: make NO_LIBELF=1
make_no_libbpf_O: make NO_LIBBPF=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_install_O: make install
make_static_O: make LDFLAGS=-static
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_gtk2_O: make NO_GTK2=1
make_tags_O: make tags
make_no_libperl_O: make NO_LIBPERL=1
make_no_slang_O: make NO_SLANG=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_help_O: make help
make_clean_all_O: make clean all
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_pure_O: make
make_no_newt_O: make NO_NEWT=1
make_install_bin_O: make install-bin
make_no_libunwind_O: make NO_LIBUNWIND=1
make_doc_O: make doc
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_util_map_o_O: make util/map.o
make_no_libaudit_O: make NO_LIBAUDIT=1
make_debug_O: make DEBUG=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_perf_o_O: make perf.o
make_no_libbionic_O: make NO_LIBBIONIC=1
make_install_prefix_O: make install prefix=/tmp/krava
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2017-06-16 19:26 Arnaldo Carvalho de Melo
@ 2017-06-16 19:34 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2017-06-16 19:34 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Andi Kleen,
David Ahern, Eugeniu Rosca, Hendrik Brueckner, Jan Kratochvil,
Jan Stancek, Jiada Wang, Jiri Olsa, Masami Hiramatsu,
Milian Wolff, Namhyung Kim, Peter Zijlstra, Ravi Bangoria,
Rui Teng, Sukadev Bhattiprolu, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 63f700aab4c11d46626de3cd051dae56cf7e9056:
>
> Merge tag 'xtensa-20170612' of git://github.com/jcmvbkbc/linux-xtensa (2017-06-13 15:09:10 +0900)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.12-20170616
>
> for you to fetch changes up to 9126cbbacecb8917bd0418809ef1d26616b2061e:
>
> perf unwind: Report module before querying isactivation in dwfl unwind (2017-06-16 14:37:30 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Fix probing of precise_ip level for default cycles event, that
> got broken recently on x86_64 when its arch code started
> considering invalid requesting precise samples when not sampling
> (i.e. when attr.sample_period == 0).
>
> This also fixes another problem in s/390 where the precision
> probing with sample_period == 0 returned precise_ip > 0, that
> then, when setting up the real cycles event (not probing) would
> return EOPNOTSUPP for precise_ip > 0 (as determined previously
> by probing) and sample_period > 0.
>
> These problems resulted in attr_precise not being set to the
> highest precision available on x86.64 when no event was specified,
> i.e. the canonical:
>
> perf record ./workload
>
> would end up using attr.precise_ip = 0. As a workaround this would
> need to be done:
>
> perf record -e cycles:P ./workload
>
> And on s/390 it would plain not work, requiring using:
>
> perf record -e cycles ./workload
>
> as a workaround. (Arnaldo Carvalho de Melo)
>
> - Fix perf build with ARCH=x86_64, when ARCH should be transformed
> into ARCH=x86, just like with the main kernel Makefile and
> tools/objtool's, i.e. use SRCARCH. (Jiada Wang)
>
> - Avoid accessing uninitialized data structures when unwinding with
> elfutils's libdw, making it more closely mimic libunwind's unwinder.
> (Milian Wolff)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf evsel: Fix probing of precise_ip level for default cycles event
>
> Jiada Wang (1):
> perf tools: Fix build with ARCH=x86_64
>
> Milian Wolff (1):
> perf unwind: Report module before querying isactivation in dwfl unwind
>
> tools/perf/Makefile.config | 38 +++++++++++++++++++-------------------
> tools/perf/Makefile.perf | 2 +-
> tools/perf/arch/Build | 2 +-
> tools/perf/pmu-events/Build | 4 ++--
> tools/perf/tests/Build | 2 +-
> tools/perf/tests/task-exit.c | 2 +-
> tools/perf/util/evsel.c | 12 ++++++++++++
> tools/perf/util/header.c | 2 +-
> tools/perf/util/unwind-libdw.c | 8 ++++++++
> 9 files changed, 46 insertions(+), 26 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2017-06-16 19:26 Arnaldo Carvalho de Melo
2017-06-16 19:34 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-06-16 19:26 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, David Ahern, Eugeniu Rosca,
Hendrik Brueckner, Jan Kratochvil, Jan Stancek, Jiada Wang,
Jiri Olsa, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Peter Zijlstra, Ravi Bangoria, Rui Teng, Sukadev Bhattiprolu,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 63f700aab4c11d46626de3cd051dae56cf7e9056:
Merge tag 'xtensa-20170612' of git://github.com/jcmvbkbc/linux-xtensa (2017-06-13 15:09:10 +0900)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.12-20170616
for you to fetch changes up to 9126cbbacecb8917bd0418809ef1d26616b2061e:
perf unwind: Report module before querying isactivation in dwfl unwind (2017-06-16 14:37:30 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix probing of precise_ip level for default cycles event, that
got broken recently on x86_64 when its arch code started
considering invalid requesting precise samples when not sampling
(i.e. when attr.sample_period == 0).
This also fixes another problem in s/390 where the precision
probing with sample_period == 0 returned precise_ip > 0, that
then, when setting up the real cycles event (not probing) would
return EOPNOTSUPP for precise_ip > 0 (as determined previously
by probing) and sample_period > 0.
These problems resulted in attr_precise not being set to the
highest precision available on x86.64 when no event was specified,
i.e. the canonical:
perf record ./workload
would end up using attr.precise_ip = 0. As a workaround this would
need to be done:
perf record -e cycles:P ./workload
And on s/390 it would plain not work, requiring using:
perf record -e cycles ./workload
as a workaround. (Arnaldo Carvalho de Melo)
- Fix perf build with ARCH=x86_64, when ARCH should be transformed
into ARCH=x86, just like with the main kernel Makefile and
tools/objtool's, i.e. use SRCARCH. (Jiada Wang)
- Avoid accessing uninitialized data structures when unwinding with
elfutils's libdw, making it more closely mimic libunwind's unwinder.
(Milian Wolff)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf evsel: Fix probing of precise_ip level for default cycles event
Jiada Wang (1):
perf tools: Fix build with ARCH=x86_64
Milian Wolff (1):
perf unwind: Report module before querying isactivation in dwfl unwind
tools/perf/Makefile.config | 38 +++++++++++++++++++-------------------
tools/perf/Makefile.perf | 2 +-
tools/perf/arch/Build | 2 +-
tools/perf/pmu-events/Build | 4 ++--
tools/perf/tests/Build | 2 +-
tools/perf/tests/task-exit.c | 2 +-
tools/perf/util/evsel.c | 12 ++++++++++++
tools/perf/util/header.c | 2 +-
tools/perf/util/unwind-libdw.c | 8 ++++++++
9 files changed, 46 insertions(+), 26 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:rawhide: Ok
26 mageia:5: Ok
27 opensuse:13.2: Ok
28 opensuse:42.1: Ok
29 opensuse:tumbleweed: Ok
30 ubuntu:12.04.5: Ok
31 ubuntu:14.04.4: Ok
32 ubuntu:14.04.4-x-linaro-arm64: Ok
33 ubuntu:15.10: Ok
34 ubuntu:16.04: Ok
35 ubuntu:16.04-x-arm: Ok
36 ubuntu:16.04-x-arm64: Ok
37 ubuntu:16.04-x-powerpc: Ok
38 ubuntu:16.04-x-powerpc64: Ok
39 ubuntu:16.04-x-powerpc64el: Ok
40 ubuntu:16.04-x-s390: Ok
41 ubuntu:16.10: Ok
42 ubuntu:17.04: Ok
#
# uname -a
Linux jouet 4.12.0-rc4+ #1 SMP Fri Jun 9 12:59:23 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking: Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation: Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Ok
38.2: BPF pinning : Ok
38.3: BPF prologue generation : Ok
38.4: BPF relocation checker : Ok
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : Ok
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
- /home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP: make FEATURE_DUMP_COPY=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump
make_no_demangle_O: make NO_DEMANGLE=1
make_pure_O: make
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_install_O: make install
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_doc_O: make doc
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libbpf_O: make NO_LIBBPF=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_install_prefix_O: make install prefix=/tmp/krava
make_util_map_o_O: make util/map.o
make_debug_O: make DEBUG=1
make_clean_all_O: make clean all
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_slang_O: make NO_SLANG=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_perf_o_O: make perf.o
make_tags_O: make tags
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_with_babeltrace_O: make LIBBABELTRACE=1
make_help_O: make help
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_bin_O: make install-bin
make_no_newt_O: make NO_NEWT=1
make_static_O: make LDFLAGS=-static
make_no_libelf_O: make NO_LIBELF=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2017-02-03 15:49 Arnaldo Carvalho de Melo
@ 2017-02-03 19:43 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2017-02-03 19:43 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Frederic Weisbecker, Jiri Olsa, Krister Johansen,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit fff4b87e594ad3d2e4f51e8d3d86a6f9d3d8b654:
>
> perf/x86/intel/uncore: Make package handling more robust (2017-02-01 08:37:27 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.10-20170203
>
> for you to fetch changes up to aa33b9b9a2ebb00d33c83a5312d4fbf2d5aeba36:
>
> perf callchain: Reference count maps (2017-02-02 11:39:09 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Reference count maps in callchains, fixing a SEGFAULT when referencing a
> map after it is freed (Krister Johansen)
>
> - Fix segfault on 'perf diff -o N' option (Namhyung Kim)
>
> - Fix 'perf diff -o/--order' option behavior (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Krister Johansen (1):
> perf callchain: Reference count maps
>
> Namhyung Kim (2):
> perf diff: Fix segfault on 'perf diff -o N' option
> perf diff: Fix -o/--order option behavior (again)
>
> tools/perf/builtin-diff.c | 2 +-
> tools/perf/ui/hist.c | 10 ++++++++++
> tools/perf/util/callchain.c | 11 +++++++++--
> tools/perf/util/callchain.h | 6 ++++++
> tools/perf/util/hist.c | 7 +++++++
> tools/perf/util/hist.h | 7 +++++++
> 6 files changed, 40 insertions(+), 3 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2017-02-03 15:49 Arnaldo Carvalho de Melo
2017-02-03 19:43 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-02-03 15:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Frederic Weisbecker,
Jiri Olsa, Krister Johansen, Masami Hiramatsu, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit fff4b87e594ad3d2e4f51e8d3d86a6f9d3d8b654:
perf/x86/intel/uncore: Make package handling more robust (2017-02-01 08:37:27 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.10-20170203
for you to fetch changes up to aa33b9b9a2ebb00d33c83a5312d4fbf2d5aeba36:
perf callchain: Reference count maps (2017-02-02 11:39:09 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Reference count maps in callchains, fixing a SEGFAULT when referencing a
map after it is freed (Krister Johansen)
- Fix segfault on 'perf diff -o N' option (Namhyung Kim)
- Fix 'perf diff -o/--order' option behavior (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Krister Johansen (1):
perf callchain: Reference count maps
Namhyung Kim (2):
perf diff: Fix segfault on 'perf diff -o N' option
perf diff: Fix -o/--order option behavior (again)
tools/perf/builtin-diff.c | 2 +-
tools/perf/ui/hist.c | 10 ++++++++++
tools/perf/util/callchain.c | 11 +++++++++--
tools/perf/util/callchain.h | 6 ++++++
tools/perf/util/hist.c | 7 +++++++
tools/perf/util/hist.h | 7 +++++++
6 files changed, 40 insertions(+), 3 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 debian:experimental-x-arm64: Ok
11 debian:experimental-x-mips: Ok
12 debian:experimental-x-mips64: Ok
13 debian:experimental-x-mipsel: Ok
14 fedora:20: Ok
15 fedora:21: Ok
16 fedora:22: Ok
17 fedora:23: Ok
18 fedora:24: Ok
19 fedora:24-x-ARC-uClibc: Ok
20 fedora:25: Ok
21 fedora:rawhide: Ok
22 mageia:5: Ok
23 opensuse:13.2: Ok
24 opensuse:42.1: Ok
25 opensuse:tumbleweed: Ok
26 ubuntu:12.04.5: Ok
27 ubuntu:14.04.4-x-linaro-arm64: Ok
28 ubuntu:15.10: Ok
29 ubuntu:16.04: Ok
30 ubuntu:16.04-x-arm: Ok
31 ubuntu:16.04-x-arm64: Ok
32 ubuntu:16.04-x-powerpc: Ok
33 ubuntu:16.04-x-powerpc64: Ok
34 ubuntu:16.04-x-powerpc64el: Ok
35 ubuntu:16.04-x-s390: Ok
36 ubuntu:16.10: Ok
# uname -a
Linux jouet 4.9.6-200.fc25.x86_64 #1 SMP Thu Jan 26 10:17:45 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: PERF_RECORD_* events & perf_sample fields : Ok
7: Parse perf pmu format : Ok
8: DSO data read : Ok
9: DSO data cache : Ok
10: DSO data reopen : Ok
11: Roundtrip evsel->name : Ok
12: Parse sched tracepoints fields : Ok
13: syscalls:sys_enter_openat event fields : Ok
14: Setup struct perf_event_attr : Ok
15: Match and link multiple hists : Ok
16: 'import perf' in python : Ok
17: Breakpoint overflow signal handler : Ok
18: Breakpoint overflow sampling : Ok
19: Number of exit events of a simple workload : Ok
20: Software clock events period values : Ok
21: Object code reading : Ok
22: Sample parsing : Ok
23: Use a dummy software event to keep tracking: Ok
24: Parse with no sample_id_all bit set : Ok
25: Filter hist entries : Ok
26: Lookup mmap thread : Ok
27: Share thread mg : Ok
28: Sort output of hist entries : Ok
29: Cumulate child hist entries : Ok
30: Track with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: kmod_path__parse : Ok
34: Thread map : Ok
35: LLVM search and compile :
35.1: Basic BPF llvm compile : Ok
35.2: kbuild searching : Ok
35.3: Compile source for BPF prologue generation: Ok
35.4: Compile source for BPF relocation : Ok
36: Session topology : Ok
37: BPF filter :
37.1: Basic BPF filtering : Ok
37.2: BPF prologue generation : Ok
37.3: BPF relocation checker : Ok
38: Synthesize thread map : Ok
39: Remove thread map : Ok
40: Synthesize cpu map : Ok
41: Synthesize stat config : Ok
42: Synthesize stat : Ok
43: Synthesize stat round : Ok
44: Synthesize attr update : Ok
45: Event times : Ok
46: Read backward ring buffer : Ok
47: Print cpu map : Ok
48: Probe SDT events : Ok
49: is_printable_array : Ok
50: Print bitmap : Ok
51: perf hooks : Ok
52: builtin clang support : Skip (not compiled in)
53: x86 rdpmc : Ok
54: Convert perf time to TSC : Ok
55: DWARF unwind : Ok
56: x86 instruction decoder - new instructions : Ok
57: Intel cqm nmi context read : Skip
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make FEATURE_DUMP_COPY=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_pure_O: make
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libperl_O: make NO_LIBPERL=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_debug_O: make DEBUG=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_auxtrace_O: make NO_AUXTRACE=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_gtk2_O: make NO_GTK2=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_O: make install
make_no_slang_O: make NO_SLANG=1
make_static_O: make LDFLAGS=-static
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libelf_O: make NO_LIBELF=1
make_help_O: make help
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libbpf_O: make NO_LIBBPF=1
make_install_prefix_O: make install prefix=/tmp/krava
make_no_libunwind_O: make NO_LIBUNWIND=1
make_doc_O: make doc
make_no_libbionic_O: make NO_LIBBIONIC=1
make_install_bin_O: make install-bin
make_util_map_o_O: make util/map.o
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_tags_O: make tags
make_clean_all_O: make clean all
make_perf_o_O: make perf.o
make_no_newt_O: make NO_NEWT=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2016-08-18 20:40 ` Arnaldo Carvalho de Melo
@ 2016-08-18 20:51 ` Ingo Molnar
-1 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2016-08-18 20:51 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexey Brodkin, Brian Sweeney,
Clark Williams, David Ahern, Jiri Olsa, Josh Poimboeuf,
linux-snps-arc, Milian Wolff, Namhyung Kim, Peter Zijlstra,
Petri Gynther, Vineet Gupta, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Build stats at the end of this message.
>
> The following changes since commit 3cace81ea5bb0b3f2b97cab8e2c8e1fae2feb7ed:
>
> Merge tag 'perf-urgent-for-mingo-20160815' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-08-16 20:08:56 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160818
>
> for you to fetch changes up to c53412ee8c7ec31373a4176ff7f3a6b79296c05c:
>
> perf evsel: Do not access outside hw cache name arrays (2016-08-18 16:39:46 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Do not access outside hw cache name arrays (Arnaldo Carvalho de Melo)
>
> - Use addr_location::addr instead of ip for entries when unwinding using
> DWARF CFI, fixing the "srcline" information for userspace application
> callchains (Milian Wolff)
>
> - Reinstate strlcpy() header guard with __UCLIBC__, fixing the build
> with uclibc, detected when building for the ARC architecture (Vineet Gupta)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf evsel: Do not access outside hw cache name arrays
>
> Milian Wolff (1):
> perf unwind: Use addr_location::addr instead of ip for entries
>
> Vineet Gupta (1):
> tools lib: Reinstate strlcpy() header guard with __UCLIBC__
>
> tools/include/linux/string.h | 6 +++++-
> tools/perf/util/evsel.c | 6 +++---
> tools/perf/util/unwind-libdw.c | 2 +-
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 4 files changed, 10 insertions(+), 6 deletions(-)
>
> Build stats, now only android-ndk doesn't build with NO_LIBELF=1, as it
> doesn't even have libelf to cross build with, and the non-cross builds
> build objtool, uClibc and an ARC architecture cross build image are in
> the works:
>
> # time dm
> 1 77.199181517 alpine:3.4: Ok
> 2 30.215940343 android-ndk:r12b-arm: Ok
> 3 80.593965325 archlinux:latest: Ok
> 4 45.102186377 centos:5: Ok
> 5 67.078635441 centos:6: Ok
> 6 73.582617061 centos:7: Ok
> 7 65.462644128 debian:7: Ok
> 8 69.919139691 debian:8: Ok
> 9 77.192563446 debian:experimental: Ok
> 10 80.651363745 fedora:20: Ok
> 11 85.566954259 fedora:21: Ok
> 12 87.547437162 fedora:22: Ok
> 13 94.866327046 fedora:23: Ok
> 14 93.829320269 fedora:24: Ok
> 15 94.860933711 fedora:rawhide: Ok
> 16 88.890456556 mageia:5: Ok
> 17 85.622890293 opensuse:13.2: Ok
> 18 87.232034972 opensuse:42.1: Ok
> 19 94.807172866 opensuse:tumbleweed: Ok
> 20 72.189153053 ubuntu:12.04.5: Ok
> 21 86.275708891 ubuntu:14.04.4: Ok
> 22 90.743742216 ubuntu:15.10: Ok
> 23 86.931085419 ubuntu:16.04: Ok
> 24 67.823595709 ubuntu:16.04-x-arm: Ok
> 25 62.985390761 ubuntu:16.04-x-arm64: Ok
> 26 64.727635984 ubuntu:16.04-x-powerpc64: Ok
> 27 63.208264990 ubuntu:16.04-x-powerpc64el: Ok
> 28 64.685772233 ubuntu:16.04-x-s390: Ok
> 29 85.089091168 ubuntu:16.10: Ok
> 2224.88s
>
> real 37m6.200s
> user 0m1.830s
> sys 0m2.653s
> #
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2016-08-18 20:51 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2016-08-18 20:51 UTC (permalink / raw)
To: linux-snps-arc
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Build stats at the end of this message.
>
> The following changes since commit 3cace81ea5bb0b3f2b97cab8e2c8e1fae2feb7ed:
>
> Merge tag 'perf-urgent-for-mingo-20160815' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-08-16 20:08:56 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160818
>
> for you to fetch changes up to c53412ee8c7ec31373a4176ff7f3a6b79296c05c:
>
> perf evsel: Do not access outside hw cache name arrays (2016-08-18 16:39:46 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Do not access outside hw cache name arrays (Arnaldo Carvalho de Melo)
>
> - Use addr_location::addr instead of ip for entries when unwinding using
> DWARF CFI, fixing the "srcline" information for userspace application
> callchains (Milian Wolff)
>
> - Reinstate strlcpy() header guard with __UCLIBC__, fixing the build
> with uclibc, detected when building for the ARC architecture (Vineet Gupta)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf evsel: Do not access outside hw cache name arrays
>
> Milian Wolff (1):
> perf unwind: Use addr_location::addr instead of ip for entries
>
> Vineet Gupta (1):
> tools lib: Reinstate strlcpy() header guard with __UCLIBC__
>
> tools/include/linux/string.h | 6 +++++-
> tools/perf/util/evsel.c | 6 +++---
> tools/perf/util/unwind-libdw.c | 2 +-
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 4 files changed, 10 insertions(+), 6 deletions(-)
>
> Build stats, now only android-ndk doesn't build with NO_LIBELF=1, as it
> doesn't even have libelf to cross build with, and the non-cross builds
> build objtool, uClibc and an ARC architecture cross build image are in
> the works:
>
> # time dm
> 1 77.199181517 alpine:3.4: Ok
> 2 30.215940343 android-ndk:r12b-arm: Ok
> 3 80.593965325 archlinux:latest: Ok
> 4 45.102186377 centos:5: Ok
> 5 67.078635441 centos:6: Ok
> 6 73.582617061 centos:7: Ok
> 7 65.462644128 debian:7: Ok
> 8 69.919139691 debian:8: Ok
> 9 77.192563446 debian:experimental: Ok
> 10 80.651363745 fedora:20: Ok
> 11 85.566954259 fedora:21: Ok
> 12 87.547437162 fedora:22: Ok
> 13 94.866327046 fedora:23: Ok
> 14 93.829320269 fedora:24: Ok
> 15 94.860933711 fedora:rawhide: Ok
> 16 88.890456556 mageia:5: Ok
> 17 85.622890293 opensuse:13.2: Ok
> 18 87.232034972 opensuse:42.1: Ok
> 19 94.807172866 opensuse:tumbleweed: Ok
> 20 72.189153053 ubuntu:12.04.5: Ok
> 21 86.275708891 ubuntu:14.04.4: Ok
> 22 90.743742216 ubuntu:15.10: Ok
> 23 86.931085419 ubuntu:16.04: Ok
> 24 67.823595709 ubuntu:16.04-x-arm: Ok
> 25 62.985390761 ubuntu:16.04-x-arm64: Ok
> 26 64.727635984 ubuntu:16.04-x-powerpc64: Ok
> 27 63.208264990 ubuntu:16.04-x-powerpc64el: Ok
> 28 64.685772233 ubuntu:16.04-x-s390: Ok
> 29 85.089091168 ubuntu:16.10: Ok
> 2224.88s
>
> real 37m6.200s
> user 0m1.830s
> sys 0m2.653s
> #
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2016-08-18 20:40 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-08-18 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexey Brodkin, Brian Sweeney, Clark Williams, David Ahern,
Jiri Olsa, Josh Poimboeuf, linux-snps-arc, Milian Wolff,
Namhyung Kim, Peter Zijlstra, Petri Gynther, Vineet Gupta,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Build stats at the end of this message.
The following changes since commit 3cace81ea5bb0b3f2b97cab8e2c8e1fae2feb7ed:
Merge tag 'perf-urgent-for-mingo-20160815' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-08-16 20:08:56 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160818
for you to fetch changes up to c53412ee8c7ec31373a4176ff7f3a6b79296c05c:
perf evsel: Do not access outside hw cache name arrays (2016-08-18 16:39:46 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Do not access outside hw cache name arrays (Arnaldo Carvalho de Melo)
- Use addr_location::addr instead of ip for entries when unwinding using
DWARF CFI, fixing the "srcline" information for userspace application
callchains (Milian Wolff)
- Reinstate strlcpy() header guard with __UCLIBC__, fixing the build
with uclibc, detected when building for the ARC architecture (Vineet Gupta)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf evsel: Do not access outside hw cache name arrays
Milian Wolff (1):
perf unwind: Use addr_location::addr instead of ip for entries
Vineet Gupta (1):
tools lib: Reinstate strlcpy() header guard with __UCLIBC__
tools/include/linux/string.h | 6 +++++-
tools/perf/util/evsel.c | 6 +++---
tools/perf/util/unwind-libdw.c | 2 +-
tools/perf/util/unwind-libunwind-local.c | 2 +-
4 files changed, 10 insertions(+), 6 deletions(-)
Build stats, now only android-ndk doesn't build with NO_LIBELF=1, as it
doesn't even have libelf to cross build with, and the non-cross builds
build objtool, uClibc and an ARC architecture cross build image are in
the works:
# time dm
1 77.199181517 alpine:3.4: Ok
2 30.215940343 android-ndk:r12b-arm: Ok
3 80.593965325 archlinux:latest: Ok
4 45.102186377 centos:5: Ok
5 67.078635441 centos:6: Ok
6 73.582617061 centos:7: Ok
7 65.462644128 debian:7: Ok
8 69.919139691 debian:8: Ok
9 77.192563446 debian:experimental: Ok
10 80.651363745 fedora:20: Ok
11 85.566954259 fedora:21: Ok
12 87.547437162 fedora:22: Ok
13 94.866327046 fedora:23: Ok
14 93.829320269 fedora:24: Ok
15 94.860933711 fedora:rawhide: Ok
16 88.890456556 mageia:5: Ok
17 85.622890293 opensuse:13.2: Ok
18 87.232034972 opensuse:42.1: Ok
19 94.807172866 opensuse:tumbleweed: Ok
20 72.189153053 ubuntu:12.04.5: Ok
21 86.275708891 ubuntu:14.04.4: Ok
22 90.743742216 ubuntu:15.10: Ok
23 86.931085419 ubuntu:16.04: Ok
24 67.823595709 ubuntu:16.04-x-arm: Ok
25 62.985390761 ubuntu:16.04-x-arm64: Ok
26 64.727635984 ubuntu:16.04-x-powerpc64: Ok
27 63.208264990 ubuntu:16.04-x-powerpc64el: Ok
28 64.685772233 ubuntu:16.04-x-s390: Ok
29 85.089091168 ubuntu:16.10: Ok
2224.88s
real 37m6.200s
user 0m1.830s
sys 0m2.653s
#
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2016-08-18 20:40 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-08-18 20:40 UTC (permalink / raw)
To: linux-snps-arc
Hi Ingo,
Please consider pulling,
- Arnaldo
Build stats at the end of this message.
The following changes since commit 3cace81ea5bb0b3f2b97cab8e2c8e1fae2feb7ed:
Merge tag 'perf-urgent-for-mingo-20160815' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-08-16 20:08:56 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160818
for you to fetch changes up to c53412ee8c7ec31373a4176ff7f3a6b79296c05c:
perf evsel: Do not access outside hw cache name arrays (2016-08-18 16:39:46 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Do not access outside hw cache name arrays (Arnaldo Carvalho de Melo)
- Use addr_location::addr instead of ip for entries when unwinding using
DWARF CFI, fixing the "srcline" information for userspace application
callchains (Milian Wolff)
- Reinstate strlcpy() header guard with __UCLIBC__, fixing the build
with uclibc, detected when building for the ARC architecture (Vineet Gupta)
Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf evsel: Do not access outside hw cache name arrays
Milian Wolff (1):
perf unwind: Use addr_location::addr instead of ip for entries
Vineet Gupta (1):
tools lib: Reinstate strlcpy() header guard with __UCLIBC__
tools/include/linux/string.h | 6 +++++-
tools/perf/util/evsel.c | 6 +++---
tools/perf/util/unwind-libdw.c | 2 +-
tools/perf/util/unwind-libunwind-local.c | 2 +-
4 files changed, 10 insertions(+), 6 deletions(-)
Build stats, now only android-ndk doesn't build with NO_LIBELF=1, as it
doesn't even have libelf to cross build with, and the non-cross builds
build objtool, uClibc and an ARC architecture cross build image are in
the works:
# time dm
1 77.199181517 alpine:3.4: Ok
2 30.215940343 android-ndk:r12b-arm: Ok
3 80.593965325 archlinux:latest: Ok
4 45.102186377 centos:5: Ok
5 67.078635441 centos:6: Ok
6 73.582617061 centos:7: Ok
7 65.462644128 debian:7: Ok
8 69.919139691 debian:8: Ok
9 77.192563446 debian:experimental: Ok
10 80.651363745 fedora:20: Ok
11 85.566954259 fedora:21: Ok
12 87.547437162 fedora:22: Ok
13 94.866327046 fedora:23: Ok
14 93.829320269 fedora:24: Ok
15 94.860933711 fedora:rawhide: Ok
16 88.890456556 mageia:5: Ok
17 85.622890293 opensuse:13.2: Ok
18 87.232034972 opensuse:42.1: Ok
19 94.807172866 opensuse:tumbleweed: Ok
20 72.189153053 ubuntu:12.04.5: Ok
21 86.275708891 ubuntu:14.04.4: Ok
22 90.743742216 ubuntu:15.10: Ok
23 86.931085419 ubuntu:16.04: Ok
24 67.823595709 ubuntu:16.04-x-arm: Ok
25 62.985390761 ubuntu:16.04-x-arm64: Ok
26 64.727635984 ubuntu:16.04-x-powerpc64: Ok
27 63.208264990 ubuntu:16.04-x-powerpc64el: Ok
28 64.685772233 ubuntu:16.04-x-s390: Ok
29 85.089091168 ubuntu:16.10: Ok
2224.88s
real 37m6.200s
user 0m1.830s
sys 0m2.653s
#
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2016-05-27 15:57 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-27 15:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Jiri Olsa, pi3orama,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 275ae411e56f8f900fa364da29c4706f9af4e1f3:
perf/x86/intel/rapl: Fix pmus free during cleanup (2016-05-25 10:56:43 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160527
for you to fetch changes up to 5ea5888b2fbf5b230da62b2a21c8247bebb6c9cf:
perf ctf: Convert invalid chars in a string before set value (2016-05-27 12:08:40 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix kptr_restrict=2 related 'perf record' segfault (Wang Nan)
- Fix CTF/libbabeltrace handling of chinese COMM strings (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Wang Nan (3):
perf symbols: Check kptr_restrict for root
perf record: Fix crash when kptr is restricted
perf ctf: Convert invalid chars in a string before set value
tools/perf/util/data-convert-bt.c | 41 +++++++++++++++++++++++++++++++++++++--
tools/perf/util/event.c | 2 ++
tools/perf/util/symbol.c | 16 +++++++--------
3 files changed, 49 insertions(+), 10 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2015-09-25 15:28 Arnaldo Carvalho de Melo
@ 2015-09-26 6:17 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2015-09-26 6:17 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, David Ahern,
Frederic Weisbecker, Jiri Olsa, Masami Hiramatsu, Namhyung Kim,
Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit d0d0313c2ae4bc220c4ed96ce340860a4e74a2e9:
>
> Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-09-23 09:41:09 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
>
> for you to fetch changes up to b5cabbcbd157a4bf5a92dfc85134999a3b55342d:
>
> perf tools: Fix copying of /proc/kcore (2015-09-25 10:45:50 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> User visible:
>
> - Fix copying of /proc/kcore made to the ~/.debug/ DSO cache to allow using
> objdump with kcore files (Adrian Hunter)
>
> - Fix adding perf probes in kernel module functions (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf intel-pt: Remove no_force_psb from documentation
> perf tools: Fix copying of /proc/kcore
>
> Arnaldo Carvalho de Melo (1):
> perf probe: Use existing routine to look for a kernel module by dso->short_name
>
> tools/perf/Documentation/intel-pt.txt | 15 ---------------
> tools/perf/util/probe-event.c | 13 +++++++------
> tools/perf/util/symbol-elf.c | 35 +++++++++++++----------------------
> 3 files changed, 20 insertions(+), 43 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2015-09-25 15:28 Arnaldo Carvalho de Melo
2015-09-26 6:17 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-25 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Borislav Petkov, David Ahern, Frederic Weisbecker, Jiri Olsa,
Masami Hiramatsu, Namhyung Kim, Stephane Eranian, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit d0d0313c2ae4bc220c4ed96ce340860a4e74a2e9:
Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-09-23 09:41:09 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to b5cabbcbd157a4bf5a92dfc85134999a3b55342d:
perf tools: Fix copying of /proc/kcore (2015-09-25 10:45:50 -0300)
----------------------------------------------------------------
perf/urgent fixes:
User visible:
- Fix copying of /proc/kcore made to the ~/.debug/ DSO cache to allow using
objdump with kcore files (Adrian Hunter)
- Fix adding perf probes in kernel module functions (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf intel-pt: Remove no_force_psb from documentation
perf tools: Fix copying of /proc/kcore
Arnaldo Carvalho de Melo (1):
perf probe: Use existing routine to look for a kernel module by dso->short_name
tools/perf/Documentation/intel-pt.txt | 15 ---------------
tools/perf/util/probe-event.c | 13 +++++++------
tools/perf/util/symbol-elf.c | 35 +++++++++++++----------------------
3 files changed, 20 insertions(+), 43 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2015-09-01 16:14 Arnaldo Carvalho de Melo
@ 2015-09-02 7:24 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2015-09-02 7:24 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern,
David S . Miller, Jiri Olsa, Kan Liang, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 532026612455a4a6fd27c1b2e7111263f63218a2:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-09-01 10:25:57 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
>
> for you to fetch changes up to af4aeadd8c04303c0aa2d112145c3627e2ebd026:
>
> perf tools: Fix link time error with sample_reg_masks on non x86 (2015-09-01 13:04:41 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Fix link time error with sample_reg_masks on non x86 (Stephane Eranian)
>
> - Fix potential array out of bounds access (Wang Nan)
>
> - Fix Intel PT instruction decoder dependency problem (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Stephane Eranian (1):
> perf tools: Fix link time error with sample_reg_masks on non x86
>
> Wang Nan (2):
> perf dwarf: Fix potential array out of bounds access
> perf build: Fix Intel PT instruction decoder dependency problem
>
> tools/perf/arch/sh/util/dwarf-regs.c | 2 +-
> tools/perf/arch/sparc/util/dwarf-regs.c | 2 +-
> tools/perf/arch/x86/util/dwarf-regs.c | 2 +-
> tools/perf/arch/x86/util/perf_regs.c | 44 ++++++++++++++++-----------------
> tools/perf/util/intel-pt-decoder/Build | 1 +
> tools/perf/util/perf_regs.c | 4 +++
> tools/perf/util/perf_regs.h | 2 ++
> 7 files changed, 31 insertions(+), 26 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2015-09-01 16:14 Arnaldo Carvalho de Melo
2015-09-02 7:24 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-01 16:14 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, David Ahern, David S . Miller, Jiri Olsa, Kan Liang,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra, pi3orama,
Stephane Eranian, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 532026612455a4a6fd27c1b2e7111263f63218a2:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-09-01 10:25:57 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to af4aeadd8c04303c0aa2d112145c3627e2ebd026:
perf tools: Fix link time error with sample_reg_masks on non x86 (2015-09-01 13:04:41 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix link time error with sample_reg_masks on non x86 (Stephane Eranian)
- Fix potential array out of bounds access (Wang Nan)
- Fix Intel PT instruction decoder dependency problem (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Stephane Eranian (1):
perf tools: Fix link time error with sample_reg_masks on non x86
Wang Nan (2):
perf dwarf: Fix potential array out of bounds access
perf build: Fix Intel PT instruction decoder dependency problem
tools/perf/arch/sh/util/dwarf-regs.c | 2 +-
tools/perf/arch/sparc/util/dwarf-regs.c | 2 +-
tools/perf/arch/x86/util/dwarf-regs.c | 2 +-
tools/perf/arch/x86/util/perf_regs.c | 44 ++++++++++++++++-----------------
tools/perf/util/intel-pt-decoder/Build | 1 +
tools/perf/util/perf_regs.c | 4 +++
tools/perf/util/perf_regs.h | 2 ++
7 files changed, 31 insertions(+), 26 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2015-01-08 15:36 Arnaldo Carvalho de Melo
@ 2015-01-09 10:04 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2015-01-09 10:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern,
Frederic Weisbecker, Jiri Olsa, Markus Trippelsdorf,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit ed9eb845d7916b2bc863e5b93c82e18be8faf032:
>
> Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-01-08 08:59:22 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
>
> for you to fetch changes up to c09e31cc128cf1aec3a6cd47203508fbf0082873:
>
> perf hists browser: Fix segfault when showing callchain (2015-01-08 11:59:16 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Free callchains when hist entries are deleted, plugging a massive leak in
> 'top -g', where hist_entries (and its callchains) are decayed over time. (Namhyung Kim)
>
> . Fix segfault when showing callchain in the hists browser (report & top) (Namhyung Kim)
>
> . Fix children sort key behavior, and also the 'perf test 32' test that
> was failing due to reliance on undefined behaviour (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Namhyung Kim (3):
> perf hists: Fix children sort key behavior
> perf callchain: Free callchains when hist entries are deleted
> perf hists browser: Fix segfault when showing callchain
>
> tools/perf/tests/hists_cumulate.c | 64 +++++++++++++++++++--------------------
> tools/perf/ui/browsers/hists.c | 2 +-
> tools/perf/ui/hist.c | 3 ++
> tools/perf/util/callchain.c | 30 ++++++++++++++++++
> tools/perf/util/callchain.h | 2 ++
> tools/perf/util/hist.c | 1 +
> 6 files changed, 69 insertions(+), 33 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2015-01-08 15:36 Arnaldo Carvalho de Melo
2015-01-09 10:04 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-01-08 15:36 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, David Ahern, Frederic Weisbecker, Jiri Olsa,
Markus Trippelsdorf, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit ed9eb845d7916b2bc863e5b93c82e18be8faf032:
Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-01-08 08:59:22 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to c09e31cc128cf1aec3a6cd47203508fbf0082873:
perf hists browser: Fix segfault when showing callchain (2015-01-08 11:59:16 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Free callchains when hist entries are deleted, plugging a massive leak in
'top -g', where hist_entries (and its callchains) are decayed over time. (Namhyung Kim)
. Fix segfault when showing callchain in the hists browser (report & top) (Namhyung Kim)
. Fix children sort key behavior, and also the 'perf test 32' test that
was failing due to reliance on undefined behaviour (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Namhyung Kim (3):
perf hists: Fix children sort key behavior
perf callchain: Free callchains when hist entries are deleted
perf hists browser: Fix segfault when showing callchain
tools/perf/tests/hists_cumulate.c | 64 +++++++++++++++++++--------------------
tools/perf/ui/browsers/hists.c | 2 +-
tools/perf/ui/hist.c | 3 ++
tools/perf/util/callchain.c | 30 ++++++++++++++++++
tools/perf/util/callchain.h | 2 ++
tools/perf/util/hist.c | 1 +
6 files changed, 69 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2014-04-18 10:20 Jiri Olsa
0 siblings, 0 replies; 53+ messages in thread
From: Jiri Olsa @ 2014-04-18 10:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Adrien BAK, Alexander Yarygin,
Arnaldo Carvalho de Melo, Christian Borntraeger, Corey Ashford,
David Ahern, Frederic Weisbecker, Jiri Olsa, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Vladimir Nikulichev, Will Deacon
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 6381c24cd6d5d6373620426ab0a96c80ed953e20:
kprobes/x86: Fix page-fault handling logic (2014-04-17 10:57:02 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-urgent-for-mingo
for you to fetch changes up to 5fef49f71bd0f2f11f55b316ab7473b7f12fd8e0:
perf tools: Error reporting improvement (2014-04-18 11:40:01 +0200)
----------------------------------------------------------------
perf/urgent fixes:
User visible:
. Adjust symbols in VDSO to properly resolve its function names (Vladimir Nikulichev)
. Improve error reporting for record session failure (Adrien BAK)
. Fix of 'Min time' counting in report command (Alexander Yarygin)
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
----------------------------------------------------------------
Adrien BAK (1):
perf tools: Error reporting improvement
Alexander Yarygin (1):
perf kvm: Fix of 'Min time' counting in report command
Vladimir Nikulichev (1):
perf tools: Adjust symbols in VDSO
tools/perf/builtin-kvm.c | 1 +
tools/perf/builtin-record.c | 2 +-
tools/perf/util/data.c | 9 ++++++++-
tools/perf/util/symbol-elf.c | 2 ++
4 files changed, 12 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2014-03-10 21:15 Arnaldo Carvalho de Melo
@ 2014-03-11 10:04 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2014-03-11 10:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Albert Strasheim,
Ben Hutchings, Corey Ashford, David Ahern, Don Zickus,
Frederic Weisbecker, Ingo Molnar, Jiri Olsa, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, stable, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit af76815a31adc75dd9526230affdd678e65ac59f:
>
> Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-03-01 10:13:25 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to fdf57dd052d5cbd415533ae98f4d423286a85220:
>
> perf machine: Use map as success in ip__resolve_ams (2014-03-10 11:19:36 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Fix build of 'trace' in some systems due to using some architecture-specific
> signal numbers (Ben Hutchings)
>
> . Stop resolving when finding a map in in ip__resolve_ams, this way at least
> the DSO will be resolved when a symbol isn't (Don Zickus)
>
> . Fix crash in elf_section_by_name when not checking if some section string index
> is valid (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Ben Hutchings (1):
> perf trace: Decode architecture-specific signal numbers
>
> Don Zickus (1):
> perf machine: Use map as success in ip__resolve_ams
>
> Jiri Olsa (1):
> perf symbols: Fix crash in elf_section_by_name
>
> tools/perf/builtin-trace.c | 10 +++++++++-
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/symbol-elf.c | 6 +++---
> 3 files changed, 13 insertions(+), 5 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2014-03-10 21:15 Arnaldo Carvalho de Melo
2014-03-11 10:04 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-03-10 21:15 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Albert Strasheim,
Ben Hutchings, Corey Ashford, David Ahern, Don Zickus,
Frederic Weisbecker, Ingo Molnar, Jiri Olsa, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, stable, Stephane Eranian,
Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit af76815a31adc75dd9526230affdd678e65ac59f:
Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-03-01 10:13:25 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to fdf57dd052d5cbd415533ae98f4d423286a85220:
perf machine: Use map as success in ip__resolve_ams (2014-03-10 11:19:36 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Fix build of 'trace' in some systems due to using some architecture-specific
signal numbers (Ben Hutchings)
. Stop resolving when finding a map in in ip__resolve_ams, this way at least
the DSO will be resolved when a symbol isn't (Don Zickus)
. Fix crash in elf_section_by_name when not checking if some section string index
is valid (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Ben Hutchings (1):
perf trace: Decode architecture-specific signal numbers
Don Zickus (1):
perf machine: Use map as success in ip__resolve_ams
Jiri Olsa (1):
perf symbols: Fix crash in elf_section_by_name
tools/perf/builtin-trace.c | 10 +++++++++-
tools/perf/util/machine.c | 2 +-
tools/perf/util/symbol-elf.c | 6 +++---
3 files changed, 13 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2013-11-01 14:56 Arnaldo Carvalho de Melo
@ 2013-11-04 6:50 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2013-11-04 6:50 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Michael Hudson-Doyle, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Wei Yang,
Will Deacon, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit e8a923cc1fff6e627f906655ad52ee694ef2f6d7:
>
> perf/x86: Fix NMI measurements (2013-10-29 12:01:20 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 46d525eae2a076adfde92dca1db12d9a3b8ad8bb:
>
> perf test: Update command line callchain attribute tests (2013-11-01 10:42:57 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Fix command line callchain attribute tests to handle the new
> -g/--call-chain semantics.
>
> . Remove cast of non-variadic function to variadic, fixing perf output
> on armhf arch. Fix from Michael Hudson-Doyle.
>
> . Fix 32-bit building of 'perf bench', from Wei Yang.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf test: Update command line callchain attribute tests
>
> Michael Hudson-Doyle (1):
> perf tools: Remove cast of non-variadic function to variadic
>
> Wei Yang (1):
> perf bench: Fix two warnings
>
> tools/perf/bench/numa.c | 4 ++--
> tools/perf/tests/attr/README | 6 +++---
> tools/perf/tests/attr/test-record-graph-default | 2 +-
> tools/perf/tests/attr/test-record-graph-dwarf | 2 +-
> tools/perf/tests/attr/test-record-graph-fp | 2 +-
> tools/perf/ui/hist.c | 2 +-
> tools/perf/util/color.c | 11 +++++++++--
> tools/perf/util/color.h | 2 +-
> 8 files changed, 19 insertions(+), 12 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2013-11-01 14:56 Arnaldo Carvalho de Melo
2013-11-04 6:50 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-11-01 14:56 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Michael Hudson-Doyle, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Wei Yang,
Will Deacon, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit e8a923cc1fff6e627f906655ad52ee694ef2f6d7:
perf/x86: Fix NMI measurements (2013-10-29 12:01:20 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to 46d525eae2a076adfde92dca1db12d9a3b8ad8bb:
perf test: Update command line callchain attribute tests (2013-11-01 10:42:57 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Fix command line callchain attribute tests to handle the new
-g/--call-chain semantics.
. Remove cast of non-variadic function to variadic, fixing perf output
on armhf arch. Fix from Michael Hudson-Doyle.
. Fix 32-bit building of 'perf bench', from Wei Yang.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf test: Update command line callchain attribute tests
Michael Hudson-Doyle (1):
perf tools: Remove cast of non-variadic function to variadic
Wei Yang (1):
perf bench: Fix two warnings
tools/perf/bench/numa.c | 4 ++--
tools/perf/tests/attr/README | 6 +++---
tools/perf/tests/attr/test-record-graph-default | 2 +-
tools/perf/tests/attr/test-record-graph-dwarf | 2 +-
tools/perf/tests/attr/test-record-graph-fp | 2 +-
tools/perf/ui/hist.c | 2 +-
tools/perf/util/color.c | 11 +++++++++--
tools/perf/util/color.h | 2 +-
8 files changed, 19 insertions(+), 12 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2013-10-20 8:27 Arnaldo Carvalho de Melo
@ 2013-10-20 8:53 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2013-10-20 8:53 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern,
Frederic Weisbecker, Ingo Molnar, Jiri Olsa, Masami Hiramatsu,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Tom Zanussi, Waiman Long, acme,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 1651d120baddf68846188bcdf0ef5350068436cf:
>
> Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2013-10-08 07:29:09 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 3090ffb5a2515990182f3f55b0688a7817325488:
>
> perf: Disable PERF_RECORD_MMAP2 support (2013-10-17 16:27:14 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Fix build error on Fedora 12.
>
> . Fix to initialize fname always before use it, bug introduced
> during this merge window, from Masami Hiramatsu.
>
> . Disable PERF_RECORD_MMAP2 support, from Stephane Eranian.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf scripting perl: Fix build error on Fedora 12
>
> Masami Hiramatsu (1):
> perf probe: Fix to initialize fname always before use it
>
> Stephane Eranian (1):
> perf: Disable PERF_RECORD_MMAP2 support
>
> kernel/events/core.c | 4 +++
> tools/perf/util/event.c | 30 ++++++++++------------
> tools/perf/util/evsel.c | 1 -
> tools/perf/util/probe-finder.c | 2 +-
> .../perf/util/scripting-engines/trace-event-perl.c | 2 +-
> 5 files changed, 19 insertions(+), 20 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2013-10-20 8:27 Arnaldo Carvalho de Melo
2013-10-20 8:53 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-10-20 8:27 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, David Ahern, Frederic Weisbecker, Ingo Molnar,
Jiri Olsa, Masami Hiramatsu, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Tom Zanussi,
Waiman Long, acme, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 1651d120baddf68846188bcdf0ef5350068436cf:
Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2013-10-08 07:29:09 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to 3090ffb5a2515990182f3f55b0688a7817325488:
perf: Disable PERF_RECORD_MMAP2 support (2013-10-17 16:27:14 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Fix build error on Fedora 12.
. Fix to initialize fname always before use it, bug introduced
during this merge window, from Masami Hiramatsu.
. Disable PERF_RECORD_MMAP2 support, from Stephane Eranian.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf scripting perl: Fix build error on Fedora 12
Masami Hiramatsu (1):
perf probe: Fix to initialize fname always before use it
Stephane Eranian (1):
perf: Disable PERF_RECORD_MMAP2 support
kernel/events/core.c | 4 +++
tools/perf/util/event.c | 30 ++++++++++------------
tools/perf/util/evsel.c | 1 -
tools/perf/util/probe-finder.c | 2 +-
.../perf/util/scripting-engines/trace-event-perl.c | 2 +-
5 files changed, 19 insertions(+), 20 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-07-02 18:07 Arnaldo Carvalho de Melo
@ 2012-07-06 8:26 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-07-06 8:26 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, David Ahern, Frederic Weisbecker, Jiri Olsa,
Namhyung Kim, Peter Zijlstra, Pradeep Kumar Surisetty,
Stephane Eranian, Steven Rostedt, arnaldo.melo,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 662f5cedb38c4b88e1cebfd54a88159f2f7ab7b9:
>
> Merge branch 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile into perf/urgent (2012-06-24 19:08:49 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 7ed97ad41ffa94040dfd593948962a7e9e7b0db9:
>
> perf kvm: Fix segfault with report and mixed guestmount use (2012-07-02 14:03:50 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Fix creation of guest machine objects when build ids are disabled,
> from David Ahern
>
> . The kvm tool was trying to access an uninitialized guestmount variable, fix
> from David Ahern.
>
> . Restore perf script output to pre-libparseevent merge format, removing
> duplicated info, fix from David Ahern
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> David Ahern (3):
> perf script: Fix format regression due to libtraceevent merge
> perf kvm: Fix regression with guest machine creation
> perf kvm: Fix segfault with report and mixed guestmount use
>
> tools/perf/util/map.c | 29 +++++++++++++++--------------
> tools/perf/util/session.c | 2 +-
> tools/perf/util/trace-event-parse.c | 3 +--
> 3 files changed, 17 insertions(+), 17 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-07-02 18:07 Arnaldo Carvalho de Melo
2012-07-06 8:26 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-07-02 18:07 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Peter Zijlstra,
Pradeep Kumar Surisetty, Stephane Eranian, Steven Rostedt,
arnaldo.melo, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 662f5cedb38c4b88e1cebfd54a88159f2f7ab7b9:
Merge branch 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile into perf/urgent (2012-06-24 19:08:49 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to 7ed97ad41ffa94040dfd593948962a7e9e7b0db9:
perf kvm: Fix segfault with report and mixed guestmount use (2012-07-02 14:03:50 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Fix creation of guest machine objects when build ids are disabled,
from David Ahern
. The kvm tool was trying to access an uninitialized guestmount variable, fix
from David Ahern.
. Restore perf script output to pre-libparseevent merge format, removing
duplicated info, fix from David Ahern
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
David Ahern (3):
perf script: Fix format regression due to libtraceevent merge
perf kvm: Fix regression with guest machine creation
perf kvm: Fix segfault with report and mixed guestmount use
tools/perf/util/map.c | 29 +++++++++++++++--------------
tools/perf/util/session.c | 2 +-
tools/perf/util/trace-event-parse.c | 3 +--
3 files changed, 17 insertions(+), 17 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-06-15 17:13 ` Arnaldo Carvalho de Melo
2012-06-15 18:28 ` Ingo Molnar
@ 2012-06-15 19:03 ` Ingo Molnar
1 sibling, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-06-15 19:03 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Corey Ashford, David Ahern, Dmitry Antipov,
Frederic Weisbecker, Jim Cromie, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian
so, the build dependency bug is hard to trigger and I've pulled
your fixes for the time being because they seem to be unrelated.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-06-15 18:28 ` Ingo Molnar
@ 2012-06-15 18:35 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-06-15 18:35 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Corey Ashford, David Ahern, Dmitry Antipov,
Frederic Weisbecker, Jim Cromie, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian
The build does not want to fail anymore :-/
I have no idea what state my tree was in - but I re-applied your
patches and the failure happened again in 'make -j':
CC builtin-help.o
CC builtin-timechart.o
util/parse-events.l: In function ‘__value’:
util/parse-events.l:18:10: error: ‘PE_ERROR’ undeclared (first
use in this function)
util/parse-events.l:18:10: note: each undeclared identifier is
reported only once for each function it appears in
util/parse-events.l:20:2: error: ‘parse_events_lval’ undeclared
(first use in this function)
util/parse-events.l: In function ‘value’:
util/parse-events.l:26:42: error: ‘PE_VALUE’ undeclared (first
use in this function)
then I took off the last patch and did a 'make' - and the bug
did not re-trigger, even after applying your patches again.
It could be some sort of build dependency problem with the flex
files.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-06-15 17:13 ` Arnaldo Carvalho de Melo
@ 2012-06-15 18:28 ` Ingo Molnar
2012-06-15 18:35 ` Ingo Molnar
2012-06-15 19:03 ` Ingo Molnar
1 sibling, 1 reply; 53+ messages in thread
From: Ingo Molnar @ 2012-06-15 18:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Corey Ashford, David Ahern, Dmitry Antipov,
Frederic Weisbecker, Jim Cromie, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Em Thu, Jun 14, 2012 at 12:07:10PM +0200, Ingo Molnar escreveu:
> > Hm, fails to build here:
> >
> > CC util/parse-events-bison.o
> > util/parse-events.l: In function ‘__value’:
> > util/parse-events.l:18:10: error: ‘PE_ERROR’ undeclared (first
> > use in this function)
> > util/parse-events.l:18:10: note: each undeclared identifier is
> > reported only once for each function it appears in
> > util/parse-events.l:20:2: error: ‘parse_events_lval’ undeclared
> > (first use in this function)
> > util/parse-events.l: In function ‘value’:
> > util/parse-events.l:26:42: error: ‘PE_VALUE’ undeclared (first
> > use in this function)
> > util/parse-events.l: In function ‘raw’:
> > util/parse-events.l:31:44: error: ‘PE_RAW’ undeclared (first use
> > in this function)
> > util/parse-events.l: In function ‘str’:
> >
> > stock Fedora 17 install. 25f42985825d builds fine.
>
> Is this 32-bit? I'm installing another VM now, but on Fedora 17 x86_64:
No, 64-bit - I'll send you more info off-list.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-06-14 10:07 ` Ingo Molnar
2012-06-14 15:11 ` Arnaldo Carvalho de Melo
@ 2012-06-15 17:13 ` Arnaldo Carvalho de Melo
2012-06-15 18:28 ` Ingo Molnar
2012-06-15 19:03 ` Ingo Molnar
1 sibling, 2 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-06-15 17:13 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Corey Ashford, David Ahern, Dmitry Antipov,
Frederic Weisbecker, Jim Cromie, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian
Em Thu, Jun 14, 2012 at 12:07:10PM +0200, Ingo Molnar escreveu:
> Hm, fails to build here:
>
> CC util/parse-events-bison.o
> util/parse-events.l: In function ‘__value’:
> util/parse-events.l:18:10: error: ‘PE_ERROR’ undeclared (first
> use in this function)
> util/parse-events.l:18:10: note: each undeclared identifier is
> reported only once for each function it appears in
> util/parse-events.l:20:2: error: ‘parse_events_lval’ undeclared
> (first use in this function)
> util/parse-events.l: In function ‘value’:
> util/parse-events.l:26:42: error: ‘PE_VALUE’ undeclared (first
> use in this function)
> util/parse-events.l: In function ‘raw’:
> util/parse-events.l:31:44: error: ‘PE_RAW’ undeclared (first use
> in this function)
> util/parse-events.l: In function ‘str’:
>
> stock Fedora 17 install. 25f42985825d builds fine.
Is this 32-bit? I'm installing another VM now, but on Fedora 17 x86_64:
[acme@fedora17 linux]$ mkdir -p ../build/perf
[acme@fedora17 linux]$ make -j2 O=/home/acme/git/build/perf -C tools/perf/
make: Entering directory `/home/acme/git/linux/tools/perf'
MKDIR /home/acme/git/build/perf/arch/x86/util/
MKDIR /home/acme/git/build/perf/bench/
MKDIR /home/acme/git/build/perf/scripts/python/Perf-Trace-Util/
MKDIR /home/acme/git/build/perf/ui/
MKDIR /home/acme/git/build/perf/ui/browsers/
MKDIR /home/acme/git/build/perf/ui/gtk/
MKDIR /home/acme/git/build/perf/ui/tui/
MKDIR /home/acme/git/build/perf/util/
MKDIR /home/acme/git/build/perf/util/scripting-engines/
PERF_VERSION = 3.5.rc1.87.gcb9dd4
make: Leaving directory `/home/acme/git/linux/tools/perf'
make: Entering directory `/home/acme/git/linux/tools/perf'
GEN /home/acme/git/build/perf/common-cmds.h
* new build flags or prefix
CC /home/acme/git/build/perf/bench/mem-memcpy-x86-64-asm.o
CC /home/acme/git/build/perf/bench/mem-memset-x86-64-asm.o
CC /home/acme/git/build/perf/bench/mem-memcpy.o
CC /home/acme/git/build/perf/bench/mem-memset.o
CC /home/acme/git/build/perf/builtin-diff.o
CC /home/acme/git/build/perf/builtin-evlist.o
CC /home/acme/git/build/perf/builtin-help.o
CC /home/acme/git/build/perf/builtin-sched.o
CC /home/acme/git/build/perf/builtin-buildid-list.o
CC /home/acme/git/build/perf/builtin-buildid-cache.o
CC /home/acme/git/build/perf/builtin-list.o
CC /home/acme/git/build/perf/builtin-record.o
CC /home/acme/git/build/perf/builtin-report.o
CC /home/acme/git/build/perf/builtin-stat.o
CC /home/acme/git/build/perf/builtin-timechart.o
CC /home/acme/git/build/perf/builtin-top.o
CC /home/acme/git/build/perf/builtin-script.o
CC /home/acme/git/build/perf/builtin-probe.o
CC /home/acme/git/build/perf/builtin-kmem.o
CC /home/acme/git/build/perf/builtin-lock.o
CC /home/acme/git/build/perf/builtin-kvm.o
CC /home/acme/git/build/perf/builtin-test.o
CC /home/acme/git/build/perf/builtin-inject.o
CC /home/acme/git/build/perf/util/abspath.o
CC /home/acme/git/build/perf/util/alias.o
CC /home/acme/git/build/perf/util/annotate.o
CC /home/acme/git/build/perf/util/build-id.o
CC /home/acme/git/build/perf/util/config.o
CC /home/acme/git/build/perf/util/ctype.o
CC /home/acme/git/build/perf/util/debugfs.o
CC /home/acme/git/build/perf/util/sysfs.o
FLEX /home/acme/git/build/perf/util/pmu-flex.c
BISON /home/acme/git/build/perf/util/pmu-bison.c
CC /home/acme/git/build/perf/util/environment.o
CC /home/acme/git/build/perf/util/event.o
CC /home/acme/git/build/perf/util/evlist.o
CC /home/acme/git/build/perf/util/evsel.o
CC /home/acme/git/build/perf/util/exec_cmd.o
CC /home/acme/git/build/perf/util/help.o
CC /home/acme/git/build/perf/util/levenshtein.o
CC /home/acme/git/build/perf/util/parse-options.o
FLEX /home/acme/git/build/perf/util/parse-events-flex.c
BISON /home/acme/git/build/perf/util/parse-events-bison.c
CC /home/acme/git/build/perf/util/parse-events-test.o
CC /home/acme/git/build/perf/util/path.o
CC /home/acme/git/build/perf/util/rbtree.o
CC /home/acme/git/build/perf/util/bitmap.o
CC /home/acme/git/build/perf/util/hweight.o
CC /home/acme/git/build/perf/util/run-command.o
CC /home/acme/git/build/perf/util/quote.o
CC /home/acme/git/build/perf/util/strbuf.o
CC /home/acme/git/build/perf/util/string.o
CC /home/acme/git/build/perf/util/strlist.o
CC /home/acme/git/build/perf/util/strfilter.o
CC /home/acme/git/build/perf/util/top.o
CC /home/acme/git/build/perf/util/usage.o
CC /home/acme/git/build/perf/util/wrapper.o
CC /home/acme/git/build/perf/util/sigchain.o
CC /home/acme/git/build/perf/util/symbol.o
CC /home/acme/git/build/perf/util/color.o
CC /home/acme/git/build/perf/util/pager.o
CC /home/acme/git/build/perf/util/header.o
CC /home/acme/git/build/perf/util/callchain.o
CC /home/acme/git/build/perf/util/values.o
CC /home/acme/git/build/perf/util/debug.o
CC /home/acme/git/build/perf/util/map.o
CC /home/acme/git/build/perf/util/pstack.o
CC /home/acme/git/build/perf/util/session.o
CC /home/acme/git/build/perf/util/thread.o
CC /home/acme/git/build/perf/util/thread_map.o
CC /home/acme/git/build/perf/util/trace-event-parse.o
CC /home/acme/git/build/perf/util/parse-events-flex.o
CC /home/acme/git/build/perf/util/parse-events-bison.o
CC /home/acme/git/build/perf/util/pmu-flex.o
CC /home/acme/git/build/perf/util/pmu-bison.o
CC /home/acme/git/build/perf/util/trace-event-read.o
CC /home/acme/git/build/perf/util/trace-event-info.o
CC /home/acme/git/build/perf/util/trace-event-scripting.o
CC /home/acme/git/build/perf/util/svghelper.o
CC /home/acme/git/build/perf/util/sort.o
CC /home/acme/git/build/perf/util/hist.o
CC /home/acme/git/build/perf/util/probe-event.o
CC /home/acme/git/build/perf/util/util.o
CC /home/acme/git/build/perf/util/xyarray.o
CC /home/acme/git/build/perf/util/cpumap.o
CC /home/acme/git/build/perf/util/cgroup.o
CC /home/acme/git/build/perf/util/target.o
CC /home/acme/git/build/perf/arch/x86/util/dwarf-regs.o
CC /home/acme/git/build/perf/arch/x86/util/header.o
CC /home/acme/git/build/perf/util/probe-finder.o
CC /home/acme/git/build/perf/util/dwarf-aux.o
CC /home/acme/git/build/perf/ui/setup.o
CC /home/acme/git/build/perf/ui/browser.o
CC /home/acme/git/build/perf/ui/browsers/annotate.o
CC /home/acme/git/build/perf/ui/browsers/hists.o
CC /home/acme/git/build/perf/ui/browsers/map.o
CC /home/acme/git/build/perf/ui/helpline.o
CC /home/acme/git/build/perf/ui/progress.o
CC /home/acme/git/build/perf/ui/util.o
CC /home/acme/git/build/perf/ui/tui/setup.o
CC /home/acme/git/build/perf/ui/gtk/browser.o
CC /home/acme/git/build/perf/ui/gtk/setup.o
CC /home/acme/git/build/perf/util/scripting-engines/trace-event-python.o
CC /home/acme/git/build/perf/scripts/python/Perf-Trace-Util/Context.o
make[1]: Entering directory `/home/acme/git/linux/tools/lib/traceevent'
make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
GEN perf-archive
CC FPIC event-parse.o
GEN /home/acme/git/build/perf/python/perf.so
CC FPIC trace-seq.o
CC FPIC parse-filter.o
CC FPIC parse-utils.o
BUILD STATIC LIB libtraceevent.a
make[1]: Leaving directory `/home/acme/git/linux/tools/lib/traceevent'
CC /home/acme/git/build/perf/perf.o
CC /home/acme/git/build/perf/builtin-annotate.o
CC /home/acme/git/build/perf/builtin-bench.o
CC /home/acme/git/build/perf/bench/sched-messaging.o
CC /home/acme/git/build/perf/bench/sched-pipe.o
CC /home/acme/git/build/perf/util/pmu.o
CC /home/acme/git/build/perf/util/parse-events.o
AR /home/acme/git/build/perf/libperf.a
LINK /home/acme/git/build/perf/perf
make: Leaving directory `/home/acme/git/linux/tools/perf'
[acme@fedora17 linux]$ cat /etc/fedora-release
Fedora release 17 (Beefy Miracle)
[acme@fedora17 linux]$
[acme@fedora17 linux]$ git describe
perf-urgent-for-mingo
[acme@fedora17 linux]$ git describe --match 'v[0-9].[0-9]*'
v3.5-rc1-87-gcb9dd49
[acme@fedora17 linux]$ git branch | grep '*'
* perf/urgent
[acme@fedora17 linux]$ uname -a
Linux fedora17.ghostprotocols.net 3.4.0-1.fc17.x86_64 #1 SMP Sun Jun 3 06:35:17 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
[acme@fedora17 linux]$
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-06-14 10:07 ` Ingo Molnar
@ 2012-06-14 15:11 ` Arnaldo Carvalho de Melo
2012-06-15 17:13 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-06-14 15:11 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Corey Ashford, David Ahern, Dmitry Antipov,
Frederic Weisbecker, Jim Cromie, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian
Em Thu, Jun 14, 2012 at 12:07:10PM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hm, fails to build here:
>
> CC util/parse-events-bison.o
> util/parse-events.l: In function ‘__value’:
> util/parse-events.l:18:10: error: ‘PE_ERROR’ undeclared (first
> use in this function)
> util/parse-events.l:18:10: note: each undeclared identifier is
> reported only once for each function it appears in
> util/parse-events.l:20:2: error: ‘parse_events_lval’ undeclared
> (first use in this function)
> util/parse-events.l: In function ‘value’:
> util/parse-events.l:26:42: error: ‘PE_VALUE’ undeclared (first
> use in this function)
> util/parse-events.l: In function ‘raw’:
> util/parse-events.l:31:44: error: ‘PE_RAW’ undeclared (first use
> in this function)
> util/parse-events.l: In function ‘str’:
>
> stock Fedora 17 install. 25f42985825d builds fine.
Oops, fixing...
- Arnaldo
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-06-13 15:29 Arnaldo Carvalho de Melo
@ 2012-06-14 10:07 ` Ingo Molnar
2012-06-14 15:11 ` Arnaldo Carvalho de Melo
2012-06-15 17:13 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-06-14 10:07 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Corey Ashford, David Ahern, Dmitry Antipov,
Frederic Weisbecker, Jim Cromie, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
arnaldo.melo, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 9ee6ddc9dada9cc4b2201631bc74fbf203183a10:
>
> Merge branch 'tip/perf/urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace into perf/urgent (2012-06-08 12:23:22 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to cb9dd49e11f83d548c822d7022ac180b0518b25c:
>
> perf tools: Fix synthesizing tracepoint names from the perf.data headers (2012-06-12 11:28:09 -0300)
>
> ----------------------------------------------------------------
> Fixes for perf/urgent
>
> . Set name of tracepoints when reading the perf.data headers, so that
> we don't end up using the local ones, from /sys.
>
> . Fix default output file for perf stat, from Stephane Eranian.
>
> . Fix endian handling of features bitmask in perf.data header, from David Ahern
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf tools: Fix synthesizing tracepoint names from the perf.data headers
>
> David Ahern (1):
> perf tools: Fix endianity swapping for adds_features bitmask
>
> Stephane Eranian (1):
> perf stat: Fix default output file
>
> tools/perf/builtin-stat.c | 8 +++++-
> tools/perf/util/header.c | 48 +++++++++++++++++++++++++++-----
> tools/perf/util/include/linux/bitops.h | 2 ++
> tools/perf/util/session.c | 10 +++++++
> tools/perf/util/session.h | 1 +
> 5 files changed, 61 insertions(+), 8 deletions(-)
Hm, fails to build here:
CC util/parse-events-bison.o
util/parse-events.l: In function ‘__value’:
util/parse-events.l:18:10: error: ‘PE_ERROR’ undeclared (first
use in this function)
util/parse-events.l:18:10: note: each undeclared identifier is
reported only once for each function it appears in
util/parse-events.l:20:2: error: ‘parse_events_lval’ undeclared
(first use in this function)
util/parse-events.l: In function ‘value’:
util/parse-events.l:26:42: error: ‘PE_VALUE’ undeclared (first
use in this function)
util/parse-events.l: In function ‘raw’:
util/parse-events.l:31:44: error: ‘PE_RAW’ undeclared (first use
in this function)
util/parse-events.l: In function ‘str’:
stock Fedora 17 install. 25f42985825d builds fine.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-06-13 15:29 Arnaldo Carvalho de Melo
2012-06-14 10:07 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-06-13 15:29 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Dmitry Antipov, Frederic Weisbecker, Jim Cromie,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, arnaldo.melo,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 9ee6ddc9dada9cc4b2201631bc74fbf203183a10:
Merge branch 'tip/perf/urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace into perf/urgent (2012-06-08 12:23:22 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to cb9dd49e11f83d548c822d7022ac180b0518b25c:
perf tools: Fix synthesizing tracepoint names from the perf.data headers (2012-06-12 11:28:09 -0300)
----------------------------------------------------------------
Fixes for perf/urgent
. Set name of tracepoints when reading the perf.data headers, so that
we don't end up using the local ones, from /sys.
. Fix default output file for perf stat, from Stephane Eranian.
. Fix endian handling of features bitmask in perf.data header, from David Ahern
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf tools: Fix synthesizing tracepoint names from the perf.data headers
David Ahern (1):
perf tools: Fix endianity swapping for adds_features bitmask
Stephane Eranian (1):
perf stat: Fix default output file
tools/perf/builtin-stat.c | 8 +++++-
tools/perf/util/header.c | 48 +++++++++++++++++++++++++++-----
tools/perf/util/include/linux/bitops.h | 2 ++
tools/perf/util/session.c | 10 +++++++
tools/perf/util/session.h | 1 +
5 files changed, 61 insertions(+), 8 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-05-30 17:18 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-05-30 17:18 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, William Cohen,
arnaldo.melo, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 063e04776172f93b16a5eefd5661a340c1126513:
Merge branch 'linus' into perf/urgent (2012-05-30 10:59:04 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to 79695e1bb65ba0e21488c360a1bed6e358354aaa:
perf stat: Initialize default events wrt exclude_{guest,host} (2012-05-30 14:02:38 -0300)
----------------------------------------------------------------
Fixes for perf/urgent.
. Fix setting of KVM exclude bits on default set of events in perf stat.
. Use right symbol for annotation in non symbolic views in perf report.
. Fix annotate browser help window "Hot line" key.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf report: Use the right symbol for annotation
perf annotate browser: Fix help window entry for navigating to hottest line
perf stat: Initialize default events wrt exclude_{guest,host}
tools/perf/builtin-report.c | 2 +-
tools/perf/builtin-stat.c | 8 ++++----
tools/perf/ui/browsers/annotate.c | 2 +-
tools/perf/util/evlist.c | 11 +++++++++++
tools/perf/util/evlist.h | 4 ++++
5 files changed, 21 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-03-14 16:58 Arnaldo Carvalho de Melo
@ 2012-03-14 17:50 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-03-14 17:50 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Anton Blanchard, David Ahern, Eric B Munson,
Frederic Weisbecker, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, stable, Stephane Eranian, Yanmin Zhang,
arnaldo.melo, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 8aa8a7c80ccdfac2df5ee48a51a4a7bee2143d4f:
>
> perf record: Fix buffer overrun bug in tracepoint_id_to_path() (2012-03-13 17:01:28 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to eae7a755ee81129370c8f555b0d5672e6673735d:
>
> perf tools, x86: Build perf on older user-space as well (2012-03-14 12:42:34 -0300)
>
> ----------------------------------------------------------------
> Some corner cases fixes.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Anton Blanchard (1):
> perf tools: Incorrect use of snprintf results in SEGV
>
> Arnaldo Carvalho de Melo (1):
> perf tools: Use scnprintf where applicable
>
> Ingo Molnar (1):
> perf tools, x86: Build perf on older user-space as well
>
> tools/perf/Makefile | 2 ++
> tools/perf/arch/powerpc/util/header.c | 2 +-
> tools/perf/arch/x86/util/header.c | 2 +-
> tools/perf/perf.h | 6 ++++++
> tools/perf/util/color.c | 9 +++++----
> tools/perf/util/header.c | 4 ++--
> tools/perf/util/hist.c | 30 +++++++++++++++---------------
> tools/perf/util/include/asm/unistd_32.h | 1 +
> tools/perf/util/include/asm/unistd_64.h | 1 +
> tools/perf/util/sort.c | 3 +++
> tools/perf/util/strbuf.c | 7 ++++---
> tools/perf/util/ui/browsers/hists.c | 12 ++++++------
> tools/perf/util/ui/helpline.c | 2 +-
> 13 files changed, 48 insertions(+), 33 deletions(-)
> create mode 100644 tools/perf/util/include/asm/unistd_32.h
> create mode 100644 tools/perf/util/include/asm/unistd_64.h
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-03-14 16:58 Arnaldo Carvalho de Melo
2012-03-14 17:50 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-03-14 16:58 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Anton Blanchard,
David Ahern, Eric B Munson, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, stable, Stephane Eranian,
Yanmin Zhang, arnaldo.melo, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 8aa8a7c80ccdfac2df5ee48a51a4a7bee2143d4f:
perf record: Fix buffer overrun bug in tracepoint_id_to_path() (2012-03-13 17:01:28 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to eae7a755ee81129370c8f555b0d5672e6673735d:
perf tools, x86: Build perf on older user-space as well (2012-03-14 12:42:34 -0300)
----------------------------------------------------------------
Some corner cases fixes.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Anton Blanchard (1):
perf tools: Incorrect use of snprintf results in SEGV
Arnaldo Carvalho de Melo (1):
perf tools: Use scnprintf where applicable
Ingo Molnar (1):
perf tools, x86: Build perf on older user-space as well
tools/perf/Makefile | 2 ++
tools/perf/arch/powerpc/util/header.c | 2 +-
tools/perf/arch/x86/util/header.c | 2 +-
tools/perf/perf.h | 6 ++++++
tools/perf/util/color.c | 9 +++++----
tools/perf/util/header.c | 4 ++--
tools/perf/util/hist.c | 30 +++++++++++++++---------------
tools/perf/util/include/asm/unistd_32.h | 1 +
tools/perf/util/include/asm/unistd_64.h | 1 +
tools/perf/util/sort.c | 3 +++
tools/perf/util/strbuf.c | 7 ++++---
tools/perf/util/ui/browsers/hists.c | 12 ++++++------
tools/perf/util/ui/helpline.c | 2 +-
13 files changed, 48 insertions(+), 33 deletions(-)
create mode 100644 tools/perf/util/include/asm/unistd_32.h
create mode 100644 tools/perf/util/include/asm/unistd_64.h
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-03-03 19:20 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-03-03 19:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Jason Wang, Joerg Roedel, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Robert Richter,
Stephane Eranian, Thomas Gleixner, arnaldo.melo,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 1018faa6cf23b256bf25919ef203cd7c129f06f2:
perf/x86/kvm: Fix Host-Only/Guest-Only counting with SVM disabled (2012-03-02 12:16:39 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to bc76efe64533305b55d1f0834fd03414da8a12b2:
perf tools: Handle kernels that don't support attr.exclude_{guest,host} (2012-03-03 12:19:56 -0300)
----------------------------------------------------------------
Cherry picked fixes from perf/core, together with the kernel fix (1018faa),
the sampling tools (top, record) are back working on AMD systems.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf tools: Handle kernels that don't support attr.exclude_{guest,host}
David Ahern (1):
perf record: No build id option fails
Joerg Roedel (1):
perf tools: Change perf_guest default back to false
tools/perf/builtin-record.c | 33 ++++++++++++++++++++++-----------
tools/perf/builtin-top.c | 23 +++++++++++++++++------
tools/perf/perf.h | 1 +
tools/perf/util/top.h | 1 +
tools/perf/util/util.c | 2 +-
5 files changed, 42 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-02-06 21:36 Arnaldo Carvalho de Melo
@ 2012-02-07 8:46 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-02-07 8:46 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ananth N Mavinakayanahalli, Clark Williams,
Corey Ashford, Eric Dumazet, Jiri Olsa, Naveen N. Rao,
Paul Mackerras, Peter Zijlstra, Robert Richter,
Srikar Dronamraju, stable, arnaldo.melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> The following changes since commit 84f2b9b2edc09595569c7397cc3c888764ffd78b:
>
> perf: Remove deprecated WARN_ON_ONCE() (2012-02-03 08:24:40 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-urgent-for-mingo
>
> for you to fetch changes up to a4a03fc7ef89020baca4f19174e6a43767c6d78a:
>
> perf evsel: Fix an issue where perf report fails to show the proper percentage (2012-02-06 18:59:38 -0200)
>
> ----------------------------------------------------------------
> Fixes for some long standing problems.
>
> ----------------------------------------------------------------
> Jiri Olsa (2):
> perf tools: Fix perf stack to non executable on x86_64
> perf tools: Fix prefix matching for kernel maps
>
> Naveen N. Rao (1):
> perf evsel: Fix an issue where perf report fails to show the proper percentage
>
> tools/perf/bench/mem-memcpy-x86-64-asm.S | 6 ++++++
> tools/perf/util/event.c | 2 +-
> tools/perf/util/evsel.c | 1 +
> 3 files changed, 8 insertions(+), 1 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-02-06 21:36 Arnaldo Carvalho de Melo
2012-02-07 8:46 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-02-06 21:36 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo,
Ananth N Mavinakayanahalli, Clark Williams, Corey Ashford,
Eric Dumazet, Jiri Olsa, Naveen N. Rao, Paul Mackerras,
Peter Zijlstra, Robert Richter, Srikar Dronamraju, stable,
arnaldo.melo
The following changes since commit 84f2b9b2edc09595569c7397cc3c888764ffd78b:
perf: Remove deprecated WARN_ON_ONCE() (2012-02-03 08:24:40 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-urgent-for-mingo
for you to fetch changes up to a4a03fc7ef89020baca4f19174e6a43767c6d78a:
perf evsel: Fix an issue where perf report fails to show the proper percentage (2012-02-06 18:59:38 -0200)
----------------------------------------------------------------
Fixes for some long standing problems.
----------------------------------------------------------------
Jiri Olsa (2):
perf tools: Fix perf stack to non executable on x86_64
perf tools: Fix prefix matching for kernel maps
Naveen N. Rao (1):
perf evsel: Fix an issue where perf report fails to show the proper percentage
tools/perf/bench/mem-memcpy-x86-64-asm.S | 6 ++++++
tools/perf/util/event.c | 2 +-
tools/perf/util/evsel.c | 1 +
3 files changed, 8 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2012-01-31 1:21 Arnaldo Carvalho de Melo
@ 2012-01-31 12:04 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2012-01-31 12:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, David Daney,
Joerg Roedel, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Peter Zijlstra, Stephane Eranian
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> The following changes since commit d0caf292505d051b1026e85faf3a85e907566f31:
>
> x86/dumpstack: Remove unneeded check in dump_trace() (2012-01-28 13:09:06 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-urgent-for-mingo
>
> for you to fetch changes up to 509605dbe9395ce1abbfac1dba375f074ff57a53:
>
> perf top: Fix number of samples displayed (2012-01-30 22:29:49 -0200)
>
> ----------------------------------------------------------------
> Fixes cherry picked from perf/core.
>
> ----------------------------------------------------------------
> David Daney (1):
> perf tools: Fix broken build by defining _GNU_SOURCE in Makefile
>
> Stephane Eranian (2):
> perf tools: Fix strlen() bug in perf_event__synthesize_event_type()
> perf top: Fix number of samples displayed
>
> tools/perf/Makefile | 7 ++-----
> tools/perf/builtin-probe.c | 2 --
> tools/perf/builtin-top.c | 13 ++++++++++---
> tools/perf/util/header.c | 2 +-
> tools/perf/util/probe-event.c | 2 --
> tools/perf/util/symbol.c | 1 -
> tools/perf/util/trace-event-parse.c | 3 +--
> tools/perf/util/ui/browsers/hists.c | 2 --
> tools/perf/util/ui/helpline.c | 1 -
> tools/perf/util/util.h | 1 -
> 10 files changed, 14 insertions(+), 20 deletions(-)
Pulled, thanks a lot Arnaldo!
I've also merged these into perf/core straight away, to make
sure the cherry-picks do not interfere and cause conflicts with
subequent work on those files.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2012-01-31 1:21 Arnaldo Carvalho de Melo
2012-01-31 12:04 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-01-31 1:21 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, David Daney,
Joerg Roedel, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Peter Zijlstra, Stephane Eranian
From: Arnaldo Carvalho de Melo <acme@redhat.com>
The following changes since commit d0caf292505d051b1026e85faf3a85e907566f31:
x86/dumpstack: Remove unneeded check in dump_trace() (2012-01-28 13:09:06 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-urgent-for-mingo
for you to fetch changes up to 509605dbe9395ce1abbfac1dba375f074ff57a53:
perf top: Fix number of samples displayed (2012-01-30 22:29:49 -0200)
----------------------------------------------------------------
Fixes cherry picked from perf/core.
----------------------------------------------------------------
David Daney (1):
perf tools: Fix broken build by defining _GNU_SOURCE in Makefile
Stephane Eranian (2):
perf tools: Fix strlen() bug in perf_event__synthesize_event_type()
perf top: Fix number of samples displayed
tools/perf/Makefile | 7 ++-----
tools/perf/builtin-probe.c | 2 --
tools/perf/builtin-top.c | 13 ++++++++++---
tools/perf/util/header.c | 2 +-
tools/perf/util/probe-event.c | 2 --
tools/perf/util/symbol.c | 1 -
tools/perf/util/trace-event-parse.c | 3 +--
tools/perf/util/ui/browsers/hists.c | 2 --
tools/perf/util/ui/helpline.c | 1 -
tools/perf/util/util.h | 1 -
10 files changed, 14 insertions(+), 20 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2011-01-11 19:50 Arnaldo Carvalho de Melo
@ 2011-01-12 8:36 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2011-01-12 8:36 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, David Ahern, Frederic Weisbecker, Kirill Smelkov,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Thomas Renninger, Tom Zanussi
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent
>
> Regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (3):
> perf evsel: Fix order of event list deletion
> perf top: Fix annotate segv
> Revert "perf tools: Emit clearer message for sys_perf_event_open ENOENT return"
>
> tools/perf/builtin-record.c | 4 +---
> tools/perf/builtin-stat.c | 1 +
> tools/perf/builtin-top.c | 5 +++--
> tools/perf/perf.c | 2 --
> 4 files changed, 5 insertions(+), 7 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2011-01-11 19:50 Arnaldo Carvalho de Melo
2011-01-12 8:36 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-01-11 19:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Ingo Molnar, Kirill Smelkov, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Thomas Renninger, Tom Zanussi
Hi Ingo,
Please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (3):
perf evsel: Fix order of event list deletion
perf top: Fix annotate segv
Revert "perf tools: Emit clearer message for sys_perf_event_open ENOENT return"
tools/perf/builtin-record.c | 4 +---
tools/perf/builtin-stat.c | 1 +
tools/perf/builtin-top.c | 5 +++--
tools/perf/perf.c | 2 --
4 files changed, 5 insertions(+), 7 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL 0/3] perf/urgent fixes
2010-10-04 18:54 Arnaldo Carvalho de Melo
@ 2010-10-05 6:18 ` Ingo Molnar
0 siblings, 0 replies; 53+ messages in thread
From: Ingo Molnar @ 2010-10-05 6:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Bernd Petrovitsch, David S . Miller,
Frederic Weisbecker, Frederik Deweerdt, Kusanagi Kouichi,
Paul Mackerras, Peter Zijlstra, Robert Richter, Stephane Eranian
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent
>
> Regards,
>
> - Arnaldo
>
> Frederik Deweerdt (1):
> perf ui hist browser: Fix segfault on 'a' for annotate
>
> Kusanagi Kouichi (1):
> perf tools: Fix build breakage
>
> Stephane Eranian (1):
> perf trace scripting: Fix extern struct definitions
>
> tools/perf/Makefile | 2 +-
> tools/perf/util/trace-event-scripting.c | 4 ++--
> tools/perf/util/ui/browsers/hists.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL 0/3] perf/urgent fixes
@ 2010-10-04 18:54 Arnaldo Carvalho de Melo
2010-10-05 6:18 ` Ingo Molnar
0 siblings, 1 reply; 53+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-10-04 18:54 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Bernd Petrovitsch,
David S . Miller, Frederic Weisbecker, Frederik Deweerdt,
Ingo Molnar, Kusanagi Kouichi, Paul Mackerras, Peter Zijlstra,
Robert Richter, Stephane Eranian
Hi Ingo,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent
Regards,
- Arnaldo
Frederik Deweerdt (1):
perf ui hist browser: Fix segfault on 'a' for annotate
Kusanagi Kouichi (1):
perf tools: Fix build breakage
Stephane Eranian (1):
perf trace scripting: Fix extern struct definitions
tools/perf/Makefile | 2 +-
tools/perf/util/trace-event-scripting.c | 4 ++--
tools/perf/util/ui/browsers/hists.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 53+ messages in thread
end of thread, other threads:[~2019-11-05 18:18 UTC | newest]
Thread overview: 53+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03 17:04 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 1/3] perf tools: tracepoint_error() can receive e=NULL, robustify it Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 2/3] perf tools: Fix thread lifetime related segfaut in intel_pt Arnaldo Carvalho de Melo
2016-02-03 17:04 ` [PATCH 3/3] perf probe: Search both .eh_frame and .debug_frame sections for probe location Arnaldo Carvalho de Melo
2016-02-04 7:56 ` [GIT PULL 0/3] perf/urgent fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2019-11-05 18:18 Arnaldo Carvalho de Melo
2017-10-10 15:26 Arnaldo Carvalho de Melo
2017-10-10 17:23 ` Ingo Molnar
2017-07-10 23:01 Arnaldo Carvalho de Melo
2017-07-11 8:17 ` Ingo Molnar
2017-06-16 19:26 Arnaldo Carvalho de Melo
2017-06-16 19:34 ` Ingo Molnar
2017-02-03 15:49 Arnaldo Carvalho de Melo
2017-02-03 19:43 ` Ingo Molnar
2016-08-18 20:40 Arnaldo Carvalho de Melo
2016-08-18 20:40 ` Arnaldo Carvalho de Melo
2016-08-18 20:51 ` Ingo Molnar
2016-08-18 20:51 ` Ingo Molnar
2016-05-27 15:57 Arnaldo Carvalho de Melo
2015-09-25 15:28 Arnaldo Carvalho de Melo
2015-09-26 6:17 ` Ingo Molnar
2015-09-01 16:14 Arnaldo Carvalho de Melo
2015-09-02 7:24 ` Ingo Molnar
2015-01-08 15:36 Arnaldo Carvalho de Melo
2015-01-09 10:04 ` Ingo Molnar
2014-04-18 10:20 Jiri Olsa
2014-03-10 21:15 Arnaldo Carvalho de Melo
2014-03-11 10:04 ` Ingo Molnar
2013-11-01 14:56 Arnaldo Carvalho de Melo
2013-11-04 6:50 ` Ingo Molnar
2013-10-20 8:27 Arnaldo Carvalho de Melo
2013-10-20 8:53 ` Ingo Molnar
2012-07-02 18:07 Arnaldo Carvalho de Melo
2012-07-06 8:26 ` Ingo Molnar
2012-06-13 15:29 Arnaldo Carvalho de Melo
2012-06-14 10:07 ` Ingo Molnar
2012-06-14 15:11 ` Arnaldo Carvalho de Melo
2012-06-15 17:13 ` Arnaldo Carvalho de Melo
2012-06-15 18:28 ` Ingo Molnar
2012-06-15 18:35 ` Ingo Molnar
2012-06-15 19:03 ` Ingo Molnar
2012-05-30 17:18 Arnaldo Carvalho de Melo
2012-03-14 16:58 Arnaldo Carvalho de Melo
2012-03-14 17:50 ` Ingo Molnar
2012-03-03 19:20 Arnaldo Carvalho de Melo
2012-02-06 21:36 Arnaldo Carvalho de Melo
2012-02-07 8:46 ` Ingo Molnar
2012-01-31 1:21 Arnaldo Carvalho de Melo
2012-01-31 12:04 ` Ingo Molnar
2011-01-11 19:50 Arnaldo Carvalho de Melo
2011-01-12 8:36 ` Ingo Molnar
2010-10-04 18:54 Arnaldo Carvalho de Melo
2010-10-05 6:18 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.