From: Mauro Carvalho Chehab <mchehab@osg.samsung.com> To: Shuah Khan <shuahkh@osg.samsung.com> Cc: tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com, stefanr@s5r6.in-berlin.de, inki.dae@samsung.com, jh1009.sung@samsung.com, elfring@users.sourceforge.net, prabhakar.csengg@gmail.com, sw0312.kim@samsung.com, p.zabel@pengutronix.de, ricardo.ribalda@gmail.com, labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com, ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oampo.co.uk, linuxbugs@vittgam.net, johan@oljud.se, klock.android@gmail.com, nenggun.kim@samsung.com, j.anaszewski@samsung.com, geliangtang@163.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-api@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 13/22] media: au0828 video change to use v4l_enable_media_source() Date: Thu, 4 Feb 2016 08:00:13 -0200 [thread overview] Message-ID: <20160204080013.0a2648ad@recife.lan> (raw) In-Reply-To: <fe282e5160ee480d9b4d792a94c94549c54545cd.1454557589.git.shuahkh@osg.samsung.com> Em Wed, 03 Feb 2016 21:03:45 -0700 Shuah Khan <shuahkh@osg.samsung.com> escreveu: > Change au0828 to check if tuner is free or not > before changing tuner configuration. > > vidioc_g_tuner(), and au0828_v4l2_close() now call > v4l-core interface v4l_enable_media_source() before > changing tuner configuration. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > drivers/media/usb/au0828/au0828-video.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > index 81952c8..8087215 100644 > --- a/drivers/media/usb/au0828/au0828-video.c > +++ b/drivers/media/usb/au0828/au0828-video.c > @@ -1006,8 +1006,12 @@ static int au0828_v4l2_close(struct file *filp) > goto end; > > if (dev->users == 1) { > - /* Save some power by putting tuner to sleep */ > - v4l2_device_call_all(&dev->v4l2_dev, 0, core, s_power, 0); > + /* Save some power by putting tuner to sleep, if it is free */ > + /* What happens when radio is using tuner?? */ > + ret = v4l_enable_media_source(vdev); > + if (ret == 0) > + v4l2_device_call_all(&dev->v4l2_dev, 0, core, > + s_power, 0); Actually, for most USB devices (and this is the case of au0828), the tuner can safely be disabled here if ALSA is not streaming, as, except for some very old USB tuner models (like em28xx-based WinTV USB2) have a separate audio output jack. Btw, those devices that have a separate audio output jack have analog tuners, like Philips FM1236. Those devices are always on, so the s_power callback are silently ignored. So, the best logic here would be to disable the tuner if: - ALSA is not streaming; - the last V4L2 file handler is closed. Additionally, media source can be disabled if the above conditions are met and if the device doesn't have a separate audio out plug (or doesn't use a silicon tuner like xc2028/3028/4000/5000). Of course, as ALSA may stream anytime, a callback would be needed to enable the media source and power on the tuner, for radio to work. I understand that the above would require some other non-trivial changes, with would be best addressed on a separate patch series. So, for now, I would add a FIXME there explaining the above. > dev->std_set_in_tuner_core = 0; > > /* When close the device, set the usb intf0 into alt0 to free > @@ -1408,10 +1412,16 @@ static int vidioc_s_audio(struct file *file, void *priv, const struct v4l2_audio > static int vidioc_g_tuner(struct file *file, void *priv, struct v4l2_tuner *t) > { > struct au0828_dev *dev = video_drvdata(file); > + struct video_device *vfd = video_devdata(file); > + int ret; > > if (t->index != 0) > return -EINVAL; > > + ret = v4l_enable_media_source(vfd); > + if (ret) > + return ret; > + > dprintk(1, "%s called std_set %d dev_state %d\n", __func__, > dev->std_set_in_tuner_core, dev->dev_state); >
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> To: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Cc: tiwai-IBi9RG/b67k@public.gmane.org, clemens-P6GI/4k7KOmELgA04lAiVw@public.gmane.org, hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, pawel-FA/gS7QP4orQT0dZR+AlfA@public.gmane.org, m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, tvboxspy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, crope-X3B1VOXEql0@public.gmane.org, ruchandani.tina-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, chehabrafael-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, stefanr-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jh1009.sung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, labbott-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org, pierre-louis.bossart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, ricard.wanderlof-VrBV9hrLPhE@public.gmane.org, julian-SZMMDGyaqes@public.gmane.org, takamichiho-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dominic.sacre-Mmb7MZpHnFY@public.gmane.org, misterpib-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org, gtmkramer-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org, normalperson-rMlxZR9MS24@public.gmane.org, joe-amhYAVlgbXj10XsdtD+oqA@public.gmane.org, linuxbugs@vittga Subject: Re: [PATCH v2 13/22] media: au0828 video change to use v4l_enable_media_source() Date: Thu, 4 Feb 2016 08:00:13 -0200 [thread overview] Message-ID: <20160204080013.0a2648ad@recife.lan> (raw) In-Reply-To: <fe282e5160ee480d9b4d792a94c94549c54545cd.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Em Wed, 03 Feb 2016 21:03:45 -0700 Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> escreveu: > Change au0828 to check if tuner is free or not > before changing tuner configuration. > > vidioc_g_tuner(), and au0828_v4l2_close() now call > v4l-core interface v4l_enable_media_source() before > changing tuner configuration. > > Signed-off-by: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> > --- > drivers/media/usb/au0828/au0828-video.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > index 81952c8..8087215 100644 > --- a/drivers/media/usb/au0828/au0828-video.c > +++ b/drivers/media/usb/au0828/au0828-video.c > @@ -1006,8 +1006,12 @@ static int au0828_v4l2_close(struct file *filp) > goto end; > > if (dev->users == 1) { > - /* Save some power by putting tuner to sleep */ > - v4l2_device_call_all(&dev->v4l2_dev, 0, core, s_power, 0); > + /* Save some power by putting tuner to sleep, if it is free */ > + /* What happens when radio is using tuner?? */ > + ret = v4l_enable_media_source(vdev); > + if (ret == 0) > + v4l2_device_call_all(&dev->v4l2_dev, 0, core, > + s_power, 0); Actually, for most USB devices (and this is the case of au0828), the tuner can safely be disabled here if ALSA is not streaming, as, except for some very old USB tuner models (like em28xx-based WinTV USB2) have a separate audio output jack. Btw, those devices that have a separate audio output jack have analog tuners, like Philips FM1236. Those devices are always on, so the s_power callback are silently ignored. So, the best logic here would be to disable the tuner if: - ALSA is not streaming; - the last V4L2 file handler is closed. Additionally, media source can be disabled if the above conditions are met and if the device doesn't have a separate audio out plug (or doesn't use a silicon tuner like xc2028/3028/4000/5000). Of course, as ALSA may stream anytime, a callback would be needed to enable the media source and power on the tuner, for radio to work. I understand that the above would require some other non-trivial changes, with would be best addressed on a separate patch series. So, for now, I would add a FIXME there explaining the above. > dev->std_set_in_tuner_core = 0; > > /* When close the device, set the usb intf0 into alt0 to free > @@ -1408,10 +1412,16 @@ static int vidioc_s_audio(struct file *file, void *priv, const struct v4l2_audio > static int vidioc_g_tuner(struct file *file, void *priv, struct v4l2_tuner *t) > { > struct au0828_dev *dev = video_drvdata(file); > + struct video_device *vfd = video_devdata(file); > + int ret; > > if (t->index != 0) > return -EINVAL; > > + ret = v4l_enable_media_source(vfd); > + if (ret) > + return ret; > + > dprintk(1, "%s called std_set %d dev_state %d\n", __func__, > dev->std_set_in_tuner_core, dev->dev_state); >
next prev parent reply other threads:[~2016-02-04 10:00 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-04 4:03 [PATCH v2 00/22] Sharing media resources across ALSA and au0828 drivers Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 01/22] uapi/media.h: Declare interface types for ALSA Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 8:38 ` Mauro Carvalho Chehab 2016-02-04 8:38 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 02/22] media: Add ALSA Media Controller function entities Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 8:40 ` Mauro Carvalho Chehab 2016-02-04 8:40 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 03/22] media: Media Controller register/unregister entity_notify API Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 9:03 ` Mauro Carvalho Chehab 2016-02-04 9:03 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 04/22] media: Media Controller enable/disable source handler API Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 05/22] media: Media Controller export non locking __media_entity_setup_link() Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 06/22] media: Media Controller non-locking __media_entity_pipeline_start/stop() Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 9:18 ` Mauro Carvalho Chehab 2016-02-04 9:18 ` Mauro Carvalho Chehab 2016-02-04 15:00 ` Shuah Khan 2016-02-04 15:00 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 07/22] media: v4l-core add enable/disable source common interfaces Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 6:29 ` kbuild test robot 2016-02-04 6:29 ` kbuild test robot 2016-02-04 9:25 ` Mauro Carvalho Chehab 2016-02-04 9:25 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 08/22] media: Move au8522_media_pads enum to au8522.h from au8522_priv.h Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 09/22] media: au8522 change to create MC pad for ALSA Audio Out Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 10/22] media: Change v4l-core to check if source is free Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 11/22] media: dvb-frontend invoke enable/disable_source handlers Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 9:35 ` Mauro Carvalho Chehab 2016-02-04 9:35 ` Mauro Carvalho Chehab 2016-02-04 14:58 ` Shuah Khan 2016-02-04 14:58 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 12/22] media: au0828 video remove au0828_enable_analog_tuner() Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 9:37 ` Mauro Carvalho Chehab 2016-02-04 9:37 ` Mauro Carvalho Chehab 2016-02-04 14:49 ` Shuah Khan 2016-02-04 14:49 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 13/22] media: au0828 video change to use v4l_enable_media_source() Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 10:00 ` Mauro Carvalho Chehab [this message] 2016-02-04 10:00 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 14/22] media: au0828 change to use Managed Media Controller API Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 10:05 ` Mauro Carvalho Chehab 2016-02-04 10:05 ` Mauro Carvalho Chehab 2016-02-04 10:08 ` Mauro Carvalho Chehab 2016-02-04 10:08 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 15/22] media: au0828 handle media_init and media_register window Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 16/22] media: au0828 create tuner to decoder link in disabled state Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 17/22] media: au0828 disable tuner to demod link Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 18/22] media: au0828 Use au8522_media_pads enum for pad defines Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 19/22] media: au0828-core register entity_notify hook Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 4:03 ` [PATCH v2 20/22] media: au0828 add enable, disable source handlers Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 10:26 ` Mauro Carvalho Chehab 2016-02-04 10:26 ` Mauro Carvalho Chehab 2016-02-08 22:42 ` Shuah Khan 2016-02-08 22:42 ` Shuah Khan 2016-02-08 23:00 ` Shuah Khan 2016-02-08 23:00 ` Shuah Khan 2016-02-09 13:42 ` Mauro Carvalho Chehab 2016-02-09 13:42 ` Mauro Carvalho Chehab 2016-02-09 10:51 ` Mauro Carvalho Chehab 2016-02-09 10:51 ` Mauro Carvalho Chehab 2016-02-04 4:03 ` [PATCH v2 21/22] sound/usb: Use Media Controller API to share media resources Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 10:36 ` Mauro Carvalho Chehab 2016-02-04 10:36 ` Mauro Carvalho Chehab 2016-02-04 10:46 ` Takashi Iwai 2016-02-04 10:46 ` Takashi Iwai 2016-02-07 11:25 ` kbuild test robot 2016-02-07 11:25 ` kbuild test robot 2016-02-04 4:03 ` [PATCH v2 22/22] media: Ensure media device unregister is done only once Shuah Khan 2016-02-04 4:03 ` Shuah Khan 2016-02-04 10:40 ` Mauro Carvalho Chehab 2016-02-04 10:40 ` Mauro Carvalho Chehab 2016-02-04 10:54 ` [PATCH v2 00/22] Sharing media resources across ALSA and au0828 drivers Mauro Carvalho Chehab 2016-02-04 10:54 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160204080013.0a2648ad@recife.lan \ --to=mchehab@osg.samsung.com \ --cc=alsa-devel@alsa-project.org \ --cc=arnd@arndb.de \ --cc=chehabrafael@gmail.com \ --cc=clemens@ladisch.de \ --cc=corbet@lwn.net \ --cc=crope@iki.fi \ --cc=dan.carpenter@oracle.com \ --cc=daniel@zonque.org \ --cc=dominic.sacre@gmx.de \ --cc=elfring@users.sourceforge.net \ --cc=geliangtang@163.com \ --cc=gtmkramer@xs4all.nl \ --cc=hans.verkuil@cisco.com \ --cc=inki.dae@samsung.com \ --cc=j.anaszewski@samsung.com \ --cc=javier@osg.samsung.com \ --cc=jh1009.sung@samsung.com \ --cc=joe@oampo.co.uk \ --cc=johan@oljud.se \ --cc=julian@jusst.de \ --cc=k.kozlowski@samsung.com \ --cc=klock.android@gmail.com \ --cc=kyungmin.park@samsung.com \ --cc=labbott@fedoraproject.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linuxbugs@vittgam.net \ --cc=m.szyprowski@samsung.com \ --cc=misterpib@gmail.com \ --cc=nenggun.kim@samsung.com \ --cc=normalperson@yhbt.net \ --cc=p.zabel@pengutronix.de \ --cc=pawel@osciak.com \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=prabhakar.csengg@gmail.com \ --cc=ricard.wanderlof@axis.com \ --cc=ricardo.ribalda@gmail.com \ --cc=ruchandani.tina@gmail.com \ --cc=sakari.ailus@linux.intel.com \ --cc=shuahkh@osg.samsung.com \ --cc=stefanr@s5r6.in-berlin.de \ --cc=sw0312.kim@samsung.com \ --cc=takamichiho@gmail.com \ --cc=tiwai@suse.com \ --cc=tvboxspy@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.