All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: zynq: fix typo in group name for qspi1
@ 2016-02-04  8:14 Helmut Buchsbaum
  2016-02-04 17:19 ` Sören Brinkmann
  2016-02-15 18:19 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Helmut Buchsbaum @ 2016-02-04  8:14 UTC (permalink / raw)
  To: Sören Brinkmann, Linus Walleij; +Cc: linux-gpio, Helmut Buchsbaum

Due to a typo Zynq pin controller does not set pin function of qspi1
when using function qspi1. So pin group for qspi1 has to be renamed to
"qspi1_0_grp" as outlined in the corresponding bindings documentation.

This also removes kernel message:
  zynq-pinctrl 700.pinctrl: invalid group "qspi1_0_grp" for function "qspi1"

Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
---
 drivers/pinctrl/pinctrl-zynq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
index af726b9..9150303 100644
--- a/drivers/pinctrl/pinctrl-zynq.c
+++ b/drivers/pinctrl/pinctrl-zynq.c
@@ -590,7 +590,7 @@ static const char * const usb1_groups[] = {"usb1_0_grp"};
 static const char * const mdio0_groups[] = {"mdio0_0_grp"};
 static const char * const mdio1_groups[] = {"mdio1_0_grp"};
 static const char * const qspi0_groups[] = {"qspi0_0_grp"};
-static const char * const qspi1_groups[] = {"qspi0_1_grp"};
+static const char * const qspi1_groups[] = {"qspi1_0_grp"};
 static const char * const qspi_fbclk_groups[] = {"qspi_fbclk_grp"};
 static const char * const qspi_cs1_groups[] = {"qspi_cs1_grp"};
 static const char * const spi0_groups[] = {"spi0_0_grp", "spi0_1_grp",
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: zynq: fix typo in group name for qspi1
  2016-02-04  8:14 [PATCH] pinctrl: zynq: fix typo in group name for qspi1 Helmut Buchsbaum
@ 2016-02-04 17:19 ` Sören Brinkmann
  2016-02-15 18:19 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Sören Brinkmann @ 2016-02-04 17:19 UTC (permalink / raw)
  To: Helmut Buchsbaum; +Cc: Linus Walleij, linux-gpio

On Thu, 2016-02-04 at 09:14:08 +0100, Helmut Buchsbaum wrote:
> Due to a typo Zynq pin controller does not set pin function of qspi1
> when using function qspi1. So pin group for qspi1 has to be renamed to
> "qspi1_0_grp" as outlined in the corresponding bindings documentation.
> 
> This also removes kernel message:
>   zynq-pinctrl 700.pinctrl: invalid group "qspi1_0_grp" for function "qspi1"
> 
> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

	Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: zynq: fix typo in group name for qspi1
  2016-02-04  8:14 [PATCH] pinctrl: zynq: fix typo in group name for qspi1 Helmut Buchsbaum
  2016-02-04 17:19 ` Sören Brinkmann
@ 2016-02-15 18:19 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-02-15 18:19 UTC (permalink / raw)
  To: Helmut Buchsbaum; +Cc: Sören Brinkmann, linux-gpio

On Thu, Feb 4, 2016 at 9:14 AM, Helmut Buchsbaum
<helmut.buchsbaum@gmail.com> wrote:

> Due to a typo Zynq pin controller does not set pin function of qspi1
> when using function qspi1. So pin group for qspi1 has to be renamed to
> "qspi1_0_grp" as outlined in the corresponding bindings documentation.
>
> This also removes kernel message:
>   zynq-pinctrl 700.pinctrl: invalid group "qspi1_0_grp" for function "qspi1"
>
> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>

Patch applied with Sören's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-15 18:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-04  8:14 [PATCH] pinctrl: zynq: fix typo in group name for qspi1 Helmut Buchsbaum
2016-02-04 17:19 ` Sören Brinkmann
2016-02-15 18:19 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.