* [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO
[not found] <[PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO>
@ 2016-02-04 23:06 ` Alexandra Yates
2016-02-04 23:27 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Alexandra Yates @ 2016-02-04 23:06 UTC (permalink / raw)
To: jdelvare, wsa, linux-i2c, linux-kernel; +Cc: Alexandra Yates
Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
resources have been moved to reside under the i801 SMBus host
controller whereas previously they were under the LPC device.
This patch adds Intel lewisburg SMBus support for iTCO device.
Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
---
drivers/i2c/busses/i2c-i801.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index f62d697..27fa0cb 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
switch (dev->device) {
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
+ case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
+ case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
priv->features |= FEATURE_I2C_BLOCK_READ;
priv->features |= FEATURE_IRQ;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-04 23:06 ` [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates
@ 2016-02-04 23:27 ` Wolfram Sang
2016-02-05 9:48 ` Jean Delvare
2016-02-05 21:56 ` Alexandra Yates
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-02-04 23:27 UTC (permalink / raw)
To: Alexandra Yates; +Cc: jdelvare, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> resources have been moved to reside under the i801 SMBus host
> controller whereas previously they were under the LPC device.
>
> This patch adds Intel lewisburg SMBus support for iTCO device.
>
> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
Please state what has changed in v2 of this patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-04 23:27 ` Wolfram Sang
@ 2016-02-05 9:48 ` Jean Delvare
2016-02-05 22:09 ` Alexandra Yates
2016-02-05 21:56 ` Alexandra Yates
1 sibling, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2016-02-05 9:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Alexandra Yates, linux-i2c, linux-kernel
On Fri, 5 Feb 2016 00:27:46 +0100, Wolfram Sang wrote:
> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
> > Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> > resources have been moved to reside under the i801 SMBus host
> > controller whereas previously they were under the LPC device.
> >
> > This patch adds Intel lewisburg SMBus support for iTCO device.
> >
> > Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>
> Please state what has changed in v2 of this patch?
Yes, Alexandra, please always include a changelog (between the ---
separator and the diffstat) when posting patch updates.
In this case there is no code change, the only change is the subject.
If I understand correctly, this is a fixup for commit
cdc5a3110e7c3ae793f367285789a6bc39c962dc ("i2c: i801: add Intel
Lewisburg device IDs") which should have included these changes. If so,
please mention it in the commit message. It may also make sense to tag
the patch for stable [v4.4].
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-04 23:27 ` Wolfram Sang
2016-02-05 9:48 ` Jean Delvare
@ 2016-02-05 21:56 ` Alexandra Yates
1 sibling, 0 replies; 5+ messages in thread
From: Alexandra Yates @ 2016-02-05 21:56 UTC (permalink / raw)
To: Wolfram Sang; +Cc: jdelvare, linux-i2c, linux-kernel
Hi Wolfram,
On 02/04/2016 03:27 PM, Wolfram Sang wrote:
> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>> resources have been moved to reside under the i801 SMBus host
>> controller whereas previously they were under the LPC device.
>>
>> This patch adds Intel lewisburg SMBus support for iTCO device.
>>
>> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>
> Please state what has changed in v2 of this patch?
>
The subject line changed I added i2c:i801 per your past request to match
the subject format for the list.
--
Thank you,
<Alexandra>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-05 9:48 ` Jean Delvare
@ 2016-02-05 22:09 ` Alexandra Yates
0 siblings, 0 replies; 5+ messages in thread
From: Alexandra Yates @ 2016-02-05 22:09 UTC (permalink / raw)
To: Jean Delvare, Wolfram Sang; +Cc: linux-i2c, linux-kernel
Hi Jean,
Thank you for your review and feedback.
On 02/05/2016 01:48 AM, Jean Delvare wrote:
> On Fri, 5 Feb 2016 00:27:46 +0100, Wolfram Sang wrote:
>> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
>>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>>> resources have been moved to reside under the i801 SMBus host
>>> controller whereas previously they were under the LPC device.
>>>
>>> This patch adds Intel lewisburg SMBus support for iTCO device.
>>>
>>> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>>
>> Please state what has changed in v2 of this patch?
>
> Yes, Alexandra, please always include a changelog (between the ---
> separator and the diffstat) when posting patch updates.
>
> In this case there is no code change, the only change is the subject.
correct
>
> If I understand correctly, this is a fixup for commit
> cdc5a3110e7c3ae793f367285789a6bc39c962dc ("i2c: i801: add Intel
> Lewisburg device IDs") which should have included these changes. If so,
> please mention it in the commit message. It may also make sense to tag
> the patch for stable [v4.4].
It is an addition to that commit, at the time I submitted the commit I
wasn't aware that this portion was needed to load dynamically since this
part of the code was in flux as well. As it is the driver loads using
modprobe. I'll add that to the commit message to make it clear and
resend the patch.
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> Thanks,
>
--
Thank you,
<Alexandra>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-05 22:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO>
2016-02-04 23:06 ` [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates
2016-02-04 23:27 ` Wolfram Sang
2016-02-05 9:48 ` Jean Delvare
2016-02-05 22:09 ` Alexandra Yates
2016-02-05 21:56 ` Alexandra Yates
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.