* [PATCH] power: bq27xxx_battery: Restore device name
@ 2016-02-02 12:15 Ivaylo Dimitrov
2016-02-02 12:27 ` Pali Rohár
2016-02-02 12:27 ` [PATCH] " Ivaylo Dimitrov
0 siblings, 2 replies; 12+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-02 12:15 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2
Cc: pali.rohar, linux-pm, linux-kernel, Ivaylo Dimitrov
Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power: bq27xxx_battery:
Reorganize I2C into a module") has removed the device name numbering from
bq27xxx_battery_i2c_probe. Fix that by restoring the code.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
drivers/power/bq27xxx_battery_i2c.c | 32 +++++++++++++++++++++++++++++---
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/drivers/power/bq27xxx_battery_i2c.c b/drivers/power/bq27xxx_battery_i2c.c
index b810e08..d98cdc5 100644
--- a/drivers/power/bq27xxx_battery_i2c.c
+++ b/drivers/power/bq27xxx_battery_i2c.c
@@ -21,6 +21,9 @@
#include <linux/power/bq27xxx_battery.h>
+static DEFINE_IDR(battery_id);
+static DEFINE_MUTEX(battery_mutex);
+
static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
{
struct bq27xxx_device_info *di = data;
@@ -70,19 +73,32 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
{
struct bq27xxx_device_info *di;
int ret;
+ char *name;
+ int num;
+
+ /* Get new ID for the new battery device */
+ mutex_lock(&battery_mutex);
+ num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
+ mutex_unlock(&battery_mutex);
+ if (num < 0)
+ return num;
+
+ name = devm_kasprintf(&client->dev, GFP_KERNEL, "%s-%d", id->name, num);
+ if (!name)
+ goto err_mem;
di = devm_kzalloc(&client->dev, sizeof(*di), GFP_KERNEL);
if (!di)
- return -ENOMEM;
+ goto err_mem;
di->dev = &client->dev;
di->chip = id->driver_data;
- di->name = id->name;
+ di->name = name;
di->bus.read = bq27xxx_battery_i2c_read;
ret = bq27xxx_battery_setup(di);
if (ret)
- return ret;
+ goto err_failed;
/* Schedule a polling after about 1 min */
schedule_delayed_work(&di->work, 60 * HZ);
@@ -103,6 +119,16 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
}
return 0;
+
+err_mem:
+ ret = -ENOMEM;
+
+err_failed:
+ mutex_lock(&battery_mutex);
+ idr_remove(&battery_id, num);
+ mutex_unlock(&battery_mutex);
+
+ return ret;
}
static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] power: bq27xxx_battery: Restore device name
2016-02-02 12:15 [PATCH] power: bq27xxx_battery: Restore device name Ivaylo Dimitrov
@ 2016-02-02 12:27 ` Pali Rohár
2016-02-02 12:32 ` Ivaylo Dimitrov
2016-02-02 12:34 ` [PATCH v1] " Ivaylo Dimitrov
2016-02-02 12:27 ` [PATCH] " Ivaylo Dimitrov
1 sibling, 2 replies; 12+ messages in thread
From: Pali Rohár @ 2016-02-02 12:27 UTC (permalink / raw)
To: Ivaylo Dimitrov; +Cc: sre, dbaryshkov, dwmw2, linux-pm, linux-kernel
On Tuesday 02 February 2016 14:15:19 Ivaylo Dimitrov wrote:
> Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power: bq27xxx_battery:
> Reorganize I2C into a module") has removed the device name numbering from
> bq27xxx_battery_i2c_probe. Fix that by restoring the code.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> drivers/power/bq27xxx_battery_i2c.c | 32 +++++++++++++++++++++++++++++---
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery_i2c.c b/drivers/power/bq27xxx_battery_i2c.c
> index b810e08..d98cdc5 100644
> --- a/drivers/power/bq27xxx_battery_i2c.c
> +++ b/drivers/power/bq27xxx_battery_i2c.c
> @@ -21,6 +21,9 @@
>
> #include <linux/power/bq27xxx_battery.h>
>
> +static DEFINE_IDR(battery_id);
> +static DEFINE_MUTEX(battery_mutex);
> +
> static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
> {
> struct bq27xxx_device_info *di = data;
> @@ -70,19 +73,32 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
> {
> struct bq27xxx_device_info *di;
> int ret;
> + char *name;
> + int num;
> +
> + /* Get new ID for the new battery device */
> + mutex_lock(&battery_mutex);
> + num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
> + mutex_unlock(&battery_mutex);
> + if (num < 0)
> + return num;
> +
> + name = devm_kasprintf(&client->dev, GFP_KERNEL, "%s-%d", id->name, num);
> + if (!name)
> + goto err_mem;
>
> di = devm_kzalloc(&client->dev, sizeof(*di), GFP_KERNEL);
> if (!di)
> - return -ENOMEM;
> + goto err_mem;
>
> di->dev = &client->dev;
> di->chip = id->driver_data;
> - di->name = id->name;
> + di->name = name;
> di->bus.read = bq27xxx_battery_i2c_read;
>
> ret = bq27xxx_battery_setup(di);
> if (ret)
> - return ret;
> + goto err_failed;
>
> /* Schedule a polling after about 1 min */
> schedule_delayed_work(&di->work, 60 * HZ);
> @@ -103,6 +119,16 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
> }
>
> return 0;
> +
> +err_mem:
> + ret = -ENOMEM;
> +
> +err_failed:
> + mutex_lock(&battery_mutex);
> + idr_remove(&battery_id, num);
> + mutex_unlock(&battery_mutex);
> +
> + return ret;
> }
>
> static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
Hi! Should not we call idr_remove() also in bq27xxx_battery_i2c_remove()?
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] power: bq27xxx_battery: Restore device name
2016-02-02 12:15 [PATCH] power: bq27xxx_battery: Restore device name Ivaylo Dimitrov
2016-02-02 12:27 ` Pali Rohár
@ 2016-02-02 12:27 ` Ivaylo Dimitrov
1 sibling, 0 replies; 12+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-02 12:27 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2; +Cc: pali.rohar, linux-pm, linux-kernel
Sorry, I've sent an incomplete patch, ignore that, will re-send the full
version
On 2.02.2016 14:15, Ivaylo Dimitrov wrote:
> Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power: bq27xxx_battery:
> Reorganize I2C into a module") has removed the device name numbering from
> bq27xxx_battery_i2c_probe. Fix that by restoring the code.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> drivers/power/bq27xxx_battery_i2c.c | 32 +++++++++++++++++++++++++++++---
> 1 file changed, 29 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] power: bq27xxx_battery: Restore device name
2016-02-02 12:27 ` Pali Rohár
@ 2016-02-02 12:32 ` Ivaylo Dimitrov
2016-02-02 12:34 ` [PATCH v1] " Ivaylo Dimitrov
1 sibling, 0 replies; 12+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-02 12:32 UTC (permalink / raw)
To: Pali Rohár; +Cc: sre, dbaryshkov, dwmw2, linux-pm, linux-kernel
On 2.02.2016 14:27, Pali Rohár wrote:
>
> Hi! Should not we call idr_remove() also in bq27xxx_battery_i2c_remove()?
>
Yes, missed that code in the commit, I am sending the full version in a
minute
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1] power: bq27xxx_battery: Restore device name
2016-02-02 12:27 ` Pali Rohár
2016-02-02 12:32 ` Ivaylo Dimitrov
@ 2016-02-02 12:34 ` Ivaylo Dimitrov
2016-02-02 12:37 ` Ivaylo Dimitrov
2016-02-02 12:47 ` kbuild test robot
1 sibling, 2 replies; 12+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-02 12:34 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2
Cc: pali.rohar, linux-pm, linux-kernel, Ivaylo Dimitrov
Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power: bq27xxx_battery:
Reorganize I2C into a module") has removed the device name numbering from
bq27xxx_battery_i2c_probe. Fix that by restoring the code.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
drivers/power/bq27xxx_battery_i2c.c | 36 +++++++++++++++++++++++++++++++++---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/drivers/power/bq27xxx_battery_i2c.c b/drivers/power/bq27xxx_battery_i2c.c
index b810e08..6b4a7cf 100644
--- a/drivers/power/bq27xxx_battery_i2c.c
+++ b/drivers/power/bq27xxx_battery_i2c.c
@@ -21,6 +21,9 @@
#include <linux/power/bq27xxx_battery.h>
+static DEFINE_IDR(battery_id);
+static DEFINE_MUTEX(battery_mutex);
+
static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
{
struct bq27xxx_device_info *di = data;
@@ -70,19 +73,32 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
{
struct bq27xxx_device_info *di;
int ret;
+ char *name;
+ int num;
+
+ /* Get new ID for the new battery device */
+ mutex_lock(&battery_mutex);
+ num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
+ mutex_unlock(&battery_mutex);
+ if (num < 0)
+ return num;
+
+ name = devm_kasprintf(&client->dev, GFP_KERNEL, "%s-%d", id->name, num);
+ if (!name)
+ goto err_mem;
di = devm_kzalloc(&client->dev, sizeof(*di), GFP_KERNEL);
if (!di)
- return -ENOMEM;
+ goto err_mem;
di->dev = &client->dev;
di->chip = id->driver_data;
- di->name = id->name;
+ di->name = name;
di->bus.read = bq27xxx_battery_i2c_read;
ret = bq27xxx_battery_setup(di);
if (ret)
- return ret;
+ goto err_failed;
/* Schedule a polling after about 1 min */
schedule_delayed_work(&di->work, 60 * HZ);
@@ -103,6 +119,16 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
}
return 0;
+
+err_mem:
+ ret = -ENOMEM;
+
+err_failed:
+ mutex_lock(&battery_mutex);
+ idr_remove(&battery_id, num);
+ mutex_unlock(&battery_mutex);
+
+ return ret;
}
static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
@@ -111,6 +137,10 @@ static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
bq27xxx_battery_teardown(di);
+ mutex_lock(&battery_mutex);
+ idr_remove(&battery_id, num);
+ mutex_unlock(&battery_mutex);
+
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1] power: bq27xxx_battery: Restore device name
2016-02-02 12:34 ` [PATCH v1] " Ivaylo Dimitrov
@ 2016-02-02 12:37 ` Ivaylo Dimitrov
2016-02-02 12:47 ` [PATCH v2] " Ivaylo Dimitrov
2016-02-02 12:47 ` kbuild test robot
1 sibling, 1 reply; 12+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-02 12:37 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2; +Cc: pali.rohar, linux-pm, linux-kernel
Guys, sorry for the noise, I got flue over my brain. This patch is
broken too, will fix it and will resend.
On 2.02.2016 14:34, Ivaylo Dimitrov wrote:
> Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power: bq27xxx_battery:
> Reorganize I2C into a module") has removed the device name numbering from
> bq27xxx_battery_i2c_probe. Fix that by restoring the code.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> drivers/power/bq27xxx_battery_i2c.c | 36 +++++++++++++++++++++++++++++++++---
> 1 file changed, 33 insertions(+), 3 deletions(-)
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] power: bq27xxx_battery: Restore device name
2016-02-02 12:37 ` Ivaylo Dimitrov
@ 2016-02-02 12:47 ` Ivaylo Dimitrov
2016-02-06 10:35 ` Pali Rohár
0 siblings, 1 reply; 12+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-02 12:47 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2
Cc: pali.rohar, linux-pm, linux-kernel, Ivaylo Dimitrov
Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power: bq27xxx_battery:
Reorganize I2C into a module") has removed the device name numbering from
bq27xxx_battery_i2c_probe. Fix that by restoring the code.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
drivers/power/bq27xxx_battery_i2c.c | 37 ++++++++++++++++++++++++++++++++---
include/linux/power/bq27xxx_battery.h | 1 +
2 files changed, 35 insertions(+), 3 deletions(-)
diff --git a/drivers/power/bq27xxx_battery_i2c.c b/drivers/power/bq27xxx_battery_i2c.c
index b810e08..b8f8d3a 100644
--- a/drivers/power/bq27xxx_battery_i2c.c
+++ b/drivers/power/bq27xxx_battery_i2c.c
@@ -21,6 +21,9 @@
#include <linux/power/bq27xxx_battery.h>
+static DEFINE_IDR(battery_id);
+static DEFINE_MUTEX(battery_mutex);
+
static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
{
struct bq27xxx_device_info *di = data;
@@ -70,19 +73,33 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
{
struct bq27xxx_device_info *di;
int ret;
+ char *name;
+ int num;
+
+ /* Get new ID for the new battery device */
+ mutex_lock(&battery_mutex);
+ num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
+ mutex_unlock(&battery_mutex);
+ if (num < 0)
+ return num;
+
+ name = devm_kasprintf(&client->dev, GFP_KERNEL, "%s-%d", id->name, num);
+ if (!name)
+ goto err_mem;
di = devm_kzalloc(&client->dev, sizeof(*di), GFP_KERNEL);
if (!di)
- return -ENOMEM;
+ goto err_mem;
+ di->id = num;
di->dev = &client->dev;
di->chip = id->driver_data;
- di->name = id->name;
+ di->name = name;
di->bus.read = bq27xxx_battery_i2c_read;
ret = bq27xxx_battery_setup(di);
if (ret)
- return ret;
+ goto err_failed;
/* Schedule a polling after about 1 min */
schedule_delayed_work(&di->work, 60 * HZ);
@@ -103,6 +120,16 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
}
return 0;
+
+err_mem:
+ ret = -ENOMEM;
+
+err_failed:
+ mutex_lock(&battery_mutex);
+ idr_remove(&battery_id, num);
+ mutex_unlock(&battery_mutex);
+
+ return ret;
}
static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
@@ -111,6 +138,10 @@ static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
bq27xxx_battery_teardown(di);
+ mutex_lock(&battery_mutex);
+ idr_remove(&battery_id, di->id);
+ mutex_unlock(&battery_mutex);
+
return 0;
}
diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h
index 998d8f1..b50c049 100644
--- a/include/linux/power/bq27xxx_battery.h
+++ b/include/linux/power/bq27xxx_battery.h
@@ -49,6 +49,7 @@ struct bq27xxx_reg_cache {
struct bq27xxx_device_info {
struct device *dev;
+ int id;
enum bq27xxx_chip chip;
const char *name;
struct bq27xxx_access_methods bus;
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1] power: bq27xxx_battery: Restore device name
2016-02-02 12:34 ` [PATCH v1] " Ivaylo Dimitrov
@ 2016-02-02 12:47 ` kbuild test robot
2016-02-02 12:47 ` kbuild test robot
1 sibling, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2016-02-02 12:47 UTC (permalink / raw)
To: Ivaylo Dimitrov
Cc: kbuild-all, sre, dbaryshkov, dwmw2, pali.rohar, linux-pm,
linux-kernel, Ivaylo Dimitrov
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
Hi Ivaylo,
[auto build test ERROR on battery/master]
[also build test ERROR on v4.5-rc2 next-20160201]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Ivaylo-Dimitrov/power-bq27xxx_battery-Restore-device-name/20160202-203646
base: git://git.infradead.org/battery-2.6.git master
config: i386-randconfig-x003-02010231 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/power/bq27xxx_battery_i2c.c: In function 'bq27xxx_battery_i2c_remove':
>> drivers/power/bq27xxx_battery_i2c.c:141:26: error: 'num' undeclared (first use in this function)
idr_remove(&battery_id, num);
^
drivers/power/bq27xxx_battery_i2c.c:141:26: note: each undeclared identifier is reported only once for each function it appears in
vim +/num +141 drivers/power/bq27xxx_battery_i2c.c
135 {
136 struct bq27xxx_device_info *di = i2c_get_clientdata(client);
137
138 bq27xxx_battery_teardown(di);
139
140 mutex_lock(&battery_mutex);
> 141 idr_remove(&battery_id, num);
142 mutex_unlock(&battery_mutex);
143
144 return 0;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 21507 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1] power: bq27xxx_battery: Restore device name
@ 2016-02-02 12:47 ` kbuild test robot
0 siblings, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2016-02-02 12:47 UTC (permalink / raw)
Cc: kbuild-all, sre, dbaryshkov, dwmw2, pali.rohar, linux-pm,
linux-kernel, Ivaylo Dimitrov
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
Hi Ivaylo,
[auto build test ERROR on battery/master]
[also build test ERROR on v4.5-rc2 next-20160201]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Ivaylo-Dimitrov/power-bq27xxx_battery-Restore-device-name/20160202-203646
base: git://git.infradead.org/battery-2.6.git master
config: i386-randconfig-x003-02010231 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/power/bq27xxx_battery_i2c.c: In function 'bq27xxx_battery_i2c_remove':
>> drivers/power/bq27xxx_battery_i2c.c:141:26: error: 'num' undeclared (first use in this function)
idr_remove(&battery_id, num);
^
drivers/power/bq27xxx_battery_i2c.c:141:26: note: each undeclared identifier is reported only once for each function it appears in
vim +/num +141 drivers/power/bq27xxx_battery_i2c.c
135 {
136 struct bq27xxx_device_info *di = i2c_get_clientdata(client);
137
138 bq27xxx_battery_teardown(di);
139
140 mutex_lock(&battery_mutex);
> 141 idr_remove(&battery_id, num);
142 mutex_unlock(&battery_mutex);
143
144 return 0;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 21507 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] power: bq27xxx_battery: Restore device name
2016-02-02 12:47 ` [PATCH v2] " Ivaylo Dimitrov
@ 2016-02-06 10:35 ` Pali Rohár
2016-02-21 11:34 ` Pali Rohár
0 siblings, 1 reply; 12+ messages in thread
From: Pali Rohár @ 2016-02-06 10:35 UTC (permalink / raw)
To: sre; +Cc: Ivaylo Dimitrov, dbaryshkov, dwmw2, linux-pm, linux-kernel
[-- Attachment #1: Type: Text/Plain, Size: 663 bytes --]
On Tuesday 02 February 2016 13:47:37 Ivaylo Dimitrov wrote:
> Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power:
> bq27xxx_battery: Reorganize I2C into a module") has removed the
> device name numbering from bq27xxx_battery_i2c_probe. Fix that by
> restoring the code.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Fixes: 703df6c097956d17a818e63961c82e8e9eef9fef
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Please apply this patch and backport to stable kernels with already has
patch 703df6c097956d17a818e63961c82e8e9eef9fef.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] power: bq27xxx_battery: Restore device name
2016-02-06 10:35 ` Pali Rohár
@ 2016-02-21 11:34 ` Pali Rohár
2016-02-23 9:32 ` Pali Rohár
0 siblings, 1 reply; 12+ messages in thread
From: Pali Rohár @ 2016-02-21 11:34 UTC (permalink / raw)
To: sre
Cc: Ivaylo Dimitrov, dbaryshkov, dwmw2, linux-pm, linux-kernel, Pavel Machek
[-- Attachment #1: Type: Text/Plain, Size: 810 bytes --]
On Saturday 06 February 2016 11:35:49 Pali Rohár wrote:
> On Tuesday 02 February 2016 13:47:37 Ivaylo Dimitrov wrote:
> > Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power:
> > bq27xxx_battery: Reorganize I2C into a module") has removed the
> > device name numbering from bq27xxx_battery_i2c_probe. Fix that by
> > restoring the code.
> >
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>
> Fixes: 703df6c097956d17a818e63961c82e8e9eef9fef
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> Tested-by: Pali Rohár <pali.rohar@gmail.com>
>
> Please apply this patch and backport to stable kernels with already
> has patch 703df6c097956d17a818e63961c82e8e9eef9fef.
I still do not see this patch in any tree... Please apply.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] power: bq27xxx_battery: Restore device name
2016-02-21 11:34 ` Pali Rohár
@ 2016-02-23 9:32 ` Pali Rohár
0 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2016-02-23 9:32 UTC (permalink / raw)
To: sre
Cc: Ivaylo Dimitrov, dbaryshkov, dwmw2, linux-pm, linux-kernel, Pavel Machek
On Sunday 21 February 2016 12:34:54 Pali Rohár wrote:
> On Saturday 06 February 2016 11:35:49 Pali Rohár wrote:
> > On Tuesday 02 February 2016 13:47:37 Ivaylo Dimitrov wrote:
> > > Patch <703df6c097956d17a818e63961c82e8e9eef9fef> ("power:
> > > bq27xxx_battery: Reorganize I2C into a module") has removed the
> > > device name numbering from bq27xxx_battery_i2c_probe. Fix that by
> > > restoring the code.
> > >
> > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> >
> > Fixes: 703df6c097956d17a818e63961c82e8e9eef9fef
> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> > Tested-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > Please apply this patch and backport to stable kernels with already
> > has patch 703df6c097956d17a818e63961c82e8e9eef9fef.
>
> I still do not see this patch in any tree... Please apply.
PING
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-02-23 9:32 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-02 12:15 [PATCH] power: bq27xxx_battery: Restore device name Ivaylo Dimitrov
2016-02-02 12:27 ` Pali Rohár
2016-02-02 12:32 ` Ivaylo Dimitrov
2016-02-02 12:34 ` [PATCH v1] " Ivaylo Dimitrov
2016-02-02 12:37 ` Ivaylo Dimitrov
2016-02-02 12:47 ` [PATCH v2] " Ivaylo Dimitrov
2016-02-06 10:35 ` Pali Rohár
2016-02-21 11:34 ` Pali Rohár
2016-02-23 9:32 ` Pali Rohár
2016-02-02 12:47 ` [PATCH v1] " kbuild test robot
2016-02-02 12:47 ` kbuild test robot
2016-02-02 12:27 ` [PATCH] " Ivaylo Dimitrov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.