* [PATCH] net: wireless: rt2x00: Fixed Spacing issues
@ 2015-10-17 20:04 Paul McQuade
2016-01-21 16:56 ` Helmut Schaa
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Paul McQuade @ 2015-10-17 20:04 UTC (permalink / raw)
To: paulmcquad; +Cc: sgruszka, kvalo, linux-wireless, netdev, linux-kernel
Removed empty spaces before/after parenthesis
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
index 1442075..ab86415 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.h
+++ b/drivers/net/wireless/rt2x00/rt61pci.h
@@ -138,14 +138,14 @@
#define PAIRWISE_TA_TABLE_BASE 0x1a00
#define SHARED_KEY_ENTRY(__idx) \
- ( SHARED_KEY_TABLE_BASE + \
- ((__idx) * sizeof(struct hw_key_entry)) )
+ (SHARED_KEY_TABLE_BASE + \
+ ((__idx) * sizeof(struct hw_key_entry)))
#define PAIRWISE_KEY_ENTRY(__idx) \
- ( PAIRWISE_KEY_TABLE_BASE + \
- ((__idx) * sizeof(struct hw_key_entry)) )
+ (PAIRWISE_KEY_TABLE_BASE + \
+ ((__idx) * sizeof(struct hw_key_entry)))
#define PAIRWISE_TA_ENTRY(__idx) \
- ( PAIRWISE_TA_TABLE_BASE + \
- ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
+ (PAIRWISE_TA_TABLE_BASE + \
+ ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
struct hw_key_entry {
u8 key[16];
@@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
#define HW_BEACON_BASE3 0x2f00
#define HW_BEACON_OFFSET(__index) \
- ( HW_BEACON_BASE0 + (__index * 0x0100) )
+ (HW_BEACON_BASE0 + (__index * 0x0100))
/*
* HOST-MCU shared memory.
@@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
/*
* DMA descriptor defines.
*/
-#define TXD_DESC_SIZE ( 16 * sizeof(__le32) )
-#define TXINFO_SIZE ( 6 * sizeof(__le32) )
-#define RXD_DESC_SIZE ( 16 * sizeof(__le32) )
+#define TXD_DESC_SIZE (16 * sizeof(__le32))
+#define TXINFO_SIZE (6 * sizeof(__le32))
+#define RXD_DESC_SIZE (16 * sizeof(__le32))
/*
* TX descriptor format for TX, PRIO and Beacon Ring.
--
2.6.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues
2015-10-17 20:04 [PATCH] net: wireless: rt2x00: Fixed Spacing issues Paul McQuade
@ 2016-01-21 16:56 ` Helmut Schaa
2016-01-21 17:02 ` Helmut Schaa
2016-02-02 15:59 ` Sudip Mukherjee
2016-02-07 7:10 ` Kalle Valo
2 siblings, 1 reply; 8+ messages in thread
From: Helmut Schaa @ 2016-01-21 16:56 UTC (permalink / raw)
To: Paul McQuade; +Cc: Stanislaw Gruszka, kvalo, linux-wireless, netdev, LKML
On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
Just noticed these did not get applied by Kalle yet.
Looks good to me.
Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
> drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
> index 1442075..ab86415 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.h
> +++ b/drivers/net/wireless/rt2x00/rt61pci.h
> @@ -138,14 +138,14 @@
> #define PAIRWISE_TA_TABLE_BASE 0x1a00
>
> #define SHARED_KEY_ENTRY(__idx) \
> - ( SHARED_KEY_TABLE_BASE + \
> - ((__idx) * sizeof(struct hw_key_entry)) )
> + (SHARED_KEY_TABLE_BASE + \
> + ((__idx) * sizeof(struct hw_key_entry)))
> #define PAIRWISE_KEY_ENTRY(__idx) \
> - ( PAIRWISE_KEY_TABLE_BASE + \
> - ((__idx) * sizeof(struct hw_key_entry)) )
> + (PAIRWISE_KEY_TABLE_BASE + \
> + ((__idx) * sizeof(struct hw_key_entry)))
> #define PAIRWISE_TA_ENTRY(__idx) \
> - ( PAIRWISE_TA_TABLE_BASE + \
> - ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
> + (PAIRWISE_TA_TABLE_BASE + \
> + ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
>
> struct hw_key_entry {
> u8 key[16];
> @@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
> #define HW_BEACON_BASE3 0x2f00
>
> #define HW_BEACON_OFFSET(__index) \
> - ( HW_BEACON_BASE0 + (__index * 0x0100) )
> + (HW_BEACON_BASE0 + (__index * 0x0100))
>
> /*
> * HOST-MCU shared memory.
> @@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
> /*
> * DMA descriptor defines.
> */
> -#define TXD_DESC_SIZE ( 16 * sizeof(__le32) )
> -#define TXINFO_SIZE ( 6 * sizeof(__le32) )
> -#define RXD_DESC_SIZE ( 16 * sizeof(__le32) )
> +#define TXD_DESC_SIZE (16 * sizeof(__le32))
> +#define TXINFO_SIZE (6 * sizeof(__le32))
> +#define RXD_DESC_SIZE (16 * sizeof(__le32))
>
> /*
> * TX descriptor format for TX, PRIO and Beacon Ring.
> --
> 2.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues
2016-01-21 16:56 ` Helmut Schaa
@ 2016-01-21 17:02 ` Helmut Schaa
2016-01-21 17:12 ` Kalle Valo
0 siblings, 1 reply; 8+ messages in thread
From: Helmut Schaa @ 2016-01-21 17:02 UTC (permalink / raw)
To: Paul McQuade; +Cc: Stanislaw Gruszka, kvalo, linux-wireless, netdev, LKML
On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
<helmut.schaa@googlemail.com> wrote:
> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
>> Removed empty spaces before/after parenthesis
>>
>> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
>
> Just noticed these did not get applied by Kalle yet.
Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
Or would you prefer Paul to respin the whole code style cleanup series?
Thanks,
Helmut
> Looks good to me.
>
> Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
>
>> ---
>> drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
>> index 1442075..ab86415 100644
>> --- a/drivers/net/wireless/rt2x00/rt61pci.h
>> +++ b/drivers/net/wireless/rt2x00/rt61pci.h
>> @@ -138,14 +138,14 @@
>> #define PAIRWISE_TA_TABLE_BASE 0x1a00
>>
>> #define SHARED_KEY_ENTRY(__idx) \
>> - ( SHARED_KEY_TABLE_BASE + \
>> - ((__idx) * sizeof(struct hw_key_entry)) )
>> + (SHARED_KEY_TABLE_BASE + \
>> + ((__idx) * sizeof(struct hw_key_entry)))
>> #define PAIRWISE_KEY_ENTRY(__idx) \
>> - ( PAIRWISE_KEY_TABLE_BASE + \
>> - ((__idx) * sizeof(struct hw_key_entry)) )
>> + (PAIRWISE_KEY_TABLE_BASE + \
>> + ((__idx) * sizeof(struct hw_key_entry)))
>> #define PAIRWISE_TA_ENTRY(__idx) \
>> - ( PAIRWISE_TA_TABLE_BASE + \
>> - ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
>> + (PAIRWISE_TA_TABLE_BASE + \
>> + ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
>>
>> struct hw_key_entry {
>> u8 key[16];
>> @@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
>> #define HW_BEACON_BASE3 0x2f00
>>
>> #define HW_BEACON_OFFSET(__index) \
>> - ( HW_BEACON_BASE0 + (__index * 0x0100) )
>> + (HW_BEACON_BASE0 + (__index * 0x0100))
>>
>> /*
>> * HOST-MCU shared memory.
>> @@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
>> /*
>> * DMA descriptor defines.
>> */
>> -#define TXD_DESC_SIZE ( 16 * sizeof(__le32) )
>> -#define TXINFO_SIZE ( 6 * sizeof(__le32) )
>> -#define RXD_DESC_SIZE ( 16 * sizeof(__le32) )
>> +#define TXD_DESC_SIZE (16 * sizeof(__le32))
>> +#define TXINFO_SIZE (6 * sizeof(__le32))
>> +#define RXD_DESC_SIZE (16 * sizeof(__le32))
>>
>> /*
>> * TX descriptor format for TX, PRIO and Beacon Ring.
>> --
>> 2.6.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues
@ 2016-01-21 17:12 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-01-21 17:12 UTC (permalink / raw)
To: Helmut Schaa
Cc: Paul McQuade, Stanislaw Gruszka, linux-wireless, netdev, LKML
Helmut Schaa <helmut.schaa@googlemail.com> writes:
> On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
> <helmut.schaa@googlemail.com> wrote:
>> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
>>> Removed empty spaces before/after parenthesis
>>>
>>> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
>>
>> Just noticed these did not get applied by Kalle yet.
>
> Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
> Or would you prefer Paul to respin the whole code style cleanup series?
Actually git should be manage that automatically, it's so awesome :)
I can also fix the title and remove the unnecessary "net: wireless:"
prefix.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues
@ 2016-01-21 17:12 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-01-21 17:12 UTC (permalink / raw)
To: Helmut Schaa
Cc: Paul McQuade, Stanislaw Gruszka, linux-wireless, netdev, LKML
Helmut Schaa <helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes:
> On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
> <helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:
>> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> Removed empty spaces before/after parenthesis
>>>
>>> Signed-off-by: Paul McQuade <paulmcquad-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> Just noticed these did not get applied by Kalle yet.
>
> Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
> Or would you prefer Paul to respin the whole code style cleanup series?
Actually git should be manage that automatically, it's so awesome :)
I can also fix the title and remove the unnecessary "net: wireless:"
prefix.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: net: wireless: rt2x00: Fixed Spacing issues
2015-10-17 20:04 [PATCH] net: wireless: rt2x00: Fixed Spacing issues Paul McQuade
2016-01-21 16:56 ` Helmut Schaa
@ 2016-02-02 15:59 ` Sudip Mukherjee
2016-02-07 7:10 ` Kalle Valo
2 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2016-02-02 15:59 UTC (permalink / raw)
To: Paul Mcquade; +Cc: sgruszka, kvalo, linux-wireless, netdev, linux-kernel
On Sat, Oct 17, 2015 at 09:04:39PM +0100, Paul Mcquade wrote:
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
>
> ---
> drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
This patch and your other patches related to rt2x00 will not apply
anymore as the driver has moved to drivers/net/wireless/ralink/rt2x00
can you please send them again after rebasing against current tree..
regards
sudip
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: net: wireless: rt2x00: Fixed Spacing issues
@ 2016-02-07 7:10 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-07 7:10 UTC (permalink / raw)
To: Paul Mcquade; +Cc: paulmcquad, sgruszka, linux-wireless, netdev, linux-kernel
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: net: wireless: rt2x00: Fixed Spacing issues
@ 2016-02-07 7:10 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-07 7:10 UTC (permalink / raw)
To: Paul Mcquade
Cc: paulmcquad-Re5JQEeQqe8AvxtiuMwx3w,
sgruszka-H+wXaHxf7aLQT0dZR+AlfA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Acked-by: Helmut Schaa <helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-07 7:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-17 20:04 [PATCH] net: wireless: rt2x00: Fixed Spacing issues Paul McQuade
2016-01-21 16:56 ` Helmut Schaa
2016-01-21 17:02 ` Helmut Schaa
2016-01-21 17:12 ` Kalle Valo
2016-01-21 17:12 ` Kalle Valo
2016-02-02 15:59 ` Sudip Mukherjee
2016-02-07 7:10 ` Kalle Valo
2016-02-07 7:10 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.