From: Mark Brown <broonie@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-spi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] spi: fix spi.h kernel-doc warning
Date: Mon, 8 Feb 2016 16:55:56 +0000 [thread overview]
Message-ID: <20160208165556.GJ7265@sirena.org.uk> (raw)
In-Reply-To: <56B54CFB.9050904@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On Fri, Feb 05, 2016 at 05:31:39PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning for missing struct field notation.
>
> ..//include/linux/spi/spi.h:540: warning: No description found for parameter 'max_transfer_size'
The patch description and especially subject here should be something
along the lines of "Document max_transfer_size" - describe what you
think the change is.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH] spi: fix spi.h kernel-doc warning
Date: Mon, 8 Feb 2016 16:55:56 +0000 [thread overview]
Message-ID: <20160208165556.GJ7265@sirena.org.uk> (raw)
In-Reply-To: <56B54CFB.9050904-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Fri, Feb 05, 2016 at 05:31:39PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
>
> Fix kernel-doc warning for missing struct field notation.
>
> ..//include/linux/spi/spi.h:540: warning: No description found for parameter 'max_transfer_size'
The patch description and especially subject here should be something
along the lines of "Document max_transfer_size" - describe what you
think the change is.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-08 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 1:31 [PATCH] spi: fix spi.h kernel-doc warning Randy Dunlap
2016-02-08 16:55 ` Mark Brown [this message]
2016-02-08 16:55 ` Mark Brown
[not found] ` <56B54CFB.9050904-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-02-08 18:01 ` Applied "spi: Document max_transfer_size" to the spi tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-04-18 0:03 [PATCH] spi: fix spi.h kernel-doc warning Randy Dunlap
2012-04-27 17:03 ` Grant Likely
2012-04-27 17:03 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208165556.GJ7265@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.