From: Petko Manolov <petkan@mip-labs.com> To: Mimi Zohar <zohar@linux.vnet.ibm.com> Cc: Dmitry Kasatkin <dmitry.kasatkin@huawei.com>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "Luis R. Rodriguez" <mcgrof@suse.com>, "kexec@lists.infradead.org" <kexec@lists.infradead.org>, "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>, "fsdevel@vger.kernel.org" <fsdevel@vger.kernel.org>, David Howells <dhowells@redhat.com>, David Woodhouse <dwmw2@infradead.org>, Kees Cook <keescook@chromium.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Dmitry Kasatkin <dmitry.kasatkin@gmail.com>, Eric Biederman <ebiederm@xmission.com>, Rusty Russell <rusty@rustcorp.com.au>, Dmitry Kasatkin <d.kasatkin@samsung.com> Subject: Re: [PATCH v3 20/22] ima: load policy using path Date: Tue, 9 Feb 2016 09:47:42 +0200 [thread overview] Message-ID: <20160209074742.GB2912@bender.nucleusys.com> (raw) In-Reply-To: <1454965936.3037.34.camel@linux.vnet.ibm.com> On 16-02-08 16:12:16, Mimi Zohar wrote: > On Mon, 2016-02-08 at 10:45 +0000, Dmitry Kasatkin wrote: > > > > > @@ -286,9 +322,12 @@ static ssize_t ima_write_policy(struct file *file, const char __user *buf, > > > > result = mutex_lock_interruptible(&ima_write_mutex); > > > > if (result < 0) > > > > goto out_free; > > > > - result = ima_parse_add_rule(data); > > > > - mutex_unlock(&ima_write_mutex); > > > > > > > > + if (data[0] == '/') > > > > > > >It seems that if we feed relative path to ima_policy the update will fail... > > > > > > Yes, i think it is always a good idea to pass absolute path. > > > > What if we at least emit a warning so people know what's wrong? > > The next patch "ima: measure and appraise the IMA policy itself" adds > the following. Is a failure message enough? That would be the wrong message. The above code does not handle relative paths so any attempt to load the policy by "./ima_policy_file" or "../../ima_policy_file" will fail. Isn't there a kernel function that checks if given string is a path-name? > + else if (ima_appraise & IMA_APPRAISE_POLICY) { > + pr_err("IMA: signed policy required\n"); > + integrity_audit_msg(AUDIT_INTEGRITY_STATUS, NULL, NULL, > + "policy_update", "signed policy > required", > + 1, 0); > + if (ima_appraise & IMA_APPRAISE_ENFORCE) > + result = -EACCES; > + } else > result = ima_parse_add_rule(data); > > > > > Petko > > > > DK: May be a good idea to print that loading policy by path or not. > > Are we including the pathname? Are you suggesting a log or audit message? I guess log is more appropriate.
WARNING: multiple messages have this Message-ID (diff)
From: Petko Manolov <petkan@mip-labs.com> To: Mimi Zohar <zohar@linux.vnet.ibm.com> Cc: Rusty Russell <rusty@rustcorp.com.au>, Kees Cook <keescook@chromium.org>, "fsdevel@vger.kernel.org" <fsdevel@vger.kernel.org>, Dmitry Kasatkin <dmitry.kasatkin@gmail.com>, "Luis R. Rodriguez" <mcgrof@suse.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, "kexec@lists.infradead.org" <kexec@lists.infradead.org>, Dmitry Kasatkin <dmitry.kasatkin@huawei.com>, David Howells <dhowells@redhat.com>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, Eric Biederman <ebiederm@xmission.com>, Dmitry Kasatkin <d.kasatkin@samsung.com>, David Woodhouse <dwmw2@infradead.org>, "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org> Subject: Re: [PATCH v3 20/22] ima: load policy using path Date: Tue, 9 Feb 2016 09:47:42 +0200 [thread overview] Message-ID: <20160209074742.GB2912@bender.nucleusys.com> (raw) In-Reply-To: <1454965936.3037.34.camel@linux.vnet.ibm.com> On 16-02-08 16:12:16, Mimi Zohar wrote: > On Mon, 2016-02-08 at 10:45 +0000, Dmitry Kasatkin wrote: > > > > > @@ -286,9 +322,12 @@ static ssize_t ima_write_policy(struct file *file, const char __user *buf, > > > > result = mutex_lock_interruptible(&ima_write_mutex); > > > > if (result < 0) > > > > goto out_free; > > > > - result = ima_parse_add_rule(data); > > > > - mutex_unlock(&ima_write_mutex); > > > > > > > > + if (data[0] == '/') > > > > > > >It seems that if we feed relative path to ima_policy the update will fail... > > > > > > Yes, i think it is always a good idea to pass absolute path. > > > > What if we at least emit a warning so people know what's wrong? > > The next patch "ima: measure and appraise the IMA policy itself" adds > the following. Is a failure message enough? That would be the wrong message. The above code does not handle relative paths so any attempt to load the policy by "./ima_policy_file" or "../../ima_policy_file" will fail. Isn't there a kernel function that checks if given string is a path-name? > + else if (ima_appraise & IMA_APPRAISE_POLICY) { > + pr_err("IMA: signed policy required\n"); > + integrity_audit_msg(AUDIT_INTEGRITY_STATUS, NULL, NULL, > + "policy_update", "signed policy > required", > + 1, 0); > + if (ima_appraise & IMA_APPRAISE_ENFORCE) > + result = -EACCES; > + } else > result = ima_parse_add_rule(data); > > > > > Petko > > > > DK: May be a good idea to print that loading policy by path or not. > > Are we including the pathname? Are you suggesting a log or audit message? I guess log is more appropriate. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-02-09 7:48 UTC|newest] Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-03 19:06 [PATCH v3 00/22] vfs: support for a common kernel file loader Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 01/22] ima: separate 'security.ima' reading functionality from collect Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 02/22] ima: refactor ima_policy_show() to display "ima_hooks" rules Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 19:45 ` Petko Manolov 2016-02-07 19:45 ` Petko Manolov 2016-02-10 19:33 ` Dmitry Kasatkin 2016-02-10 19:33 ` Dmitry Kasatkin 2016-02-03 19:06 ` [PATCH v3 03/22] ima: use "ima_hooks" enum as function argument Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 19:46 ` Petko Manolov 2016-02-07 19:46 ` Petko Manolov 2016-02-10 19:35 ` Dmitry Kasatkin 2016-02-10 19:35 ` Dmitry Kasatkin 2016-02-03 19:06 ` [PATCH v3 04/22] firmware: simplify dev_*() print messages for generic helpers Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:26 ` Kees Cook 2016-02-04 17:26 ` Kees Cook 2016-02-03 19:06 ` [PATCH v3 05/22] firmware: move completing fw into a helper Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:27 ` Kees Cook 2016-02-04 17:27 ` Kees Cook 2016-02-03 19:06 ` [PATCH v3 06/22] firmware: fold successful fw read early Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:36 ` Kees Cook 2016-02-04 17:36 ` Kees Cook 2016-02-04 20:26 ` Luis R. Rodriguez 2016-02-04 20:26 ` Luis R. Rodriguez 2016-02-03 19:06 ` [PATCH v3 07/22] vfs: define a generic function to read a file from the kernel Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:41 ` Kees Cook 2016-02-04 17:41 ` Kees Cook 2016-02-03 19:06 ` [PATCH v3 08/22] vfs: define kernel_read_file_id enumeration Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:41 ` Kees Cook 2016-02-04 17:41 ` Kees Cook 2016-02-04 19:45 ` Luis R. Rodriguez 2016-02-04 19:45 ` Luis R. Rodriguez 2016-02-03 19:06 ` [PATCH v3 09/22] ima: provide buffer hash calculation function Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 10/22] ima: calculate the hash of a buffer using aynchronous hash(ahash) Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-10 19:58 ` Dmitry Kasatkin 2016-02-10 19:58 ` Dmitry Kasatkin 2016-02-03 19:06 ` [PATCH v3 11/22] ima: define a new hook to measure and appraise a file already in memory Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-10 20:27 ` Dmitry Kasatkin 2016-02-10 20:27 ` Dmitry Kasatkin 2016-02-03 19:06 ` [PATCH v3 12/22] vfs: define kernel_read_file_from_path Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:46 ` Kees Cook 2016-02-04 17:46 ` Kees Cook 2016-02-04 19:47 ` Luis R. Rodriguez 2016-02-04 19:47 ` Luis R. Rodriguez 2016-02-03 19:06 ` [PATCH v3 13/22] firmware: replace call to fw_read_file_contents() with kernel version Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:56 ` Kees Cook 2016-02-04 17:56 ` Kees Cook 2016-02-04 19:51 ` Luis R. Rodriguez 2016-02-04 19:51 ` Luis R. Rodriguez 2016-02-03 19:06 ` [PATCH v3 14/22] security: define kernel_read_file hook Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:57 ` Kees Cook 2016-02-04 17:57 ` Kees Cook 2016-02-04 19:54 ` Luis R. Rodriguez 2016-02-04 19:54 ` Luis R. Rodriguez 2016-02-11 16:54 ` Casey Schaufler 2016-02-11 16:54 ` Casey Schaufler 2016-02-11 19:35 ` Mimi Zohar 2016-02-11 19:35 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 15/22] vfs: define kernel_copy_file_from_fd() Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 17:58 ` Kees Cook 2016-02-04 17:58 ` Kees Cook 2016-02-04 19:55 ` Luis R. Rodriguez 2016-02-04 19:55 ` Luis R. Rodriguez 2016-02-03 19:06 ` [PATCH v3 16/22] module: replace copy_module_from_fd with kernel version Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 18:04 ` Kees Cook 2016-02-04 18:04 ` Kees Cook 2016-02-04 19:56 ` Luis R. Rodriguez 2016-02-04 19:56 ` Luis R. Rodriguez 2016-02-05 0:19 ` Mimi Zohar 2016-02-05 0:19 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 17/22] ima: remove firmware and module specific cached status info Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 19:56 ` Petko Manolov 2016-02-07 19:56 ` Petko Manolov 2016-02-10 20:18 ` Dmitry Kasatkin 2016-02-10 20:18 ` Dmitry Kasatkin 2016-02-10 23:14 ` Mimi Zohar 2016-02-10 23:14 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 18/22] kexec: replace call to copy_file_from_fd() with kernel version Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-04 18:05 ` Kees Cook 2016-02-04 18:05 ` Kees Cook 2016-02-04 19:57 ` Luis R. Rodriguez 2016-02-04 19:57 ` Luis R. Rodriguez 2016-02-12 12:50 ` Dave Young 2016-02-12 12:50 ` Dave Young 2016-02-03 19:06 ` [PATCH v3 19/22] ima: support for kexec image and initramfs Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 20:10 ` Petko Manolov 2016-02-07 20:10 ` Petko Manolov 2016-02-08 23:34 ` Mimi Zohar 2016-02-08 23:34 ` Mimi Zohar 2016-02-10 21:09 ` Dmitry Kasatkin 2016-02-10 21:09 ` Dmitry Kasatkin 2016-02-10 23:21 ` Mimi Zohar 2016-02-10 23:21 ` Mimi Zohar [not found] ` <CACE9dm8OJ1cgbKszUG-pCiEMVarUFLLWi_jewVV-JEMGAJsA-g@mail.gmail.com> 2016-02-11 2:08 ` Mimi Zohar 2016-02-11 2:08 ` Mimi Zohar 2016-02-11 8:47 ` Dmitry Kasatkin 2016-02-11 8:47 ` Dmitry Kasatkin 2016-02-11 12:16 ` Mimi Zohar 2016-02-11 12:16 ` Mimi Zohar 2016-02-12 12:53 ` Dave Young 2016-02-12 12:53 ` Dave Young 2016-02-12 13:09 ` Mimi Zohar 2016-02-12 13:09 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 20/22] ima: load policy using path Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 19:59 ` Petko Manolov 2016-02-07 19:59 ` Petko Manolov 2016-02-08 9:58 ` Dmitry Kasatkin 2016-02-08 9:58 ` Dmitry Kasatkin 2016-02-08 10:35 ` Petko Manolov 2016-02-08 10:35 ` Petko Manolov 2016-02-08 10:45 ` Dmitry Kasatkin 2016-02-08 10:45 ` Dmitry Kasatkin 2016-02-08 21:12 ` Mimi Zohar 2016-02-08 21:12 ` Mimi Zohar 2016-02-09 7:47 ` Petko Manolov [this message] 2016-02-09 7:47 ` Petko Manolov 2016-02-03 19:06 ` [PATCH v3 21/22] ima: measure and appraise the IMA policy itself Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 20:01 ` Petko Manolov 2016-02-07 20:01 ` Petko Manolov 2016-02-10 20:22 ` Dmitry Kasatkin 2016-02-10 20:22 ` Dmitry Kasatkin 2016-02-10 23:15 ` Mimi Zohar 2016-02-10 23:15 ` Mimi Zohar 2016-02-03 19:06 ` [PATCH v3 22/22] ima: require signed IMA policy Mimi Zohar 2016-02-03 19:06 ` Mimi Zohar 2016-02-07 20:02 ` Petko Manolov 2016-02-07 20:02 ` Petko Manolov 2016-02-10 20:24 ` Dmitry Kasatkin 2016-02-10 20:24 ` Dmitry Kasatkin 2016-02-04 18:15 ` [PATCH v3 00/22] vfs: support for a common kernel file loader Kees Cook 2016-02-04 18:15 ` Kees Cook 2016-02-04 23:54 ` Mimi Zohar 2016-02-04 23:54 ` Mimi Zohar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160209074742.GB2912@bender.nucleusys.com \ --to=petkan@mip-labs.com \ --cc=d.kasatkin@samsung.com \ --cc=dhowells@redhat.com \ --cc=dmitry.kasatkin@gmail.com \ --cc=dmitry.kasatkin@huawei.com \ --cc=dmitry.torokhov@gmail.com \ --cc=dwmw2@infradead.org \ --cc=ebiederm@xmission.com \ --cc=fsdevel@vger.kernel.org \ --cc=keescook@chromium.org \ --cc=kexec@lists.infradead.org \ --cc=linux-modules@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=mcgrof@suse.com \ --cc=rusty@rustcorp.com.au \ --cc=zohar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.