All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
@ 2016-02-09 11:14 ` Dan Carpenter
  0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-02-09 11:14 UTC (permalink / raw)
  To: Alasdair Kergon, Mike Snitzer
  Cc: dm-devel, Shaohua Li, linux-raid, linux-kernel, kernel-janitors

We can just return -ENOMEM if the kzalloc() fails.

Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 6b7e80e..1a5f879 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
 	int err;
 
 	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
+	if (!md->tag_set)
+		return -ENOMEM;
 	md->tag_set->ops = &dm_mq_ops;
 	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
 	md->tag_set->numa_node = NUMA_NO_NODE;

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
@ 2016-02-09 11:14 ` Dan Carpenter
  0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-02-09 11:14 UTC (permalink / raw)
  To: Alasdair Kergon, Mike Snitzer
  Cc: dm-devel, Shaohua Li, linux-raid, linux-kernel, kernel-janitors

We can just return -ENOMEM if the kzalloc() fails.

Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 6b7e80e..1a5f879 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
 	int err;
 
 	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
+	if (!md->tag_set)
+		return -ENOMEM;
 	md->tag_set->ops = &dm_mq_ops;
 	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
 	md->tag_set->numa_node = NUMA_NO_NODE;

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [dm-devel] [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
  2016-02-09 11:14 ` Dan Carpenter
  (?)
@ 2016-02-09 11:35   ` Johannes Thumshirn
  -1 siblings, 0 replies; 7+ messages in thread
From: Johannes Thumshirn @ 2016-02-09 11:35 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Alasdair Kergon, Mike Snitzer, linux-raid, kernel-janitors,
	dm-devel, Shaohua Li, linux-kernel

On Tue, Feb 09, 2016 at 02:14:40PM +0300, Dan Carpenter wrote:
> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 6b7e80e..1a5f879 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
>  	int err;
>  
>  	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
> +	if (!md->tag_set)
> +		return -ENOMEM;
>  	md->tag_set->ops = &dm_mq_ops;
>  	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
>  	md->tag_set->numa_node = NUMA_NO_NODE;
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Good catch,

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [dm-devel] [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
@ 2016-02-09 11:35   ` Johannes Thumshirn
  0 siblings, 0 replies; 7+ messages in thread
From: Johannes Thumshirn @ 2016-02-09 11:35 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Alasdair Kergon, Mike Snitzer, linux-raid, kernel-janitors,
	dm-devel, Shaohua Li, linux-kernel

On Tue, Feb 09, 2016 at 02:14:40PM +0300, Dan Carpenter wrote:
> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 6b7e80e..1a5f879 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
>  	int err;
>  
>  	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
> +	if (!md->tag_set)
> +		return -ENOMEM;
>  	md->tag_set->ops = &dm_mq_ops;
>  	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
>  	md->tag_set->numa_node = NUMA_NO_NODE;
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Good catch,

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [dm-devel] [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
@ 2016-02-09 11:35   ` Johannes Thumshirn
  0 siblings, 0 replies; 7+ messages in thread
From: Johannes Thumshirn @ 2016-02-09 11:35 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Alasdair Kergon, Mike Snitzer, linux-raid, kernel-janitors,
	dm-devel, Shaohua Li, linux-kernel

On Tue, Feb 09, 2016 at 02:14:40PM +0300, Dan Carpenter wrote:
> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 6b7e80e..1a5f879 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
>  	int err;
>  
>  	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
> +	if (!md->tag_set)
> +		return -ENOMEM;
>  	md->tag_set->ops = &dm_mq_ops;
>  	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
>  	md->tag_set->numa_node = NUMA_NO_NODE;
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Good catch,

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
  2016-02-09 11:14 ` Dan Carpenter
@ 2016-02-09 15:08   ` Mike Snitzer
  -1 siblings, 0 replies; 7+ messages in thread
From: Mike Snitzer @ 2016-02-09 15:08 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Alasdair Kergon, dm-devel, linux-kernel, kernel-janitors

On Tue, Feb 09 2016 at  6:14am -0500,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, folded in.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()
@ 2016-02-09 15:08   ` Mike Snitzer
  0 siblings, 0 replies; 7+ messages in thread
From: Mike Snitzer @ 2016-02-09 15:08 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Alasdair Kergon, dm-devel, linux-kernel, kernel-janitors

On Tue, Feb 09 2016 at  6:14am -0500,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, folded in.

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-09 15:08 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 11:14 [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue() Dan Carpenter
2016-02-09 11:14 ` Dan Carpenter
2016-02-09 11:35 ` [dm-devel] " Johannes Thumshirn
2016-02-09 11:35   ` Johannes Thumshirn
2016-02-09 11:35   ` Johannes Thumshirn
2016-02-09 15:08 ` Mike Snitzer
2016-02-09 15:08   ` Mike Snitzer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.