All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	mpe@ellerman.id.au,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm: Some arch may want to use HPAGE_PMD related values as variables
Date: Wed, 10 Feb 2016 01:14:57 +0200	[thread overview]
Message-ID: <20160209231457.GB22327@node.shutemov.name> (raw)
In-Reply-To: <20160209132608.814f08a0c3670b4f9d807441@linux-foundation.org>

On Tue, Feb 09, 2016 at 01:26:08PM -0800, Andrew Morton wrote:
> On Tue,  9 Feb 2016 21:41:44 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > @@ -660,6 +660,18 @@ static int __init hugepage_init(void)
> >  		return -EINVAL;
> >  	}
> >  
> > +	khugepaged_pages_to_scan = HPAGE_PMD_NR * 8;
> > +	khugepaged_max_ptes_none = HPAGE_PMD_NR - 1;
> 
> I don't understand this change.  We change the initialization from
> at-compile-time to at-run-time, but nothing useful appears to have been
> done.

It's preparation patch. HPAGE_PMD_NR is going to be based on variable on
Power soon. Compile-time is not an option.

-- 
 Kirill A. Shutemov

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	mpe@ellerman.id.au,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm: Some arch may want to use HPAGE_PMD related values as variables
Date: Wed, 10 Feb 2016 01:14:57 +0200	[thread overview]
Message-ID: <20160209231457.GB22327@node.shutemov.name> (raw)
In-Reply-To: <20160209132608.814f08a0c3670b4f9d807441@linux-foundation.org>

On Tue, Feb 09, 2016 at 01:26:08PM -0800, Andrew Morton wrote:
> On Tue,  9 Feb 2016 21:41:44 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > @@ -660,6 +660,18 @@ static int __init hugepage_init(void)
> >  		return -EINVAL;
> >  	}
> >  
> > +	khugepaged_pages_to_scan = HPAGE_PMD_NR * 8;
> > +	khugepaged_max_ptes_none = HPAGE_PMD_NR - 1;
> 
> I don't understand this change.  We change the initialization from
> at-compile-time to at-run-time, but nothing useful appears to have been
> done.

It's preparation patch. HPAGE_PMD_NR is going to be based on variable on
Power soon. Compile-time is not an option.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-02-09 23:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 16:11 [PATCH V2] mm: Some arch may want to use HPAGE_PMD related values as variables Aneesh Kumar K.V
2016-02-09 16:11 ` Aneesh Kumar K.V
2016-02-09 19:42 ` Kirill A. Shutemov
2016-02-09 19:42   ` Kirill A. Shutemov
2016-02-10  2:34   ` Aneesh Kumar K.V
2016-02-10  2:34     ` Aneesh Kumar K.V
2016-02-09 21:26 ` Andrew Morton
2016-02-09 21:26   ` Andrew Morton
2016-02-09 23:14   ` Kirill A. Shutemov [this message]
2016-02-09 23:14     ` Kirill A. Shutemov
2016-02-10  2:39   ` Aneesh Kumar K.V
2016-02-10  2:39     ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209231457.GB22327@node.shutemov.name \
    --to=kirill@shutemov.name \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.