All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Capture revision id in error state
@ 2016-01-26 17:52 Arun Siluvery
  2016-01-27 11:33 ` Ville Syrjälä
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Arun Siluvery @ 2016-01-26 17:52 UTC (permalink / raw)
  To: intel-gfx

Revision id along with device id is useful in better identification of the HW
and its limitations so include this detail in error state.

Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 7eeb244..f3ddc3b 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);
 	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
 	if (HAS_CSR(dev)) {
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Capture revision id in error state
  2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
@ 2016-01-27 11:33 ` Ville Syrjälä
  2016-01-27 11:44   ` Arun Siluvery
  2016-01-27 17:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2016-01-27 11:33 UTC (permalink / raw)
  To: Arun Siluvery; +Cc: intel-gfx

On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote:
> Revision id along with device id is useful in better identification of the HW
> and its limitations so include this detail in error state.
> 
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 7eeb244..f3ddc3b 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
>  	err_printf(m, "Reset count: %u\n", error->reset_count);
>  	err_printf(m, "Suspend count: %u\n", error->suspend_count);
>  	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
> +	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);

"PCI revision" maybe?

>  	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
>  
>  	if (HAS_CSR(dev)) {
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Capture revision id in error state
  2016-01-27 11:33 ` Ville Syrjälä
@ 2016-01-27 11:44   ` Arun Siluvery
  2016-01-27 17:46     ` Chris Wilson
  0 siblings, 1 reply; 11+ messages in thread
From: Arun Siluvery @ 2016-01-27 11:44 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On 27/01/2016 11:33, Ville Syrjälä wrote:
> On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote:
>> Revision id along with device id is useful in better identification of the HW
>> and its limitations so include this detail in error state.
>>
>> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 7eeb244..f3ddc3b 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
>>   	err_printf(m, "Reset count: %u\n", error->reset_count);
>>   	err_printf(m, "Suspend count: %u\n", error->suspend_count);
>>   	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
>> +	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);
>
> "PCI revision" maybe?
sure, makes it more clear.

regards
Arun

>
>>   	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
>>
>>   	if (HAS_CSR(dev)) {
>> --
>> 1.9.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Capture revision id in error state
  2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
  2016-01-27 11:33 ` Ville Syrjälä
@ 2016-01-27 17:38 ` Patchwork
  2016-01-28 14:33 ` Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2016-01-27 17:38 UTC (permalink / raw)
  To: arun.siluvery; +Cc: intel-gfx

== Summary ==

Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly: 2016y-01m-27d-16h-33m-06s UTC integration manifest

Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-b:
                dmesg-warn -> PASS       (ilk-hp8440p)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> FAIL       (byt-nuc)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> FAIL       (byt-nuc)
        Subgroup suspend-read-crc-pipe-c:
                skip       -> FAIL       (byt-nuc)

bdw-nuci7        total:141  pass:132  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:144  pass:138  dwarn:0   dfail:0   fail:0   skip:6  
bsw-nuc-2        total:144  pass:120  dwarn:0   dfail:0   fail:0   skip:24 
byt-nuc          total:144  pass:127  dwarn:0   dfail:0   fail:3   skip:14 
hsw-brixbox      total:144  pass:137  dwarn:0   dfail:0   fail:0   skip:7  
hsw-gt2          total:144  pass:140  dwarn:0   dfail:0   fail:0   skip:4  
ilk-hp8440p      total:144  pass:105  dwarn:0   dfail:0   fail:1   skip:38 
ivb-t430s        total:144  pass:138  dwarn:0   dfail:0   fail:0   skip:6  
skl-i5k-2        total:144  pass:135  dwarn:1   dfail:0   fail:0   skip:8  
snb-dellxps      total:144  pass:130  dwarn:0   dfail:0   fail:0   skip:14 
snb-x220t        total:144  pass:130  dwarn:0   dfail:0   fail:1   skip:13 

Results at /archive/results/CI_IGT_test/Patchwork_1268/

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Capture revision id in error state
  2016-01-27 11:44   ` Arun Siluvery
@ 2016-01-27 17:46     ` Chris Wilson
  0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2016-01-27 17:46 UTC (permalink / raw)
  To: Arun Siluvery; +Cc: intel-gfx

On Wed, Jan 27, 2016 at 11:44:07AM +0000, Arun Siluvery wrote:
> On 27/01/2016 11:33, Ville Syrjälä wrote:
> >On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote:
> >>Revision id along with device id is useful in better identification of the HW
> >>and its limitations so include this detail in error state.
> >>
> >>Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> >>---
> >>  drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>index 7eeb244..f3ddc3b 100644
> >>--- a/drivers/gpu/drm/i915/i915_gpu_error.c
> >>+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
> >>  	err_printf(m, "Reset count: %u\n", error->reset_count);
> >>  	err_printf(m, "Suspend count: %u\n", error->suspend_count);
> >>  	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
> >>+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);
> >
> >"PCI revision" maybe?
> sure, makes it more clear.

We also use the subvendor ids, so if we might as well dump the full PCI
ID whilst we are making an adjustment here.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Capture revision id in error state
  2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
  2016-01-27 11:33 ` Ville Syrjälä
  2016-01-27 17:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-01-28 14:33 ` Patchwork
  2016-01-28 17:18 ` [PATCH] drm/i915: Capture PCI revision and subsytem details " Arun Siluvery
  2016-01-29 10:27 ` ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2) Patchwork
  4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2016-01-28 14:33 UTC (permalink / raw)
  To: arun.siluvery; +Cc: intel-gfx

== Summary ==

Series 2850v1 drm/i915: Capture revision id in error state
http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/1/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                pass       -> DMESG-WARN (bsw-nuc-2)
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE

bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:159  pass:153  dwarn:0   dfail:0   fail:0   skip:6  
bsw-nuc-2        total:159  pass:134  dwarn:1   dfail:0   fail:0   skip:24 
byt-nuc          total:159  pass:142  dwarn:0   dfail:0   fail:0   skip:17 
hsw-brixbox      total:159  pass:152  dwarn:0   dfail:0   fail:0   skip:7  
hsw-gt2          total:159  pass:155  dwarn:0   dfail:0   fail:0   skip:4  
ilk-hp8440p      total:159  pass:113  dwarn:1   dfail:0   fail:1   skip:44 
ivb-t430s        total:159  pass:151  dwarn:0   dfail:0   fail:0   skip:8  
snb-dellxps      total:159  pass:141  dwarn:0   dfail:0   fail:0   skip:18 
snb-x220t        total:159  pass:141  dwarn:0   dfail:0   fail:1   skip:17 

HANGED skl-i5k-2 in igt@gem_sync@basic-blt

Results at /archive/results/CI_IGT_test/Patchwork_1297/

b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest
0c76833e1e379768b1151bdc7f04340695174d44 drm/i915: Capture revision id in error state

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] drm/i915: Capture PCI revision and subsytem details in error state
  2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
                   ` (2 preceding siblings ...)
  2016-01-28 14:33 ` Patchwork
@ 2016-01-28 17:18 ` Arun Siluvery
  2016-02-10  7:47   ` Daniel Vetter
  2016-01-29 10:27 ` ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2) Patchwork
  4 siblings, 1 reply; 11+ messages in thread
From: Arun Siluvery @ 2016-01-28 17:18 UTC (permalink / raw)
  To: intel-gfx

Revision id along with device id is useful in better identification of the HW
and its limitations so include this detail in error state.

v2: make it clear that it is PCI revision and We might as well dump PCI
subsystem details while we update this (Ville, Chris).

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 7eeb244..978c026 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -365,6 +365,10 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "PCI Revision: 0x%02x\n", dev->pdev->revision);
+	err_printf(m, "PCI Subsystem: %04x:%04x\n",
+		   dev->pdev->subsystem_vendor,
+		   dev->pdev->subsystem_device);
 	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
 	if (HAS_CSR(dev)) {
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)
  2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
                   ` (3 preceding siblings ...)
  2016-01-28 17:18 ` [PATCH] drm/i915: Capture PCI revision and subsytem details " Arun Siluvery
@ 2016-01-29 10:27 ` Patchwork
  2016-01-29 11:08   ` Arun Siluvery
  4 siblings, 1 reply; 11+ messages in thread
From: Patchwork @ 2016-01-29 10:27 UTC (permalink / raw)
  To: arun.siluvery; +Cc: intel-gfx

== Summary ==

Series 2850v2 drm/i915: Capture revision id in error state
http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (ilk-hp8440p)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-1:
                pass       -> DMESG-WARN (hsw-gt2)
        Subgroup nonblocking-crc-pipe-a:
                skip       -> PASS       (byt-nuc)
        Subgroup nonblocking-crc-pipe-b:
                pass       -> DMESG-WARN (ilk-hp8440p)

bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12 
bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30 
byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23 
hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13 
hsw-gt2          total:159  pass:148  dwarn:1   dfail:0   fail:0   skip:10 
ilk-hp8440p      total:159  pass:108  dwarn:2   dfail:0   fail:0   skip:49 
ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14 
skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14 
snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22 
snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1313/

5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest
76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)
  2016-01-29 10:27 ` ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2) Patchwork
@ 2016-01-29 11:08   ` Arun Siluvery
  2016-02-10  7:48     ` Daniel Vetter
  0 siblings, 1 reply; 11+ messages in thread
From: Arun Siluvery @ 2016-01-29 11:08 UTC (permalink / raw)
  To: intel-gfx

On 29/01/2016 10:27, Patchwork wrote:
> == Summary ==
>
> Series 2850v2 drm/i915: Capture revision id in error state
> http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/
>
> Test kms_flip:
>          Subgroup basic-flip-vs-dpms:
>                  pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
[BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on 
ilk-hp8440p
known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787

> Test kms_force_connector_basic:
>          Subgroup prune-stale-modes:
>                  pass       -> SKIP       (ilk-hp8440p)
It is not showing up in patchwork results page.

> Test kms_pipe_crc_basic:
>          Subgroup bad-nb-words-1:
>                  pass       -> DMESG-WARN (hsw-gt2)
known issue, it is not on P1 list though,
https://bugs.freedesktop.org/show_bug.cgi?id=93226


>          Subgroup nonblocking-crc-pipe-a:
>                  skip       -> PASS       (byt-nuc)
It is not showing up in patchwork results page, checked detailed results 
page and it was skipped once before.

>          Subgroup nonblocking-crc-pipe-b:
>                  pass       -> DMESG-WARN (ilk-hp8440p)
[BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on 
ilk-hp8440p
known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787

regards
Arun

>
> bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9
> bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12
> bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30
> byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23
> hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13
> hsw-gt2          total:159  pass:148  dwarn:1   dfail:0   fail:0   skip:10
> ilk-hp8440p      total:159  pass:108  dwarn:2   dfail:0   fail:0   skip:49
> ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14
> skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14
> snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22
> snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21
>
> Results at /archive/results/CI_IGT_test/Patchwork_1313/
>
> 5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest
> 76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state
>
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Capture PCI revision and subsytem details in error state
  2016-01-28 17:18 ` [PATCH] drm/i915: Capture PCI revision and subsytem details " Arun Siluvery
@ 2016-02-10  7:47   ` Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2016-02-10  7:47 UTC (permalink / raw)
  To: Arun Siluvery; +Cc: intel-gfx

On Thu, Jan 28, 2016 at 05:18:41PM +0000, Arun Siluvery wrote:
> Revision id along with device id is useful in better identification of the HW
> and its limitations so include this detail in error state.
> 
> v2: make it clear that it is PCI revision and We might as well dump PCI
> subsystem details while we update this (Ville, Chris).
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 7eeb244..978c026 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -365,6 +365,10 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
>  	err_printf(m, "Reset count: %u\n", error->reset_count);
>  	err_printf(m, "Suspend count: %u\n", error->suspend_count);
>  	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
> +	err_printf(m, "PCI Revision: 0x%02x\n", dev->pdev->revision);
> +	err_printf(m, "PCI Subsystem: %04x:%04x\n",
> +		   dev->pdev->subsystem_vendor,
> +		   dev->pdev->subsystem_device);
>  	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
>  
>  	if (HAS_CSR(dev)) {
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)
  2016-01-29 11:08   ` Arun Siluvery
@ 2016-02-10  7:48     ` Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2016-02-10  7:48 UTC (permalink / raw)
  To: Arun Siluvery; +Cc: intel-gfx

On Fri, Jan 29, 2016 at 11:08:53AM +0000, Arun Siluvery wrote:
> On 29/01/2016 10:27, Patchwork wrote:
> >== Summary ==
> >
> >Series 2850v2 drm/i915: Capture revision id in error state
> >http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/
> >
> >Test kms_flip:
> >         Subgroup basic-flip-vs-dpms:
> >                 pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
> [BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on
> ilk-hp8440p
> known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787
> 
> >Test kms_force_connector_basic:
> >         Subgroup prune-stale-modes:
> >                 pass       -> SKIP       (ilk-hp8440p)
> It is not showing up in patchwork results page.
> 
> >Test kms_pipe_crc_basic:
> >         Subgroup bad-nb-words-1:
> >                 pass       -> DMESG-WARN (hsw-gt2)
> known issue, it is not on P1 list though,
> https://bugs.freedesktop.org/show_bug.cgi?id=93226
> 
> 
> >         Subgroup nonblocking-crc-pipe-a:
> >                 skip       -> PASS       (byt-nuc)
> It is not showing up in patchwork results page, checked detailed results
> page and it was skipped once before.

Yeah, something is broken with the edid injection and seems racy,
resulting in corruption and who knows what else. Not sure what's going on,
but the overall issue is tracked as P1 in

https://bugs.freedesktop.org/show_bug.cgi?id=93769

> 
> >         Subgroup nonblocking-crc-pipe-b:
> >                 pass       -> DMESG-WARN (ilk-hp8440p)
> [BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on
> ilk-hp8440p
> known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787
> 
> regards
> Arun
> 
> >
> >bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9
> >bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12
> >bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30
> >byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23
> >hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13
> >hsw-gt2          total:159  pass:148  dwarn:1   dfail:0   fail:0   skip:10
> >ilk-hp8440p      total:159  pass:108  dwarn:2   dfail:0   fail:0   skip:49
> >ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14
> >skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14
> >snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22
> >snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21
> >
> >Results at /archive/results/CI_IGT_test/Patchwork_1313/
> >
> >5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest
> >76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state
> >
> >
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-02-10  7:48 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
2016-01-27 11:33 ` Ville Syrjälä
2016-01-27 11:44   ` Arun Siluvery
2016-01-27 17:46     ` Chris Wilson
2016-01-27 17:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-01-28 14:33 ` Patchwork
2016-01-28 17:18 ` [PATCH] drm/i915: Capture PCI revision and subsytem details " Arun Siluvery
2016-02-10  7:47   ` Daniel Vetter
2016-01-29 10:27 ` ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2) Patchwork
2016-01-29 11:08   ` Arun Siluvery
2016-02-10  7:48     ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.