From: Stefan Hajnoczi <stefanha@gmail.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, famz@redhat.com, den@virtuozzo.com,
armbru@redhat.com, qemu-devel@nongnu.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges
Date: Wed, 10 Feb 2016 10:08:25 +0000 [thread overview]
Message-ID: <20160210100825.GA7317@stefanha-x1.localdomain> (raw)
In-Reply-To: <1454151394-52320-3-git-send-email-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Add qmp command to query dirty bitmap contents. This is needed for
> external backup.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/dirty-bitmap.c | 55 +++++++++++++++++++++++++++++++++++++++
> blockdev.c | 62 ++++++++++++++++++++++++++++++++++++++++++++
> include/block/dirty-bitmap.h | 7 +++++
> qapi/block-core.json | 54 ++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 33 +++++++++++++++++++++++
> 5 files changed, 211 insertions(+)
This API produces large replies and/or requires many calls to fetch all
bitmap data. The worst case is a 101010... bitmap.
I consider the dirty bitmap to be data (vs control) and not something
that should be sent over a control channel like the QMP monitor.
How about writing the dirty bitmap to a file? The new bitmap file
format that Fam is working on could be used. That way the dirty bitmap
can be saved asynchronously without hogging the QMP monitor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-10 10:08 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 10:56 [Qemu-devel] [PATCH v2 0/6] external backup api Vladimir Sementsov-Ogievskiy
2016-01-30 10:56 ` [Qemu-devel] [PATCH 1/6] block dirty bitmap: add next_zero function Vladimir Sementsov-Ogievskiy
2016-01-30 10:56 ` [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges Vladimir Sementsov-Ogievskiy
2016-02-10 10:08 ` Stefan Hajnoczi [this message]
2016-02-10 13:57 ` Denis V. Lunev
2016-02-10 15:26 ` John Snow
2016-02-10 15:36 ` Denis V. Lunev
2016-02-10 15:37 ` John Snow
2016-02-10 15:40 ` Denis V. Lunev
2016-02-14 5:05 ` Fam Zheng
2016-01-30 10:56 ` [Qemu-devel] [PATCH 3/6] iotests: test query-block-dirty-bitmap-ranges Vladimir Sementsov-Ogievskiy
2016-01-30 10:56 ` [Qemu-devel] [PATCH 4/6] qapi: add qmp commands for some dirty bitmap functions Vladimir Sementsov-Ogievskiy
2016-01-30 10:56 ` [Qemu-devel] [PATCH 5/6] qapi: make block-dirty-bitmap-create-successor transaction-able Vladimir Sementsov-Ogievskiy
2016-01-30 10:56 ` [Qemu-devel] [PATCH 6/6] iotests: test external backup api Vladimir Sementsov-Ogievskiy
2016-02-03 8:14 ` [Qemu-devel] [PATCH v2 0/6] " Fam Zheng
2016-02-03 10:57 ` Vladimir Sementsov-Ogievskiy
2016-02-03 11:02 ` Fam Zheng
2016-02-03 11:24 ` Vladimir Sementsov-Ogievskiy
2016-02-05 8:28 ` Denis V. Lunev
2016-02-05 8:44 ` Fam Zheng
2016-02-09 14:21 ` Stefan Hajnoczi
2016-02-09 14:37 ` Denis V. Lunev
2016-02-09 16:49 ` John Snow
2016-02-09 16:58 ` Denis V. Lunev
2016-02-09 18:12 ` John Snow
2016-02-09 19:25 ` Denis V. Lunev
2016-02-10 8:04 ` Denis V. Lunev
2016-02-09 14:28 ` Stefan Hajnoczi
2016-02-09 14:41 ` Denis V. Lunev
2016-02-10 10:10 ` Stefan Hajnoczi
2016-02-16 17:09 ` Stefan Hajnoczi
2016-02-16 17:17 ` Vladimir Sementsov-Ogievskiy
2016-02-16 17:20 ` Denis V. Lunev
2016-02-18 16:39 ` Stefan Hajnoczi
2016-02-18 17:07 ` Markus Armbruster
2016-02-17 17:47 ` Vladimir Sementsov-Ogievskiy
2016-02-18 0:59 ` Fam Zheng
2016-02-18 12:11 ` Daniel P. Berrange
2016-02-18 16:41 ` Stefan Hajnoczi
2016-02-19 2:08 ` Fam Zheng
2016-02-19 8:51 ` Markus Armbruster
2016-02-24 23:34 ` John Snow
2016-02-26 19:55 ` Paolo Bonzini
2016-02-26 20:03 ` Paolo Bonzini
2016-02-26 20:29 ` Denis V. Lunev
2016-02-26 21:37 ` John Snow
2016-02-26 20:40 ` Denis V. Lunev
2016-02-27 4:26 ` Fam Zheng
2016-02-29 8:14 ` Markus Armbruster
2016-02-29 8:54 ` Paolo Bonzini
2016-02-29 9:42 ` Paolo Bonzini
2016-02-29 10:05 ` Fam Zheng
2016-03-10 17:37 ` Stefan Hajnoczi
2016-03-10 17:40 ` Paolo Bonzini
2016-03-14 16:27 ` Denis V. Lunev
2016-02-29 10:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210100825.GA7317@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.