[Buildroot] [PATCH 1/1] package/vpnc: fix musl build

[Buildroot] [PATCH 1/1] package/vpnc: fix musl build

[Bernd Kuhls]

The autobuilders did not catch the error yet because they failed
earlier with other packages, but I am continuing the build based
on the defconfig from:
http://autobuild.buildroot.net/results/6cc/6cc0f8c067e07deea688b9b97284601a596b898c/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/vpnc/0004-musl.patch | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 package/vpnc/0004-musl.patch

diff --git a/package/vpnc/0004-musl.patch b/package/vpnc/0004-musl.patch
new file mode 100644
index 0000000..db254b6
--- /dev/null
+++ b/package/vpnc/0004-musl.patch
@@ -0,0 +1,39 @@
+Fix musl build
+
+Downloaded from
+http://git.alpinelinux.org/cgit/aports/tree/testing/vpnc/working.patch
+
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+
+diff --git a/sysdep.c b/sysdep.c
+index ff07753..43fdb74 100644
+--- a/sysdep.c
++++ b/sysdep.c
+@@ -59,7 +59,7 @@
+ #if defined(__DragonFly__)
+ #include <net/tun/if_tun.h>
+ #elif defined(__linux__)
+-#include <linux/if_tun.h>
++/*#include <linux/if_tun.h>*/
+ #elif defined(__APPLE__)
+ /* no header for tun */
+ #elif defined(__CYGWIN__)
+diff --git a/sysdep.h b/sysdep.h
+index a5eafd6..af34e94 100644
+--- a/sysdep.h
++++ b/sysdep.h
+@@ -38,11 +38,13 @@ int tun_get_hwaddr(int fd, char *dev, uint8_t *hwaddr);
+ 
+ /***************************************************************************/
+ #if defined(__linux__) || defined(__GLIBC__)
++#ifdef __GLIBC__
+ #include <error.h>
++#define HAVE_ERROR     1
++#endif
+ 
+ #define HAVE_VASPRINTF 1
+ #define HAVE_ASPRINTF  1
+-#define HAVE_ERROR     1
+ #define HAVE_GETLINE   1
+ #define HAVE_UNSETENV  1
+ #define HAVE_SETENV    1
-- 
2.7.0.rc3

[Buildroot] [PATCH 1/1] package/vpnc: fix musl build

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 24 Jan 2016 14:00:56 +0100, Bernd Kuhls wrote:
> The autobuilders did not catch the error yet because they failed
> earlier with other packages, but I am continuing the build based
> on the defconfig from:
> http://autobuild.buildroot.net/results/6cc/6cc0f8c067e07deea688b9b97284601a596b898c/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Once again, those patches really didn't had a proper commit log, so I
don't want to merge something like this. Yes the other existing patches
for vpnc are crappy, but it's not a reason to add more of them.

So instead, I've sent a series which updates the vpnc package,
reformats the patch with Git, splits them properly, adds proper commit
logs, and I submitted a pull request upstream.

See:

  http://lists.busybox.net/pipermail/buildroot/2016-February/152495.html

Could you review all the pending musl fix patches from you that are in
patchwork, and try to rework the ones where the musl patches don't
have a proper commit log. Hint: if the commit log is just "musl fix",
then it's wrong. If the commit makes it work for musl, but is otherwise
non-upstreamable, it's wrong.

It would really help if you could clean up some of those patches. We do
want to fix musl related issues, but not at the expense of having
unclean patches added in Buildroot.

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com