All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] scsi: sim710: fix build warning
@ 2016-02-11  4:59 Sudip Mukherjee
  2016-02-11  8:46 ` Johannes Thumshirn
  2016-02-11 14:36 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-02-11  4:59 UTC (permalink / raw)
  To: James E.J. Bottomley, Martin K. Petersen
  Cc: linux-kernel, linux-scsi, akpm, Sudip Mukherjee

We are getting build warning about:
 "Section mismatch in reference from the variable sim710_eisa_driver to
 the function .init.text:sim710_eisa_probe()
 The variable sim710_eisa_driver references the function __init
 sim710_eisa_probe()"

sim710_eisa_probe() was having __init but that was being referenced from
sim710_eisa_driver.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

patch first sent on 4th Sept.2015. There is no review or ACK yet.
warning is still there with next-20160209,
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/107948115

 drivers/scsi/sim710.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/sim710.c b/drivers/scsi/sim710.c
index 3b3b56f..82ed998 100644
--- a/drivers/scsi/sim710.c
+++ b/drivers/scsi/sim710.c
@@ -176,8 +176,7 @@ static struct eisa_device_id sim710_eisa_ids[] = {
 };
 MODULE_DEVICE_TABLE(eisa, sim710_eisa_ids);
 
-static __init int
-sim710_eisa_probe(struct device *dev)
+static int sim710_eisa_probe(struct device *dev)
 {
 	struct eisa_device *edev = to_eisa_device(dev);
 	unsigned long io_addr = edev->base_addr;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] scsi: sim710: fix build warning
  2016-02-11  4:59 [PATCH RESEND] scsi: sim710: fix build warning Sudip Mukherjee
@ 2016-02-11  8:46 ` Johannes Thumshirn
  2016-02-11 14:36 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2016-02-11  8:46 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: James E.J. Bottomley, Martin K. Petersen, linux-kernel, linux-scsi, akpm

On Thu, Feb 11, 2016 at 10:29:03AM +0530, Sudip Mukherjee wrote:
> We are getting build warning about:
>  "Section mismatch in reference from the variable sim710_eisa_driver to
>  the function .init.text:sim710_eisa_probe()
>  The variable sim710_eisa_driver references the function __init
>  sim710_eisa_probe()"
> 
> sim710_eisa_probe() was having __init but that was being referenced from
> sim710_eisa_driver.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] scsi: sim710: fix build warning
  2016-02-11  4:59 [PATCH RESEND] scsi: sim710: fix build warning Sudip Mukherjee
  2016-02-11  8:46 ` Johannes Thumshirn
@ 2016-02-11 14:36 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-02-11 14:36 UTC (permalink / raw)
  To: Sudip Mukherjee; +Cc: linux-kernel, linux-scsi, akpm

>>>>> "Sudip" == Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

Sudip> We are getting build warning about: "Section mismatch in
Sudip> reference from the variable sim710_eisa_driver to the function
Sudip> .init.text:sim710_eisa_probe() The variable sim710_eisa_driver
Sudip> references the function __init sim710_eisa_probe()"

Sudip> sim710_eisa_probe() was having __init but that was being
Sudip> referenced from sim710_eisa_driver.

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-11 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-11  4:59 [PATCH RESEND] scsi: sim710: fix build warning Sudip Mukherjee
2016-02-11  8:46 ` Johannes Thumshirn
2016-02-11 14:36 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.