All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
	"Rafael J . Wysocki"
	<rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Peter Hurley
	<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>,
	Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Subject: Re: [PATCH 3/7] spi: omap2-mcspi: Fix PM regression with deferred probe for pm_runtime_reinit
Date: Thu, 11 Feb 2016 09:36:20 -0800	[thread overview]
Message-ID: <20160211173620.GU19432@atomide.com> (raw)
In-Reply-To: <20160211155255.GA1953-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

* Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [160211 07:54]:
> On Thu, Feb 11, 2016 at 07:08:06AM -0800, Tony Lindgren wrote:
> > * Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [160211 03:52]:
> 
> > > Why, I'm not seeing any dependencies here?  I'd also expect to be seeing
> > > an awful lot more changes like this, this shouldn't be an OMAP thing -
> > > do we need to fix the core API and then roll out the transition in a
> > > different way?
> 
> > Please feel free to pick up this one if you have other fixes
> > lined up, nothing stopping that.
> 
> I'll take it myself unless there is a strong reason to merge it as part
> of another series.

OK thanks!

> > There will be likely more fixes like this to make drivers follow
> > the PM runtime API documentation. These were just the initial
> > ones that were obvious.
> 
> This does sound like there's been a change in the interface compared to
> what users are actually doing - is this an actual problem or is it just
> a divergence from docs?

It's an actual problem at least on omaps as the omap_device code
is very picky about the hardware state.

Depending how the PM runtime is implemented, it may be a problem
for some other cases too.

For non-omap cases, my guess is that it's mostly a divergence from
the docs and non-critical.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] spi: omap2-mcspi: Fix PM regression with deferred probe for pm_runtime_reinit
Date: Thu, 11 Feb 2016 09:36:20 -0800	[thread overview]
Message-ID: <20160211173620.GU19432@atomide.com> (raw)
In-Reply-To: <20160211155255.GA1953@sirena.org.uk>

* Mark Brown <broonie@kernel.org> [160211 07:54]:
> On Thu, Feb 11, 2016 at 07:08:06AM -0800, Tony Lindgren wrote:
> > * Mark Brown <broonie@kernel.org> [160211 03:52]:
> 
> > > Why, I'm not seeing any dependencies here?  I'd also expect to be seeing
> > > an awful lot more changes like this, this shouldn't be an OMAP thing -
> > > do we need to fix the core API and then roll out the transition in a
> > > different way?
> 
> > Please feel free to pick up this one if you have other fixes
> > lined up, nothing stopping that.
> 
> I'll take it myself unless there is a strong reason to merge it as part
> of another series.

OK thanks!

> > There will be likely more fixes like this to make drivers follow
> > the PM runtime API documentation. These were just the initial
> > ones that were obvious.
> 
> This does sound like there's been a change in the interface compared to
> what users are actually doing - is this an actual problem or is it just
> a divergence from docs?

It's an actual problem at least on omaps as the omap_device code
is very picky about the hardware state.

Depending how the PM runtime is implemented, it may be a problem
for some other cases too.

For non-omap cases, my guess is that it's mostly a divergence from
the docs and non-critical.

Regards,

Tony

  parent reply	other threads:[~2016-02-11 17:36 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 23:02 [PATCH 0/7] PM runtime regression fixes for omaps Tony Lindgren
2016-02-10 23:02 ` Tony Lindgren
2016-02-10 23:02 ` [PATCH 1/7] mmc: omap_hsmmc: Fix PM regression with deferred probe for pm_runtime_reinit Tony Lindgren
2016-02-10 23:02   ` Tony Lindgren
2016-02-11 10:18   ` Ulf Hansson
2016-02-11 10:18     ` Ulf Hansson
2016-02-11 15:02     ` Tony Lindgren
2016-02-11 15:02       ` Tony Lindgren
     [not found]       ` <20160211150240.GR19432-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-02-11 15:13         ` Ulf Hansson
2016-02-11 15:13           ` Ulf Hansson
2016-02-11 17:26           ` Tony Lindgren
2016-02-11 17:26             ` Tony Lindgren
2016-02-12 12:59             ` Ulf Hansson
2016-02-12 12:59               ` Ulf Hansson
2016-02-22 17:54               ` Tony Lindgren
2016-02-22 17:54                 ` Tony Lindgren
2016-02-10 23:02 ` [PATCH 2/7] i2c: omap: " Tony Lindgren
2016-02-10 23:02   ` Tony Lindgren
     [not found]   ` <1455145370-20301-3-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-02-11 17:34     ` Wolfram Sang
2016-02-11 17:34       ` Wolfram Sang
2016-02-11 17:56       ` Tony Lindgren
2016-02-11 17:56         ` Tony Lindgren
2016-02-12 12:50   ` Ulf Hansson
2016-02-12 12:50     ` Ulf Hansson
2016-02-12 18:43   ` Wolfram Sang
2016-02-12 18:43     ` Wolfram Sang
2016-02-10 23:02 ` [PATCH 3/7] spi: omap2-mcspi: " Tony Lindgren
2016-02-10 23:02   ` Tony Lindgren
2016-02-11 11:51   ` Mark Brown
2016-02-11 11:51     ` Mark Brown
     [not found]     ` <20160211115128.GF13270-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-11 15:08       ` Tony Lindgren
2016-02-11 15:08         ` Tony Lindgren
2016-02-11 15:52         ` Mark Brown
2016-02-11 15:52           ` Mark Brown
     [not found]           ` <20160211155255.GA1953-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-11 17:36             ` Tony Lindgren [this message]
2016-02-11 17:36               ` Tony Lindgren
2016-02-11 18:36               ` Mark Brown
2016-02-11 18:36                 ` Mark Brown
2016-02-11 18:52                 ` Tony Lindgren
2016-02-11 18:52                   ` Tony Lindgren
2016-02-12 12:51   ` Ulf Hansson
2016-02-12 12:51     ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 4/7] serial: 8250_omap: " Tony Lindgren
2016-02-10 23:02   ` Tony Lindgren
2016-02-12  3:17   ` Greg Kroah-Hartman
2016-02-12  3:17     ` Greg Kroah-Hartman
2016-02-12 12:52   ` Ulf Hansson
2016-02-12 12:52     ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 5/7] serial: omap: " Tony Lindgren
2016-02-10 23:02   ` Tony Lindgren
2016-02-12 12:52   ` Ulf Hansson
2016-02-12 12:52     ` Ulf Hansson
     [not found] ` <1455145370-20301-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-02-10 23:02   ` [PATCH 6/7] ARM: OMAP2+: Improve omap_device error for driver writers Tony Lindgren
2016-02-10 23:02     ` Tony Lindgren
2016-02-12  1:13     ` Kevin Hilman
2016-02-12  1:13       ` Kevin Hilman
     [not found]     ` <1455145370-20301-7-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-02-12 12:53       ` Ulf Hansson
2016-02-12 12:53         ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 7/7] ARM: OMAP2+: Fix omap_device for module reload on PM runtime forbid Tony Lindgren
2016-02-10 23:02   ` Tony Lindgren
2016-02-12  1:13   ` Kevin Hilman
2016-02-12  1:13     ` Kevin Hilman
2016-02-12 12:54   ` Ulf Hansson
2016-02-12 12:54     ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160211173620.GU19432@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org \
    --cc=rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=t-kristo-l0cyMroinI0@public.gmane.org \
    --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.