From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>,
Matthew Wilcox <willy@linux.intel.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@lists.01.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS
Date: Fri, 12 Feb 2016 07:50:49 +1100 [thread overview]
Message-ID: <20160211205049.GJ19486@dastard> (raw)
In-Reply-To: <20160211194922.GA5260@linux.intel.com>
On Thu, Feb 11, 2016 at 12:49:22PM -0700, Ross Zwisler wrote:
> I think the plan of unsetting S_DAX on bdev->bd_inode when we mount will save
> us from this, as long as we do it super early in the mount process.
I think that S_DAX should not be set on the block device by default
in the first place. If we've been surprised by unexpected behaviour,
then I'm sure there are going to be other surprises waiting for us.
DAX default policy should be opt-in, not opt-out.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>,
Matthew Wilcox <willy@linux.intel.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@ml01.01.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS
Date: Fri, 12 Feb 2016 07:50:49 +1100 [thread overview]
Message-ID: <20160211205049.GJ19486@dastard> (raw)
In-Reply-To: <20160211194922.GA5260@linux.intel.com>
On Thu, Feb 11, 2016 at 12:49:22PM -0700, Ross Zwisler wrote:
> I think the plan of unsetting S_DAX on bdev->bd_inode when we mount will save
> us from this, as long as we do it super early in the mount process.
I think that S_DAX should not be set on the block device by default
in the first place. If we've been surprised by unexpected behaviour,
then I'm sure there are going to be other surprises waiting for us.
DAX default policy should be opt-in, not opt-out.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>,
Matthew Wilcox <willy@linux.intel.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@lists.01.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS
Date: Fri, 12 Feb 2016 07:50:49 +1100 [thread overview]
Message-ID: <20160211205049.GJ19486@dastard> (raw)
In-Reply-To: <20160211194922.GA5260@linux.intel.com>
On Thu, Feb 11, 2016 at 12:49:22PM -0700, Ross Zwisler wrote:
> I think the plan of unsetting S_DAX on bdev->bd_inode when we mount will save
> us from this, as long as we do it super early in the mount process.
I think that S_DAX should not be set on the block device by default
in the first place. If we've been surprised by unexpected behaviour,
then I'm sure there are going to be other surprises waiting for us.
DAX default policy should be opt-in, not opt-out.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-11 20:50 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 20:48 [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS Ross Zwisler
2016-02-10 20:48 ` Ross Zwisler
2016-02-10 20:48 ` Ross Zwisler
2016-02-10 20:48 ` [PATCH v2 1/2] dax: supply DAX clearing code with correct bdev Ross Zwisler
2016-02-10 20:48 ` Ross Zwisler
2016-02-10 20:48 ` Ross Zwisler
2016-02-10 20:48 ` [PATCH v2 2/2] dax: move writeback calls into the filesystems Ross Zwisler
2016-02-10 20:48 ` Ross Zwisler
2016-02-10 20:48 ` Ross Zwisler
2016-02-10 22:03 ` Dave Chinner
2016-02-10 22:03 ` Dave Chinner
2016-02-10 22:03 ` Dave Chinner
2016-02-10 22:43 ` Ross Zwisler
2016-02-10 22:43 ` Ross Zwisler
2016-02-10 22:43 ` Ross Zwisler
2016-02-10 23:44 ` Dave Chinner
2016-02-10 23:44 ` Dave Chinner
2016-02-10 23:44 ` Dave Chinner
2016-02-11 12:50 ` Jan Kara
2016-02-11 12:50 ` Jan Kara
2016-02-11 12:50 ` Jan Kara
2016-02-11 15:22 ` Dan Williams
2016-02-11 15:22 ` Dan Williams
2016-02-11 15:22 ` Dan Williams
2016-02-11 15:22 ` Dan Williams
2016-02-11 16:22 ` Jan Kara
2016-02-11 16:22 ` Jan Kara
2016-02-11 16:22 ` Jan Kara
2016-02-11 16:22 ` Jan Kara
2016-02-11 20:46 ` Dave Chinner
2016-02-11 20:46 ` Dave Chinner
2016-02-11 20:46 ` Dave Chinner
2016-02-11 20:46 ` Dave Chinner
2016-02-11 20:58 ` Dan Williams
2016-02-11 20:58 ` Dan Williams
2016-02-11 20:58 ` Dan Williams
2016-02-11 20:58 ` Dan Williams
2016-02-11 22:46 ` Dave Chinner
2016-02-11 22:46 ` Dave Chinner
2016-02-11 22:46 ` Dave Chinner
2016-02-11 22:59 ` Dan Williams
2016-02-11 22:59 ` Dan Williams
2016-02-11 22:59 ` Dan Williams
2016-02-11 23:44 ` Dave Chinner
2016-02-11 23:44 ` Dave Chinner
2016-02-11 23:44 ` Dave Chinner
2016-02-11 12:43 ` [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS Jan Kara
2016-02-11 12:43 ` Jan Kara
2016-02-11 12:43 ` Jan Kara
2016-02-11 19:49 ` Ross Zwisler
2016-02-11 19:49 ` Ross Zwisler
2016-02-11 19:49 ` Ross Zwisler
2016-02-11 19:49 ` Ross Zwisler
2016-02-11 20:50 ` Dave Chinner [this message]
2016-02-11 20:50 ` Dave Chinner
2016-02-11 20:50 ` Dave Chinner
2016-02-12 19:03 ` Ross Zwisler
2016-02-12 19:03 ` Ross Zwisler
2016-02-12 19:03 ` Ross Zwisler
2016-02-12 19:03 ` Ross Zwisler
2016-02-13 2:38 ` Dave Chinner
2016-02-13 2:38 ` Dave Chinner
2016-02-13 2:38 ` Dave Chinner
2016-02-13 4:59 ` Ross Zwisler
2016-02-13 4:59 ` Ross Zwisler
2016-02-13 4:59 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211205049.GJ19486@dastard \
--to=david@fromorbit.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.