[PATCH] dscc4: Undefined signed int shift

[PATCH] dscc4: Undefined signed int shift

[Michael McConville]

My analysis in the below mail applies, although the second part is
unnecessary because i isn't used in arithmetic operations here:

https://marc.info/?l=openbsd-tech&m=145377854103866&w=2

Thanks for your time.

Signed-off-by: Michael McConville <mmcco@mykolab.com>
---
 drivers/net/wan/dscc4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 7a72407..6292259 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -1626,7 +1626,7 @@ try:
 		if (state & Xpr) {
 			void __iomem *scc_addr;
 			unsigned long ring;
-			int i;
+			unsigned int i;
 
 			/*
 			 * - the busy condition happens (sometimes);

Re: [PATCH] dscc4: Undefined signed int shift

[Francois Romieu]

Michael McConville <mmcco@mykolab.com> :
> My analysis in the below mail applies, although the second part is
> unnecessary because i isn't used in arithmetic operations here:
> 
> https://marc.info/?l=openbsd-tech&m=145377854103866&w=2
> 
> Thanks for your time.

Acked-by: Francois Romieu <romieu@fr.zoreil.com>

For all practical matters it doesn't necessarily deserves to be fed
through stable.

-- 
Ueimor

Re: [PATCH] dscc4: Undefined signed int shift

[David Miller]

From: Michael McConville <mmcco@mykolab.com>
Date: Fri, 5 Feb 2016 20:46:25 -0500

> My analysis in the below mail applies, although the second part is
> unnecessary because i isn't used in arithmetic operations here:
> 
> https://marc.info/?l=openbsd-tech&m=145377854103866&w=2
> 
> Thanks for your time.
> 
> Signed-off-by: Michael McConville <mmcco@mykolab.com>

Applied, thanks.