[PATCH v2 6/6] staging: rtl8192u: ieee80211: Remove MSECS macro

[PATCH v2 6/6] staging: rtl8192u: ieee80211: Remove MSECS macro

[Amitoj Kaur Chawla]

Remove driver specific macro MSECS since all instances of this macro
have been replaced by direct calls to msecs_to_jiffies().

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
        -None

 drivers/staging/rtl8192u/ieee80211/ieee80211.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
index 967ef9a..c0a0897 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
@@ -329,7 +329,6 @@ typedef struct ieee_param {
 
 
 // linux under 2.6.9 release may not support it, so modify it for common use
-#define MSECS(t) msecs_to_jiffies(t)
 #define msleep_interruptible_rsl  msleep_interruptible
 
 #define IEEE80211_DATA_LEN		2304
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v2 6/6] staging: rtl8192u: ieee80211: Remove MSECS macro

[Julia Lawall]

On Sat, 13 Feb 2016, Amitoj Kaur Chawla wrote:

> Remove driver specific macro MSECS since all instances of this macro
> have been replaced by direct calls to msecs_to_jiffies().
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
>         -None
> 
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index 967ef9a..c0a0897 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -329,7 +329,6 @@ typedef struct ieee_param {
>  
>  
>  // linux under 2.6.9 release may not support it, so modify it for common use
> -#define MSECS(t) msecs_to_jiffies(t)
>  #define msleep_interruptible_rsl  msleep_interruptible

In another patch, this macro looks like a good candidate for dropping too.

julia

>  
>  #define IEEE80211_DATA_LEN		2304
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160213043423.GA6239%40amitoj-Inspiron-3542.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2 6/6] staging: rtl8192u: ieee80211: Remove MSECS macro

[Amitoj Kaur Chawla]

On Sat, Feb 13, 2016 at 12:05 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sat, 13 Feb 2016, Amitoj Kaur Chawla wrote:
>
>> Remove driver specific macro MSECS since all instances of this macro
>> have been replaced by direct calls to msecs_to_jiffies().
>>
>> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>> ---
>> Changes in v2:
>>         -None
>>
>>  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
>> index 967ef9a..c0a0897 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
>> @@ -329,7 +329,6 @@ typedef struct ieee_param {
>>
>>
>>  // linux under 2.6.9 release may not support it, so modify it for common use
>> -#define MSECS(t) msecs_to_jiffies(t)
>>  #define msleep_interruptible_rsl  msleep_interruptible
>
> In another patch, this macro looks like a good candidate for dropping too.
>
> julia
>
Hmm, yes will see the instances for this too.

Thanks,
Amitoj