* [U-Boot] [PATCH] gpio: Correct handling of 'gpio status'
@ 2016-02-14 23:28 Simon Glass
2016-02-15 7:36 ` Soeren Moch
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Simon Glass @ 2016-02-14 23:28 UTC (permalink / raw)
To: u-boot
This is broken - we need to look at the first two characters to distinguish
'gpio status' from 'gpio set'.
Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
Reported-by: Soeren Moch <smoch@web.de>
Signed-off-by: Simon Glass <sjg@chromium.org>
---
cmd/gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/gpio.c b/cmd/gpio.c
index 2b78b16..693998e 100644
--- a/cmd/gpio.c
+++ b/cmd/gpio.c
@@ -141,7 +141,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#endif
if (argc > 0)
str_gpio = *argv;
- if (!strncmp(str_cmd, "status", 1)) {
+ if (!strncmp(str_cmd, "status", 2)) {
/* Support deprecated gpio_status() */
#ifdef gpio_status
gpio_status();
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gpio: Correct handling of 'gpio status'
2016-02-14 23:28 [U-Boot] [PATCH] gpio: Correct handling of 'gpio status' Simon Glass
@ 2016-02-15 7:36 ` Soeren Moch
2016-02-15 11:02 ` Bin Meng
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Soeren Moch @ 2016-02-15 7:36 UTC (permalink / raw)
To: u-boot
On 15.02.2016 00:28, Simon Glass wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
>
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Soeren Moch <smoch@web.de>
With this patch 'gpio set' works again.
Thanks,
Soeren
> ---
>
> cmd/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/gpio.c b/cmd/gpio.c
> index 2b78b16..693998e 100644
> --- a/cmd/gpio.c
> +++ b/cmd/gpio.c
> @@ -141,7 +141,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> #endif
> if (argc > 0)
> str_gpio = *argv;
> - if (!strncmp(str_cmd, "status", 1)) {
> + if (!strncmp(str_cmd, "status", 2)) {
> /* Support deprecated gpio_status() */
> #ifdef gpio_status
> gpio_status();
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gpio: Correct handling of 'gpio status'
2016-02-14 23:28 [U-Boot] [PATCH] gpio: Correct handling of 'gpio status' Simon Glass
2016-02-15 7:36 ` Soeren Moch
@ 2016-02-15 11:02 ` Bin Meng
2016-02-15 11:03 ` Hannes Schmelzer
2016-02-15 22:36 ` [U-Boot] " Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2016-02-15 11:02 UTC (permalink / raw)
To: u-boot
On Mon, Feb 15, 2016 at 7:28 AM, Simon Glass <sjg@chromium.org> wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
>
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> cmd/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gpio: Correct handling of 'gpio status'
2016-02-14 23:28 [U-Boot] [PATCH] gpio: Correct handling of 'gpio status' Simon Glass
2016-02-15 7:36 ` Soeren Moch
2016-02-15 11:02 ` Bin Meng
@ 2016-02-15 11:03 ` Hannes Schmelzer
2016-02-15 22:36 ` [U-Boot] " Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Hannes Schmelzer @ 2016-02-15 11:03 UTC (permalink / raw)
To: u-boot
On 15.02.2016 00:28, Simon Glass wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
>
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> cmd/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/gpio.c b/cmd/gpio.c
> index 2b78b16..693998e 100644
> --- a/cmd/gpio.c
> +++ b/cmd/gpio.c
> @@ -141,7 +141,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> #endif
> if (argc > 0)
> str_gpio = *argv;
> - if (!strncmp(str_cmd, "status", 1)) {
> + if (!strncmp(str_cmd, "status", 2)) {
> /* Support deprecated gpio_status() */
> #ifdef gpio_status
> gpio_status();
Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] gpio: Correct handling of 'gpio status'
2016-02-14 23:28 [U-Boot] [PATCH] gpio: Correct handling of 'gpio status' Simon Glass
` (2 preceding siblings ...)
2016-02-15 11:03 ` Hannes Schmelzer
@ 2016-02-15 22:36 ` Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2016-02-15 22:36 UTC (permalink / raw)
To: u-boot
On Sun, Feb 14, 2016 at 04:28:59PM -0700, Simon Glass wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
>
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Tested-by: Soeren Moch <smoch@web.de>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160215/2f9cb69c/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-15 22:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-14 23:28 [U-Boot] [PATCH] gpio: Correct handling of 'gpio status' Simon Glass
2016-02-15 7:36 ` Soeren Moch
2016-02-15 11:02 ` Bin Meng
2016-02-15 11:03 ` Hannes Schmelzer
2016-02-15 22:36 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.