* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2016-02-10 22:33 Michael Chan
2016-02-10 22:33 ` [PATCH net 1/5] bnxt_en: Fix ethtool autoneg logic Michael Chan
` (5 more replies)
0 siblings, 6 replies; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
Fixed autoneg logic and some related cleanups, fixed tx push operation,
and reduced default ring sizes.
Michael Chan (5):
bnxt_en: Fix ethtool autoneg logic.
bnxt_en: Cleanup and Fix flow control setup logic
bnxt_en: Remove 20G support and advertise only 40GbaseCR4.
bnxt_en: Fix implementation of tx push operation.
bnxt_en: Reduce default ring sizes.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 62 ++++++++++++-----------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 46 +++++------------
3 files changed, 56 insertions(+), 67 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 1/5] bnxt_en: Fix ethtool autoneg logic.
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
@ 2016-02-10 22:33 ` Michael Chan
2016-02-10 22:33 ` [PATCH net 2/5] bnxt_en: Cleanup and Fix flow control setup logic Michael Chan
` (4 subsequent siblings)
5 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
1. Determine autoneg on|off setting from link_info->autoneg. Using the
firmware returned setting can be misleading if autoneg is changed and
there hasn't been a phy update from the firmware.
2. If autoneg is disabled, link_info->autoneg should be set to 0 to
indicate both speed and flow control autoneg are disabled.
3. To enable autoneg flow control, speed autoneg must be enabled.
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 922b898..7240307 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -561,7 +561,7 @@ static int bnxt_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
if (link_info->auto_link_speeds)
cmd->supported |= SUPPORTED_Autoneg;
- if (BNXT_AUTO_MODE(link_info->auto_mode)) {
+ if (link_info->autoneg) {
cmd->advertising =
bnxt_fw_to_ethtool_advertised_spds(link_info);
cmd->advertising |= ADVERTISED_Autoneg;
@@ -729,7 +729,7 @@ static int bnxt_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
speed = ethtool_cmd_speed(cmd);
link_info->req_link_speed = bnxt_get_fw_speed(dev, speed);
link_info->req_duplex = BNXT_LINK_DUPLEX_FULL;
- link_info->autoneg &= ~BNXT_AUTONEG_SPEED;
+ link_info->autoneg = 0;
link_info->advertising = 0;
}
@@ -748,8 +748,7 @@ static void bnxt_get_pauseparam(struct net_device *dev,
if (BNXT_VF(bp))
return;
- epause->autoneg = !!(link_info->auto_pause_setting &
- BNXT_LINK_PAUSE_BOTH);
+ epause->autoneg = !!(link_info->autoneg & BNXT_AUTONEG_FLOW_CTRL);
epause->rx_pause = ((link_info->pause & BNXT_LINK_PAUSE_RX) != 0);
epause->tx_pause = ((link_info->pause & BNXT_LINK_PAUSE_TX) != 0);
}
@@ -765,6 +764,9 @@ static int bnxt_set_pauseparam(struct net_device *dev,
return rc;
if (epause->autoneg) {
+ if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
+ return -EINVAL;
+
link_info->autoneg |= BNXT_AUTONEG_FLOW_CTRL;
link_info->req_flow_ctrl |= BNXT_LINK_PAUSE_BOTH;
} else {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 2/5] bnxt_en: Cleanup and Fix flow control setup logic
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2016-02-10 22:33 ` [PATCH net 1/5] bnxt_en: Fix ethtool autoneg logic Michael Chan
@ 2016-02-10 22:33 ` Michael Chan
2016-02-10 22:33 ` [PATCH net 3/5] bnxt_en: Remove 20G support and advertise only 40GbaseCR4 Michael Chan
` (3 subsequent siblings)
5 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
Cleanup bnxt_probe_phy() to cleanly separate 2 code blocks for autoneg
on and off. Autoneg flow control is possible only if autoneg is enabled.
In bnxt_get_settings(), Pause and Asym_Pause are always supported.
Only the advertisement bits change depending on the ethtool -A setting
in auto mode.
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++-------------
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 15 ++-------------
2 files changed, 9 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 5dc89e5..ddcf7ef 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -5670,22 +5670,16 @@ static int bnxt_probe_phy(struct bnxt *bp)
}
/*initialize the ethool setting copy with NVM settings */
- if (BNXT_AUTO_MODE(link_info->auto_mode))
- link_info->autoneg |= BNXT_AUTONEG_SPEED;
-
- if (link_info->auto_pause_setting & BNXT_LINK_PAUSE_BOTH) {
- if (link_info->auto_pause_setting == BNXT_LINK_PAUSE_BOTH)
- link_info->autoneg |= BNXT_AUTONEG_FLOW_CTRL;
+ if (BNXT_AUTO_MODE(link_info->auto_mode)) {
+ link_info->autoneg = BNXT_AUTONEG_SPEED |
+ BNXT_AUTONEG_FLOW_CTRL;
+ link_info->advertising = link_info->auto_link_speeds;
link_info->req_flow_ctrl = link_info->auto_pause_setting;
- } else if (link_info->force_pause_setting & BNXT_LINK_PAUSE_BOTH) {
+ } else {
+ link_info->req_link_speed = link_info->force_link_speed;
+ link_info->req_duplex = link_info->duplex_setting;
link_info->req_flow_ctrl = link_info->force_pause_setting;
}
- link_info->req_duplex = link_info->duplex_setting;
- if (link_info->autoneg & BNXT_AUTONEG_SPEED)
- link_info->req_link_speed = link_info->auto_link_speed;
- else
- link_info->req_link_speed = link_info->force_link_speed;
- link_info->advertising = link_info->auto_link_speeds;
snprintf(phy_ver, PHY_VER_STR_LEN, " ph %d.%d.%d",
link_info->phy_ver[0],
link_info->phy_ver[1],
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 7240307..afc9655 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -557,6 +557,7 @@ static int bnxt_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
u16 ethtool_speed;
cmd->supported = bnxt_fw_to_ethtool_support_spds(link_info);
+ cmd->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
if (link_info->auto_link_speeds)
cmd->supported |= SUPPORTED_Autoneg;
@@ -570,28 +571,16 @@ static int bnxt_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
cmd->autoneg = AUTONEG_DISABLE;
cmd->advertising = 0;
}
- if (link_info->auto_pause_setting & BNXT_LINK_PAUSE_BOTH) {
+ if (link_info->autoneg & BNXT_AUTONEG_FLOW_CTRL) {
if ((link_info->auto_pause_setting & BNXT_LINK_PAUSE_BOTH) ==
BNXT_LINK_PAUSE_BOTH) {
cmd->advertising |= ADVERTISED_Pause;
- cmd->supported |= SUPPORTED_Pause;
} else {
cmd->advertising |= ADVERTISED_Asym_Pause;
- cmd->supported |= SUPPORTED_Asym_Pause;
if (link_info->auto_pause_setting &
BNXT_LINK_PAUSE_RX)
cmd->advertising |= ADVERTISED_Pause;
}
- } else if (link_info->force_pause_setting & BNXT_LINK_PAUSE_BOTH) {
- if ((link_info->force_pause_setting & BNXT_LINK_PAUSE_BOTH) ==
- BNXT_LINK_PAUSE_BOTH) {
- cmd->supported |= SUPPORTED_Pause;
- } else {
- cmd->supported |= SUPPORTED_Asym_Pause;
- if (link_info->force_pause_setting &
- BNXT_LINK_PAUSE_RX)
- cmd->supported |= SUPPORTED_Pause;
- }
}
cmd->port = PORT_NONE;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 3/5] bnxt_en: Remove 20G support and advertise only 40GbaseCR4.
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2016-02-10 22:33 ` [PATCH net 1/5] bnxt_en: Fix ethtool autoneg logic Michael Chan
2016-02-10 22:33 ` [PATCH net 2/5] bnxt_en: Cleanup and Fix flow control setup logic Michael Chan
@ 2016-02-10 22:33 ` Michael Chan
2016-02-10 22:33 ` [PATCH net 4/5] bnxt_en: Fix implementation of tx push operation Michael Chan
` (2 subsequent siblings)
5 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
20G is not supported by production hardware and only the 40GbaseCR4 standard
is supported.
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index afc9655..3238817 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -486,15 +486,8 @@ static u32 bnxt_fw_to_ethtool_support_spds(struct bnxt_link_info *link_info)
speed_mask |= SUPPORTED_2500baseX_Full;
if (fw_speeds & BNXT_LINK_SPEED_MSK_10GB)
speed_mask |= SUPPORTED_10000baseT_Full;
- /* TODO: support 25GB, 50GB with different cable type */
- if (fw_speeds & BNXT_LINK_SPEED_MSK_20GB)
- speed_mask |= SUPPORTED_20000baseMLD2_Full |
- SUPPORTED_20000baseKR2_Full;
if (fw_speeds & BNXT_LINK_SPEED_MSK_40GB)
- speed_mask |= SUPPORTED_40000baseKR4_Full |
- SUPPORTED_40000baseCR4_Full |
- SUPPORTED_40000baseSR4_Full |
- SUPPORTED_40000baseLR4_Full;
+ speed_mask |= SUPPORTED_40000baseCR4_Full;
return speed_mask;
}
@@ -514,15 +507,8 @@ static u32 bnxt_fw_to_ethtool_advertised_spds(struct bnxt_link_info *link_info)
speed_mask |= ADVERTISED_2500baseX_Full;
if (fw_speeds & BNXT_LINK_SPEED_MSK_10GB)
speed_mask |= ADVERTISED_10000baseT_Full;
- /* TODO: how to advertise 20, 25, 40, 50GB with different cable type ?*/
- if (fw_speeds & BNXT_LINK_SPEED_MSK_20GB)
- speed_mask |= ADVERTISED_20000baseMLD2_Full |
- ADVERTISED_20000baseKR2_Full;
if (fw_speeds & BNXT_LINK_SPEED_MSK_40GB)
- speed_mask |= ADVERTISED_40000baseKR4_Full |
- ADVERTISED_40000baseCR4_Full |
- ADVERTISED_40000baseSR4_Full |
- ADVERTISED_40000baseLR4_Full;
+ speed_mask |= ADVERTISED_40000baseCR4_Full;
return speed_mask;
}
@@ -659,6 +645,9 @@ static u16 bnxt_get_fw_auto_link_speeds(u32 advertising)
if (advertising & ADVERTISED_10000baseT_Full)
fw_speed_mask |= BNXT_LINK_SPEED_MSK_10GB;
+ if (advertising & ADVERTISED_40000baseCR4_Full)
+ fw_speed_mask |= BNXT_LINK_SPEED_MSK_40GB;
+
return fw_speed_mask;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 4/5] bnxt_en: Fix implementation of tx push operation.
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (2 preceding siblings ...)
2016-02-10 22:33 ` [PATCH net 3/5] bnxt_en: Remove 20G support and advertise only 40GbaseCR4 Michael Chan
@ 2016-02-10 22:33 ` Michael Chan
2016-02-10 22:33 ` [PATCH net 5/5] bnxt_en: Reduce default ring sizes Michael Chan
2016-02-16 20:51 ` [PATCH net 0/5] bnxt_en: Bug fixes David Miller
5 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
tx push is supported for small packets to reduce DMA latency. The
following bugs are fixed in this patch:
1. Fix the definition of the push BD which is different from the DMA BD.
2. The push buffer has to be zero padded to the next 64-bit word boundary
or tx checksum won't be correct.
3. Increase the tx push packet threshold to 164 bytes (192 bytes with the BD)
so that small tunneled packets are within the threshold.
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 42 ++++++++++++++++++-------------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 11 ++++++--
2 files changed, 34 insertions(+), 19 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index ddcf7ef..82f4e6d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -69,7 +69,7 @@ MODULE_VERSION(DRV_MODULE_VERSION);
#define BNXT_RX_DMA_OFFSET NET_SKB_PAD
#define BNXT_RX_COPY_THRESH 256
-#define BNXT_TX_PUSH_THRESH 92
+#define BNXT_TX_PUSH_THRESH 164
enum board_idx {
BCM57301,
@@ -223,11 +223,12 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
}
if (free_size == bp->tx_ring_size && length <= bp->tx_push_thresh) {
- struct tx_push_bd *push = txr->tx_push;
- struct tx_bd *tx_push = &push->txbd1;
- struct tx_bd_ext *tx_push1 = &push->txbd2;
- void *pdata = tx_push1 + 1;
- int j;
+ struct tx_push_buffer *tx_push_buf = txr->tx_push;
+ struct tx_push_bd *tx_push = &tx_push_buf->push_bd;
+ struct tx_bd_ext *tx_push1 = &tx_push->txbd2;
+ void *pdata = tx_push_buf->data;
+ u64 *end;
+ int j, push_len;
/* Set COAL_NOW to be ready quickly for the next push */
tx_push->tx_bd_len_flags_type =
@@ -247,6 +248,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
tx_push1->tx_bd_cfa_meta = cpu_to_le32(vlan_tag_flags);
tx_push1->tx_bd_cfa_action = cpu_to_le32(cfa_action);
+ end = PTR_ALIGN(pdata + length + 1, 8) - 1;
+ *end = 0;
+
skb_copy_from_linear_data(skb, pdata, len);
pdata += len;
for (j = 0; j < last_frag; j++) {
@@ -261,22 +265,29 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
pdata += skb_frag_size(frag);
}
- memcpy(txbd, tx_push, sizeof(*txbd));
+ txbd->tx_bd_len_flags_type = tx_push->tx_bd_len_flags_type;
+ txbd->tx_bd_haddr = txr->data_mapping;
prod = NEXT_TX(prod);
txbd = &txr->tx_desc_ring[TX_RING(prod)][TX_IDX(prod)];
memcpy(txbd, tx_push1, sizeof(*txbd));
prod = NEXT_TX(prod);
- push->doorbell =
+ tx_push->doorbell =
cpu_to_le32(DB_KEY_TX_PUSH | DB_LONG_TX_PUSH | prod);
txr->tx_prod = prod;
netdev_tx_sent_queue(txq, skb->len);
- __iowrite64_copy(txr->tx_doorbell, push,
- (length + sizeof(*push) + 8) / 8);
+ push_len = (length + sizeof(*tx_push) + 7) / 8;
+ if (push_len > 16) {
+ __iowrite64_copy(txr->tx_doorbell, tx_push_buf, 16);
+ __iowrite64_copy(txr->tx_doorbell + 4, tx_push_buf + 1,
+ push_len - 16);
+ } else {
+ __iowrite64_copy(txr->tx_doorbell, tx_push_buf,
+ push_len);
+ }
tx_buf->is_push = 1;
-
goto tx_done;
}
@@ -1753,7 +1764,7 @@ static int bnxt_alloc_tx_rings(struct bnxt *bp)
push_size = L1_CACHE_ALIGN(sizeof(struct tx_push_bd) +
bp->tx_push_thresh);
- if (push_size > 128) {
+ if (push_size > 256) {
push_size = 0;
bp->tx_push_thresh = 0;
}
@@ -1772,7 +1783,6 @@ static int bnxt_alloc_tx_rings(struct bnxt *bp)
return rc;
if (bp->tx_push_size) {
- struct tx_bd *txbd;
dma_addr_t mapping;
/* One pre-allocated DMA buffer to backup
@@ -1786,13 +1796,11 @@ static int bnxt_alloc_tx_rings(struct bnxt *bp)
if (!txr->tx_push)
return -ENOMEM;
- txbd = &txr->tx_push->txbd1;
-
mapping = txr->tx_push_mapping +
sizeof(struct tx_push_bd);
- txbd->tx_bd_haddr = cpu_to_le64(mapping);
+ txr->data_mapping = cpu_to_le64(mapping);
- memset(txbd + 1, 0, sizeof(struct tx_bd_ext));
+ memset(txr->tx_push, 0, sizeof(struct tx_push_bd));
}
ring->queue_id = bp->q_info[j].queue_id;
if (i % bp->tx_nr_rings_per_tc == (bp->tx_nr_rings_per_tc - 1))
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index 8af3ca8..9b4866c 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -523,10 +523,16 @@ struct bnxt_ring_struct {
struct tx_push_bd {
__le32 doorbell;
- struct tx_bd txbd1;
+ __le32 tx_bd_len_flags_type;
+ u32 tx_bd_opaque;
struct tx_bd_ext txbd2;
};
+struct tx_push_buffer {
+ struct tx_push_bd push_bd;
+ u32 data[25];
+};
+
struct bnxt_tx_ring_info {
struct bnxt_napi *bnapi;
u16 tx_prod;
@@ -538,8 +544,9 @@ struct bnxt_tx_ring_info {
dma_addr_t tx_desc_mapping[MAX_TX_PAGES];
- struct tx_push_bd *tx_push;
+ struct tx_push_buffer *tx_push;
dma_addr_t tx_push_mapping;
+ __le64 data_mapping;
#define BNXT_DEV_STATE_CLOSING 0x1
u32 dev_state;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 5/5] bnxt_en: Reduce default ring sizes.
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (3 preceding siblings ...)
2016-02-10 22:33 ` [PATCH net 4/5] bnxt_en: Fix implementation of tx push operation Michael Chan
@ 2016-02-10 22:33 ` Michael Chan
2016-02-16 20:51 ` [PATCH net 0/5] bnxt_en: Bug fixes David Miller
5 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
The current default tx ring size of 512 causes an extra page to be
allocated for the tx ring with only 1 entry in it. Reduce it to
511. The default rx ring size is also reduced to 511 to use less
memory by default.
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index 9b4866c..2be51b3 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -411,8 +411,8 @@ struct rx_tpa_end_cmp_ext {
#define BNXT_NUM_TESTS(bp) 0
-#define BNXT_DEFAULT_RX_RING_SIZE 1023
-#define BNXT_DEFAULT_TX_RING_SIZE 512
+#define BNXT_DEFAULT_RX_RING_SIZE 511
+#define BNXT_DEFAULT_TX_RING_SIZE 511
#define MAX_TPA 64
--
1.8.3.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (4 preceding siblings ...)
2016-02-10 22:33 ` [PATCH net 5/5] bnxt_en: Reduce default ring sizes Michael Chan
@ 2016-02-16 20:51 ` David Miller
5 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2016-02-16 20:51 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: Michael Chan <mchan@broadcom.com>
Date: Wed, 10 Feb 2016 17:33:45 -0500
> Fixed autoneg logic and some related cleanups, fixed tx push operation,
> and reduced default ring sizes.
Series applied, thanks Michael.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2024-01-17 23:45 Michael Chan
@ 2024-01-19 2:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 26+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-19 2:10 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, edumazet, kuba, pabeni, andrew.gospodarek
Hello:
This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 17 Jan 2024 15:45:10 -0800 you wrote:
> This series contains 5 miscellaneous fixes. The fixes include adding
> delay for FLR, buffer memory leak, RSS table size calculation,
> ethtool self test kernel warning, and mqprio crash.
>
> Michael Chan (5):
> bnxt_en: Wait for FLR to complete during probe
> bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
> bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
> bnxt_en: Prevent kernel warning when running offline self test
> bnxt_en: Fix possible crash after creating sw mqprio TCs
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: Wait for FLR to complete during probe
https://git.kernel.org/netdev/net/c/e6602b3c07d8
- [net,2/5] bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
https://git.kernel.org/netdev/net/c/a261fd41f44f
- [net,3/5] bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
https://git.kernel.org/netdev/net/c/602801d18667
- [net,4/5] bnxt_en: Prevent kernel warning when running offline self test
https://git.kernel.org/netdev/net/c/7d544a01450e
- [net,5/5] bnxt_en: Fix possible crash after creating sw mqprio TCs
https://git.kernel.org/netdev/net/c/bb89cf26f515
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2024-01-17 23:45 Michael Chan
2024-01-19 2:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2024-01-17 23:45 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, kuba, pabeni, andrew.gospodarek
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
This series contains 5 miscellaneous fixes. The fixes include adding
delay for FLR, buffer memory leak, RSS table size calculation,
ethtool self test kernel warning, and mqprio crash.
Michael Chan (5):
bnxt_en: Wait for FLR to complete during probe
bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
bnxt_en: Prevent kernel warning when running offline self test
bnxt_en: Fix possible crash after creating sw mqprio TCs
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 49 +++++++++++++------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 7 +--
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 2 +-
5 files changed, 42 insertions(+), 19 deletions(-)
--
2.30.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2022-12-27 3:19 Michael Chan
@ 2022-12-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 26+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-28 10:20 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, bpf, gospo
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 26 Dec 2022 22:19:35 -0500 you wrote:
> This series fixes a devlink bug and several XDP related bugs. The
> devlink bug causes a kernel crash on VF devices. The XDP driver
> patches fix and clean up the RX XDP path and re-enable header-data
> split that was disabled by mistake when adding the XDP multi-buffer
> support.
>
> Michael Chan (4):
> bnxt_en: Simplify bnxt_xdp_buff_init()
> bnxt_en: Fix XDP RX path
> bnxt_en: Fix first buffer size calculations for XDP multi-buffer
> bnxt_en: Fix HDS and jumbo thresholds for RX packets
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix devlink port registration to netdev
https://git.kernel.org/netdev/net/c/0020ae2a4aa8
- [net,2/5] bnxt_en: Simplify bnxt_xdp_buff_init()
https://git.kernel.org/netdev/net/c/bbfc17e50ba2
- [net,3/5] bnxt_en: Fix XDP RX path
https://git.kernel.org/netdev/net/c/9b3e607871ea
- [net,4/5] bnxt_en: Fix first buffer size calculations for XDP multi-buffer
https://git.kernel.org/netdev/net/c/1abeacc1979f
- [net,5/5] bnxt_en: Fix HDS and jumbo thresholds for RX packets
https://git.kernel.org/netdev/net/c/a056ebcc30e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2022-12-27 3:19 Michael Chan
2022-12-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2022-12-27 3:19 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, bpf, gospo
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
This series fixes a devlink bug and several XDP related bugs. The
devlink bug causes a kernel crash on VF devices. The XDP driver
patches fix and clean up the RX XDP path and re-enable header-data
split that was disabled by mistake when adding the XDP multi-buffer
support.
Michael Chan (4):
bnxt_en: Simplify bnxt_xdp_buff_init()
bnxt_en: Fix XDP RX path
bnxt_en: Fix first buffer size calculations for XDP multi-buffer
bnxt_en: Fix HDS and jumbo thresholds for RX packets
Vikas Gupta (1):
bnxt_en: fix devlink port registration to netdev
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 +++++++++++--------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++++++---
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 20 +++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 6 ++---
4 files changed, 39 insertions(+), 29 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2021-09-05 18:10 Michael Chan
@ 2021-09-05 19:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 26+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-05 19:50 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edwin.peer, gospo
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Sun, 5 Sep 2021 14:10:54 -0400 you wrote:
> This series includes 3 fixes related to devlink firmware and chip
> versions. The other 2 patches fix a UDP tunneling issue and an
> error recovery issue.
>
> Edwin Peer (2):
> bnxt_en: fix stored FW_PSID version masks
> bnxt_en: fix read of stored FW_PSID version on P5 devices
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix stored FW_PSID version masks
https://git.kernel.org/netdev/net/c/1656db67233e
- [net,2/5] bnxt_en: fix read of stored FW_PSID version on P5 devices
https://git.kernel.org/netdev/net/c/beb55fcf950f
- [net,3/5] bnxt_en: Fix asic.rev in devlink dev info command
https://git.kernel.org/netdev/net/c/6fdab8a3ade2
- [net,4/5] bnxt_en: Fix UDP tunnel logic
https://git.kernel.org/netdev/net/c/7ae9dc356f24
- [net,5/5] bnxt_en: Fix possible unintended driver initiated error recovery
https://git.kernel.org/netdev/net/c/1b2b91831983
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2021-09-05 18:10 Michael Chan
2021-09-05 19:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2021-09-05 18:10 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edwin.peer, gospo
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
This series includes 3 fixes related to devlink firmware and chip
versions. The other 2 patches fix a UDP tunneling issue and an
error recovery issue.
Edwin Peer (2):
bnxt_en: fix stored FW_PSID version masks
bnxt_en: fix read of stored FW_PSID version on P5 devices
Michael Chan (3):
bnxt_en: Fix asic.rev in devlink dev info command
bnxt_en: Fix UDP tunnel logic
bnxt_en: Fix possible unintended driver initiated error recovery
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53 ++++++++++++-------
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 51 ++++++++++++------
.../net/ethernet/broadcom/bnxt/bnxt_devlink.h | 4 +-
3 files changed, 72 insertions(+), 36 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-10-26 4:18 Michael Chan
@ 2020-10-27 1:36 ` Jakub Kicinski
0 siblings, 0 replies; 26+ messages in thread
From: Jakub Kicinski @ 2020-10-27 1:36 UTC (permalink / raw)
To: Michael Chan; +Cc: netdev, gospo
On Mon, 26 Oct 2020 00:18:16 -0400 Michael Chan wrote:
> These 5 bug fixes are all related to the firmware reset or AER recovery.
> 2 patches fix the cleanup logic for the workqueue used to handle firmware
> reset and recovery. 1 patch ensures that the chip will have the proper
> BAR addresses latched after fatal AER recovery. 1 patch fixes the
> open path to check for firmware reset abort error. The last one
> sends the fw reset command unconditionally to fix the AER reset logic.
>
> Please queue these for -stable as well. Thanks.
Applied, thanks!
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-10-26 4:18 Michael Chan
2020-10-27 1:36 ` Jakub Kicinski
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2020-10-26 4:18 UTC (permalink / raw)
To: kuba; +Cc: netdev, gospo
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
These 5 bug fixes are all related to the firmware reset or AER recovery.
2 patches fix the cleanup logic for the workqueue used to handle firmware
reset and recovery. 1 patch ensures that the chip will have the proper
BAR addresses latched after fatal AER recovery. 1 patch fixes the
open path to check for firmware reset abort error. The last one
sends the fw reset command unconditionally to fix the AER reset logic.
Please queue these for -stable as well. Thanks.
Michael Chan (1):
bnxt_en: Check abort error state in bnxt_open_nic().
Vasundhara Volam (4):
bnxt_en: Fix regression in workqueue cleanup logic in
bnxt_remove_one().
bnxt_en: Invoke cancel_delayed_work_sync() for PFs also.
bnxt_en: Re-write PCI BARs after PCI fatal error.
bnxt_en: Send HWRM_FUNC_RESET fw command unconditionally.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 49 ++++++++++++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 32 insertions(+), 18 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4166 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-04-26 20:24 Michael Chan
@ 2020-04-27 18:45 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2020-04-27 18:45 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 26 Apr 2020 16:24:37 -0400
> A collection of 5 miscellaneous bug fixes covering VF anti-spoof setup
> issues, devlink MSIX max value, AER, context memory allocation error
> path, and VLAN acceleration logic.
>
> Please queue for -stable. Thanks.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-04-26 20:24 Michael Chan
2020-04-27 18:45 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2020-04-26 20:24 UTC (permalink / raw)
To: davem; +Cc: netdev
A collection of 5 miscellaneous bug fixes covering VF anti-spoof setup
issues, devlink MSIX max value, AER, context memory allocation error
path, and VLAN acceleration logic.
Please queue for -stable. Thanks.
Michael Chan (4):
bnxt_en: Fix VF anti-spoof filter setup.
bnxt_en: Improve AER slot reset.
bnxt_en: Return error when allocating zero size context memory.
bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().
Vasundhara Volam (1):
bnxt_en: Reduce BNXT_MSIX_VEC_MAX value to supported CQs per PF.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 -
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 ++--------
4 files changed, 16 insertions(+), 17 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-03-22 20:40 Michael Chan
2020-03-23 17:27 ` Jakub Kicinski
@ 2020-03-24 4:43 ` David Miller
1 sibling, 0 replies; 26+ messages in thread
From: David Miller @ 2020-03-24 4:43 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 22 Mar 2020 16:40:00 -0400
> 5 bug fix patches covering an indexing bug for priority counters, memory
> leak when retrieving DCB ETS settings, error path return code, proper
> disabling of PCI before freeing context memory, and proper ring accounting
> in error path.
Series applied.
> Please also apply these to -stable. Thanks.
Queued up, thanks.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-03-22 20:40 Michael Chan
@ 2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
1 sibling, 0 replies; 26+ messages in thread
From: Jakub Kicinski @ 2020-03-23 17:27 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
On Sun, 22 Mar 2020 16:40:00 -0400 Michael Chan wrote:
> 5 bug fix patches covering an indexing bug for priority counters, memory
> leak when retrieving DCB ETS settings, error path return code, proper
> disabling of PCI before freeing context memory, and proper ring accounting
> in error path.
>
> Please also apply these to -stable. Thanks.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-03-22 20:40 Michael Chan
2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
0 siblings, 2 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
5 bug fix patches covering an indexing bug for priority counters, memory
leak when retrieving DCB ETS settings, error path return code, proper
disabling of PCI before freeing context memory, and proper ring accounting
in error path.
Please also apply these to -stable. Thanks.
Edwin Peer (1):
bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets()
Michael Chan (3):
bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S.
bnxt_en: Return error if bnxt_alloc_ctx_mem() fails.
bnxt_en: Free context memory after disabling PCI in probe error path.
Vasundhara Volam (1):
bnxt_en: Reset rings if ring reservation fails during open()
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++++++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 15 ++++++++----
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 +++----
4 files changed, 35 insertions(+), 18 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2019-10-21 5:34 Michael Chan
@ 2019-10-22 20:29 ` Jakub Kicinski
0 siblings, 0 replies; 26+ messages in thread
From: Jakub Kicinski @ 2019-10-22 20:29 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, vasundhara-v.volam
On Mon, 21 Oct 2019 01:34:24 -0400, Michael Chan wrote:
> Devlink and error recovery bug fix patches. Most of the work is by
> Vasundhara Volam.
Thanks, applied.
> Please queue patch 1 and 2 for -stable also. Thanks.
FWIW these will likely only reach 5.3 since it looks like the bug dates
to 5.1 but 5.1 and 5.2 branches of stable are already EOL.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2019-10-21 5:34 Michael Chan
2019-10-22 20:29 ` Jakub Kicinski
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2019-10-21 5:34 UTC (permalink / raw)
To: davem; +Cc: netdev, vasundhara-v.volam
Devlink and error recovery bug fix patches. Most of the work is by
Vasundhara Volam. Please queue patch 1 and 2 for -stable also. Thanks.
Michael Chan (1):
bnxt_en: Fix devlink NVRAM related byte order related issues.
Vasundhara Volam (4):
bnxt_en: Fix the size of devlink MSIX parameters.
bnxt_en: Adjust the time to wait before polling firmware readiness.
bnxt_en: Minor formatting changes in FW devlink_health_reporter
bnxt_en: Avoid disabling pci device in bnxt_remove_one() for already
disabled device.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 112 +++++++++++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 3 +-
3 files changed, 73 insertions(+), 52 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2019-06-29 15:16 Michael Chan
@ 2019-06-30 23:01 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2019-06-30 23:01 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sat, 29 Jun 2019 11:16:43 -0400
> Miscellaneous bug fix patches, including two resource handling fixes for
> the RDMA driver, a PCI shutdown patch to add pci_disable_device(), a patch
> to fix ethtool selftest crash, and the last one suppresses an unnecessry
> error message.
Series applied.
> Please also queue patches 1, 2, and 3 for -stable. Thanks.
Queued up.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2019-06-29 15:16 Michael Chan
2019-06-30 23:01 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2019-06-29 15:16 UTC (permalink / raw)
To: davem; +Cc: netdev
Miscellaneous bug fix patches, including two resource handling fixes for
the RDMA driver, a PCI shutdown patch to add pci_disable_device(), a patch
to fix ethtool selftest crash, and the last one suppresses an unnecessry
error message.
Please also queue patches 1, 2, and 3 for -stable. Thanks.
Michael Chan (5):
bnxt_en: Disable bus master during PCI shutdown and driver unload.
bnxt_en: Fix ethtool selftest crash under error conditions.
bnxt_en: Fix statistics context reservation logic for RDMA driver.
bnxt_en: Cap the returned MSIX vectors to the RDMA driver.
bnxt_en: Suppress error messages when querying DSCP DCB capabilities.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++---
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 4 +++-
4 files changed, 20 insertions(+), 12 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2015-11-05 21:25 Michael Chan
@ 2015-11-05 21:35 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2015-11-05 21:35 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: Michael Chan <mchan@broadcom.com>
Date: Thu, 5 Nov 2015 16:25:46 -0500
> Miscellaneous small bug fixes.
This looks fine, series applied, thanks.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2015-11-05 21:25 Michael Chan
2015-11-05 21:35 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2015-11-05 21:25 UTC (permalink / raw)
To: davem; +Cc: netdev
Miscellaneous small bug fixes.
Michael Chan (5):
bnxt_en: Change sp events definitions to represent bit position.
bnxt_en: Determine tcp/ipv6 RSS hash type correctly.
bnxt_en: map CAG_REG_LEGACY_INT_STATUS_MASK to GRC window #4
bnxt_en: Fix comparison of u16 sw_id against negative value.
bnxt_en: More robust SRIOV cleanup sequence.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++++++++++++-----
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 26 +++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 40 +++++++++++++++++--------
3 files changed, 64 insertions(+), 30 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2024-01-19 2:10 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 22:33 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2016-02-10 22:33 ` [PATCH net 1/5] bnxt_en: Fix ethtool autoneg logic Michael Chan
2016-02-10 22:33 ` [PATCH net 2/5] bnxt_en: Cleanup and Fix flow control setup logic Michael Chan
2016-02-10 22:33 ` [PATCH net 3/5] bnxt_en: Remove 20G support and advertise only 40GbaseCR4 Michael Chan
2016-02-10 22:33 ` [PATCH net 4/5] bnxt_en: Fix implementation of tx push operation Michael Chan
2016-02-10 22:33 ` [PATCH net 5/5] bnxt_en: Reduce default ring sizes Michael Chan
2016-02-16 20:51 ` [PATCH net 0/5] bnxt_en: Bug fixes David Miller
-- strict thread matches above, loose matches on Subject: below --
2024-01-17 23:45 Michael Chan
2024-01-19 2:10 ` patchwork-bot+netdevbpf
2022-12-27 3:19 Michael Chan
2022-12-28 10:20 ` patchwork-bot+netdevbpf
2021-09-05 18:10 Michael Chan
2021-09-05 19:50 ` patchwork-bot+netdevbpf
2020-10-26 4:18 Michael Chan
2020-10-27 1:36 ` Jakub Kicinski
2020-04-26 20:24 Michael Chan
2020-04-27 18:45 ` David Miller
2020-03-22 20:40 Michael Chan
2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
2019-10-21 5:34 Michael Chan
2019-10-22 20:29 ` Jakub Kicinski
2019-06-29 15:16 Michael Chan
2019-06-30 23:01 ` David Miller
2015-11-05 21:25 Michael Chan
2015-11-05 21:35 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.