* [PATCH i-g-t] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks
@ 2016-02-08 18:56 Gabriel Feceoru
2016-02-16 15:30 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel Feceoru @ 2016-02-08 18:56 UTC (permalink / raw)
To: intel-gfx
Some platforms have ring BSD available but no BSD2.
Because of the current verification, tests involving ring BSD1
will be skipped if no BSD2 is available.
Decoupling the checks will allow running the BSD1 specific tests
on these platforms.
Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
---
lib/ioctl_wrappers.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index f371bf0..dfabde7 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -1348,8 +1348,10 @@ void gem_require_ring(int fd, int ring_id)
/* silly ABI, the kernel thinks everyone who has BSD also has BSD2 */
if ((ring_id & ~(3<<13)) == I915_EXEC_BSD) {
- if (ring_id & (3 << 13))
+ if (ring_id & (2 << 13))
igt_require(gem_has_bsd2(fd));
+ if (ring_id & (1 << 13))
+ igt_require(gem_has_bsd(fd))
}
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks
2016-02-08 18:56 [PATCH i-g-t] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks Gabriel Feceoru
@ 2016-02-16 15:30 ` Daniel Vetter
2016-02-16 15:33 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2016-02-16 15:30 UTC (permalink / raw)
To: Gabriel Feceoru; +Cc: intel-gfx
On Mon, Feb 08, 2016 at 08:56:06PM +0200, Gabriel Feceoru wrote:
> Some platforms have ring BSD available but no BSD2.
> Because of the current verification, tests involving ring BSD1
> will be skipped if no BSD2 is available.
>
> Decoupling the checks will allow running the BSD1 specific tests
> on these platforms.
>
> Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
Applied, thanks.
-Daniel
> ---
> lib/ioctl_wrappers.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index f371bf0..dfabde7 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -1348,8 +1348,10 @@ void gem_require_ring(int fd, int ring_id)
>
> /* silly ABI, the kernel thinks everyone who has BSD also has BSD2 */
> if ((ring_id & ~(3<<13)) == I915_EXEC_BSD) {
> - if (ring_id & (3 << 13))
> + if (ring_id & (2 << 13))
> igt_require(gem_has_bsd2(fd));
> + if (ring_id & (1 << 13))
> + igt_require(gem_has_bsd(fd))
> }
> }
>
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks
2016-02-16 15:30 ` Daniel Vetter
@ 2016-02-16 15:33 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-02-16 15:33 UTC (permalink / raw)
To: Gabriel Feceoru; +Cc: intel-gfx
On Tue, Feb 16, 2016 at 04:30:32PM +0100, Daniel Vetter wrote:
> On Mon, Feb 08, 2016 at 08:56:06PM +0200, Gabriel Feceoru wrote:
> > Some platforms have ring BSD available but no BSD2.
> > Because of the current verification, tests involving ring BSD1
> > will be skipped if no BSD2 is available.
> >
> > Decoupling the checks will allow running the BSD1 specific tests
> > on these platforms.
> >
> > Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
>
> Applied, thanks.
Well not, since it doesn't even compile.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-16 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-08 18:56 [PATCH i-g-t] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks Gabriel Feceoru
2016-02-16 15:30 ` Daniel Vetter
2016-02-16 15:33 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.