From: Han Xu <xhnjupt@gmail.com> To: Yunhui Cui <B56489@freescale.com> Cc: dwmw2@infradead.org, computersforpeace@gmail.com, han.xu@freescale.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yao.yuan@nxp.com Subject: Re: [PATCH v2 3/4] mtd:spi-nor:fsl-quadspi:Add fast-read mode support Date: Thu, 18 Feb 2016 02:07:42 +0800 [thread overview] Message-ID: <20160217180742.GB17485@shlinux2> (raw) In-Reply-To: <1454326208-4533-3-git-send-email-B56489@freescale.com> On Mon, Feb 01, 2016 at 07:30:07PM +0800, Yunhui Cui wrote: > The qspi driver add generic fast-read mode for different > flash venders. There are some different board flash work on > different mode, such fast-read, quad-mode. > So we have to modify the third entrace parameter of spi_nor_scan(). > > Signed-off-by: Yunhui Cui <B56489@freescale.com> > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 27 +++++++++++++++++++++------ > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c > index 9861290..0a31cb1 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -389,11 +389,21 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) > /* Read */ > lut_base = SEQID_READ * 4; > > - qspi_writel(q, LUT0(CMD, PAD1, read_op) | LUT1(ADDR, PAD1, addrlen), > - base + QUADSPI_LUT(lut_base)); > - qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > - LUT1(FSL_READ, PAD4, rxfifo), > - base + QUADSPI_LUT(lut_base + 1)); > + if (nor->flash_read == SPI_NOR_FAST) { > + qspi_writel(q, LUT0(CMD, PAD1, read_op) | > + LUT1(ADDR, PAD1, addrlen), > + base + QUADSPI_LUT(lut_base)); > + qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > + LUT1(FSL_READ, PAD1, rxfifo), > + base + QUADSPI_LUT(lut_base + 1)); > + } else if (nor->flash_read == SPI_NOR_QUAD) { > + qspi_writel(q, LUT0(CMD, PAD1, read_op) | > + LUT1(ADDR, PAD1, addrlen), > + base + QUADSPI_LUT(lut_base)); > + qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > + LUT1(FSL_READ, PAD4, rxfifo), > + base + QUADSPI_LUT(lut_base + 1)); > + } > > /* Write enable */ > lut_base = SEQID_WREN * 4; > @@ -468,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) > { > switch (cmd) { > case SPINOR_OP_READ_1_1_4: > + case SPINOR_OP_READ_FAST: > return SEQID_READ; > case SPINOR_OP_WREN: > return SEQID_WREN; > @@ -963,6 +974,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) > struct spi_nor *nor; > struct mtd_info *mtd; > int ret, i = 0; > + enum read_mode mode = SPI_NOR_QUAD; > > q = devm_kzalloc(dev, sizeof(*q), GFP_KERNEL); > if (!q) > @@ -1064,7 +1076,10 @@ static int fsl_qspi_probe(struct platform_device *pdev) > /* set the chip address for READID */ > fsl_qspi_set_base_addr(q, nor); > > - ret = spi_nor_scan(nor, NULL, SPI_NOR_QUAD); > + ret = of_property_read_bool(np, "m25p,fast-read"); > + mode = (ret) ? SPI_NOR_FAST : SPI_NOR_QUAD; > + > + ret = spi_nor_scan(nor, NULL, mode); > if (ret) > goto mutex_failed; > I understand you want to provide a more generic read mode, but this is a quad spi driver, I prefer to provide the options, either quad read/quad IO read, or just normal read. > -- > 2.1.0.27.g96db324 > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: xhnjupt@gmail.com (Han Xu) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/4] mtd:spi-nor:fsl-quadspi:Add fast-read mode support Date: Thu, 18 Feb 2016 02:07:42 +0800 [thread overview] Message-ID: <20160217180742.GB17485@shlinux2> (raw) In-Reply-To: <1454326208-4533-3-git-send-email-B56489@freescale.com> On Mon, Feb 01, 2016 at 07:30:07PM +0800, Yunhui Cui wrote: > The qspi driver add generic fast-read mode for different > flash venders. There are some different board flash work on > different mode, such fast-read, quad-mode. > So we have to modify the third entrace parameter of spi_nor_scan(). > > Signed-off-by: Yunhui Cui <B56489@freescale.com> > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 27 +++++++++++++++++++++------ > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c > index 9861290..0a31cb1 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -389,11 +389,21 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) > /* Read */ > lut_base = SEQID_READ * 4; > > - qspi_writel(q, LUT0(CMD, PAD1, read_op) | LUT1(ADDR, PAD1, addrlen), > - base + QUADSPI_LUT(lut_base)); > - qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > - LUT1(FSL_READ, PAD4, rxfifo), > - base + QUADSPI_LUT(lut_base + 1)); > + if (nor->flash_read == SPI_NOR_FAST) { > + qspi_writel(q, LUT0(CMD, PAD1, read_op) | > + LUT1(ADDR, PAD1, addrlen), > + base + QUADSPI_LUT(lut_base)); > + qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > + LUT1(FSL_READ, PAD1, rxfifo), > + base + QUADSPI_LUT(lut_base + 1)); > + } else if (nor->flash_read == SPI_NOR_QUAD) { > + qspi_writel(q, LUT0(CMD, PAD1, read_op) | > + LUT1(ADDR, PAD1, addrlen), > + base + QUADSPI_LUT(lut_base)); > + qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > + LUT1(FSL_READ, PAD4, rxfifo), > + base + QUADSPI_LUT(lut_base + 1)); > + } > > /* Write enable */ > lut_base = SEQID_WREN * 4; > @@ -468,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) > { > switch (cmd) { > case SPINOR_OP_READ_1_1_4: > + case SPINOR_OP_READ_FAST: > return SEQID_READ; > case SPINOR_OP_WREN: > return SEQID_WREN; > @@ -963,6 +974,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) > struct spi_nor *nor; > struct mtd_info *mtd; > int ret, i = 0; > + enum read_mode mode = SPI_NOR_QUAD; > > q = devm_kzalloc(dev, sizeof(*q), GFP_KERNEL); > if (!q) > @@ -1064,7 +1076,10 @@ static int fsl_qspi_probe(struct platform_device *pdev) > /* set the chip address for READID */ > fsl_qspi_set_base_addr(q, nor); > > - ret = spi_nor_scan(nor, NULL, SPI_NOR_QUAD); > + ret = of_property_read_bool(np, "m25p,fast-read"); > + mode = (ret) ? SPI_NOR_FAST : SPI_NOR_QUAD; > + > + ret = spi_nor_scan(nor, NULL, mode); > if (ret) > goto mutex_failed; > I understand you want to provide a more generic read mode, but this is a quad spi driver, I prefer to provide the options, either quad read/quad IO read, or just normal read. > -- > 2.1.0.27.g96db324 > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2016-02-17 18:11 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-01 11:30 [PATCH v2 1/4] mtd:fsl-quadspi:use the property fields of SPI-NOR Yunhui Cui 2016-02-01 11:30 ` Yunhui Cui 2016-02-01 11:30 ` [PATCH v2 2/4] mtd: fsl-quadspi: Rename SEQID_QUAD_READ to SEQID_READ Yunhui Cui 2016-02-01 11:30 ` Yunhui Cui 2016-02-01 11:30 ` [PATCH v2 3/4] mtd:spi-nor:fsl-quadspi:Add fast-read mode support Yunhui Cui 2016-02-01 11:30 ` Yunhui Cui 2016-02-17 18:07 ` Han Xu [this message] 2016-02-17 18:07 ` Han Xu 2016-02-25 8:07 ` Yunhui Cui 2016-02-25 8:07 ` Yunhui Cui 2016-02-25 8:07 ` Yunhui Cui 2016-02-26 16:31 ` Han Xu 2016-02-26 16:31 ` Han Xu 2016-02-26 16:31 ` Han Xu 2016-02-29 3:43 ` Yunhui Cui 2016-02-29 3:43 ` Yunhui Cui 2016-02-29 3:43 ` Yunhui Cui 2016-02-29 20:17 ` Han Xu 2016-02-29 20:17 ` Han Xu 2016-02-29 20:17 ` Han Xu 2016-03-02 1:50 ` Yunhui Cui 2016-03-02 1:50 ` Yunhui Cui 2016-03-02 1:50 ` Yunhui Cui 2016-02-01 11:30 ` [PATCH v2 4/4] mtd:spi_nor: Disable Micron flash HW protection Yunhui Cui 2016-02-01 11:30 ` Yunhui Cui
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160217180742.GB17485@shlinux2 \ --to=xhnjupt@gmail.com \ --cc=B56489@freescale.com \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=han.xu@freescale.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=yao.yuan@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.