* [PATCH] clk: mvebu: Require corediv clock for Armada 38x
@ 2016-02-10 20:41 Kevin Smith
2016-02-10 21:28 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Kevin Smith @ 2016-02-10 20:41 UTC (permalink / raw)
To: linux-clk
Cc: Kevin Smith, Michael Turquette, Stephen Boyd, Gregory CLEMENT,
Thomas Petazzoni
The corediv clock driver is required for the pxa3xx_nand driver,
but is not included in the ARMADA_38X_CLK config. Add
MVEBU_CLK_COREDIV as a dependency of ARMADA_38X_CLK.
Without the corediv driver, nand initialization fails with the
message:
pxa3xx-nand f10d0000.flash: failed to get nand clock
pxa3xx-nand f10d0000.flash: alloc nand resource failed
With corediv enabled, flash is successfully detected.
Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
drivers/clk/mvebu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig
index 2769625..1107056 100644
--- a/drivers/clk/mvebu/Kconfig
+++ b/drivers/clk/mvebu/Kconfig
@@ -20,6 +20,7 @@ config ARMADA_375_CLK
config ARMADA_38X_CLK
bool
select MVEBU_CLK_COMMON
+ select MVEBU_CLK_COREDIV
config ARMADA_39X_CLK
bool
--
2.4.6
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH] clk: mvebu: Require corediv clock for Armada 38x 2016-02-10 20:41 [PATCH] clk: mvebu: Require corediv clock for Armada 38x Kevin Smith @ 2016-02-10 21:28 ` Thomas Petazzoni 2016-02-10 23:38 ` Kevin Smith 2016-02-10 23:40 ` [PATCH v2 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2 siblings, 1 reply; 19+ messages in thread From: Thomas Petazzoni @ 2016-02-10 21:28 UTC (permalink / raw) To: Kevin Smith; +Cc: linux-clk, Michael Turquette, Stephen Boyd, Gregory CLEMENT Dear Kevin Smith, On Wed, 10 Feb 2016 20:41:13 +0000, Kevin Smith wrote: > The corediv clock driver is required for the pxa3xx_nand driver, > but is not included in the ARMADA_38X_CLK config. Add > MVEBU_CLK_COREDIV as a dependency of ARMADA_38X_CLK. > > Without the corediv driver, nand initialization fails with the > message: > > pxa3xx-nand f10d0000.flash: failed to get nand clock > pxa3xx-nand f10d0000.flash: alloc nand resource failed > > With corediv enabled, flash is successfully detected. > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > drivers/clk/mvebu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig > index 2769625..1107056 100644 > --- a/drivers/clk/mvebu/Kconfig > +++ b/drivers/clk/mvebu/Kconfig > @@ -20,6 +20,7 @@ config ARMADA_375_CLK > config ARMADA_38X_CLK > bool > select MVEBU_CLK_COMMON > + select MVEBU_CLK_COREDIV Thanks for the patch! I believe there are some more issues in this Kconfig file: - The ARMADA_XP_CLK option selects MVEBU_CLK_COREDIV but there is no corediv clock on Armada XP. - The ARMADA_375_CLK should also select MVEBU_CLK_COREDIV. However, technically speaking, building ARMADA_38X_CLK or ARMADA_375_CLK does not require building clk-corediv.c, it only needs common.c. So maybe instead we should change arch/arm/mach-mvebu/Kconfig to have MACH_ARMADA_xxx select MVEBU_CLK_COREDIV when needed. But maybe I'm being overly pedantic here, and your solution is good enough. I don't have a strong opinion on this. But if we go with your solution, then I'd like to fix the Armada XP and Armada 375 cases as well. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] clk: mvebu: Require corediv clock for Armada 38x 2016-02-10 21:28 ` Thomas Petazzoni @ 2016-02-10 23:38 ` Kevin Smith 0 siblings, 0 replies; 19+ messages in thread From: Kevin Smith @ 2016-02-10 23:38 UTC (permalink / raw) To: Thomas Petazzoni Cc: linux-clk, Michael Turquette, Stephen Boyd, Gregory CLEMENT Dear Thomas, On 02/10/2016 03:28 PM, Thomas Petazzoni wrote: > Dear Kevin Smith, > > On Wed, 10 Feb 2016 20:41:13 +0000, Kevin Smith wrote: >> The corediv clock driver is required for the pxa3xx_nand driver, >> but is not included in the ARMADA_38X_CLK config. Add >> MVEBU_CLK_COREDIV as a dependency of ARMADA_38X_CLK. >> >> Without the corediv driver, nand initialization fails with the >> message: >> >> pxa3xx-nand f10d0000.flash: failed to get nand clock >> pxa3xx-nand f10d0000.flash: alloc nand resource failed >> >> With corediv enabled, flash is successfully detected. >> >> Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> >> Cc: Michael Turquette <mturquette@baylibre.com> >> Cc: Stephen Boyd <sboyd@codeaurora.org> >> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> --- >> drivers/clk/mvebu/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig >> index 2769625..1107056 100644 >> --- a/drivers/clk/mvebu/Kconfig >> +++ b/drivers/clk/mvebu/Kconfig >> @@ -20,6 +20,7 @@ config ARMADA_375_CLK >> config ARMADA_38X_CLK >> bool >> select MVEBU_CLK_COMMON >> + select MVEBU_CLK_COREDIV > Thanks for the patch! Glad to contribute! > I believe there are some more issues in this Kconfig file: > > - The ARMADA_XP_CLK option selects MVEBU_CLK_COREDIV but there is no > corediv clock on Armada XP. > > - The ARMADA_375_CLK should also select MVEBU_CLK_COREDIV. I thought this was probably missing from other platforms as well, but=20 only have a board and documentation for a38x, so I couldn't check. > However, technically speaking, building ARMADA_38X_CLK or > ARMADA_375_CLK does not require building clk-corediv.c, it only needs > common.c. So maybe instead we should change arch/arm/mach-mvebu/Kconfig > to have MACH_ARMADA_xxx select MVEBU_CLK_COREDIV when needed. I think this is a good idea. It looks to me like the corediv is only=20 needed for NAND right now. I will submit a v2 soon with an mvebu=20 compile dependent on NAND. Let me know what you think of it. > But maybe I'm being overly pedantic here, and your solution is good > enough. I don't have a strong opinion on this. No, I agree this is not ideal. I think your solution is much cleaner. Thank you, Kevin= ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-10 20:41 [PATCH] clk: mvebu: Require corediv clock for Armada 38x Kevin Smith 2016-02-10 21:28 ` Thomas Petazzoni @ 2016-02-10 23:40 ` Kevin Smith 2016-02-10 23:40 ` [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2 siblings, 1 reply; 19+ messages in thread From: Kevin Smith @ 2016-02-10 23:40 UTC (permalink / raw) To: linux-clk Cc: Kevin Smith, Michael Turquette, Stephen Boyd, Gregory CLEMENT, Thomas Petazzoni There is no corediv clock on Armada XP, so this is unnecessary. Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@codeaurora.org> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- drivers/clk/mvebu/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig index 2769625..e1bc567 100644 --- a/drivers/clk/mvebu/Kconfig +++ b/drivers/clk/mvebu/Kconfig @@ -29,7 +29,6 @@ config ARMADA_XP_CLK bool select MVEBU_CLK_COMMON select MVEBU_CLK_CPU - select MVEBU_CLK_COREDIV =20 config DOVE_CLK bool --=20 2.4.6 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-10 23:40 ` [PATCH v2 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith @ 2016-02-10 23:40 ` Kevin Smith 2016-02-11 8:16 ` Thomas Petazzoni 0 siblings, 1 reply; 19+ messages in thread From: Kevin Smith @ 2016-02-10 23:40 UTC (permalink / raw) To: linux-clk Cc: Kevin Smith, Michael Turquette, Stephen Boyd, Gregory CLEMENT, Thomas Petazzoni The corediv clock is not required for all builds, only those that enable peripherals that need it. Move the corediv config option from the clock driver Kconfig to the mvebu Kconfig and make it conditional. This also enables corediv on Armada 375 and 38X as needed. Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@codeaurora.org> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/arm/mach-mvebu/Kconfig | 3 +++ drivers/clk/mvebu/Kconfig | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 64e3d2c..794e7c5 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -32,6 +32,7 @@ config MACH_ARMADA_370 select CPU_PJ4B select MACH_MVEBU_V7 select PINCTRL_ARMADA_370 + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx help Say 'Y' here if you want your kernel to support boards based on the Marvell Armada 370 SoC with device tree. @@ -48,6 +49,7 @@ config MACH_ARMADA_375 select HAVE_SMP select MACH_MVEBU_V7 select PINCTRL_ARMADA_375 + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx help Say 'Y' here if you want your kernel to support boards based on the Marvell Armada 375 SoC with device tree. @@ -64,6 +66,7 @@ config MACH_ARMADA_38X select HAVE_SMP select MACH_MVEBU_V7 select PINCTRL_ARMADA_38X + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx help Say 'Y' here if you want your kernel to support boards based on the Marvell Armada 380/385 SoC with device tree. diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig index e1bc567..eaee8f0 100644 --- a/drivers/clk/mvebu/Kconfig +++ b/drivers/clk/mvebu/Kconfig @@ -11,7 +11,6 @@ config ARMADA_370_CLK bool select MVEBU_CLK_COMMON select MVEBU_CLK_CPU - select MVEBU_CLK_COREDIV =20 config ARMADA_375_CLK bool --=20 2.4.6 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-10 23:40 ` [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith @ 2016-02-11 8:16 ` Thomas Petazzoni 2016-02-11 16:01 ` Kevin Smith 0 siblings, 1 reply; 19+ messages in thread From: Thomas Petazzoni @ 2016-02-11 8:16 UTC (permalink / raw) To: Kevin Smith; +Cc: linux-clk, Michael Turquette, Stephen Boyd, Gregory CLEMENT Kevin, On Wed, 10 Feb 2016 23:40:26 +0000, Kevin Smith wrote: > The corediv clock is not required for all builds, only those that > enable peripherals that need it. Move the corediv config option > from the clock driver Kconfig to the mvebu Kconfig and make it > conditional. > > This also enables corediv on Armada 375 and 38X as needed. > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > arch/arm/mach-mvebu/Kconfig | 3 +++ > drivers/clk/mvebu/Kconfig | 1 - > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig > index 64e3d2c..794e7c5 100644 > --- a/arch/arm/mach-mvebu/Kconfig > +++ b/arch/arm/mach-mvebu/Kconfig > @@ -32,6 +32,7 @@ config MACH_ARMADA_370 > select CPU_PJ4B > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_370 > + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx Thanks for the new iteration. I know the corediv clock is only used for the NAND, but I'm wondering if it's really worth doing this "if MTD_NAND_PXA3xx. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 8:16 ` Thomas Petazzoni @ 2016-02-11 16:01 ` Kevin Smith 2016-02-11 16:04 ` Thomas Petazzoni 0 siblings, 1 reply; 19+ messages in thread From: Kevin Smith @ 2016-02-11 16:01 UTC (permalink / raw) To: Thomas Petazzoni Cc: linux-clk, Michael Turquette, Stephen Boyd, Gregory CLEMENT Hello Thomas, On 02/11/2016 02:16 AM, Thomas Petazzoni wrote: > Kevin, > > On Wed, 10 Feb 2016 23:40:26 +0000, Kevin Smith wrote: >> The corediv clock is not required for all builds, only those that >> enable peripherals that need it. Move the corediv config option >> from the clock driver Kconfig to the mvebu Kconfig and make it >> conditional. >> >> This also enables corediv on Armada 375 and 38X as needed. >> >> Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> >> Cc: Michael Turquette <mturquette@baylibre.com> >> Cc: Stephen Boyd <sboyd@codeaurora.org> >> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> --- >> arch/arm/mach-mvebu/Kconfig | 3 +++ >> drivers/clk/mvebu/Kconfig | 1 - >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig >> index 64e3d2c..794e7c5 100644 >> --- a/arch/arm/mach-mvebu/Kconfig >> +++ b/arch/arm/mach-mvebu/Kconfig >> @@ -32,6 +32,7 @@ config MACH_ARMADA_370 >> select CPU_PJ4B >> select MACH_MVEBU_V7 >> select PINCTRL_ARMADA_370 >> + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx > Thanks for the new iteration. I know the corediv clock is only used for > the NAND, but I'm wondering if it's really worth doing this "if > MTD_NAND_PXA3xx. > > Thomas Maybe I misunderstood. In your previous e-mail you said "building=20 ARMADA_38X_CLK or ARMADA_375_CLK does not require building=20 clk-corediv.c, it only needs common.c. So maybe instead we should=20 change arch/arm/mach-mvebu/Kconfig to have MACH_ARMADA_xxx select=20 MVEBU_CLK_COREDIV when needed." I thought you meant only when a=20 peripheral depended on the coreclk. Should I remove the conditional and just have MACH_ARMADA_XXX always=20 enable MVEBU_CLK_COREDIV for platforms that have it? Thank you, Kevin= ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 16:01 ` Kevin Smith @ 2016-02-11 16:04 ` Thomas Petazzoni 2016-02-11 16:10 ` Kevin Smith 0 siblings, 1 reply; 19+ messages in thread From: Thomas Petazzoni @ 2016-02-11 16:04 UTC (permalink / raw) To: Kevin Smith; +Cc: linux-clk, Michael Turquette, Stephen Boyd, Gregory CLEMENT Kevin, On Thu, 11 Feb 2016 16:01:03 +0000, Kevin Smith wrote: > >> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig > >> index 64e3d2c..794e7c5 100644 > >> --- a/arch/arm/mach-mvebu/Kconfig > >> +++ b/arch/arm/mach-mvebu/Kconfig > >> @@ -32,6 +32,7 @@ config MACH_ARMADA_370 > >> select CPU_PJ4B > >> select MACH_MVEBU_V7 > >> select PINCTRL_ARMADA_370 > >> + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx > > Thanks for the new iteration. I know the corediv clock is only used for > > the NAND, but I'm wondering if it's really worth doing this "if > > MTD_NAND_PXA3xx. > > > > Thomas > Maybe I misunderstood. In your previous e-mail you said "building > ARMADA_38X_CLK or ARMADA_375_CLK does not require building > clk-corediv.c, it only needs common.c. So maybe instead we should > change arch/arm/mach-mvebu/Kconfig to have MACH_ARMADA_xxx select > MVEBU_CLK_COREDIV when needed." I thought you meant only when a > peripheral depended on the coreclk. > > Should I remove the conditional and just have MACH_ARMADA_XXX always > enable MVEBU_CLK_COREDIV for platforms that have it? Yes, at least, this is what my comment was suggesting to do. Sorry if it was unclear, but my point is that the clock is there regardless of whether the NAND driver is available/used. Anyway, it's not a big deal because the defconfig has the pxa3xx_nand driver enabled, so most people are very likely going to have this driver enabled on Marvell platforms. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 16:04 ` Thomas Petazzoni @ 2016-02-11 16:10 ` Kevin Smith 0 siblings, 0 replies; 19+ messages in thread From: Kevin Smith @ 2016-02-11 16:10 UTC (permalink / raw) To: Thomas Petazzoni Cc: linux-clk, Michael Turquette, Stephen Boyd, Gregory CLEMENT On 02/11/2016 10:04 AM, Thomas Petazzoni wrote: > Kevin, > > On Thu, 11 Feb 2016 16:01:03 +0000, Kevin Smith wrote: > >>>> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig >>>> index 64e3d2c..794e7c5 100644 >>>> --- a/arch/arm/mach-mvebu/Kconfig >>>> +++ b/arch/arm/mach-mvebu/Kconfig >>>> @@ -32,6 +32,7 @@ config MACH_ARMADA_370 >>>> select CPU_PJ4B >>>> select MACH_MVEBU_V7 >>>> select PINCTRL_ARMADA_370 >>>> + select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx >>> Thanks for the new iteration. I know the corediv clock is only used for >>> the NAND, but I'm wondering if it's really worth doing this "if >>> MTD_NAND_PXA3xx. >>> >>> Thomas >> Maybe I misunderstood. In your previous e-mail you said "building >> ARMADA_38X_CLK or ARMADA_375_CLK does not require building >> clk-corediv.c, it only needs common.c. So maybe instead we should >> change arch/arm/mach-mvebu/Kconfig to have MACH_ARMADA_xxx select >> MVEBU_CLK_COREDIV when needed." I thought you meant only when a >> peripheral depended on the coreclk. >> >> Should I remove the conditional and just have MACH_ARMADA_XXX always >> enable MVEBU_CLK_COREDIV for platforms that have it? > Yes, at least, this is what my comment was suggesting to do. Sorry if > it was unclear, but my point is that the clock is there regardless of > whether the NAND driver is available/used. > > Anyway, it's not a big deal because the defconfig has the pxa3xx_nand > driver enabled, so most people are very likely going to have this > driver enabled on Marvell platforms. > > Best regards, > > Thomas Ah, thanks for the clarification. This sounds good to me. v3 on the=20 way. :) Thank you, Kevin= ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-10 20:41 [PATCH] clk: mvebu: Require corediv clock for Armada 38x Kevin Smith 2016-02-10 21:28 ` Thomas Petazzoni 2016-02-10 23:40 ` [PATCH v2 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith @ 2016-02-11 16:53 ` Kevin Smith 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith ` (3 more replies) 2 siblings, 4 replies; 19+ messages in thread From: Kevin Smith @ 2016-02-11 16:53 UTC (permalink / raw) To: linux-clk Cc: Kevin Smith, Michael Turquette, Stephen Boyd, Gregory CLEMENT, Thomas Petazzoni There is no corediv clock on Armada XP, so this is unnecessary. Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@codeaurora.org> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- drivers/clk/mvebu/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig index 2769625..e1bc567 100644 --- a/drivers/clk/mvebu/Kconfig +++ b/drivers/clk/mvebu/Kconfig @@ -29,7 +29,6 @@ config ARMADA_XP_CLK bool select MVEBU_CLK_COMMON select MVEBU_CLK_CPU - select MVEBU_CLK_COREDIV =20 config DOVE_CLK bool --=20 2.4.6 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith @ 2016-02-11 16:54 ` Kevin Smith 2016-02-12 16:28 ` Gregory CLEMENT ` (2 more replies) 2016-02-12 16:28 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Gregory CLEMENT ` (2 subsequent siblings) 3 siblings, 3 replies; 19+ messages in thread From: Kevin Smith @ 2016-02-11 16:54 UTC (permalink / raw) To: linux-clk Cc: Kevin Smith, Michael Turquette, Stephen Boyd, Gregory CLEMENT, Thomas Petazzoni The core clock does not depend on corediv, so enabling corediv based on the clock is not really correct. Move the corediv config option from the clock driver Kconfig to the mvebu Kconfig so that it can be enabled by the MACH option instead. This also enables corediv on Armada 375 and 38X, which was previously missing. Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@codeaurora.org> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/arm/mach-mvebu/Kconfig | 3 +++ drivers/clk/mvebu/Kconfig | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 64e3d2c..71e97da 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -32,6 +32,7 @@ config MACH_ARMADA_370 select CPU_PJ4B select MACH_MVEBU_V7 select PINCTRL_ARMADA_370 + select MVEBU_CLK_COREDIV help Say 'Y' here if you want your kernel to support boards based on the Marvell Armada 370 SoC with device tree. @@ -48,6 +49,7 @@ config MACH_ARMADA_375 select HAVE_SMP select MACH_MVEBU_V7 select PINCTRL_ARMADA_375 + select MVEBU_CLK_COREDIV help Say 'Y' here if you want your kernel to support boards based on the Marvell Armada 375 SoC with device tree. @@ -64,6 +66,7 @@ config MACH_ARMADA_38X select HAVE_SMP select MACH_MVEBU_V7 select PINCTRL_ARMADA_38X + select MVEBU_CLK_COREDIV help Say 'Y' here if you want your kernel to support boards based on the Marvell Armada 380/385 SoC with device tree. diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig index e1bc567..eaee8f0 100644 --- a/drivers/clk/mvebu/Kconfig +++ b/drivers/clk/mvebu/Kconfig @@ -11,7 +11,6 @@ config ARMADA_370_CLK bool select MVEBU_CLK_COMMON select MVEBU_CLK_CPU - select MVEBU_CLK_COREDIV =20 config ARMADA_375_CLK bool --=20 2.4.6 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith @ 2016-02-12 16:28 ` Gregory CLEMENT 2016-02-18 1:16 ` Michael Turquette 2016-02-25 23:06 ` Stephen Boyd 2 siblings, 0 replies; 19+ messages in thread From: Gregory CLEMENT @ 2016-02-12 16:28 UTC (permalink / raw) To: Kevin Smith; +Cc: linux-clk, Michael Turquette, Stephen Boyd, Thomas Petazzoni Hi Kevin, =20 On jeu., f=C3=A9vr. 11 2016, Kevin Smith <kevin.smith@elecsyscorp.com> wro= te: > The core clock does not depend on corediv, so enabling corediv > based on the clock is not really correct. Move the corediv > config option from the clock driver Kconfig to the mvebu Kconfig > so that it can be enabled by the MACH option instead. > > This also enables corediv on Armada 375 and 38X, which was > previously missing. > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > --- > arch/arm/mach-mvebu/Kconfig | 3 +++ > drivers/clk/mvebu/Kconfig | 1 - > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig > index 64e3d2c..71e97da 100644 > --- a/arch/arm/mach-mvebu/Kconfig > +++ b/arch/arm/mach-mvebu/Kconfig > @@ -32,6 +32,7 @@ config MACH_ARMADA_370 > select CPU_PJ4B > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_370 > + select MVEBU_CLK_COREDIV > help > Say 'Y' here if you want your kernel to support boards based > on the Marvell Armada 370 SoC with device tree. > @@ -48,6 +49,7 @@ config MACH_ARMADA_375 > select HAVE_SMP > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_375 > + select MVEBU_CLK_COREDIV > help > Say 'Y' here if you want your kernel to support boards based > on the Marvell Armada 375 SoC with device tree. > @@ -64,6 +66,7 @@ config MACH_ARMADA_38X > select HAVE_SMP > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_38X > + select MVEBU_CLK_COREDIV > help > Say 'Y' here if you want your kernel to support boards based > on the Marvell Armada 380/385 SoC with device tree. > diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig > index e1bc567..eaee8f0 100644 > --- a/drivers/clk/mvebu/Kconfig > +++ b/drivers/clk/mvebu/Kconfig > @@ -11,7 +11,6 @@ config ARMADA_370_CLK > bool > select MVEBU_CLK_COMMON > select MVEBU_CLK_CPU > - select MVEBU_CLK_COREDIV >=20=20 > config ARMADA_375_CLK > bool > --=20 > 2.4.6 --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith 2016-02-12 16:28 ` Gregory CLEMENT @ 2016-02-18 1:16 ` Michael Turquette 2016-02-25 23:06 ` Stephen Boyd 2 siblings, 0 replies; 19+ messages in thread From: Michael Turquette @ 2016-02-18 1:16 UTC (permalink / raw) To: Kevin Smith, linux-clk Cc: Kevin Smith, Stephen Boyd, Gregory CLEMENT, Thomas Petazzoni Quoting Kevin Smith (2016-02-11 08:54:00) > The core clock does not depend on corediv, so enabling corediv > based on the clock is not really correct. Move the corediv > config option from the clock driver Kconfig to the mvebu Kconfig > so that it can be enabled by the MACH option instead. > = > This also enables corediv on Armada 375 and 38X, which was > previously missing. > = > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: Michael Turquette <mturquette@baylibre.com> I'm fine to take both patches through the clk tree, or to have them go through arm-soc. Let me know if you have a preference. Regards, Mike > --- > arch/arm/mach-mvebu/Kconfig | 3 +++ > drivers/clk/mvebu/Kconfig | 1 - > 2 files changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig > index 64e3d2c..71e97da 100644 > --- a/arch/arm/mach-mvebu/Kconfig > +++ b/arch/arm/mach-mvebu/Kconfig > @@ -32,6 +32,7 @@ config MACH_ARMADA_370 > select CPU_PJ4B > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_370 > + select MVEBU_CLK_COREDIV > help > Say 'Y' here if you want your kernel to support boards based > on the Marvell Armada 370 SoC with device tree. > @@ -48,6 +49,7 @@ config MACH_ARMADA_375 > select HAVE_SMP > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_375 > + select MVEBU_CLK_COREDIV > help > Say 'Y' here if you want your kernel to support boards based > on the Marvell Armada 375 SoC with device tree. > @@ -64,6 +66,7 @@ config MACH_ARMADA_38X > select HAVE_SMP > select MACH_MVEBU_V7 > select PINCTRL_ARMADA_38X > + select MVEBU_CLK_COREDIV > help > Say 'Y' here if you want your kernel to support boards based > on the Marvell Armada 380/385 SoC with device tree. > diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig > index e1bc567..eaee8f0 100644 > --- a/drivers/clk/mvebu/Kconfig > +++ b/drivers/clk/mvebu/Kconfig > @@ -11,7 +11,6 @@ config ARMADA_370_CLK > bool > select MVEBU_CLK_COMMON > select MVEBU_CLK_CPU > - select MVEBU_CLK_COREDIV > = > config ARMADA_375_CLK > bool > -- = > 2.4.6 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith 2016-02-12 16:28 ` Gregory CLEMENT 2016-02-18 1:16 ` Michael Turquette @ 2016-02-25 23:06 ` Stephen Boyd 2 siblings, 0 replies; 19+ messages in thread From: Stephen Boyd @ 2016-02-25 23:06 UTC (permalink / raw) To: Kevin Smith Cc: linux-clk, Michael Turquette, Gregory CLEMENT, Thomas Petazzoni On 02/11, Kevin Smith wrote: > The core clock does not depend on corediv, so enabling corediv > based on the clock is not really correct. Move the corediv > config option from the clock driver Kconfig to the mvebu Kconfig > so that it can be enabled by the MACH option instead. > > This also enables corediv on Armada 375 and 38X, which was > previously missing. > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith @ 2016-02-12 16:28 ` Gregory CLEMENT 2016-02-18 1:16 ` Michael Turquette 2016-02-25 23:06 ` Stephen Boyd 3 siblings, 0 replies; 19+ messages in thread From: Gregory CLEMENT @ 2016-02-12 16:28 UTC (permalink / raw) To: Kevin Smith; +Cc: linux-clk, Michael Turquette, Stephen Boyd, Thomas Petazzoni Hi Kevin, =20 On jeu., f=C3=A9vr. 11 2016, Kevin Smith <kevin.smith@elecsyscorp.com> wro= te: > There is no corediv clock on Armada XP, so this is unnecessary. > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > --- > drivers/clk/mvebu/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig > index 2769625..e1bc567 100644 > --- a/drivers/clk/mvebu/Kconfig > +++ b/drivers/clk/mvebu/Kconfig > @@ -29,7 +29,6 @@ config ARMADA_XP_CLK > bool > select MVEBU_CLK_COMMON > select MVEBU_CLK_CPU > - select MVEBU_CLK_COREDIV >=20=20 > config DOVE_CLK > bool > --=20 > 2.4.6 --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith 2016-02-12 16:28 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Gregory CLEMENT @ 2016-02-18 1:16 ` Michael Turquette 2016-02-18 8:11 ` Thomas Petazzoni 2016-02-25 23:06 ` Stephen Boyd 3 siblings, 1 reply; 19+ messages in thread From: Michael Turquette @ 2016-02-18 1:16 UTC (permalink / raw) To: Kevin Smith, linux-clk Cc: Kevin Smith, Stephen Boyd, Gregory CLEMENT, Thomas Petazzoni Quoting Kevin Smith (2016-02-11 08:53:52) > There is no corediv clock on Armada XP, so this is unnecessary. > = > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: Michael Turquette <mturquette@baylibre.com> I'm fine to take both patches through the clk tree, or to have them go through arm-soc. Let me know if you have a preference. Regards, Mike > --- > drivers/clk/mvebu/Kconfig | 1 - > 1 file changed, 1 deletion(-) > = > diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig > index 2769625..e1bc567 100644 > --- a/drivers/clk/mvebu/Kconfig > +++ b/drivers/clk/mvebu/Kconfig > @@ -29,7 +29,6 @@ config ARMADA_XP_CLK > bool > select MVEBU_CLK_COMMON > select MVEBU_CLK_CPU > - select MVEBU_CLK_COREDIV > = > config DOVE_CLK > bool > -- = > 2.4.6 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-18 1:16 ` Michael Turquette @ 2016-02-18 8:11 ` Thomas Petazzoni 2016-02-18 17:54 ` Gregory CLEMENT 0 siblings, 1 reply; 19+ messages in thread From: Thomas Petazzoni @ 2016-02-18 8:11 UTC (permalink / raw) To: Michael Turquette; +Cc: Kevin Smith, linux-clk, Stephen Boyd, Gregory CLEMENT Hello, On Wed, 17 Feb 2016 17:16:30 -0800, Michael Turquette wrote: > Quoting Kevin Smith (2016-02-11 08:53:52) > > There is no corediv clock on Armada XP, so this is unnecessary. > > > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Acked-by: Michael Turquette <mturquette@baylibre.com> > > I'm fine to take both patches through the clk tree, or to have them go > through arm-soc. Let me know if you have a preference. I'll let Gregory Clement answer on this one. Since there is no build dependency with the stuff planned in arm-soc, I believe it's fine if you take them, but I'll let Greg give you the final answer since he is taking care of the mvebu stuff going to arm-soc. Thanks for the review! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-18 8:11 ` Thomas Petazzoni @ 2016-02-18 17:54 ` Gregory CLEMENT 0 siblings, 0 replies; 19+ messages in thread From: Gregory CLEMENT @ 2016-02-18 17:54 UTC (permalink / raw) To: Michael Turquette, Thomas Petazzoni; +Cc: Kevin Smith, linux-clk, Stephen Boyd Hi Mike,=20 =20 On jeu., f=C3=A9vr. 18 2016, Thomas Petazzoni <thomas.petazzoni@free-elect= rons.com> wrote: > Hello, > > On Wed, 17 Feb 2016 17:16:30 -0800, Michael Turquette wrote: >> Quoting Kevin Smith (2016-02-11 08:53:52) >> > There is no corediv clock on Armada XP, so this is unnecessary. >> >=20 >> > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> >> > Cc: Michael Turquette <mturquette@baylibre.com> >> > Cc: Stephen Boyd <sboyd@codeaurora.org> >> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> >> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >>=20 >> Acked-by: Michael Turquette <mturquette@baylibre.com> >>=20 >> I'm fine to take both patches through the clk tree, or to have them go >> through arm-soc. Let me know if you have a preference. > > I'll let Gregory Clement answer on this one. Since there is no build > dependency with the stuff planned in arm-soc, I believe it's fine if > you take them, but I'll let Greg give you the final answer since he is > taking care of the mvebu stuff going to arm-soc. Indeed I prefer that you take them in the clock tree. Thanks, Gregory > > Thanks for the review! > > Thomas > --=20 > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith ` (2 preceding siblings ...) 2016-02-18 1:16 ` Michael Turquette @ 2016-02-25 23:06 ` Stephen Boyd 3 siblings, 0 replies; 19+ messages in thread From: Stephen Boyd @ 2016-02-25 23:06 UTC (permalink / raw) To: Kevin Smith Cc: linux-clk, Michael Turquette, Gregory CLEMENT, Thomas Petazzoni On 02/11, Kevin Smith wrote: > There is no corediv clock on Armada XP, so this is unnecessary. > > Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2016-02-25 23:06 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-02-10 20:41 [PATCH] clk: mvebu: Require corediv clock for Armada 38x Kevin Smith 2016-02-10 21:28 ` Thomas Petazzoni 2016-02-10 23:38 ` Kevin Smith 2016-02-10 23:40 ` [PATCH v2 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2016-02-10 23:40 ` [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith 2016-02-11 8:16 ` Thomas Petazzoni 2016-02-11 16:01 ` Kevin Smith 2016-02-11 16:04 ` Thomas Petazzoni 2016-02-11 16:10 ` Kevin Smith 2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith 2016-02-11 16:54 ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith 2016-02-12 16:28 ` Gregory CLEMENT 2016-02-18 1:16 ` Michael Turquette 2016-02-25 23:06 ` Stephen Boyd 2016-02-12 16:28 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Gregory CLEMENT 2016-02-18 1:16 ` Michael Turquette 2016-02-18 8:11 ` Thomas Petazzoni 2016-02-18 17:54 ` Gregory CLEMENT 2016-02-25 23:06 ` Stephen Boyd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.