* [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
@ 2016-02-13 14:03 ` Sudip Mukherjee
0 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2016-02-13 14:03 UTC (permalink / raw)
To: Florian Fainelli, David S. Miller
Cc: linux-kernel, kernel-testers, netdev, Geert Uytterhoeven,
Sudip Mukherjee, Helmut Buchsbaum
The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
with the error:
drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
GPIO is now used to reset the switch so we should have a dependency on
GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
can build test it.
Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
v2: added COMPILE_TEST and gpio/consumer.h
drivers/net/phy/Kconfig | 1 +
drivers/net/phy/spi_ks8995.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index f0a7702..186f202 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -262,3 +262,4 @@ endif # PHYLIB
config MICREL_KS8995MA
tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
depends on SPI
+ depends on GPIOLIB || COMPILE_TEST
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index 5e7340f..55000f6 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -20,6 +20,7 @@
#include <linux/device.h>
#include <linux/of.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/of_gpio.h>
#include <linux/spi/spi.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
@ 2016-02-13 14:03 ` Sudip Mukherjee
0 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2016-02-13 14:03 UTC (permalink / raw)
To: Florian Fainelli, David S. Miller
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
Sudip Mukherjee, Helmut Buchsbaum
The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
with the error:
drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
GPIO is now used to reset the switch so we should have a dependency on
GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
can build test it.
Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
Cc: Helmut Buchsbaum <helmut.buchsbaum-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
---
v2: added COMPILE_TEST and gpio/consumer.h
drivers/net/phy/Kconfig | 1 +
drivers/net/phy/spi_ks8995.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index f0a7702..186f202 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -262,3 +262,4 @@ endif # PHYLIB
config MICREL_KS8995MA
tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
depends on SPI
+ depends on GPIOLIB || COMPILE_TEST
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index 5e7340f..55000f6 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -20,6 +20,7 @@
#include <linux/device.h>
#include <linux/of.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/of_gpio.h>
#include <linux/spi/spi.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
@ 2016-02-17 1:36 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-02-17 1:36 UTC (permalink / raw)
To: sudipm.mukherjee
Cc: f.fainelli, linux-kernel, kernel-testers, netdev, geert,
helmut.buchsbaum
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Sat, 13 Feb 2016 19:33:15 +0530
> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
> drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
>
> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
> can build test it.
>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> v2: added COMPILE_TEST and gpio/consumer.h
I'm going to apply Arnd's patch because it properly removes the
unnecessary linux/gpio.h include.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
@ 2016-02-17 1:36 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-02-17 1:36 UTC (permalink / raw)
To: sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w
Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, geert-Td1EMuHUCqxL1ZNQvxDV9g,
helmut.buchsbaum-Re5JQEeQqe8AvxtiuMwx3w
From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Sat, 13 Feb 2016 19:33:15 +0530
> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
> drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
>
> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
> can build test it.
>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <helmut.buchsbaum-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
> ---
>
> v2: added COMPILE_TEST and gpio/consumer.h
I'm going to apply Arnd's patch because it properly removes the
unnecessary linux/gpio.h include.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
2016-02-17 1:36 ` David Miller
(?)
@ 2016-02-19 8:29 ` Sudip Mukherjee
2016-02-19 16:13 ` David Miller
-1 siblings, 1 reply; 8+ messages in thread
From: Sudip Mukherjee @ 2016-02-19 8:29 UTC (permalink / raw)
To: David Miller
Cc: f.fainelli, linux-kernel, kernel-testers, netdev, geert,
helmut.buchsbaum
On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Date: Sat, 13 Feb 2016 19:33:15 +0530
>
> > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> > with the error:
> > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
> > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
> >
> > GPIO is now used to reset the switch so we should have a dependency on
> > GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
> > can build test it.
> >
> > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> > Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> >
> > v2: added COMPILE_TEST and gpio/consumer.h
>
> I'm going to apply Arnd's patch because it properly removes the
> unnecessary linux/gpio.h include.
I think Arnd's patch is still not applied as we are still having build
failures for the implicit declarations. Or you want me to send v3 after
removing unnecessary linux/gpio.h include?
regards
suduo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
2016-02-19 8:29 ` Sudip Mukherjee
@ 2016-02-19 16:13 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-02-19 16:13 UTC (permalink / raw)
To: sudipm.mukherjee
Cc: f.fainelli, linux-kernel, kernel-testers, netdev, geert,
helmut.buchsbaum
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Fri, 19 Feb 2016 13:59:09 +0530
> On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote:
>> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>> Date: Sat, 13 Feb 2016 19:33:15 +0530
>>
>> > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
>> > with the error:
>> > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>> > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
...
> I think Arnd's patch is still not applied as we are still having build
> failures for the implicit declarations. Or you want me to send v3 after
> removing unnecessary linux/gpio.h include?
It's definitely there in net-next, commit 27090cbdc345cd5fd6f6e57a8986c504c27e4d23
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
@ 2016-02-19 16:13 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-02-19 16:13 UTC (permalink / raw)
To: sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w
Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, geert-Td1EMuHUCqxL1ZNQvxDV9g,
helmut.buchsbaum-Re5JQEeQqe8AvxtiuMwx3w
From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Fri, 19 Feb 2016 13:59:09 +0530
> On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote:
>> From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Date: Sat, 13 Feb 2016 19:33:15 +0530
>>
>> > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
>> > with the error:
>> > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>> > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
...
> I think Arnd's patch is still not applied as we are still having build
> failures for the implicit declarations. Or you want me to send v3 after
> removing unnecessary linux/gpio.h include?
It's definitely there in net-next, commit 27090cbdc345cd5fd6f6e57a8986c504c27e4d23
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
2016-02-19 16:13 ` David Miller
(?)
@ 2016-02-19 16:35 ` Sudip Mukherjee
-1 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2016-02-19 16:35 UTC (permalink / raw)
To: David Miller
Cc: f.fainelli, linux-kernel, kernel-testers, netdev, geert,
helmut.buchsbaum
On Friday 19 February 2016 09:43 PM, David Miller wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Date: Fri, 19 Feb 2016 13:59:09 +0530
>
>> On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote:
>>> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>>> Date: Sat, 13 Feb 2016 19:33:15 +0530
>>>
>>>> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
>>>> with the error:
>>>> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>>>> drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
> ...
>> I think Arnd's patch is still not applied as we are still having build
>> failures for the implicit declarations. Or you want me to send v3 after
>> removing unnecessary linux/gpio.h include?
>
> It's definitely there in net-next, commit 27090cbdc345cd5fd6f6e57a8986c504c27e4d23
>
Ohhh.. ok.. linux-next is still using net-next from next-20160217, I
hope Monday it will be fine.
regards
sudip
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-19 16:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-13 14:03 [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee
2016-02-13 14:03 ` Sudip Mukherjee
2016-02-17 1:36 ` David Miller
2016-02-17 1:36 ` David Miller
2016-02-19 8:29 ` Sudip Mukherjee
2016-02-19 16:13 ` David Miller
2016-02-19 16:13 ` David Miller
2016-02-19 16:35 ` Sudip Mukherjee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.