All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8712: Drop else after return
@ 2016-02-21 20:50 Bhaktipriya Shridhar
  2016-02-22 12:58 ` [Outreachy kernel] " Daniel Baluta
  0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2016-02-21 20:50 UTC (permalink / raw)
  To: outreachy-kernel

Remove unnecessary else when there is a return statement in the
corresponding if block.

The following Coccinelle patch used:

@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
         s1

@@
expression e1;
@@
if (e1) { ... return ...; }
-else{
	...
-}

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/staging/rtl8712/xmit_linux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
index f8866d7..adb51f0 100644
--- a/drivers/staging/rtl8712/xmit_linux.c
+++ b/drivers/staging/rtl8712/xmit_linux.c
@@ -72,8 +72,7 @@ sint r8712_endofpktfile(struct pkt_file *pfile)
 {
 	if (pfile->pkt_len == 0)
 		return true;
-	else
-		return false;
+	return false;
 }


--
2.1.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8712: Drop else after return
  2016-02-21 20:50 [PATCH] staging: rtl8712: Drop else after return Bhaktipriya Shridhar
@ 2016-02-22 12:58 ` Daniel Baluta
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Baluta @ 2016-02-22 12:58 UTC (permalink / raw)
  To: Bhaktipriya Shridhar; +Cc: outreachy-kernel

On Sun, Feb 21, 2016 at 10:50 PM, Bhaktipriya Shridhar
<bhaktipriya96@gmail.com> wrote:
> Remove unnecessary else when there is a return statement in the
> corresponding if block.
>
> The following Coccinelle patch used:
>
> @@
> expression e2;
> statement s1;
> @@
> if(e2) { ... return ...; }
> -else
>          s1
>
> @@
> expression e1;
> @@
> if (e1) { ... return ...; }
> -else{
>         ...
> -}
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  drivers/staging/rtl8712/xmit_linux.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
> index f8866d7..adb51f0 100644
> --- a/drivers/staging/rtl8712/xmit_linux.c
> +++ b/drivers/staging/rtl8712/xmit_linux.c
> @@ -72,8 +72,7 @@ sint r8712_endofpktfile(struct pkt_file *pfile)
>  {
>         if (pfile->pkt_len == 0)

Here we could just return pfile->pkt_len == 0;


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-22 12:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-21 20:50 [PATCH] staging: rtl8712: Drop else after return Bhaktipriya Shridhar
2016-02-22 12:58 ` [Outreachy kernel] " Daniel Baluta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.