From: Stephen Hemminger <stephen@networkplumber.org>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
eladr@mellanox.com, yotamg@mellanox.com, ogerlitz@mellanox.com,
yishaih@mellanox.com, dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, eugenia@mellanox.com,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
hadarh@mellanox.com, jhs@mojatatu.com, john.fastabend@gmail.com,
jeffrey.t.kirsher@intel.com, brouer@redhat.com,
ivecera@redhat.com, rami.rosen@intel.com
Subject: Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface
Date: Tue, 23 Feb 2016 09:31:39 -0800 [thread overview]
Message-ID: <20160223093139.21303e16@samsung9> (raw)
In-Reply-To: <56CC41C8.10802@stressinduktion.org>
On Tue, 23 Feb 2016 12:26:00 +0100
Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
> Hi Jiri,
>
> On 22.02.2016 19:31, Jiri Pirko wrote:
> > From: Jiri Pirko <jiri@mellanox.com>
> >
> > So far, there has been an mlx4-specific sysfs file allowing user to
> > change port type to either Ethernet of InfiniBand. This is very
> > inconvenient.
>
> Again, I want to express my concerns regarding all of this until this
> will be integrated into udev/systemd for stable device names. While one
> can build wrapper code around devlink to have stable devlink ports, I
> don't see a reason to include kernel code which actually has more
> problems than the sysfs approach. This harms admins to use those devices
> and will additionally require user space to write boiler plate code.
>
> Thanks,
> Hannes
>
I appreciate that you need to have a lighterweight model for
network devices. But have to agree with Hannes.
This code breaks the model expected by applications like Quagga, SNMP
and lots of other legacy code. Is this really going to work with the
legacy Linux model.
next prev parent reply other threads:[~2016-02-23 17:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 18:31 [patch net-next 0/9] Introduce devlink interface and first drivers to use it Jiri Pirko
2016-02-22 18:31 ` [patch net-next 1/9] Introduce devlink infrastructure Jiri Pirko
2016-02-22 22:29 ` roopa
2016-02-23 7:47 ` Jiri Pirko
2016-02-24 7:02 ` Yuval Mintz
2016-02-24 10:56 ` Jiri Pirko
2016-02-22 18:31 ` [patch net-next 2/9] mlx4: Implement devlink interface Jiri Pirko
2016-02-22 18:31 ` [patch net-next 3/9] mlx4: Implement port type setting via " Jiri Pirko
2016-02-23 11:26 ` Hannes Frederic Sowa
2016-02-23 12:21 ` Jiri Pirko
2016-02-23 13:28 ` Hannes Frederic Sowa
2016-02-23 14:26 ` Jiri Pirko
2016-02-23 15:16 ` Hannes Frederic Sowa
2016-02-23 15:30 ` Jiri Pirko
2016-02-23 15:57 ` Hannes Frederic Sowa
2016-02-23 16:04 ` Jiri Pirko
2016-02-23 16:45 ` Hannes Frederic Sowa
2016-02-23 16:55 ` Jiri Pirko
2016-02-23 17:07 ` Hannes Frederic Sowa
2016-02-23 15:20 ` Andy Gospodarek
2016-02-23 15:31 ` Jiri Pirko
2016-02-23 18:16 ` David Miller
2016-02-23 17:31 ` Stephen Hemminger [this message]
2016-02-24 7:15 ` Jiri Pirko
2016-02-22 18:31 ` [patch net-next 4/9] mlxsw: Implement " Jiri Pirko
2016-02-22 18:32 ` [patch net-next 5/9] mlxsw: core: Add devlink port splitter callbacks Jiri Pirko
2016-02-22 18:32 ` [patch net-next 6/9] mlxsw: spectrum: Unmap local port from module during teardown Jiri Pirko
2016-02-22 20:32 ` John Fastabend
2016-02-22 21:00 ` Ido Schimmel
2016-02-22 21:08 ` John Fastabend
2016-02-23 4:50 ` Andy Gospodarek
2016-02-22 18:32 ` [patch net-next 7/9] mlxsw: spectrum: Store local port to module mapping during init Jiri Pirko
2016-02-22 18:32 ` [patch net-next 8/9] mlxsw: spectrum: Mark unused ports using NULL Jiri Pirko
2016-02-22 18:32 ` [patch net-next 9/9] mlxsw: spectrum: Introduce port splitting Jiri Pirko
2016-02-23 5:12 ` [patch net-next 0/9] Introduce devlink interface and first drivers to use it Andy Gospodarek
2016-02-23 7:32 ` Jiri Pirko
2016-02-23 14:34 ` Andy Gospodarek
2016-02-23 14:45 ` Jiri Pirko
2016-02-23 15:55 ` Andy Gospodarek
2016-02-23 16:01 ` Jiri Pirko
2016-02-23 16:19 ` Andy Gospodarek
2016-02-23 16:23 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223093139.21303e16@samsung9 \
--to=stephen@networkplumber.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=eladr@mellanox.com \
--cc=eugenia@mellanox.com \
--cc=hadarh@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=ogerlitz@mellanox.com \
--cc=rami.rosen@intel.com \
--cc=roopa@cumulusnetworks.com \
--cc=sean.hefty@intel.com \
--cc=yishaih@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.