From: kbuild test robot <lkp@intel.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: kbuild-all@01.org, Rafael Wysocki <rjw@rjwysocki.net>,
Doug Smythies <dsmythies@telus.net>,
Stephane Gasparini <stephane.gasparini@linux.intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Dirk Brandewie <dirk.j.brandewie@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Linux-PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH 1/1] intel_pstate: Increase hold-off time before samples are scaled v2
Date: Tue, 23 Feb 2016 22:48:34 +0800 [thread overview]
Message-ID: <201602232203.ZpZW3dHN%fengguang.wu@intel.com> (raw)
In-Reply-To: <1456237784-17205-1-git-send-email-mgorman@techsingularity.net>
[-- Attachment #1: Type: text/plain, Size: 3436 bytes --]
Hi Mel,
[auto build test WARNING on pm/linux-next]
[also build test WARNING on next-20160223]
[cannot apply to v4.5-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Mel-Gorman/intel_pstate-Increase-hold-off-time-before-samples-are-scaled-v2/20160223-223212
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-x006-201608 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/cpufreq/intel_pstate.c: In function 'get_target_pstate_use_performance':
>> drivers/cpufreq/intel_pstate.c:957:49: warning: unused variable 'sample_ratio' [-Wunused-variable]
int32_t core_busy, max_pstate, current_pstate, sample_ratio;
^
vim +/sample_ratio +957 drivers/cpufreq/intel_pstate.c
63d1d656 Philippe Longepe 2015-12-04 941
63d1d656 Philippe Longepe 2015-12-04 942
e70eed2b Philippe Longepe 2015-12-04 943 /*
e70eed2b Philippe Longepe 2015-12-04 944 * The load can be estimated as the ratio of the mperf counter
e70eed2b Philippe Longepe 2015-12-04 945 * running at a constant frequency during active periods
e70eed2b Philippe Longepe 2015-12-04 946 * (C0) and the time stamp counter running at the same frequency
e70eed2b Philippe Longepe 2015-12-04 947 * also during C-states.
e70eed2b Philippe Longepe 2015-12-04 948 */
63d1d656 Philippe Longepe 2015-12-04 949 cpu_load = div64_u64(int_tofp(100) * mperf, sample->tsc);
e70eed2b Philippe Longepe 2015-12-04 950 cpu->sample.busy_scaled = cpu_load;
e70eed2b Philippe Longepe 2015-12-04 951
e70eed2b Philippe Longepe 2015-12-04 952 return cpu->pstate.current_pstate - pid_calc(&cpu->pid, cpu_load);
e70eed2b Philippe Longepe 2015-12-04 953 }
e70eed2b Philippe Longepe 2015-12-04 954
157386b6 Philippe Longepe 2015-12-04 955 static inline int32_t get_target_pstate_use_performance(struct cpudata *cpu)
93f0822d Dirk Brandewie 2013-02-06 956 {
c4ee841f Dirk Brandewie 2014-05-29 @957 int32_t core_busy, max_pstate, current_pstate, sample_ratio;
402c43ed Rafael J. Wysocki 2016-02-05 958 u64 duration_ns;
93f0822d Dirk Brandewie 2013-02-06 959
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 960 /*
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 961 * core_busy is the ratio of actual performance to max
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 962 * max_pstate is the max non turbo pstate available
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 963 * current_pstate was the pstate that was requested during
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 964 * the last sample period.
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 965 *
:::::: The code at line 957 was first introduced by commit
:::::: c4ee841f602e5eef8eab673295c49c5b49d7732b intel_pstate: add sample time scaling
:::::: TO: Dirk Brandewie <dirk.j.brandewie@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 23263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Rafael Wysocki <rjw@rjwysocki.net>,
Doug Smythies <dsmythies@telus.net>,
Stephane Gasparini <stephane.gasparini@linux.intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Dirk Brandewie <dirk.j.brandewie@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Linux-PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH 1/1] intel_pstate: Increase hold-off time before samples are scaled v2
Date: Tue, 23 Feb 2016 22:48:34 +0800 [thread overview]
Message-ID: <201602232203.ZpZW3dHN%fengguang.wu@intel.com> (raw)
In-Reply-To: <1456237784-17205-1-git-send-email-mgorman@techsingularity.net>
[-- Attachment #1: Type: text/plain, Size: 3436 bytes --]
Hi Mel,
[auto build test WARNING on pm/linux-next]
[also build test WARNING on next-20160223]
[cannot apply to v4.5-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Mel-Gorman/intel_pstate-Increase-hold-off-time-before-samples-are-scaled-v2/20160223-223212
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-x006-201608 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/cpufreq/intel_pstate.c: In function 'get_target_pstate_use_performance':
>> drivers/cpufreq/intel_pstate.c:957:49: warning: unused variable 'sample_ratio' [-Wunused-variable]
int32_t core_busy, max_pstate, current_pstate, sample_ratio;
^
vim +/sample_ratio +957 drivers/cpufreq/intel_pstate.c
63d1d656 Philippe Longepe 2015-12-04 941
63d1d656 Philippe Longepe 2015-12-04 942
e70eed2b Philippe Longepe 2015-12-04 943 /*
e70eed2b Philippe Longepe 2015-12-04 944 * The load can be estimated as the ratio of the mperf counter
e70eed2b Philippe Longepe 2015-12-04 945 * running at a constant frequency during active periods
e70eed2b Philippe Longepe 2015-12-04 946 * (C0) and the time stamp counter running at the same frequency
e70eed2b Philippe Longepe 2015-12-04 947 * also during C-states.
e70eed2b Philippe Longepe 2015-12-04 948 */
63d1d656 Philippe Longepe 2015-12-04 949 cpu_load = div64_u64(int_tofp(100) * mperf, sample->tsc);
e70eed2b Philippe Longepe 2015-12-04 950 cpu->sample.busy_scaled = cpu_load;
e70eed2b Philippe Longepe 2015-12-04 951
e70eed2b Philippe Longepe 2015-12-04 952 return cpu->pstate.current_pstate - pid_calc(&cpu->pid, cpu_load);
e70eed2b Philippe Longepe 2015-12-04 953 }
e70eed2b Philippe Longepe 2015-12-04 954
157386b6 Philippe Longepe 2015-12-04 955 static inline int32_t get_target_pstate_use_performance(struct cpudata *cpu)
93f0822d Dirk Brandewie 2013-02-06 956 {
c4ee841f Dirk Brandewie 2014-05-29 @957 int32_t core_busy, max_pstate, current_pstate, sample_ratio;
402c43ed Rafael J. Wysocki 2016-02-05 958 u64 duration_ns;
93f0822d Dirk Brandewie 2013-02-06 959
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 960 /*
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 961 * core_busy is the ratio of actual performance to max
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 962 * max_pstate is the max non turbo pstate available
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 963 * current_pstate was the pstate that was requested during
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 964 * the last sample period.
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 965 *
:::::: The code at line 957 was first introduced by commit
:::::: c4ee841f602e5eef8eab673295c49c5b49d7732b intel_pstate: add sample time scaling
:::::: TO: Dirk Brandewie <dirk.j.brandewie@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 23263 bytes --]
next prev parent reply other threads:[~2016-02-23 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:29 [PATCH 1/1] intel_pstate: Increase hold-off time before samples are scaled v2 Mel Gorman
2016-02-23 14:48 ` kbuild test robot [this message]
2016-02-23 14:48 ` kbuild test robot
2016-02-23 21:50 ` Srinivas Pandruvada
2016-02-24 9:03 ` Mel Gorman
2016-02-24 13:33 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201602232203.ZpZW3dHN%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=dirk.j.brandewie@intel.com \
--cc=dsmythies@telus.net \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stephane.gasparini@linux.intel.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.