[PATCH 0/7] clk: Make reset_control_ops const

[PATCH 0/7] clk: Make reset_control_ops const

[Philipp Zabel]

Since commit 203d4f347d86 ("reset: Make reset_control_ops const") marked
the ops pointer in struct reset_controller_dev as const, these structs
can be made const, too. The commit is currently sitting in the
arm-soc/for-next branch.

regards
Philipp

Philipp Zabel (7):
  clk: mediatek: Make reset_control_ops const
  clk: mmp: Make reset_control_ops const
  clk: rockchip: Make reset_control_ops const
  clk: atlas7: Make reset_control_ops const
  clk: sunxi: Make reset_control_ops const
  clk: tegra: Make reset_control_ops const
  clk: qcom: Make reset_control_ops const

 drivers/clk/mediatek/reset.c      | 2 +-
 drivers/clk/mmp/reset.c           | 2 +-
 drivers/clk/qcom/reset.c          | 2 +-
 drivers/clk/qcom/reset.h          | 2 +-
 drivers/clk/rockchip/softrst.c    | 2 +-
 drivers/clk/sirf/clk-atlas7.c     | 2 +-
 drivers/clk/sunxi/clk-a10-ve.c    | 2 +-
 drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
 drivers/clk/sunxi/clk-usb.c       | 2 +-
 drivers/clk/tegra/clk.c           | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.7.0

[PATCH 1/7] clk: mediatek: Make reset_control_ops const

[Philipp Zabel]

The mtk_reset_ops structure is never modified. Make it const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/mediatek/reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
index 9e9fe4b..309049d 100644
--- a/drivers/clk/mediatek/reset.c
+++ b/drivers/clk/mediatek/reset.c
@@ -57,7 +57,7 @@ static int mtk_reset(struct reset_controller_dev *rcdev,
 	return mtk_reset_deassert(rcdev, id);
 }
 
-static struct reset_control_ops mtk_reset_ops = {
+static const struct reset_control_ops mtk_reset_ops = {
 	.assert = mtk_reset_assert,
 	.deassert = mtk_reset_deassert,
 	.reset = mtk_reset,
-- 
2.7.0

Re: [PATCH 1/7] clk: mediatek: Make reset_control_ops const

[Matthias Brugger]

On 25/02/16 10:45, Philipp Zabel wrote:
> The mtk_reset_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>   drivers/clk/mediatek/reset.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
> index 9e9fe4b..309049d 100644
> --- a/drivers/clk/mediatek/reset.c
> +++ b/drivers/clk/mediatek/reset.c
> @@ -57,7 +57,7 @@ static int mtk_reset(struct reset_controller_dev *rcdev,
>   	return mtk_reset_deassert(rcdev, id);
>   }
>
> -static struct reset_control_ops mtk_reset_ops = {
> +static const struct reset_control_ops mtk_reset_ops = {
>   	.assert = mtk_reset_assert,
>   	.deassert = mtk_reset_deassert,
>   	.reset = mtk_reset,
>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Re: [PATCH 1/7] clk: mediatek: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The mtk_reset_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 2/7] clk: mmp: Make reset_control_ops const

[Philipp Zabel]

The mmp_clk_reset_ops structure is never modified. Make it const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/mmp/reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mmp/reset.c b/drivers/clk/mmp/reset.c
index b54da1f..b4e4d6a 100644
--- a/drivers/clk/mmp/reset.c
+++ b/drivers/clk/mmp/reset.c
@@ -74,7 +74,7 @@ static int mmp_clk_reset_deassert(struct reset_controller_dev *rcdev,
 	return 0;
 }
 
-static struct reset_control_ops mmp_clk_reset_ops = {
+static const struct reset_control_ops mmp_clk_reset_ops = {
 	.assert		= mmp_clk_reset_assert,
 	.deassert	= mmp_clk_reset_deassert,
 };
-- 
2.7.0

Re: [PATCH 2/7] clk: mmp: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The mmp_clk_reset_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 3/7] clk: rockchip: Make reset_control_ops const

[Philipp Zabel]

The rockchip_softrst_ops structure is never modified. Make it const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/rockchip/softrst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/rockchip/softrst.c b/drivers/clk/rockchip/softrst.c
index 552f7bb..21218987 100644
--- a/drivers/clk/rockchip/softrst.c
+++ b/drivers/clk/rockchip/softrst.c
@@ -81,7 +81,7 @@ static int rockchip_softrst_deassert(struct reset_controller_dev *rcdev,
 	return 0;
 }
 
-static struct reset_control_ops rockchip_softrst_ops = {
+static const struct reset_control_ops rockchip_softrst_ops = {
 	.assert		= rockchip_softrst_assert,
 	.deassert	= rockchip_softrst_deassert,
 };
-- 
2.7.0

Re: [PATCH 3/7] clk: rockchip: Make reset_control_ops const

[Heiko Stuebner]

Am Donnerstag, 25. Februar 2016, 10:45:08 schrieb Philipp Zabel:
> The rockchip_softrst_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

looks sane, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 3/7] clk: rockchip: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The rockchip_softrst_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 4/7] clk: atlas7: Make reset_control_ops const

[Philipp Zabel]

The atlas7_rst_ops structure is never modified. Make it const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/sirf/clk-atlas7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sirf/clk-atlas7.c b/drivers/clk/sirf/clk-atlas7.c
index 957aae6..d0c6c9a 100644
--- a/drivers/clk/sirf/clk-atlas7.c
+++ b/drivers/clk/sirf/clk-atlas7.c
@@ -1423,7 +1423,7 @@ static int atlas7_reset_module(struct reset_controller_dev *rcdev,
 	return 0;
 }
 
-static struct reset_control_ops atlas7_rst_ops = {
+static const struct reset_control_ops atlas7_rst_ops = {
 	.reset = atlas7_reset_module,
 };
 
-- 
2.7.0

Re: [PATCH 4/7] clk: atlas7: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The atlas7_rst_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 5/7] clk: sunxi: Make reset_control_ops const

[Philipp Zabel]

The sunxi_ve_reset_ops, sun9i_mmc_reset_ops, and sunxi_usb_reset_ops
structures are never modified. Make them const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/sunxi/clk-a10-ve.c    | 2 +-
 drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
 drivers/clk/sunxi/clk-usb.c       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/sunxi/clk-a10-ve.c b/drivers/clk/sunxi/clk-a10-ve.c
index 044c171..d9ea22e 100644
--- a/drivers/clk/sunxi/clk-a10-ve.c
+++ b/drivers/clk/sunxi/clk-a10-ve.c
@@ -85,7 +85,7 @@ static int sunxi_ve_of_xlate(struct reset_controller_dev *rcdev,
 	return 0;
 }
 
-static struct reset_control_ops sunxi_ve_reset_ops = {
+static const struct reset_control_ops sunxi_ve_reset_ops = {
 	.assert		= sunxi_ve_reset_assert,
 	.deassert	= sunxi_ve_reset_deassert,
 };
diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c
index a9b1761..028dd83 100644
--- a/drivers/clk/sunxi/clk-sun9i-mmc.c
+++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
@@ -83,7 +83,7 @@ static int sun9i_mmc_reset_deassert(struct reset_controller_dev *rcdev,
 	return 0;
 }
 
-static struct reset_control_ops sun9i_mmc_reset_ops = {
+static const struct reset_control_ops sun9i_mmc_reset_ops = {
 	.assert		= sun9i_mmc_reset_assert,
 	.deassert	= sun9i_mmc_reset_deassert,
 };
diff --git a/drivers/clk/sunxi/clk-usb.c b/drivers/clk/sunxi/clk-usb.c
index 67b8e38..4210260 100644
--- a/drivers/clk/sunxi/clk-usb.c
+++ b/drivers/clk/sunxi/clk-usb.c
@@ -76,7 +76,7 @@ static int sunxi_usb_reset_deassert(struct reset_controller_dev *rcdev,
 	return 0;
 }
 
-static struct reset_control_ops sunxi_usb_reset_ops = {
+static const struct reset_control_ops sunxi_usb_reset_ops = {
 	.assert		= sunxi_usb_reset_assert,
 	.deassert	= sunxi_usb_reset_deassert,
 };
-- 
2.7.0

Re: [PATCH 5/7] clk: sunxi: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The sunxi_ve_reset_ops, sun9i_mmc_reset_ops, and sunxi_usb_reset_ops
> structures are never modified. Make them const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 6/7] clk: tegra: Make reset_control_ops const

[Philipp Zabel]

The rst_ops structure is never modified. Make it const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/tegra/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
index 2a3a4fe..f60fe2e 100644
--- a/drivers/clk/tegra/clk.c
+++ b/drivers/clk/tegra/clk.c
@@ -271,7 +271,7 @@ void __init tegra_init_from_table(struct tegra_clk_init_table *tbl,
 	}
 }
 
-static struct reset_control_ops rst_ops = {
+static const struct reset_control_ops rst_ops = {
 	.assert = tegra_clk_rst_assert,
 	.deassert = tegra_clk_rst_deassert,
 };
-- 
2.7.0

Re: [PATCH 6/7] clk: tegra: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The rst_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 7/7] clk: qcom: Make reset_control_ops const

[Philipp Zabel]

The qcom_reset_ops structure is never modified. Make it const.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/clk/qcom/reset.c | 2 +-
 drivers/clk/qcom/reset.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/reset.c b/drivers/clk/qcom/reset.c
index 6c977d3..0324d8d 100644
--- a/drivers/clk/qcom/reset.c
+++ b/drivers/clk/qcom/reset.c
@@ -55,7 +55,7 @@ qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id)
 	return regmap_update_bits(rst->regmap, map->reg, mask, 0);
 }
 
-struct reset_control_ops qcom_reset_ops = {
+const struct reset_control_ops qcom_reset_ops = {
 	.reset = qcom_reset,
 	.assert = qcom_reset_assert,
 	.deassert = qcom_reset_deassert,
diff --git a/drivers/clk/qcom/reset.h b/drivers/clk/qcom/reset.h
index 0e11e21..cda8779 100644
--- a/drivers/clk/qcom/reset.h
+++ b/drivers/clk/qcom/reset.h
@@ -32,6 +32,6 @@ struct qcom_reset_controller {
 #define to_qcom_reset_controller(r) \
 	container_of(r, struct qcom_reset_controller, rcdev);
 
-extern struct reset_control_ops qcom_reset_ops;
+extern const struct reset_control_ops qcom_reset_ops;
 
 #endif
-- 
2.7.0

Re: [PATCH 7/7] clk: qcom: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> The qcom_reset_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 0/7] clk: Make reset_control_ops const

[Stephen Boyd]

On 02/25, Philipp Zabel wrote:
> Since commit 203d4f347d86 ("reset: Make reset_control_ops const") marked
> the ops pointer in struct reset_controller_dev as const, these structs
> can be made const, too. The commit is currently sitting in the
> arm-soc/for-next branch.
> 

All these patches look fine. I take it we have to wait for a
cycle to merge them though because the commit you mention is only
in the arm-soc tree? Or did you want to take them through arm-soc?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 0/7] clk: Make reset_control_ops const

[Philipp Zabel]

Am Donnerstag, den 25.02.2016, 13:04 -0800 schrieb Stephen Boyd:
> On 02/25, Philipp Zabel wrote:
> > Since commit 203d4f347d86 ("reset: Make reset_control_ops const") marked
> > the ops pointer in struct reset_controller_dev as const, these structs
> > can be made const, too. The commit is currently sitting in the
> > arm-soc/for-next branch.
> > 
> 
> All these patches look fine. I take it we have to wait for a
> cycle to merge them though because the commit you mention is only
> in the arm-soc tree?

Or you could merge commit 203d4f347d86 before applying them, which would
just pull in another minor reset patch on top of v4.5-rc1. Since this is
already merged as part of the reset-for-4.6 tag, these commits are
stable.

>  Or did you want to take them through arm-soc?

Not unless that was your preferred option.

regards
Philipp

Re: [PATCH 0/7] clk: Make reset_control_ops const

[Stephen Boyd]

On 02/26, Philipp Zabel wrote:
> Am Donnerstag, den 25.02.2016, 13:04 -0800 schrieb Stephen Boyd:
> > On 02/25, Philipp Zabel wrote:
> > > Since commit 203d4f347d86 ("reset: Make reset_control_ops const") marked
> > > the ops pointer in struct reset_controller_dev as const, these structs
> > > can be made const, too. The commit is currently sitting in the
> > > arm-soc/for-next branch.
> > > 
> > 
> > All these patches look fine. I take it we have to wait for a
> > cycle to merge them though because the commit you mention is only
> > in the arm-soc tree?
> 
> Or you could merge commit 203d4f347d86 before applying them, which would
> just pull in another minor reset patch on top of v4.5-rc1. Since this is
> already merged as part of the reset-for-4.6 tag, these commits are
> stable.
> 
> >  Or did you want to take them through arm-soc?
> 
> Not unless that was your preferred option.
> 

Ok I think we'll apply these after v4.6-rc1 is released. They're
so minor that we can send them in with the first batch of
clk-fixes before -rc2 is released.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 0/7] clk: Make reset_control_ops const

[Philipp Zabel]

Am Freitag, den 04.03.2016, 10:55 -0800 schrieb Stephen Boyd:
> Ok I think we'll apply these after v4.6-rc1 is released. They're
> so minor that we can send them in with the first batch of
> clk-fixes before -rc2 is released.

Ok, thank you.

regards
Philipp