All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: arnd@arndb.de, catalin.marinas@arm.com,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	linux-doc@vger.kernel.org, Prasun.Kapoor@caviumnetworks.com,
	pinskia@gmail.com, agraf@suse.de, broonie@kernel.org,
	joseph@codesourcery.com,
	christoph.muellner@theobroma-systems.com,
	Nathan_Lynch@mentor.com, klimov.linux@gmail.com,
	bamvor.zhangjian@huawei.com
Subject: Re: [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers
Date: Thu, 25 Feb 2016 23:20:47 +0100	[thread overview]
Message-ID: <20160225222047.GB5950@osiris> (raw)
In-Reply-To: <20160225202350.GB16123@yury-N73SV>

On Thu, Feb 25, 2016 at 11:23:50PM +0300, Yury Norov wrote:
> On Thu, Feb 25, 2016 at 09:51:40AM +0100, Heiko Carstens wrote:
> > On Wed, Feb 24, 2016 at 09:34:12PM +0300, Yury Norov wrote:
> > > diff --git a/include/linux/syscalls_structs.h b/include/linux/syscalls_structs.h
> > > new file mode 100644
> > > index 0000000..a920cbc
> > > --- /dev/null
> > > +++ b/include/linux/syscalls_structs.h
> > > @@ -0,0 +1,60 @@
> > > +#ifndef _LINUX_SYSCALL_STRUCTS_H
> > > +#define _LINUX_SYSCALL_STRUCTS_H
> > > +
> > > +struct epoll_event;
> > > +struct iattr;
> > > +struct inode;
> > > +struct iocb;
> > > +struct io_event;
> > > +struct iovec;
> > > +struct itimerspec;
> > > +struct itimerval;
> > 
> > This is not needed for s390, right? So might be worth a separate patch
> > which moves the forward declarations?
> 
> This patch also introduces __SC_WRAP, not needed as well. The idea of
> this patch is to introduce all the tricky machinery at once. If you
> think we need split it, I'm OK, but maybe it's enough to add more
> detailed description... What do you think?

Ok, I see. Then the only change I'd like to request is to update the
comment in front of the COMPAT_SYSCALL_WRAPx macro which talks about 33/31
bit pointer sizes. This doesn't make too much sense for common code :)

WARNING: multiple messages have this Message-ID (diff)
From: heiko.carstens@de.ibm.com (Heiko Carstens)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers
Date: Thu, 25 Feb 2016 23:20:47 +0100	[thread overview]
Message-ID: <20160225222047.GB5950@osiris> (raw)
In-Reply-To: <20160225202350.GB16123@yury-N73SV>

On Thu, Feb 25, 2016 at 11:23:50PM +0300, Yury Norov wrote:
> On Thu, Feb 25, 2016 at 09:51:40AM +0100, Heiko Carstens wrote:
> > On Wed, Feb 24, 2016 at 09:34:12PM +0300, Yury Norov wrote:
> > > diff --git a/include/linux/syscalls_structs.h b/include/linux/syscalls_structs.h
> > > new file mode 100644
> > > index 0000000..a920cbc
> > > --- /dev/null
> > > +++ b/include/linux/syscalls_structs.h
> > > @@ -0,0 +1,60 @@
> > > +#ifndef _LINUX_SYSCALL_STRUCTS_H
> > > +#define _LINUX_SYSCALL_STRUCTS_H
> > > +
> > > +struct epoll_event;
> > > +struct iattr;
> > > +struct inode;
> > > +struct iocb;
> > > +struct io_event;
> > > +struct iovec;
> > > +struct itimerspec;
> > > +struct itimerval;
> > 
> > This is not needed for s390, right? So might be worth a separate patch
> > which moves the forward declarations?
> 
> This patch also introduces __SC_WRAP, not needed as well. The idea of
> this patch is to introduce all the tricky machinery at once. If you
> think we need split it, I'm OK, but maybe it's enough to add more
> detailed description... What do you think?

Ok, I see. Then the only change I'd like to request is to update the
comment in front of the COMPAT_SYSCALL_WRAPx macro which talks about 33/31
bit pointer sizes. This doesn't make too much sense for common code :)

  reply	other threads:[~2016-02-25 22:20 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 18:34 [PATCH v2 0/5] all: s390: make compat wrappers the generic solution Yury Norov
2016-02-24 18:34 ` Yury Norov
2016-02-24 18:34 ` Yury Norov
2016-02-24 18:34 ` [PATCH 1/5] all: syscall wrappers: add documentation Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-24 18:34 ` [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390 Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-25  8:49   ` Heiko Carstens
2016-02-25  8:49     ` Heiko Carstens
2016-02-25 20:19     ` Yury Norov
2016-02-25 20:19       ` Yury Norov
2016-02-25 20:19       ` Yury Norov
2016-02-25 22:10       ` Heiko Carstens
2016-02-25 22:10         ` Heiko Carstens
2016-02-24 18:34 ` [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-25  8:51   ` Heiko Carstens
2016-02-25  8:51     ` Heiko Carstens
2016-02-25 20:23     ` Yury Norov
2016-02-25 20:23       ` Yury Norov
2016-02-25 20:23       ` Yury Norov
2016-02-25 22:20       ` Heiko Carstens [this message]
2016-02-25 22:20         ` Heiko Carstens
2016-02-24 18:34 ` [PATCH 4/5] all: s390: move compat_wrappers.c from arch/s390/kernel to kernel/ Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-25  8:52   ` Heiko Carstens
2016-02-25  8:52     ` Heiko Carstens
2016-02-25 20:27   ` Yury Norov
2016-02-25 20:27     ` Yury Norov
2016-02-25 20:27     ` Yury Norov
2016-02-24 18:34 ` [PATCH 5/5] all: wrap needed syscalls in generic unistd Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-24 18:34   ` Yury Norov
2016-02-25  8:54 ` [PATCH v2 0/5] all: s390: make compat wrappers the generic solution Heiko Carstens
2016-02-25  8:54   ` Heiko Carstens
2016-02-26 14:34 [PATCH v3 " Yury Norov
2016-02-26 14:34 ` [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers Yury Norov
2016-02-26 14:34   ` Yury Norov
2016-02-26 14:34   ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225222047.GB5950@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=Nathan_Lynch@mentor.com \
    --cc=Prasun.Kapoor@caviumnetworks.com \
    --cc=agraf@suse.de \
    --cc=arnd@arndb.de \
    --cc=bamvor.zhangjian@huawei.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=joseph@codesourcery.com \
    --cc=klimov.linux@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pinskia@gmail.com \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.