From: Josh Cartwright <joshc@ni.com>
To: Kuba Kicinski <kubakici@wp.pl>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sean Nyekj?r <sean.nyekjaer@prevas.dk>,
linux-serial@vger.kernel.org, linux-rt-users@vger.kernel.org,
Jon Ringle <jringle@gridpoint.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow
Date: Fri, 26 Feb 2016 13:00:48 -0600 [thread overview]
Message-ID: <20160226190048.GC12917@jcartwri.amer.corp.natinst.com> (raw)
In-Reply-To: <835668C1-5DDB-4495-AD00-4EE8DDD0D146@wp.pl>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Fri, Feb 26, 2016 at 01:26:27PM -0500, Kuba Kicinski wrote:
> On 26 February 2016 11:52:28 GMT-05:00, Josh Cartwright <joshc@ni.com> wrote:
[..]
> > Instead, the driver needs to implement it's own oneshot-like
> > handling at the device-level: in the registered irq handler, capture
> > triggered interrupt state, squelch/mask, and enqueue the
> > kthread_work. In the tail-end of the kthread_work, re-enable
> > interrupts at the device level.
>
> The problem there being IIRC that i2c doesn't provide async writes so
> we can't mask from irq callback. The only option would be
> disable_irq/enable_irq, right?
Ah, yes, that is a problem. If by disable_irq(), you mean
disable_irq_nosync(), then yes, I think that'd work.
Josh
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-26 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56CDCCE6.5020801@prevas.dk>
2016-02-24 17:39 ` sc16is7xx: a lot of time is spend in sc16is7xx_port_irq Sean Nyekjær
2016-02-24 17:39 ` Sean Nyekjær
2016-02-24 22:35 ` Josh Cartwright
2016-02-26 11:43 ` Sebastian Andrzej Siewior
2016-02-26 11:48 ` [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow Sebastian Andrzej Siewior
2016-02-26 14:34 ` Kuba Kicinski
2016-02-26 16:52 ` Josh Cartwright
2016-02-26 18:26 ` Kuba Kicinski
2016-02-26 19:00 ` Josh Cartwright [this message]
2016-03-07 16:41 ` Sebastian Andrzej Siewior
2016-03-07 16:58 ` Josh Cartwright
2016-03-07 17:22 ` Sean Nyekjær
2016-03-08 21:18 ` Jakub Kicinski
2016-03-09 7:03 ` Sean Nyekjær
2016-03-09 7:03 ` Sean Nyekjær
2016-03-09 11:13 ` Jakub Kicinski
2016-03-09 11:13 ` Jakub Kicinski
2016-03-09 12:04 ` Sebastian Andrzej Siewior
2016-03-09 14:06 Maarten Brock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226190048.GC12917@jcartwri.amer.corp.natinst.com \
--to=joshc@ni.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jringle@gridpoint.com \
--cc=kubakici@wp.pl \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sean.nyekjaer@prevas.dk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.