From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk> To: Jakub Kicinski <kubakici@wp.pl>, Josh Cartwright <joshc@ni.com> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <linux-serial@vger.kernel.org>, <linux-rt-users@vger.kernel.org>, Jon Ringle <jringle@gridpoint.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow Date: Wed, 9 Mar 2016 08:03:06 +0100 [thread overview] Message-ID: <56DFCAAA.3090807@prevas.dk> (raw) In-Reply-To: <20160308211845.57e9796a@laptop> On 2016-03-08 22:18, Jakub Kicinski wrote: > On Mon, 7 Mar 2016 10:58:09 -0600, Josh Cartwright wrote: >>> I got lost here. Where do we stand here now? >> I understood the comment from Kuba to mean that he would be implementing >> the disable_irq()/enable_irq() idea above to fix all the problems with >> this driver. >> >> Kuba- did I read that right? > I was hoping Sean or someone else would take up this task ;) Yes i could try :-) At least i have a working setup with the hardware. > > It should be a pretty simple patch. > > Kuba I not entirely sure what i have to do... - Reenable the ONE_SHOT - Disable irq when running in the loop, and enable when returning? - Implement threaded irq? /Sean
WARNING: multiple messages have this Message-ID (diff)
From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk> To: Jakub Kicinski <kubakici@wp.pl>, Josh Cartwright <joshc@ni.com> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-serial@vger.kernel.org, linux-rt-users@vger.kernel.org, Jon Ringle <jringle@gridpoint.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow Date: Wed, 9 Mar 2016 08:03:06 +0100 [thread overview] Message-ID: <56DFCAAA.3090807@prevas.dk> (raw) In-Reply-To: <20160308211845.57e9796a@laptop> On 2016-03-08 22:18, Jakub Kicinski wrote: > On Mon, 7 Mar 2016 10:58:09 -0600, Josh Cartwright wrote: >>> I got lost here. Where do we stand here now? >> I understood the comment from Kuba to mean that he would be implementing >> the disable_irq()/enable_irq() idea above to fix all the problems with >> this driver. >> >> Kuba- did I read that right? > I was hoping Sean or someone else would take up this task ;) Yes i could try :-) At least i have a working setup with the hardware. > > It should be a pretty simple patch. > > Kuba I not entirely sure what i have to do... - Reenable the ONE_SHOT - Disable irq when running in the loop, and enable when returning? - Implement threaded irq? /Sean
next prev parent reply other threads:[~2016-03-09 7:03 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <56CDCCE6.5020801@prevas.dk> 2016-02-24 17:39 ` sc16is7xx: a lot of time is spend in sc16is7xx_port_irq Sean Nyekjær 2016-02-24 17:39 ` Sean Nyekjær 2016-02-24 22:35 ` Josh Cartwright 2016-02-26 11:43 ` Sebastian Andrzej Siewior 2016-02-26 11:48 ` [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow Sebastian Andrzej Siewior 2016-02-26 14:34 ` Kuba Kicinski 2016-02-26 16:52 ` Josh Cartwright 2016-02-26 18:26 ` Kuba Kicinski 2016-02-26 19:00 ` Josh Cartwright 2016-03-07 16:41 ` Sebastian Andrzej Siewior 2016-03-07 16:58 ` Josh Cartwright 2016-03-07 17:22 ` Sean Nyekjær 2016-03-08 21:18 ` Jakub Kicinski 2016-03-09 7:03 ` Sean Nyekjær [this message] 2016-03-09 7:03 ` Sean Nyekjær 2016-03-09 11:13 ` Jakub Kicinski 2016-03-09 11:13 ` Jakub Kicinski 2016-03-09 12:04 ` Sebastian Andrzej Siewior 2016-03-09 14:06 Maarten Brock
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56DFCAAA.3090807@prevas.dk \ --to=sean.nyekjaer@prevas.dk \ --cc=bigeasy@linutronix.de \ --cc=gregkh@linuxfoundation.org \ --cc=joshc@ni.com \ --cc=jringle@gridpoint.com \ --cc=kubakici@wp.pl \ --cc=linux-rt-users@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.