From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sedat Dilek <sedat.dilek@gmail.com>,
Jiri Kosina <jikos@kernel.org>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Andy Lutomirski <luto@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@ti.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning
Date: Wed, 2 Mar 2016 11:35:35 -0500 [thread overview]
Message-ID: <20160302113535.6abe9a2c@gandalf.local.home> (raw)
In-Reply-To: <20160302162412.GI6357@twins.programming.kicks-ass.net>
On Wed, 2 Mar 2016 17:24:12 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Mar 02, 2016 at 04:53:36PM +0100, Sedat Dilek wrote:
> > ffffffff8110f570 <del_timer_sync>:
> > ffffffff8110f570: 55 push %rbp
> > ffffffff8110f571: 48 89 e5 mov %rsp,%rbp
> > ffffffff8110f574: 41 57 push %r15
> > ffffffff8110f576: 41 56 push %r14
> > ffffffff8110f578: 53 push %rbx
> > ffffffff8110f579: 48 83 ec 28 sub $0x28,%rsp
>
> stack offset is 0x28 bytes [*]
Actually, isn't it really 0x40 bytes? The stack pushed 3 words (8 bytes
each) before doing the subtract. 0x28 == 40 bytes, 3 * 8 = 24,
40 + 24 = 64 == 0x40.
>
> > ffffffff8110f57d: 48 89 fb mov %rdi,%rbx
> > ffffffff8110f580: e8 6b 6e 80 00 callq ffffffff819163f0 <mcount>
> > ffffffff8110f585: e8 66 6e 80 00 callq ffffffff819163f0 <mcount>
> > ffffffff8110f58a: e8 61 6e 80 00 callq ffffffff819163f0 <mcount>
> > ffffffff8110f58f: e8 5c 6e 80 00 callq ffffffff819163f0 <mcount>
>
> Your compiler is on drugs!
Totally agree!
[..]
>
> > ffffffff8110f5fd: 4c 89 75 d0 mov %r14,-0x30(%rbp)
> > ffffffff8110f601: ff 75 d0 pushq -0x30(%rbp)
> > ffffffff8110f604: 9d popfq
>
> put r14 into -0x30(rbp) and pushes/pops that, see [*] this is 8 bytes
> over stack ?!
But from rbp, the stack is 0x40 bytes. This may be fine.
-- Steve
next prev parent reply other threads:[~2016-03-02 16:35 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 8:10 [PATCH] usbhid: Fix lockdep unannotated irqs-off warning Sedat Dilek
2015-09-28 11:33 ` Jiri Kosina
2015-09-29 8:40 ` Sedat Dilek
2015-09-29 9:27 ` Jiri Kosina
2015-09-29 18:54 ` Sedat Dilek
2015-09-29 19:08 ` Steven Rostedt
2015-09-29 19:32 ` Sedat Dilek
[not found] ` <CA+icZUWH2vR_vpYu4hCS578U3ssmoiF0pLYUfM-Xo-57e8uN=g@mail.gmail.com>
2015-09-30 6:41 ` Sedat Dilek
2015-09-30 8:50 ` Steven Rostedt
2015-09-30 7:35 ` Jiri Kosina
2015-09-30 8:56 ` Steven Rostedt
2015-09-30 9:46 ` Sedat Dilek
2015-09-30 10:13 ` Steven Rostedt
2015-09-30 10:39 ` Sedat Dilek
[not found] ` <CA+icZUXSzScTmMgLZwPQq9RMH9cUsD5_iDxKTVuG0rrGqH-8Cw@mail.gmail.com>
2015-10-01 2:01 ` Steven Rostedt
2015-10-01 5:34 ` Sedat Dilek
2015-10-01 6:05 ` Sedat Dilek
[not found] ` <CA+icZUUyaHqHP2v52juhGhoTNS9xX7LT2YxkOppLz6f9Z+FBEA@mail.gmail.com>
[not found] ` <CA+icZUWagGMVNs5gBPRBhYO0LsY2A1hK3KSLabp9ZpDVOTmtig@mail.gmail.com>
2015-10-13 0:57 ` Steven Rostedt
2016-03-01 10:05 ` Sedat Dilek
2016-03-01 15:07 ` Steven Rostedt
2016-03-01 15:17 ` Peter Zijlstra
2016-03-02 15:00 ` Sedat Dilek
2016-03-02 15:17 ` Peter Zijlstra
2016-03-02 15:34 ` Sedat Dilek
2016-03-02 15:53 ` Sedat Dilek
2016-03-02 15:56 ` Steven Rostedt
2016-03-02 16:08 ` Sedat Dilek
2016-03-02 16:11 ` Sedat Dilek
2016-03-02 16:21 ` Sedat Dilek
2016-03-02 16:24 ` Peter Zijlstra
2016-03-02 16:35 ` Steven Rostedt [this message]
2016-03-02 16:42 ` Peter Zijlstra
2016-03-02 16:42 ` Sedat Dilek
2016-03-02 16:52 ` Sedat Dilek
2016-03-01 15:59 ` Alan Stern
2016-03-02 6:25 ` Sedat Dilek
2016-03-04 16:04 ` Alan Stern
2016-03-05 22:30 ` Sedat Dilek
2016-03-06 8:51 ` Sedat Dilek
2016-03-06 17:23 ` Alan Stern
2016-03-02 6:36 ` Sedat Dilek
2016-03-02 8:34 ` Sedat Dilek
2016-03-02 8:37 ` Jiri Kosina
2016-03-02 9:11 ` Sedat Dilek
[not found] ` <CA+icZUX3tJvRor6CbOZFBecTAUZzyWzjLzJSEdb3c12yKRAT3g@mail.gmail.com>
2015-09-29 13:13 ` Steven Rostedt
2016-03-07 15:59 Sedat Dilek
2016-03-07 16:28 ` Sedat Dilek
2016-03-07 16:41 ` Alan Stern
2016-03-07 17:03 ` Steven Rostedt
2016-03-07 17:05 ` Jiri Kosina
2016-03-07 17:15 ` Sedat Dilek
2016-03-07 17:27 ` David Laight
2016-03-07 18:07 ` Alan Stern
2016-03-07 18:30 ` Linus Torvalds
2016-06-27 19:50 ` Sedat Dilek
2016-06-27 20:03 ` Sedat Dilek
2016-06-27 20:14 ` Linus Torvalds
2016-06-27 20:27 ` Sedat Dilek
2016-06-27 20:36 ` Linus Torvalds
2016-03-07 17:11 ` Steven Rostedt
2016-03-07 17:18 ` Sedat Dilek
2016-03-07 17:24 ` Jiri Kosina
2016-03-07 17:30 ` Steven Rostedt
2016-03-07 18:04 ` Andy Lutomirski
2016-03-07 19:10 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302113535.6abe9a2c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=balbi@ti.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sedat.dilek@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.