* [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-03 10:02 ` Jan Stancek
0 siblings, 0 replies; 16+ messages in thread
From: Jan Stancek @ 2016-03-03 10:02 UTC (permalink / raw)
To: linux-mm
Cc: linux-kernel, akpm, n-horiguchi, mike.kravetz, hillf.zj,
kirill.shutemov, dave.hansen, paul.gortmaker, jstancek
Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
this value is propagated to userspace. EOPNOTSUPP is part of uapi
and is widely supported by libc libraries.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
mm/hugetlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 01f2b48c8618..851a29928a99 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy,
int ret;
if (!hugepages_supported())
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
table->data = &tmp;
table->maxlen = sizeof(unsigned long);
@@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write,
int ret;
if (!hugepages_supported())
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
tmp = h->nr_overcommit_huge_pages;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-03 10:02 ` Jan Stancek
0 siblings, 0 replies; 16+ messages in thread
From: Jan Stancek @ 2016-03-03 10:02 UTC (permalink / raw)
To: linux-mm
Cc: linux-kernel, akpm, n-horiguchi, mike.kravetz, hillf.zj,
kirill.shutemov, dave.hansen, paul.gortmaker, jstancek
Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
this value is propagated to userspace. EOPNOTSUPP is part of uapi
and is widely supported by libc libraries.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
mm/hugetlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 01f2b48c8618..851a29928a99 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy,
int ret;
if (!hugepages_supported())
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
table->data = &tmp;
table->maxlen = sizeof(unsigned long);
@@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write,
int ret;
if (!hugepages_supported())
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
tmp = h->nr_overcommit_huge_pages;
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-03 10:02 ` Jan Stancek
@ 2016-03-03 10:54 ` Kirill A. Shutemov
-1 siblings, 0 replies; 16+ messages in thread
From: Kirill A. Shutemov @ 2016-03-03 10:54 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, akpm, n-horiguchi, mike.kravetz,
hillf.zj, kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, Mar 03, 2016 at 11:02:51AM +0100, Jan Stancek wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/hugetlb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 01f2b48c8618..851a29928a99 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> table->data = &tmp;
> table->maxlen = sizeof(unsigned long);
> @@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> tmp = h->nr_overcommit_huge_pages;
>
> --
> 1.8.3.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-03 10:54 ` Kirill A. Shutemov
0 siblings, 0 replies; 16+ messages in thread
From: Kirill A. Shutemov @ 2016-03-03 10:54 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, akpm, n-horiguchi, mike.kravetz,
hillf.zj, kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, Mar 03, 2016 at 11:02:51AM +0100, Jan Stancek wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/hugetlb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 01f2b48c8618..851a29928a99 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> table->data = &tmp;
> table->maxlen = sizeof(unsigned long);
> @@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> tmp = h->nr_overcommit_huge_pages;
>
> --
> 1.8.3.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-03 10:02 ` Jan Stancek
@ 2016-03-03 23:05 ` Naoya Horiguchi
-1 siblings, 0 replies; 16+ messages in thread
From: Naoya Horiguchi @ 2016-03-03 23:05 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, akpm, mike.kravetz, hillf.zj,
kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, Mar 03, 2016 at 11:02:51AM +0100, Jan Stancek wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> mm/hugetlb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 01f2b48c8618..851a29928a99 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> table->data = &tmp;
> table->maxlen = sizeof(unsigned long);
> @@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> tmp = h->nr_overcommit_huge_pages;
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-03 23:05 ` Naoya Horiguchi
0 siblings, 0 replies; 16+ messages in thread
From: Naoya Horiguchi @ 2016-03-03 23:05 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, akpm, mike.kravetz, hillf.zj,
kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, Mar 03, 2016 at 11:02:51AM +0100, Jan Stancek wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> mm/hugetlb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 01f2b48c8618..851a29928a99 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> table->data = &tmp;
> table->maxlen = sizeof(unsigned long);
> @@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write,
> int ret;
>
> if (!hugepages_supported())
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> tmp = h->nr_overcommit_huge_pages;
>
> --
> 1.8.3.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-03 10:02 ` Jan Stancek
@ 2016-03-04 21:38 ` Andrew Morton
-1 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2016-03-04 21:38 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, n-horiguchi, mike.kravetz, hillf.zj,
kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, 3 Mar 2016 11:02:51 +0100 Jan Stancek <jstancek@redhat.com> wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
hm, what is the actual user-visible effect of this change? Does it fix
some misbehaviour?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-04 21:38 ` Andrew Morton
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2016-03-04 21:38 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, n-horiguchi, mike.kravetz, hillf.zj,
kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, 3 Mar 2016 11:02:51 +0100 Jan Stancek <jstancek@redhat.com> wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
hm, what is the actual user-visible effect of this change? Does it fix
some misbehaviour?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-04 21:38 ` Andrew Morton
@ 2016-03-05 8:09 ` Jan Stancek
-1 siblings, 0 replies; 16+ messages in thread
From: Jan Stancek @ 2016-03-05 8:09 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, linux-kernel, n-horiguchi, mike kravetz, hillf zj,
kirill shutemov, dave hansen, paul gortmaker
----- Original Message -----
> From: "Andrew Morton" <akpm@linux-foundation.org>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, "mike kravetz"
> <mike.kravetz@oracle.com>, "hillf zj" <hillf.zj@alibaba-inc.com>, "kirill shutemov"
> <kirill.shutemov@linux.intel.com>, "dave hansen" <dave.hansen@linux.intel.com>, "paul gortmaker"
> <paul.gortmaker@windriver.com>
> Sent: Friday, 4 March, 2016 10:38:07 PM
> Subject: Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
>
> On Thu, 3 Mar 2016 11:02:51 +0100 Jan Stancek <jstancek@redhat.com> wrote:
>
> > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > and is widely supported by libc libraries.
>
> hm, what is the actual user-visible effect of this change? Does it fix
> some misbehaviour?
>
It gives nicer message to user, rather than:
# cat /proc/sys/vm/nr_hugepages
cat: /proc/sys/vm/nr_hugepages: Unknown error 524
And also LTP's proc01 test was failing because this ret code (524)
was unexpected:
proc01 1 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages: errno=???(524): Unknown error 524
proc01 2 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages_mempolicy: errno=???(524): Unknown error 524
proc01 3 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_overcommit_hugepages: errno=???(524): Unknown error 524
Regards,
Jan
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-05 8:09 ` Jan Stancek
0 siblings, 0 replies; 16+ messages in thread
From: Jan Stancek @ 2016-03-05 8:09 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, linux-kernel, n-horiguchi, mike kravetz, hillf zj,
kirill shutemov, dave hansen, paul gortmaker
----- Original Message -----
> From: "Andrew Morton" <akpm@linux-foundation.org>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, "mike kravetz"
> <mike.kravetz@oracle.com>, "hillf zj" <hillf.zj@alibaba-inc.com>, "kirill shutemov"
> <kirill.shutemov@linux.intel.com>, "dave hansen" <dave.hansen@linux.intel.com>, "paul gortmaker"
> <paul.gortmaker@windriver.com>
> Sent: Friday, 4 March, 2016 10:38:07 PM
> Subject: Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
>
> On Thu, 3 Mar 2016 11:02:51 +0100 Jan Stancek <jstancek@redhat.com> wrote:
>
> > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > and is widely supported by libc libraries.
>
> hm, what is the actual user-visible effect of this change? Does it fix
> some misbehaviour?
>
It gives nicer message to user, rather than:
# cat /proc/sys/vm/nr_hugepages
cat: /proc/sys/vm/nr_hugepages: Unknown error 524
And also LTP's proc01 test was failing because this ret code (524)
was unexpected:
proc01 1 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages: errno=???(524): Unknown error 524
proc01 2 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages_mempolicy: errno=???(524): Unknown error 524
proc01 3 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_overcommit_hugepages: errno=???(524): Unknown error 524
Regards,
Jan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-03 10:02 ` Jan Stancek
@ 2016-03-07 22:18 ` David Rientjes
-1 siblings, 0 replies; 16+ messages in thread
From: David Rientjes @ 2016-03-07 22:18 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, akpm, n-horiguchi, mike.kravetz,
hillf.zj, kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, 3 Mar 2016, Jan Stancek wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-07 22:18 ` David Rientjes
0 siblings, 0 replies; 16+ messages in thread
From: David Rientjes @ 2016-03-07 22:18 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, akpm, n-horiguchi, mike.kravetz,
hillf.zj, kirill.shutemov, dave.hansen, paul.gortmaker
On Thu, 3 Mar 2016, Jan Stancek wrote:
> Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> this value is propagated to userspace. EOPNOTSUPP is part of uapi
> and is widely supported by libc libraries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-05 8:09 ` Jan Stancek
@ 2016-03-08 0:03 ` Andrew Morton
-1 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2016-03-08 0:03 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, n-horiguchi, mike kravetz, hillf zj,
kirill shutemov, dave hansen, paul gortmaker
On Sat, 5 Mar 2016 03:09:50 -0500 (EST) Jan Stancek <jstancek@redhat.com> wrote:
> > > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > > and is widely supported by libc libraries.
> >
> > hm, what is the actual user-visible effect of this change? Does it fix
> > some misbehaviour?
> >
>
> It gives nicer message to user, rather than:
> # cat /proc/sys/vm/nr_hugepages
> cat: /proc/sys/vm/nr_hugepages: Unknown error 524
>
> And also LTP's proc01 test was failing because this ret code (524)
> was unexpected:
> proc01 1 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages: errno=???(524): Unknown error 524
> proc01 2 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages_mempolicy: errno=???(524): Unknown error 524
> proc01 3 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_overcommit_hugepages: errno=???(524): Unknown error 524
>
Ah, OK, thanks. "Unknown error 524" is rather rude. I'll queue this
for 4.5.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-08 0:03 ` Andrew Morton
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2016-03-08 0:03 UTC (permalink / raw)
To: Jan Stancek
Cc: linux-mm, linux-kernel, n-horiguchi, mike kravetz, hillf zj,
kirill shutemov, dave hansen, paul gortmaker
On Sat, 5 Mar 2016 03:09:50 -0500 (EST) Jan Stancek <jstancek@redhat.com> wrote:
> > > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > > and is widely supported by libc libraries.
> >
> > hm, what is the actual user-visible effect of this change? Does it fix
> > some misbehaviour?
> >
>
> It gives nicer message to user, rather than:
> # cat /proc/sys/vm/nr_hugepages
> cat: /proc/sys/vm/nr_hugepages: Unknown error 524
>
> And also LTP's proc01 test was failing because this ret code (524)
> was unexpected:
> proc01 1 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages: errno=???(524): Unknown error 524
> proc01 2 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages_mempolicy: errno=???(524): Unknown error 524
> proc01 3 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_overcommit_hugepages: errno=???(524): Unknown error 524
>
Ah, OK, thanks. "Unknown error 524" is rather rude. I'll queue this
for 4.5.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
2016-03-07 22:18 ` David Rientjes
@ 2016-03-08 3:00 ` Hillf Danton
-1 siblings, 0 replies; 16+ messages in thread
From: Hillf Danton @ 2016-03-08 3:00 UTC (permalink / raw)
To: 'David Rientjes', 'Jan Stancek'
Cc: linux-mm, linux-kernel, akpm, n-horiguchi, mike.kravetz,
kirill.shutemov, dave.hansen, paul.gortmaker
>
> On Thu, 3 Mar 2016, Jan Stancek wrote:
>
> > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > and is widely supported by libc libraries.
> >
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > Cc: Mike Kravetz <mike.kravetz@oracle.com>
> > Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
@ 2016-03-08 3:00 ` Hillf Danton
0 siblings, 0 replies; 16+ messages in thread
From: Hillf Danton @ 2016-03-08 3:00 UTC (permalink / raw)
To: 'David Rientjes', 'Jan Stancek'
Cc: linux-mm, linux-kernel, akpm, n-horiguchi, mike.kravetz,
kirill.shutemov, dave.hansen, paul.gortmaker
>
> On Thu, 3 Mar 2016, Jan Stancek wrote:
>
> > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > and is widely supported by libc libraries.
> >
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > Cc: Mike Kravetz <mike.kravetz@oracle.com>
> > Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-03-08 3:08 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-03 10:02 [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers Jan Stancek
2016-03-03 10:02 ` Jan Stancek
2016-03-03 10:54 ` Kirill A. Shutemov
2016-03-03 10:54 ` Kirill A. Shutemov
2016-03-03 23:05 ` Naoya Horiguchi
2016-03-03 23:05 ` Naoya Horiguchi
2016-03-04 21:38 ` Andrew Morton
2016-03-04 21:38 ` Andrew Morton
2016-03-05 8:09 ` Jan Stancek
2016-03-05 8:09 ` Jan Stancek
2016-03-08 0:03 ` Andrew Morton
2016-03-08 0:03 ` Andrew Morton
2016-03-07 22:18 ` David Rientjes
2016-03-07 22:18 ` David Rientjes
2016-03-08 3:00 ` Hillf Danton
2016-03-08 3:00 ` Hillf Danton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.