[Buildroot] [PATCH 1/1] package/kbd: fix not installing to the target

[Buildroot] [PATCH 1/1] package/kbd: fix not installing to the target

[Martin Bark]

Commit https://git.busybox.net/buildroot/commit/?id=9f81bad fixed a build
error in kbd but unfortunately it broke the target install rule so that
nothing is being installed.

Move setting KBD_INSTALL_TARGET_OPTS after $(eval $(autotools-package))
so that it is set correctly and now installs to the target again.

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Martin Bark <martin@barkynet.com>
---
 package/kbd/kbd.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/kbd/kbd.mk b/package/kbd/kbd.mk
index 9dabce1..9d959cf 100644
--- a/package/kbd/kbd.mk
+++ b/package/kbd/kbd.mk
@@ -17,6 +17,6 @@ KBD_LICENSE = GPLv2+
 KBD_LICENSE_FILES = COPYING
 KBD_AUTORECONF = YES
 
-KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs
-
 $(eval $(autotools-package))
+
+KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs
-- 
2.7.1

[Buildroot] [PATCH 1/1] package/kbd: fix not installing to the target

[Thomas Petazzoni]

Dear Martin Bark,

On Fri,  4 Mar 2016 17:16:35 +0000, Martin Bark wrote:

> -KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs
> -
>  $(eval $(autotools-package))
> +
> +KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs

I know this solution is also used in the util-linux package, but in
fact I don't really like it. Can you try using

KBD_MAKE_ENV = \
	MKINSTALLDIRS=...

(before the eval of autotools-package) ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] package/kbd: fix not installing to the target

[Martin Bark]

Thomas,

On 4 March 2016 at 20:22, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Martin Bark,
>
> On Fri,  4 Mar 2016 17:16:35 +0000, Martin Bark wrote:
>
>> -KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs
>> -
>>  $(eval $(autotools-package))
>> +
>> +KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs
>
> I know this solution is also used in the util-linux package, but in
> fact I don't really like it. Can you try using
>
> KBD_MAKE_ENV = \
>         MKINSTALLDIRS=...
>
> (before the eval of autotools-package) ?

I've made the change you suggested, see
http://patchwork.ozlabs.org/patch/592898/

Thanks

Martin

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com