* [U-Boot] [PATCH] dm: omap_timer: Fix conversion of address to a pointer
@ 2016-03-05 11:10 Lokesh Vutla
2016-03-07 23:38 ` Tom Rini
2016-03-15 11:59 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Lokesh Vutla @ 2016-03-05 11:10 UTC (permalink / raw)
To: u-boot
OMAP timer driver directly typecasts fdt_addr_t to a pointer. This is
not strictly correct, as it gives a build warning when fdt_addr_t is u64.
So, use map_physmem for a proper typecasts.
This is inspired by commit 167efe01bc5a9 ("dm: ns16550: Use an address
instead of a pointer for the uart base")
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
drivers/timer/omap-timer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/timer/omap-timer.c b/drivers/timer/omap-timer.c
index 3bb38c5..7422e0a 100644
--- a/drivers/timer/omap-timer.c
+++ b/drivers/timer/omap-timer.c
@@ -79,7 +79,8 @@ static int omap_timer_ofdata_to_platdata(struct udevice *dev)
{
struct omap_timer_priv *priv = dev_get_priv(dev);
- priv->regs = (struct omap_gptimer_regs *)dev_get_addr(dev);
+ priv->regs = map_physmem(dev_get_addr(dev),
+ sizeof(struct omap_gptimer_regs), MAP_NOCACHE);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dm: omap_timer: Fix conversion of address to a pointer
2016-03-05 11:10 [U-Boot] [PATCH] dm: omap_timer: Fix conversion of address to a pointer Lokesh Vutla
@ 2016-03-07 23:38 ` Tom Rini
2016-03-15 11:59 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-03-07 23:38 UTC (permalink / raw)
To: u-boot
On Sat, Mar 05, 2016 at 04:40:32PM +0530, Lokesh Vutla wrote:
> OMAP timer driver directly typecasts fdt_addr_t to a pointer. This is
> not strictly correct, as it gives a build warning when fdt_addr_t is u64.
> So, use map_physmem for a proper typecasts.
>
> This is inspired by commit 167efe01bc5a9 ("dm: ns16550: Use an address
> instead of a pointer for the uart base")
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160307/a303caf0/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] dm: omap_timer: Fix conversion of address to a pointer
2016-03-05 11:10 [U-Boot] [PATCH] dm: omap_timer: Fix conversion of address to a pointer Lokesh Vutla
2016-03-07 23:38 ` Tom Rini
@ 2016-03-15 11:59 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-03-15 11:59 UTC (permalink / raw)
To: u-boot
On Sat, Mar 05, 2016 at 04:40:32PM +0530, Lokesh Vutla wrote:
> OMAP timer driver directly typecasts fdt_addr_t to a pointer. This is
> not strictly correct, as it gives a build warning when fdt_addr_t is u64.
> So, use map_physmem for a proper typecasts.
>
> This is inspired by commit 167efe01bc5a9 ("dm: ns16550: Use an address
> instead of a pointer for the uart base")
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160315/a08c09d4/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-15 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-05 11:10 [U-Boot] [PATCH] dm: omap_timer: Fix conversion of address to a pointer Lokesh Vutla
2016-03-07 23:38 ` Tom Rini
2016-03-15 11:59 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.