* [PATCH] Input: synaptics-rmi4: Remove check of Non-NULL array
@ 2016-03-15 0:35 ` Andrew Duggan
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Duggan @ 2016-03-15 0:35 UTC (permalink / raw)
To: linux-input, linux-kernel; +Cc: Andrew Duggan, Dmitry Torokhov, Dan Carpenter
Originally the irq_mask member of rmi_function was a pointer. Then it was
switched to being a zero length array. However, the checks for a NULL
pointer where not removed.
Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
drivers/input/rmi4/rmi_driver.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index da38f0a..faa295e 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -126,7 +126,7 @@ static void process_one_interrupt(struct rmi_driver_data *data,
return;
fh = to_rmi_function_handler(fn->dev.driver);
- if (fn->irq_mask && fh->attention) {
+ if (fh->attention) {
bitmap_and(data->fn_irq_bits, data->irq_status, fn->irq_mask,
data->irq_count);
if (!bitmap_empty(data->fn_irq_bits, data->irq_count))
@@ -172,8 +172,7 @@ int rmi_process_interrupt_requests(struct rmi_device *rmi_dev)
* use irq_chip.
*/
list_for_each_entry(entry, &data->function_list, node)
- if (entry->irq_mask)
- process_one_interrupt(data, entry);
+ process_one_interrupt(data, entry);
if (data->input)
input_sync(data->input);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Input: synaptics-rmi4: Remove check of Non-NULL array
@ 2016-03-15 0:35 ` Andrew Duggan
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Duggan @ 2016-03-15 0:35 UTC (permalink / raw)
To: linux-input, linux-kernel; +Cc: Andrew Duggan, Dmitry Torokhov, Dan Carpenter
Originally the irq_mask member of rmi_function was a pointer. Then it was
switched to being a zero length array. However, the checks for a NULL
pointer where not removed.
Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
drivers/input/rmi4/rmi_driver.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index da38f0a..faa295e 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -126,7 +126,7 @@ static void process_one_interrupt(struct rmi_driver_data *data,
return;
fh = to_rmi_function_handler(fn->dev.driver);
- if (fn->irq_mask && fh->attention) {
+ if (fh->attention) {
bitmap_and(data->fn_irq_bits, data->irq_status, fn->irq_mask,
data->irq_count);
if (!bitmap_empty(data->fn_irq_bits, data->irq_count))
@@ -172,8 +172,7 @@ int rmi_process_interrupt_requests(struct rmi_device *rmi_dev)
* use irq_chip.
*/
list_for_each_entry(entry, &data->function_list, node)
- if (entry->irq_mask)
- process_one_interrupt(data, entry);
+ process_one_interrupt(data, entry);
if (data->input)
input_sync(data->input);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4: Remove check of Non-NULL array
2016-03-15 0:35 ` Andrew Duggan
(?)
@ 2016-03-18 0:10 ` Dmitry Torokhov
-1 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2016-03-18 0:10 UTC (permalink / raw)
To: Andrew Duggan; +Cc: linux-input, linux-kernel, Dan Carpenter
On Mon, Mar 14, 2016 at 05:35:01PM -0700, Andrew Duggan wrote:
> Originally the irq_mask member of rmi_function was a pointer. Then it was
> switched to being a zero length array. However, the checks for a NULL
> pointer where not removed.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
> index da38f0a..faa295e 100644
> --- a/drivers/input/rmi4/rmi_driver.c
> +++ b/drivers/input/rmi4/rmi_driver.c
> @@ -126,7 +126,7 @@ static void process_one_interrupt(struct rmi_driver_data *data,
> return;
>
> fh = to_rmi_function_handler(fn->dev.driver);
> - if (fn->irq_mask && fh->attention) {
> + if (fh->attention) {
> bitmap_and(data->fn_irq_bits, data->irq_status, fn->irq_mask,
> data->irq_count);
> if (!bitmap_empty(data->fn_irq_bits, data->irq_count))
> @@ -172,8 +172,7 @@ int rmi_process_interrupt_requests(struct rmi_device *rmi_dev)
> * use irq_chip.
> */
> list_for_each_entry(entry, &data->function_list, node)
> - if (entry->irq_mask)
> - process_one_interrupt(data, entry);
> + process_one_interrupt(data, entry);
>
> if (data->input)
> input_sync(data->input);
> --
> 2.5.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-18 0:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 0:35 [PATCH] Input: synaptics-rmi4: Remove check of Non-NULL array Andrew Duggan
2016-03-15 0:35 ` Andrew Duggan
2016-03-18 0:10 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.