From: Borislav Petkov <bp@alien8.de>
To: Joerg Roedel <joro@8bytes.org>
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de,
vw@iommu.org, labbott@redhat.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header
Date: Fri, 18 Mar 2016 12:33:44 +0100 [thread overview]
Message-ID: <20160318113344.GE7817@pd.tnic> (raw)
In-Reply-To: <20160318111100.GG2195@8bytes.org>
On Fri, Mar 18, 2016 at 12:11:01PM +0100, Joerg Roedel wrote:
> On Fri, Mar 18, 2016 at 11:39:18AM +0100, Borislav Petkov wrote:
> > Yeah, so arch/x86/include/asm/ has all the x86-specific stuff which is
> > not exported to userspace, so moving stuff there makes sense to me.
>
> While the AMD IOMMU is only available on x86 today, there is nothing
> x86-specific in its architecture, so I don't think its header files
> belong to arch/x86.
>
> By that reasoning we could also move all of the intel gpu stuff to
> arch/x86. But we don't do it, because it doesn't make sense and because
> it doesn't belong there.
And according to that argument of yours, we should move everything
which is not too close to the arch it is being used on, to generic
include/linux/. Because it might possibly get used some day by other
arches. Yeah right.
And looking at include/linux - it looks like a dumping ground for
headers. :-\
I guess anything is better than putting non-generic enough stuff in
include/linux/. Maybe drivers/include or something in that direction
would be better...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
andihartmann-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header
Date: Fri, 18 Mar 2016 12:33:44 +0100 [thread overview]
Message-ID: <20160318113344.GE7817@pd.tnic> (raw)
In-Reply-To: <20160318111100.GG2195-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On Fri, Mar 18, 2016 at 12:11:01PM +0100, Joerg Roedel wrote:
> On Fri, Mar 18, 2016 at 11:39:18AM +0100, Borislav Petkov wrote:
> > Yeah, so arch/x86/include/asm/ has all the x86-specific stuff which is
> > not exported to userspace, so moving stuff there makes sense to me.
>
> While the AMD IOMMU is only available on x86 today, there is nothing
> x86-specific in its architecture, so I don't think its header files
> belong to arch/x86.
>
> By that reasoning we could also move all of the intel gpu stuff to
> arch/x86. But we don't do it, because it doesn't make sense and because
> it doesn't belong there.
And according to that argument of yours, we should move everything
which is not too close to the arch it is being used on, to generic
include/linux/. Because it might possibly get used some day by other
arches. Yeah right.
And looking at include/linux - it looks like a dumping ground for
headers. :-\
I guess anything is better than putting non-generic enough stuff in
include/linux/. Maybe drivers/include or something in that direction
would be better...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-03-18 11:33 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:12 [PATCH V5 00/10] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 01/10] perf/amd/iommu: Misc fix up perf_iommu_read Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-03-12 13:22 ` Peter Zijlstra
2016-03-12 13:22 ` Peter Zijlstra
2016-03-14 5:26 ` Suravee Suthikulpanit
2016-03-14 5:26 ` Suravee Suthikulpanit
2016-03-14 9:58 ` Peter Zijlstra
2016-03-14 9:58 ` Peter Zijlstra
2016-03-14 13:37 ` Suravee Suthikulpanit
2016-03-14 13:37 ` Suravee Suthikulpanit
2016-03-14 14:19 ` Borislav Petkov
2016-03-14 14:19 ` Borislav Petkov
2016-03-14 16:39 ` Peter Zijlstra
2016-03-14 16:39 ` Peter Zijlstra
2016-03-15 0:39 ` Suravee Suthikulpanit
2016-03-15 0:39 ` Suravee Suthikulpanit
2016-03-15 8:44 ` Peter Zijlstra
2016-03-15 8:44 ` Peter Zijlstra
2016-03-15 10:40 ` Borislav Petkov
2016-03-15 10:40 ` Borislav Petkov
2016-03-15 10:53 ` Peter Zijlstra
2016-03-15 10:53 ` Peter Zijlstra
2016-03-18 7:07 ` Suravee Suthikulpanit
2016-03-18 7:07 ` Suravee Suthikulpanit
2016-03-18 9:04 ` Borislav Petkov
2016-03-18 9:04 ` Borislav Petkov
2016-03-18 9:09 ` Suravee Suthikulpanit
2016-03-18 9:09 ` Suravee Suthikulpanit
2016-03-18 9:29 ` Borislav Petkov
2016-03-18 10:06 ` Suravee Suthikulpanit
2016-03-18 10:06 ` Suravee Suthikulpanit
2016-03-18 10:39 ` Borislav Petkov
2016-03-18 10:39 ` Borislav Petkov
2016-03-18 11:11 ` Joerg Roedel
2016-03-18 11:33 ` Borislav Petkov [this message]
2016-03-18 11:33 ` Borislav Petkov
2016-02-23 14:12 ` [PATCH V5 03/10] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 04/10] perf/amd/iommu: Modify IOMMU API to allow specifying IOMMU index Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 05/10] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 06/10] perf/amd/iommu: Clean up perf_iommu_enable_event Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 07/10] perf/amd/iommu: Clean up get_next_available_iommu_bnk_cntr Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 08/10] perf/amd/iommu: Rename struct perf_amd_iommu to perf_iommu Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 09/10] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-23 14:12 ` [PATCH V5 10/10] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
2016-02-23 14:12 ` Suravee Suthikulpanit
2016-02-25 14:54 ` [PATCH V5 00/10] perf/amd/iommu: Enable multi-IOMMU support Joerg Roedel
2016-02-25 14:54 ` Joerg Roedel
2016-03-07 1:44 ` Suravee Suthikulpanit
2016-03-07 1:44 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318113344.GE7817@pd.tnic \
--to=bp@alien8.de \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=acme@kernel.org \
--cc=andihartmann@freenet.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vw@iommu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.