[Intel-wired-lan] [linux-next:master 4434/12950] drivers/net/ethernet/intel/igb/igb_main.c:5968:6: sparse: symbol 'igb_update_pf_vlvf' was not declared. Should it be static?

[Intel-wired-lan] [linux-next:master 4434/12950] drivers/net/ethernet/intel/igb/igb_main.c:5968:6: sparse: symbol 'igb_update_pf_vlvf' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   5e3497cca281616e7930b74a0076b7324dcc2057
commit: 16903caa339961b9f8a68b64f4f313789de48599 [4434/12950] igb: Add support for VLAN promiscuous with SR-IOV and NTUPLE
reproduce:
        # apt-get install sparse
        git checkout 16903caa339961b9f8a68b64f4f313789de48599
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/net/ethernet/intel/igb/igb_main.c:7785:33: sparse: incorrect type in argument 1 (different base types)
   drivers/net/ethernet/intel/igb/igb_main.c:7785:33:    expected restricted __le32 const [usertype] *p
   drivers/net/ethernet/intel/igb/igb_main.c:7785:33:    got restricted __be32 [usertype] *<noident>
   drivers/net/ethernet/intel/igb/igb_main.c:7786:34: sparse: incorrect type in argument 1 (different base types)
   drivers/net/ethernet/intel/igb/igb_main.c:7786:34:    expected restricted __le16 const [usertype] *p
   drivers/net/ethernet/intel/igb/igb_main.c:7786:34:    got restricted __be16 [usertype] *<noident>
   drivers/net/ethernet/intel/igb/igb_main.c:454:25: sparse: cast to restricted __le64
   drivers/net/ethernet/intel/igb/igb_main.c:454:25: sparse: cast to restricted __le64
   drivers/net/ethernet/intel/igb/igb_main.c:534:33: sparse: cast to restricted __le64
   drivers/net/ethernet/intel/igb/igb_main.c:534:33: sparse: cast to restricted __le64
   drivers/net/ethernet/intel/igb/igb_main.c:540:33: sparse: cast to restricted __le64
   drivers/net/ethernet/intel/igb/igb_main.c:540:33: sparse: cast to restricted __le64
>> drivers/net/ethernet/intel/igb/igb_main.c:5968:6: sparse: symbol 'igb_update_pf_vlvf' was not declared. Should it be static?
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast to restricted __be16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast from restricted __le16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast to restricted __be16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast from restricted __le16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast to restricted __be16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast from restricted __le16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast to restricted __be16
   drivers/net/ethernet/intel/igb/igb_main.c:6987:31: sparse: cast from restricted __le16

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[Intel-wired-lan] [RFC PATCH linux-next] igb: igb_update_pf_vlvf() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 igb_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 7366d4f..04bb264 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -5965,7 +5965,7 @@ static int igb_find_vlvf_entry(struct e1000_hw *hw, u32 vlan)
 	return idx;
 }
 
-void igb_update_pf_vlvf(struct igb_adapter *adapter, u32 vid)
+static void igb_update_pf_vlvf(struct igb_adapter *adapter, u32 vid)
 {
 	struct e1000_hw *hw = &adapter->hw;
 	u32 bits, pf_id;