[U-Boot] [PATCH] sandbox: Enable many more commands

[U-Boot] [PATCH] sandbox: Enable many more commands

[Tom Rini]

- Set CONFIG_SYS_CACHELINE_SIZE to ARCH_DMA_MINALIGN as that should be
  good enough.
- Make <asm/io.h> include <asm/types.h> like other arches do
- Enable many many more drivers in sandbox_defconfig so that we can get
  more build-time testing on this platform.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 arch/sandbox/include/asm/cache.h |    1 +
 arch/sandbox/include/asm/io.h    |    1 +
 configs/sandbox_defconfig        |   56 ++++++++++++++++++++++++++++++++++++--
 3 files changed, 56 insertions(+), 2 deletions(-)

diff --git a/arch/sandbox/include/asm/cache.h b/arch/sandbox/include/asm/cache.h
index ffbb984..a545e4b 100644
--- a/arch/sandbox/include/asm/cache.h
+++ b/arch/sandbox/include/asm/cache.h
@@ -20,5 +20,6 @@
 #else
 #define ARCH_DMA_MINALIGN	16
 #endif
+#define CONFIG_SYS_CACHELINE_SIZE	ARCH_DMA_MINALIGN
 
 #endif /* __SANDBOX_CACHE_H__ */
diff --git a/arch/sandbox/include/asm/io.h b/arch/sandbox/include/asm/io.h
index 5b87fde..b87ee19 100644
--- a/arch/sandbox/include/asm/io.h
+++ b/arch/sandbox/include/asm/io.h
@@ -57,5 +57,6 @@ void outw(unsigned int value, unsigned int addr);
 void outb(unsigned int value, unsigned int addr);
 
 #include <iotrace.h>
+#include <asm/types.h>
 
 #endif
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index 02534bf..1e6f4bf 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -1,42 +1,78 @@
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_PCI=y
 CONFIG_DEFAULT_DEVICE_TREE="sandbox"
+CONFIG_I8042_KEYB=y
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
+CONFIG_SPL_LOAD_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
+CONFIG_BOOTSTAGE_USER_COUNT=0x20
+CONFIG_BOOTSTAGE_FDT=y
+CONFIG_BOOTSTAGE_STASH=y
+CONFIG_BOOTSTAGE_STASH_ADDR=0x0
+CONFIG_BOOTSTAGE_STASH_SIZE=0x4096
 CONFIG_CONSOLE_RECORD=y
 CONFIG_CONSOLE_RECORD_OUT_SIZE=0x1000
+CONFIG_CMD_CPU=y
+CONFIG_CMD_LICENSE=y
 # CONFIG_CMD_ELF is not set
 # CONFIG_CMD_IMLS is not set
-# CONFIG_CMD_FLASH is not set
+CONFIG_LOOPW=y
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_MX_CYCLIC=y
+CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_DEMO=y
 CONFIG_CMD_REMOTEPROC=y
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_TFTPPUT=y
+CONFIG_CMD_TFTPSRV=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_TIMER=y
 CONFIG_CMD_SOUND=y
+CONFIG_CMD_BOOTSTAGE=y
 CONFIG_CMD_PMIC=y
 CONFIG_CMD_REGULATOR=y
 CONFIG_CMD_TPM=y
 CONFIG_CMD_TPM_TEST=y
 CONFIG_OF_CONTROL=y
 CONFIG_OF_HOSTFILE=y
+CONFIG_NETCONSOLE=y
 CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SPL_SYSCON=y
 CONFIG_DEVRES=y
+CONFIG_DEBUG_DEVRES=y
 CONFIG_ADC=y
 CONFIG_ADC_SANDBOX=y
+CONFIG_BLK=y
 CONFIG_CLK=y
+CONFIG_CPU=y
+CONFIG_DM_DEMO=y
+CONFIG_DM_DEMO_SIMPLE=y
+CONFIG_DM_DEMO_SHAPE=y
 CONFIG_SANDBOX_GPIO=y
+CONFIG_DM_I2C_COMPAT=y
+CONFIG_I2C_CROS_EC_TUNNEL=y
+CONFIG_I2C_CROS_EC_LDO=y
+CONFIG_DM_I2C_GPIO=y
 CONFIG_SYS_I2C_SANDBOX=y
+CONFIG_I2C_MUX=y
+CONFIG_SPL_I2C_MUX=y
+CONFIG_I2C_ARB_GPIO_CHALLENGE=y
 CONFIG_CROS_EC_KEYB=y
 CONFIG_LED=y
 CONFIG_LED_GPIO=y
 CONFIG_CMD_CROS_EC=y
 CONFIG_CROS_EC=y
+CONFIG_CROS_EC_I2C=y
+CONFIG_CROS_EC_LPC=y
 CONFIG_CROS_EC_SANDBOX=y
+CONFIG_CROS_EC_SPI=y
+CONFIG_PWRSEQ=y
+CONFIG_SPL_PWRSEQ=y
 CONFIG_RESET=y
 CONFIG_DM_MMC=y
 CONFIG_SPI_FLASH_SANDBOX=y
@@ -55,11 +91,27 @@ CONFIG_DM_PCI_COMPAT=y
 CONFIG_PCI_SANDBOX=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
+CONFIG_ROCKCHIP_PINCTRL=y
+CONFIG_ROCKCHIP_3036_PINCTRL=y
 CONFIG_PINCTRL_SANDBOX=y
 CONFIG_DM_PMIC=y
+CONFIG_PMIC_ACT8846=y
+CONFIG_DM_PMIC_PFUZE100=y
+CONFIG_DM_PMIC_MAX77686=y
+CONFIG_PMIC_RK808=y
+CONFIG_PMIC_S2MPS11=y
 CONFIG_DM_PMIC_SANDBOX=y
+CONFIG_PMIC_S5M8767=y
+CONFIG_PMIC_TPS65090=y
 CONFIG_DM_REGULATOR=y
+CONFIG_REGULATOR_ACT8846=y
+CONFIG_DM_REGULATOR_PFUZE100=y
+CONFIG_DM_REGULATOR_MAX77686=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_REGULATOR_RK808=y
+CONFIG_REGULATOR_S5M8767=y
 CONFIG_DM_REGULATOR_SANDBOX=y
+CONFIG_REGULATOR_TPS65090=y
 CONFIG_RAM=y
 CONFIG_REMOTEPROC_SANDBOX=y
 CONFIG_DM_RTC=y
-- 
1.7.9.5

[U-Boot] [PATCH] sandbox: Enable many more commands

[Simon Glass]

On 15 March 2016 at 11:20, Tom Rini <trini@konsulko.com> wrote:
>   good enough.
> - Make <asm/io.h> include <asm/types.h> like other arches do
> - Enable many many more drivers in sandbox_defconfig so that we can get
>   more build-time testing on this platform.
>
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  arch/sandbox/include/asm/cache.h |    1 +
>  arch/sandbox/include/asm/io.h    |    1 +
>  configs/sandbox_defconfig        |   56 ++++++++++++++++++++++++++++++++++++--
>  3 files changed, 56 insertions(+), 2 deletions(-)

Great!

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] sandbox: Enable many more commands

[Simon Glass]

Hi Tom,

On 15 March 2016 at 21:32, Simon Glass <sjg@chromium.org> wrote:
>
> On 15 March 2016 at 11:20, Tom Rini <trini@konsulko.com> wrote:
> >   good enough.
> > - Make <asm/io.h> include <asm/types.h> like other arches do
> > - Enable many many more drivers in sandbox_defconfig so that we can get
> >   more build-time testing on this platform.
> >
> > Cc: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> >  arch/sandbox/include/asm/cache.h |    1 +
> >  arch/sandbox/include/asm/io.h    |    1 +
> >  configs/sandbox_defconfig        |   56 ++++++++++++++++++++++++++++++++++++--
> >  3 files changed, 56 insertions(+), 2 deletions(-)
>
> Great!
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

I am seeing errors with this patch building for sandbox:

tools/bin2header.c: In function ?main?:
tools/bin2header.c:26:3: warning: implicit declaration of function
?read? [-Wimplicit-function-declaration]
   nread = read(0, buf, sizeof(buf));
   ^
cmd/license.c:15:21: fatal error: license.h: No such file or directory
 #include <license.h>
                     ^
compilation terminated.
make[2]: *** [cmd/license.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [cmd] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2


Can you take a look? If it matters I am doing an out-of-tree build.

Regards,
Simon

[U-Boot] [PATCH] sandbox: Enable many more commands

[Tom Rini]

On Sat, Mar 19, 2016 at 06:25:48PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On 15 March 2016 at 21:32, Simon Glass <sjg@chromium.org> wrote:
> >
> > On 15 March 2016 at 11:20, Tom Rini <trini@konsulko.com> wrote:
> > >   good enough.
> > > - Make <asm/io.h> include <asm/types.h> like other arches do
> > > - Enable many many more drivers in sandbox_defconfig so that we can get
> > >   more build-time testing on this platform.
> > >
> > > Cc: Simon Glass <sjg@chromium.org>
> > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > ---
> > >  arch/sandbox/include/asm/cache.h |    1 +
> > >  arch/sandbox/include/asm/io.h    |    1 +
> > >  configs/sandbox_defconfig        |   56 ++++++++++++++++++++++++++++++++++++--
> > >  3 files changed, 56 insertions(+), 2 deletions(-)
> >
> > Great!
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> I am seeing errors with this patch building for sandbox:
> 
> tools/bin2header.c: In function ?main?:
> tools/bin2header.c:26:3: warning: implicit declaration of function
> ?read? [-Wimplicit-function-declaration]
>    nread = read(0, buf, sizeof(buf));
>    ^
> cmd/license.c:15:21: fatal error: license.h: No such file or directory
>  #include <license.h>
>                      ^
> compilation terminated.
> make[2]: *** [cmd/license.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [cmd] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> 
> 
> Can you take a look? If it matters I am doing an out-of-tree build.

Yeah, sorry, this relies on the cmd: license patch I posted in order to
work as nothing uses the license command today and it's pretty badly
broken, but easily fixed.  I was hoping Masahiro would chime in on the
kbuild fun that the patch does, but if you wanna pull it in that's fine,
I'll probably grab it soon otherwise myself.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160319/a0f9d6de/attachment.sig>

[U-Boot] [PATCH] sandbox: Enable many more commands

[Simon Glass]

On 19 March 2016 at 18:33, Tom Rini <trini@konsulko.com> wrote:
>
> On Sat, Mar 19, 2016 at 06:25:48PM -0600, Simon Glass wrote:
> > Hi Tom,
> >
> > On 15 March 2016 at 21:32, Simon Glass <sjg@chromium.org> wrote:
> > >
> > > On 15 March 2016 at 11:20, Tom Rini <trini@konsulko.com> wrote:
> > > >   good enough.
> > > > - Make <asm/io.h> include <asm/types.h> like other arches do
> > > > - Enable many many more drivers in sandbox_defconfig so that we can get
> > > >   more build-time testing on this platform.
> > > >
> > > > Cc: Simon Glass <sjg@chromium.org>
> > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > ---
> > > >  arch/sandbox/include/asm/cache.h |    1 +
> > > >  arch/sandbox/include/asm/io.h    |    1 +
> > > >  configs/sandbox_defconfig        |   56 ++++++++++++++++++++++++++++++++++++--
> > > >  3 files changed, 56 insertions(+), 2 deletions(-)
> > >
> > > Great!
> > >
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > I am seeing errors with this patch building for sandbox:
> >
> > tools/bin2header.c: In function ?main?:
> > tools/bin2header.c:26:3: warning: implicit declaration of function
> > ?read? [-Wimplicit-function-declaration]
> >    nread = read(0, buf, sizeof(buf));
> >    ^
> > cmd/license.c:15:21: fatal error: license.h: No such file or directory
> >  #include <license.h>
> >                      ^
> > compilation terminated.
> > make[2]: *** [cmd/license.o] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > make[1]: *** [cmd] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [sub-make] Error 2
> >
> >
> > Can you take a look? If it matters I am doing an out-of-tree build.
>
> Yeah, sorry, this relies on the cmd: license patch I posted in order to
> work as nothing uses the license command today and it's pretty badly
> broken, but easily fixed.  I was hoping Masahiro would chime in on the
> kbuild fun that the patch does, but if you wanna pull it in that's fine,
> I'll probably grab it soon otherwise myself.

Applied to u-boot-dm, thanks!