* [PATCH] jbd2: remove excess descriptions for handle_s
@ 2016-03-19 17:06 Luis de Bethencourt
2016-03-21 8:41 ` Jan Kara
2016-05-06 2:37 ` [RESEND Patch] " Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2016-03-19 17:06 UTC (permalink / raw)
To: linux-kernel; +Cc: tytso, jack, linux-ext4, Luis de Bethencourt
Commit bf6993276f74 ("jbd2: Use tracepoints for history file")
removed the members j_history, j_history_max and j_history_cur from struct
handle_s but the descriptions stayed lingering. Removing them.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Hi,
Noticed this issue when running make htmldocs.
It gives the following warnings:
.//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history' description in 'journal_s'
.//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_max' description in 'journal_s'
.//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_cur' description in 'journal_s'
Thanks,
Luis
include/linux/jbd2.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index fd1083c..401792d 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -781,9 +781,6 @@ jbd2_time_diff(unsigned long start, unsigned long end)
* @j_wbufsize: maximum number of buffer_heads allowed in j_wbuf, the
* number that will fit in j_blocksize
* @j_last_sync_writer: most recent pid which did a synchronous write
- * @j_history: Buffer storing the transactions statistics history
- * @j_history_max: Maximum number of transactions in the statistics history
- * @j_history_cur: Current number of transactions in the statistics history
* @j_history_lock: Protect the transactions statistics history
* @j_proc_entry: procfs entry for the jbd statistics directory
* @j_stats: Overall statistics
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: remove excess descriptions for handle_s
2016-03-19 17:06 [PATCH] jbd2: remove excess descriptions for handle_s Luis de Bethencourt
@ 2016-03-21 8:41 ` Jan Kara
2016-05-06 2:37 ` [RESEND Patch] " Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2016-03-21 8:41 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, tytso, jack, linux-ext4
On Sat 19-03-16 17:06:03, Luis de Bethencourt wrote:
> Commit bf6993276f74 ("jbd2: Use tracepoints for history file")
> removed the members j_history, j_history_max and j_history_cur from struct
> handle_s but the descriptions stayed lingering. Removing them.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> Hi,
>
> Noticed this issue when running make htmldocs.
>
> It gives the following warnings:
> .//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history' description in 'journal_s'
> .//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_max' description in 'journal_s'
> .//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_cur' description in 'journal_s'
>
> Thanks,
> Luis
>
> include/linux/jbd2.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index fd1083c..401792d 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -781,9 +781,6 @@ jbd2_time_diff(unsigned long start, unsigned long end)
> * @j_wbufsize: maximum number of buffer_heads allowed in j_wbuf, the
> * number that will fit in j_blocksize
> * @j_last_sync_writer: most recent pid which did a synchronous write
> - * @j_history: Buffer storing the transactions statistics history
> - * @j_history_max: Maximum number of transactions in the statistics history
> - * @j_history_cur: Current number of transactions in the statistics history
> * @j_history_lock: Protect the transactions statistics history
> * @j_proc_entry: procfs entry for the jbd statistics directory
> * @j_stats: Overall statistics
> --
> 2.5.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND Patch] jbd2: remove excess descriptions for handle_s
2016-03-19 17:06 [PATCH] jbd2: remove excess descriptions for handle_s Luis de Bethencourt
2016-03-21 8:41 ` Jan Kara
@ 2016-05-06 2:37 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2016-05-06 2:37 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, linux-ext4, jack
On Mon, Apr 11, 2016 at 12:44:16PM +0100, Luis de Bethencourt wrote:
> Commit bf6993276f74 ("jbd2: Use tracepoints for history file")
> removed the members j_history, j_history_max and j_history_cur from struct
> handle_s but the descriptions stayed lingering. Removing them.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-06 2:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-19 17:06 [PATCH] jbd2: remove excess descriptions for handle_s Luis de Bethencourt
2016-03-21 8:41 ` Jan Kara
2016-05-06 2:37 ` [RESEND Patch] " Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.