* [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet
@ 2016-03-20 14:05 Samuel Thibault
2016-03-20 14:05 ` Samuel Thibault
2016-03-21 9:48 ` Peter Maydell
0 siblings, 2 replies; 6+ messages in thread
From: Samuel Thibault @ 2016-03-20 14:05 UTC (permalink / raw)
To: qemu-devel, peter.maydell; +Cc: Samuel Thibault, jan.kiszka
The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to 6f843b773c2fdec99f1d27081b0cc80fede76493:
slirp: Fix memory leak on small incoming ipv4 packet (2016-03-20 12:17:16 +0100)
----------------------------------------------------------------
slirp: Fix memory leak on small incoming ipv4 packet
----------------------------------------------------------------
Samuel Thibault (1):
slirp: Fix memory leak on small incoming ipv4 packet
slirp/ip_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet
2016-03-20 14:05 [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet Samuel Thibault
@ 2016-03-20 14:05 ` Samuel Thibault
2016-03-21 9:48 ` Peter Maydell
1 sibling, 0 replies; 6+ messages in thread
From: Samuel Thibault @ 2016-03-20 14:05 UTC (permalink / raw)
To: qemu-devel, peter.maydell; +Cc: Samuel Thibault, jan.kiszka
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
slirp/ip_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/ip_input.c b/slirp/ip_input.c
index 12f173d..b464f6b 100644
--- a/slirp/ip_input.c
+++ b/slirp/ip_input.c
@@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
DEBUG_ARG("m_len = %d", m->m_len);
if (m->m_len < sizeof (struct ip)) {
- return;
+ goto bad;
}
ip = mtod(m, struct ip *);
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet
2016-03-20 14:05 [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet Samuel Thibault
2016-03-20 14:05 ` Samuel Thibault
@ 2016-03-21 9:48 ` Peter Maydell
2016-03-21 23:49 ` Samuel Thibault
1 sibling, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2016-03-21 9:48 UTC (permalink / raw)
To: Samuel Thibault; +Cc: J. Kiszka, QEMU Developers
On 20 March 2016 at 14:05, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)
>
> are available in the git repository at:
>
> http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 6f843b773c2fdec99f1d27081b0cc80fede76493:
>
> slirp: Fix memory leak on small incoming ipv4 packet (2016-03-20 12:17:16 +0100)
>
> ----------------------------------------------------------------
> slirp: Fix memory leak on small incoming ipv4 packet
>
> ----------------------------------------------------------------
> Samuel Thibault (1):
> slirp: Fix memory leak on small incoming ipv4 packet
Hi -- I couldn't find where these patches had been sent to the mailing
list previously (though it's possible I missed them). Generally the
process for QEMU is that first patches are sent as normal [PATCH] mails,
for code review. Patches should only be put into pull requests once
they've been through the review process. (And then you can batch them
up so you don't have to send me two pulls for one patch each.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet
2016-03-21 9:48 ` Peter Maydell
@ 2016-03-21 23:49 ` Samuel Thibault
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Thibault @ 2016-03-21 23:49 UTC (permalink / raw)
To: Peter Maydell; +Cc: J. Kiszka, QEMU Developers
Hello,
Peter Maydell, on Mon 21 Mar 2016 09:48:48 +0000, wrote:
> Generally the
> process for QEMU is that first patches are sent as normal [PATCH] mails,
> for code review. Patches should only be put into pull requests once
> they've been through the review process. (And then you can batch them
> up so you don't have to send me two pulls for one patch each.)
Ah OK. Since they were one-liners, I thought they didn't need the review
step. Now resent for review.
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet
2016-03-20 11:23 Samuel Thibault
@ 2016-03-20 14:06 ` Samuel Thibault
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Thibault @ 2016-03-20 14:06 UTC (permalink / raw)
To: qemu-devel, peter.maydell; +Cc: jan.kiszka
Ah, sorry, that didn't include the cover letter with the branch to pull
from. I have resent the pull request.
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet
@ 2016-03-20 11:23 Samuel Thibault
2016-03-20 14:06 ` Samuel Thibault
0 siblings, 1 reply; 6+ messages in thread
From: Samuel Thibault @ 2016-03-20 11:23 UTC (permalink / raw)
To: qemu-devel, peter.maydell; +Cc: Samuel Thibault, jan.kiszka
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
slirp/ip_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/ip_input.c b/slirp/ip_input.c
index 12f173d..b464f6b 100644
--- a/slirp/ip_input.c
+++ b/slirp/ip_input.c
@@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
DEBUG_ARG("m_len = %d", m->m_len);
if (m->m_len < sizeof (struct ip)) {
- return;
+ goto bad;
}
ip = mtod(m, struct ip *);
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-21 23:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-20 14:05 [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet Samuel Thibault
2016-03-20 14:05 ` Samuel Thibault
2016-03-21 9:48 ` Peter Maydell
2016-03-21 23:49 ` Samuel Thibault
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 11:23 Samuel Thibault
2016-03-20 14:06 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.