* [PATCH] Staging: olpc_dcon: Add space around '<<'
@ 2016-03-13 22:11 Dilek Uzulmez
2016-03-22 1:40 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Dilek Uzulmez @ 2016-03-13 22:11 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
Add space around operator '<<'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '<<' (ctx:VxV)
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index d06e19d..ca29ac9 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -9,18 +9,18 @@
#define DCON_REG_ID 0
#define DCON_REG_MODE 1
-#define MODE_PASSTHRU (1<<0)
-#define MODE_SLEEP (1<<1)
-#define MODE_SLEEP_AUTO (1<<2)
-#define MODE_BL_ENABLE (1<<3)
-#define MODE_BLANK (1<<4)
-#define MODE_CSWIZZLE (1<<5)
-#define MODE_COL_AA (1<<6)
-#define MODE_MONO_LUMA (1<<7)
-#define MODE_SCAN_INT (1<<8)
-#define MODE_CLOCKDIV (1<<9)
-#define MODE_DEBUG (1<<14)
-#define MODE_SELFTEST (1<<15)
+#define MODE_PASSTHRU (1 << 0)
+#define MODE_SLEEP (1 << 1)
+#define MODE_SLEEP_AUTO (1 << 2)
+#define MODE_BL_ENABLE (1 << 3)
+#define MODE_BLANK (1 << 4)
+#define MODE_CSWIZZLE (1 << 5)
+#define MODE_COL_AA (1 << 6)
+#define MODE_MONO_LUMA (1 << 7)
+#define MODE_SCAN_INT (1 << 8)
+#define MODE_CLOCKDIV (1 << 9)
+#define MODE_DEBUG (1 << 14)
+#define MODE_SELFTEST (1 << 15)
#define DCON_REG_HRES 0x2
#define DCON_REG_HTOTAL 0x3
@@ -35,11 +35,11 @@
#define DCON_REG_MEM_OPT_B 0x42
/* Load Delay Locked Loop (DLL) settings for clock delay */
-#define MEM_DLL_CLOCK_DELAY (1<<0)
+#define MEM_DLL_CLOCK_DELAY (1 << 0)
/* Memory controller power down function */
-#define MEM_POWER_DOWN (1<<8)
+#define MEM_POWER_DOWN (1 << 8)
/* Memory controller software reset */
-#define MEM_SOFT_RESET (1<<0)
+#define MEM_SOFT_RESET (1 << 0)
/* Status values */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: olpc_dcon: Add space around '<<'
2016-03-13 22:11 [PATCH] Staging: olpc_dcon: Add space around '<<' Dilek Uzulmez
@ 2016-03-22 1:40 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-22 1:40 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Mon, Mar 14, 2016 at 12:11:04AM +0200, Dilek Uzulmez wrote:
> Add space around operator '<<'. Problem found using checkpatch.pl
> CHECK: spaces preferred around that '<<' (ctx:VxV)
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
This driver is no longer even in the kernel tree :(
Please be sure to always work from the correct branch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-22 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-13 22:11 [PATCH] Staging: olpc_dcon: Add space around '<<' Dilek Uzulmez
2016-03-22 1:40 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.