* [PATCH] Staging: lustre: Do not add space between function name and open parenthesis.
@ 2016-03-21 14:58 Sandhya Bankar
2016-03-22 1:45 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-03-21 14:58 UTC (permalink / raw)
To: outreachy-kernel
Do not add space between function name and open parenthesis.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
.../staging/lustre/lustre/osc/osc_cl_internal.h | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h b/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
index d55d04d..3dfe5f6 100644
--- a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
+++ b/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
@@ -417,20 +417,20 @@ extern struct lu_context_key osc_session_key;
int osc_lock_init(const struct lu_env *env,
struct cl_object *obj, struct cl_lock *lock,
const struct cl_io *io);
-int osc_io_init (const struct lu_env *env,
- struct cl_object *obj, struct cl_io *io);
-int osc_req_init (const struct lu_env *env, struct cl_device *dev,
- struct cl_req *req);
+int osc_io_init(const struct lu_env *env,
+ struct cl_object *obj, struct cl_io *io);
+int osc_req_init(const struct lu_env *env, struct cl_device *dev,
+ struct cl_req *req);
struct lu_object *osc_object_alloc(const struct lu_env *env,
const struct lu_object_header *hdr,
struct lu_device *dev);
int osc_page_init(const struct lu_env *env, struct cl_object *obj,
struct cl_page *page, struct page *vmpage);
-void osc_index2policy (ldlm_policy_data_t *policy, const struct cl_object *obj,
- pgoff_t start, pgoff_t end);
-int osc_lvb_print (const struct lu_env *env, void *cookie,
- lu_printer_t p, const struct ost_lvb *lvb);
+void osc_index2policy(ldlm_policy_data_t *policy, const struct cl_object *obj,
+ pgoff_t start, pgoff_t end);
+int osc_lvb_print(const struct lu_env *env, void *cookie,
+ lu_printer_t p, const struct ost_lvb *lvb);
void osc_page_submit(const struct lu_env *env, struct osc_page *opg,
enum cl_req_type crt, int brw_flags);
@@ -458,11 +458,11 @@ int osc_cache_wait_range(const struct lu_env *env, struct osc_object *obj,
void osc_io_unplug(const struct lu_env *env, struct client_obd *cli,
struct osc_object *osc);
-void osc_object_set_contended (struct osc_object *obj);
+void osc_object_set_contended(struct osc_object *obj);
void osc_object_clear_contended(struct osc_object *obj);
-int osc_object_is_contended (struct osc_object *obj);
+int osc_object_is_contended(struct osc_object *obj);
-int osc_lock_is_lockless (const struct osc_lock *olck);
+int osc_lock_is_lockless(const struct osc_lock *olck);
/*****************************************************************************
*
--
1.8.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: lustre: Do not add space between function name and open parenthesis.
2016-03-21 14:58 [PATCH] Staging: lustre: Do not add space between function name and open parenthesis Sandhya Bankar
@ 2016-03-22 1:45 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-22 1:45 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Mon, Mar 21, 2016 at 08:28:16PM +0530, Sandhya Bankar wrote:
> Do not add space between function name and open parenthesis.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> .../staging/lustre/lustre/osc/osc_cl_internal.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h b/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
> index d55d04d..3dfe5f6 100644
> --- a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
> +++ b/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
> @@ -417,20 +417,20 @@ extern struct lu_context_key osc_session_key;
> int osc_lock_init(const struct lu_env *env,
> struct cl_object *obj, struct cl_lock *lock,
> const struct cl_io *io);
> -int osc_io_init (const struct lu_env *env,
> - struct cl_object *obj, struct cl_io *io);
> -int osc_req_init (const struct lu_env *env, struct cl_device *dev,
> - struct cl_req *req);
> +int osc_io_init(const struct lu_env *env,
> + struct cl_object *obj, struct cl_io *io);
> +int osc_req_init(const struct lu_env *env, struct cl_device *dev,
> + struct cl_req *req);
> struct lu_object *osc_object_alloc(const struct lu_env *env,
> const struct lu_object_header *hdr,
> struct lu_device *dev);
> int osc_page_init(const struct lu_env *env, struct cl_object *obj,
> struct cl_page *page, struct page *vmpage);
>
> -void osc_index2policy (ldlm_policy_data_t *policy, const struct cl_object *obj,
> - pgoff_t start, pgoff_t end);
> -int osc_lvb_print (const struct lu_env *env, void *cookie,
> - lu_printer_t p, const struct ost_lvb *lvb);
> +void osc_index2policy(ldlm_policy_data_t *policy, const struct cl_object *obj,
> + pgoff_t start, pgoff_t end);
> +int osc_lvb_print(const struct lu_env *env, void *cookie,
> + lu_printer_t p, const struct ost_lvb *lvb);
Does the code look better now? Before your patch, it looked much nicer,
don't you think?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-22 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21 14:58 [PATCH] Staging: lustre: Do not add space between function name and open parenthesis Sandhya Bankar
2016-03-22 1:45 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.