All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line
       [not found] <20160312141722.GA388@kerneldev.linux>
@ 2016-03-12 15:01 ` Adonis Settouf
  2016-03-22  2:07   ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Adonis Settouf @ 2016-03-12 15:01 UTC (permalink / raw)
  To: gregkh, mateusz.kulikowski, potrzebye, devel, linux-kernel; +Cc: adonis.settouf

This patch fixes the checkpatch.pl warning regarding the exceeding 80
characters on line 36. This patch add a newline after function statement
on line 52

Signed-off-by: Adonis Settouf <adonis.settouf@gmail.com>
---
 drivers/staging/rtl8192e/dot11d.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
index 735a199..5cffc8f 100644
--- a/drivers/staging/rtl8192e/dot11d.h
+++ b/drivers/staging/rtl8192e/dot11d.h
@@ -30,8 +30,8 @@ enum dot11d_state {
 };
 
 /**
- * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains
- *		  valid country information element.
+ * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if
+ * @CountryIeBuf contains valid country information element.
  * @channel_map: holds channel values
  *		0 - invalid,
  *		1 - valid (active scan),
@@ -78,6 +78,7 @@ static inline void RESET_CIE_WATCHDOG(struct rtllib_device *__pIeeeDev)
 {
 	GET_CIE_WATCHDOG(__pIeeeDev) = 0;
 }
+
 #define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))
 
 void dot11d_init(struct rtllib_device *dev);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line
  2016-03-12 15:01 ` [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line Adonis Settouf
@ 2016-03-22  2:07   ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-22  2:07 UTC (permalink / raw)
  To: Adonis Settouf; +Cc: mateusz.kulikowski, potrzebye, devel, linux-kernel

On Sat, Mar 12, 2016 at 04:01:03PM +0100, Adonis Settouf wrote:
> This patch fixes the checkpatch.pl warning regarding the exceeding 80
> characters on line 36. This patch add a newline after function statement
> on line 52

You did 2 different things in the same patch, that should be 2 patches.

> 
> Signed-off-by: Adonis Settouf <adonis.settouf@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 735a199..5cffc8f 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -30,8 +30,8 @@ enum dot11d_state {
>  };
>  
>  /**
> - * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains
> - *		  valid country information element.
> + * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if
> + * @CountryIeBuf contains valid country information element.

You forgot to indent like the rest of this comment block did :(

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-22  2:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20160312141722.GA388@kerneldev.linux>
2016-03-12 15:01 ` [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line Adonis Settouf
2016-03-22  2:07   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.