All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: build: fix static standalone utilities
@ 2016-03-21 14:16 Noah Massey
  2016-03-22 15:08 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Noah Massey @ 2016-03-21 14:16 UTC (permalink / raw)
  To: linux-btrfs; +Cc: David Sterba, Noah Massey

commit b5e7979 "btrfs-progs: build: extend per-binary objects" allows
the standalone utilities to link against object files shared with the
main binary. However, the btrfs-*.static targets need to be adjusted
to build against the static versions of the common files.

Signed-off-by: Noah Massey <noah.massey@gmail.com>
---
 Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.in b/Makefile.in
index dd30686..c553c5f 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -254,7 +254,7 @@ $(lib_links):
 btrfs-%.static: $(static_objects) btrfs-%.static.o $(static_libbtrfs_objects)
 	@echo "    [LD]     $@"
 	$(Q)$(CC) $(STATIC_CFLAGS) -o $@ $@.o $(static_objects) \
-		$($(subst -,_,$(subst .static,,$@)-objects)) \
+		$(patsubst %.o, %.static.o, $($(subst -,_,$(subst .static,,$@)-objects))) \
 		$(static_libbtrfs_objects) $(STATIC_LDFLAGS) \
 		$($(subst -,_,$(subst .static,,$@)-libs)) $(STATIC_LIBS)
 
-- 
2.7.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: build: fix static standalone utilities
  2016-03-21 14:16 [PATCH] btrfs-progs: build: fix static standalone utilities Noah Massey
@ 2016-03-22 15:08 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-03-22 15:08 UTC (permalink / raw)
  To: Noah Massey; +Cc: linux-btrfs, David Sterba, Noah Massey

On Mon, Mar 21, 2016 at 10:16:07AM -0400, Noah Massey wrote:
> commit b5e7979 "btrfs-progs: build: extend per-binary objects" allows
> the standalone utilities to link against object files shared with the
> main binary. However, the btrfs-*.static targets need to be adjusted
> to build against the static versions of the common files.
> 
> Signed-off-by: Noah Massey <noah.massey@gmail.com>

Applied, thanks. I'll release a .1 version probably next week as there
are more build fixes accumulated.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-22 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21 14:16 [PATCH] btrfs-progs: build: fix static standalone utilities Noah Massey
2016-03-22 15:08 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.