All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com,
	mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	abologna@redhat.com, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface
Date: Wed, 23 Mar 2016 12:14:29 +0800	[thread overview]
Message-ID: <20160323041429.GG28183@pxdev.xzpeter.org> (raw)
In-Reply-To: <874mbyl64i.fsf@blackfin.pond.sub.org>

On Tue, Mar 22, 2016 at 07:28:13PM +0100, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
> > diff --git a/scripts/qapi.py b/scripts/qapi.py
> > index 6b2aa6e..716474e 100644
> > --- a/scripts/qapi.py
> > +++ b/scripts/qapi.py
> > @@ -46,6 +46,7 @@ returns_whitelist = [
>    # Whitelist of commands allowed to return a non-dictionary
>    returns_whitelist = [
>        'human-monitor-command',
>        'qom-get',
>        'query-migrate-cache-size',
> >      'query-tpm-models',
> >      'query-tpm-types',
> >      'ringbuf-read',
> > +    'query-gic-capability',
> >  
> >      # From QGA:
> >      'guest-file-open',
> 
> The whitelist exists to except existing commands from design rules on
> return types.  New commands don't get to violate the rules without a
> really, really compelling reason.
> 
> Do you actually need this?
> 
> If yes, why should your command be permitted to violate the design
> rules?

This might not be required. Agree with you and Eric. Will use a hash
instead with single key.

> > +#include "qemu/osdep.h"
> > +#include "hw/boards.h"
> > +#include "qemu/error-report.h"
> > +#include "sysemu/kvm.h"
> > +#include "qmp-commands.h"
> 
> I very much doubt you need all these includes.  Try dropping all but the
> first and the last one.

I just copied them from machine.c and dropped lots, seems still
redundant... Will keep it a minimum subset in next version. Thanks!

-- peterx

  reply	other threads:[~2016-03-23  4:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  3:27 [Qemu-devel] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct Peter Xu
2016-03-22 18:29   ` Markus Armbruster
2016-03-22 18:41     ` Markus Armbruster
2016-03-23  2:58       ` Peter Xu
2016-03-23  9:33         ` Markus Armbruster
2016-03-23 11:48           ` Peter Xu
2016-03-23 12:21             ` Markus Armbruster
2016-03-23 14:25               ` Peter Xu
2016-03-23 15:17                 ` Markus Armbruster
2016-03-24  2:27                   ` Peter Xu
2016-03-22 18:32   ` Eric Blake
2016-03-23  3:09     ` Peter Xu
2016-03-23  9:44       ` Markus Armbruster
2016-03-23 11:56         ` Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface Peter Xu
2016-03-22 18:28   ` Markus Armbruster
2016-03-23  4:14     ` Peter Xu [this message]
2016-03-23  9:52       ` Markus Armbruster
2016-03-23 12:04         ` Peter Xu
2016-03-23 14:06           ` Markus Armbruster
2016-03-23 14:31             ` Eric Blake
2016-03-22 18:42   ` Eric Blake
2016-03-22 19:09     ` Markus Armbruster
2016-03-23  4:07     ` Peter Xu
2016-03-23  9:54       ` Markus Armbruster
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 3/5] arm: enhance kvm_arm_create_scratch_host_vcpu Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 4/5] kvm: add kvm_support_device() helper function Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 5/5] arm: implement query-gic-capabilities Peter Xu
2016-03-21 15:56 ` [Qemu-devel] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command Andrea Bolognani
2016-03-22  2:23   ` Peter Xu
2016-03-22 14:20 ` Markus Armbruster
2016-03-23  5:19   ` Peter Xu
2016-03-22 14:49 ` Peter Maydell
2016-03-23  5:43   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323041429.GG28183@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=abologna@redhat.com \
    --cc=armbru@redhat.com \
    --cc=drjones@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.